brackt/app/services/simulations/ncaam-simulator.ts

33 lines
1.3 KiB
TypeScript
Raw Normal View History

import { NCAABasketballSimulator } from "./ncaa-basketball-simulator";
import type { Simulator, SimulationResult } from "./types";
Honor engine knobs across simulators, de-dupe odds, unify config UI Two problems addressed: 1. Favorites' P(1st) was too sharp (e.g. NHL top teams ~20% vs ~12% implied). - The NHL simulator hardcoded its parity factor (1000) and ignored the season config's parityFactor, so the knob meant to flatten the distribution did nothing. It also re-blended raw futures odds into every game on top of the odds->Elo conversion, double-counting the same signal. - NHL now reads parityFactor/iterations/seasonGames/overtimeRate from config and no longer re-blends odds per game (odds enter once, via the central odds->Elo resolver). Honoring parity 2500 flattens a top team from ~29% to ~13% title odds. 2. "Season Config" and "Input Policy" were two forms over the same stored object that didn't reflect each other, and the engine-knob half was inert for many simulators. - Every simulator now reads its engine knobs (iterations everywhere; parityFactor for all Elo-based sims) from the merged config, passed in by the runner via the Simulator interface. Defaults equal the former hardcoded constants, so behavior is unchanged unless a season overrides. - The admin simulator page is now a single "Simulator Configuration" card with structured Engine and Input-derivation sections (profile-driven, so each sport shows only the knobs it honors) plus an Advanced raw-JSON escape hatch — all writing the same config. Also: centralized the duplicated configNumber helpers into config-access.ts; the central odds->Elo resolver now maps onto the configured Elo floor/ceiling so those bounds set the odds-derived spread (a real flattening dial). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PAFMogMkFJf52YpHyCDvuf
2026-06-30 22:00:33 +00:00
import { optionalPositiveNumber } from "./config-access";
const KENPOM_SCALE_FACTOR = 7.5;
/**
* NCAAM neutral-court win probability using a KenPom-like adjusted efficiency
* margin. Ratings are season-scoped simulator inputs, not hardcoded data.
*/
export function kenpomWinProbability(netrtgA: number, netrtgB: number): number {
return 1 / (1 + Math.exp(-(netrtgA - netrtgB) / KENPOM_SCALE_FACTOR));
}
function kenpomWinProbabilityWithScale(scaleFactor: number): (netrtgA: number, netrtgB: number) => number {
return (netrtgA, netrtgB) => 1 / (1 + Math.exp(-(netrtgA - netrtgB) / scaleFactor));
}
export class NCAAMSimulator implements Simulator {
private readonly simulator = new NCAABasketballSimulator({
source: "ncaam_bracket_rating",
missingRatingName: "KenPom-like rating",
selectionRatingDivisor: 8,
winProbability: kenpomWinProbability,
getWinProbability: (config) =>
kenpomWinProbabilityWithScale(optionalPositiveNumber(config.ratingScaleFactor, KENPOM_SCALE_FACTOR)),
});
simulate(sportsSeasonId: string): Promise<SimulationResult[]> {
return this.simulator.simulate(sportsSeasonId);
}
}