2026-04-23 22:09:25 -07:00
|
|
|
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
|
|
|
|
|
|
|
|
// ── DB mock ────────────────────────────────────────────────────────────────
|
|
|
|
|
|
|
|
|
|
const DEFAULT_SEASON = {
|
|
|
|
|
id: "season-1",
|
|
|
|
|
pointsFor1st: 100, pointsFor2nd: 75, pointsFor3rd: 50,
|
|
|
|
|
pointsFor4th: 40, pointsFor5th: 30, pointsFor6th: 20,
|
|
|
|
|
pointsFor7th: 10, pointsFor8th: 5,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
type PickRow = {
|
|
|
|
|
participant: {
|
|
|
|
|
id: string;
|
|
|
|
|
name: string;
|
|
|
|
|
sportsSeasonId: string;
|
|
|
|
|
sportsSeason: { id: string; scoringPattern: string };
|
|
|
|
|
results: { finalPosition: number | null }[];
|
|
|
|
|
};
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
interface MakeDbOpts {
|
|
|
|
|
season?: typeof DEFAULT_SEASON | null;
|
|
|
|
|
picks?: PickRow[];
|
|
|
|
|
scoringEvents?: { sportsSeasonId: string; bracketTemplateId: string | null }[];
|
|
|
|
|
qualifyingTotals?: { participantId: string; totalQualifyingPoints: string }[];
|
2026-05-17 21:58:53 -07:00
|
|
|
seasonParticipantResults?: { sportsSeasonId: string; finalPosition: number | null }[];
|
2026-04-23 22:09:25 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function makeDb(opts: MakeDbOpts = {}) {
|
|
|
|
|
const {
|
|
|
|
|
season = DEFAULT_SEASON,
|
|
|
|
|
picks = [],
|
|
|
|
|
scoringEvents = [],
|
|
|
|
|
qualifyingTotals = [],
|
2026-05-17 21:58:53 -07:00
|
|
|
seasonParticipantResults = [],
|
2026-04-23 22:09:25 -07:00
|
|
|
} = opts;
|
|
|
|
|
|
|
|
|
|
return {
|
|
|
|
|
query: {
|
|
|
|
|
seasons: {
|
|
|
|
|
findFirst: vi.fn().mockResolvedValue(season),
|
|
|
|
|
},
|
|
|
|
|
draftPicks: {
|
|
|
|
|
findMany: vi.fn().mockResolvedValue(picks),
|
|
|
|
|
},
|
|
|
|
|
scoringEvents: {
|
|
|
|
|
findMany: vi.fn().mockResolvedValue(scoringEvents),
|
|
|
|
|
},
|
Canonical tournament layer: schema + backfill (1/2) (#365)
* refactor(schema): rename per-window tables to season_* prefix
Renames participants, participant_expected_values, participant_qualifying_totals,
participant_results, participant_surface_elos to season_* prefixed names.
Renames event_results.participant_id to season_participant_id.
Phase 1a of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor: rename participant.ts model file to season-participant.ts
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(models): update model layer to use renamed schema exports
Updated all model files to use the renamed schema exports from Task 1:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantQualifyingTotals → seasonParticipantQualifyingTotals
- participantResults → seasonParticipantResults
- participantSurfaceElos → seasonParticipantSurfaceElos
- eventResults.participantId → eventResults.seasonParticipantId
- db.query relation accessors updated
- Relation field .participant → .seasonParticipant where applicable
- Import paths updated: ./participant → ./season-participant
Files updated (14 model files + 3 test files):
- draft-pick.ts
- draft-utils.ts
- event-result.ts
- group-stage-match.ts
- participant-result.ts
- qualifying-points.ts
- scoring-calculator.ts
- scoring-event.ts
- sports-season.ts
- surface-elo.ts
- team-score-events.ts
- cs2-major-stage.ts
- golf-skills.ts
- participant-expected-value.ts
- __tests__/sports-season.clone.test.ts
- __tests__/auto-pick.test.ts
- __tests__/executeAutoPick.timer.test.ts
Typecheck errors decreased: 779 → 499 (280 fewer)
All model file errors related to renamed schemas resolved.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(routes): update route layer to use renamed schema exports
- Update model import from ~/models/participant to ~/models/season-participant
- Rename schema.participants to schema.seasonParticipants
- Rename schema.participantResults to schema.seasonParticipantResults
- Rename db.query.participants to db.query.seasonParticipants
- Update 9 route files and 1 test file
Affected files:
- admin.sports-seasons.$id.events.$eventId.bracket.server.ts
- admin.sports-seasons.$id.participants.tsx
- api/draft.force-manual-pick.ts
- api/draft.make-pick.ts
- api/draft.replace-pick.ts
- api/seasons.$seasonId.draft.ts
- leagues/$leagueId.draft-board.$seasonId.tsx
- leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
- admin/__tests__/sports-seasons-participants.test.ts
Error count reduced from 499 to 453 (46 errors fixed).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(routes): update route files for schema rename
Update route imports from ~/models/participant to ~/models/season-participant
and fix references to .participant/.participantId on event results to use
.seasonParticipant/.seasonParticipantId after schema rename.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(services): update simulators and services for renamed schema
Update all simulators, services, and server files to use renamed schema tables:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantResults → seasonParticipantResults
- eventResults.participantId → eventResults.seasonParticipantId
Files updated:
- 20 sport simulators (NBA, NHL, NFL, MLB, etc.)
- probability-updater.ts
- standings-sync/index.ts
- sports-data-sync.server.ts
- server/socket.ts
Typecheck errors reduced from 365 to 0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* migration: rename per-window tables to season_* prefix
* fix(tests): update mock query keys after participants table rename
Change mock db.query.participants to db.query.seasonParticipants in test
files to match the schema rename from commit 66145a9. This fixes
"Cannot read properties of undefined (reading 'findFirst'/'findMany')"
errors that occurred when production code queries db.query.seasonParticipants
but test mocks only defined the old participants key.
Files updated:
- app/services/simulations/__tests__/world-cup-simulator.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.timer-mode.test.ts
- app/routes/api/__tests__/draft.make-pick.timer-mode.test.ts
- server/__tests__/timer-autodraft.test.ts
- app/models/__tests__/team-score-events.test.ts
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(tests): update remaining mock paths and keys after schema rename
* fix(tests): final two mock stragglers after schema rename
- draft-pick.test.ts: assertion on db.query.participantQualifyingTotals
- process-match-result.test.ts: mock key participants → seasonParticipants
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* chore: add post-phase1a baseline capture (temp, for diff verification)
* chore: capture pre-migration baselines
* chore: remove post-phase1a capture helper after verification
* schema: add canonical tournament & participant tables
Adds tournaments, participants (canonical), tournament_results, and
participant_surface_elos (canonical). Adds nullable tournament_id to
scoring_events and nullable participant_id to season_participants.
Phase 1b of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(models): add canonical tournament, participant, result, surface-elo models
Adds CRUD modules for the canonical tables created in commit 775b905.
Each module mirrors existing app/models conventions (database() from
~/database/context, schema from ~/database/schema, mock-based tests).
Key implementation notes:
- participant.ts exports use "Canonical" prefix (CanonicalParticipant,
createCanonicalParticipant, etc.) to avoid collision with existing
season-participant.ts exports
- All four models include comprehensive unit tests following the
audit-log.test.ts pattern
- Tests use mocked db responses (no real database access)
- Upsert functions use onConflictDoUpdate for appropriate unique constraints
Part of Phase 1b of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* migration: create canonical tables, add nullable FKs
* scripts: add extractTournamentIdentity helper for backfill
Pure function that derives canonical (name, year) identity from a
scoring_events row, stripping trailing 4-digit years from the name or
falling back to eventDate. Used by the Phase 2 backfill to group
per-window events into canonical tournaments.
* scripts: add backfill orchestrator for canonical layer
Populates canonical tournaments, participants, tournament_results, and
participant_surface_elos from per-window data for qualifying-points
sports. Skips already-linked rows, is idempotent, and supports dry-run
mode.
Critical invariants enforced by the implementation:
- qualifying_points_awarded is never copied to tournament_results
- season_participant_qualifying_totals is never touched
- conflicting surface-Elo values between windows raise a loud error
(recorded in report.errors) rather than overwriting
* scripts: add backfill CLI with dry-run default
Wires backfill-canonical-layer.ts to a CLI entry point exposed as
`npm run backfill:canonical`. Defaults to --dry-run; requires --apply
to actually write. Supports --sport=<uuid> to limit to a single sport.
Exits 2 if the backfill reports errors (e.g., surface-Elo conflicts).
* fix(backfill-cli): wrap runBackfill in DatabaseContext.run
The orchestrator uses database() from ~/database/context, which requires
AsyncLocalStorage to be populated. Wrap the CLI invocation with
DatabaseContext.run(db, ...) using server/db's cached connection pool.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(backfill-cli): exit 0 on success so pg pool doesn't block
The cached postgres connection pool keeps the Node event loop open after
main() returns. Explicit process.exit(0) on success mirrors the pattern
in scripts/capture-baseline.ts.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Chris Parsons <chrisp@extrahop.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-01 20:13:18 -07:00
|
|
|
seasonParticipantQualifyingTotals: {
|
2026-04-23 22:09:25 -07:00
|
|
|
findMany: vi.fn().mockResolvedValue(qualifyingTotals),
|
|
|
|
|
},
|
2026-05-17 21:58:53 -07:00
|
|
|
seasonParticipantResults: {
|
|
|
|
|
findMany: vi.fn().mockResolvedValue(seasonParticipantResults),
|
|
|
|
|
},
|
2026-04-23 22:09:25 -07:00
|
|
|
},
|
|
|
|
|
} as any;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
import { getDraftedParticipantsWithPoints } from "../draft-pick";
|
|
|
|
|
|
|
|
|
|
function makePick(overrides: {
|
|
|
|
|
id?: string;
|
|
|
|
|
name?: string;
|
|
|
|
|
sportsSeasonId?: string;
|
|
|
|
|
scoringPattern?: string;
|
|
|
|
|
finalPosition?: number | null;
|
|
|
|
|
}): PickRow {
|
|
|
|
|
const {
|
|
|
|
|
id = "p-1",
|
|
|
|
|
name = "Participant One",
|
|
|
|
|
sportsSeasonId = "ss-1",
|
|
|
|
|
scoringPattern = "playoff_bracket",
|
|
|
|
|
finalPosition = null,
|
|
|
|
|
} = overrides;
|
|
|
|
|
return {
|
|
|
|
|
participant: {
|
|
|
|
|
id,
|
|
|
|
|
name,
|
|
|
|
|
sportsSeasonId,
|
|
|
|
|
sportsSeason: { id: sportsSeasonId, scoringPattern },
|
|
|
|
|
results: finalPosition !== null ? [{ finalPosition }] : [],
|
|
|
|
|
},
|
|
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
describe("getDraftedParticipantsWithPoints", () => {
|
|
|
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
|
|
|
|
|
|
it("returns empty map when season not found", async () => {
|
|
|
|
|
const db = makeDb({ season: null });
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
expect(result.size).toBe(0);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("returns empty map when no picks", async () => {
|
|
|
|
|
const db = makeDb({ picks: [] });
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
expect(result.size).toBe(0);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe("playoff_bracket pattern", () => {
|
|
|
|
|
it("returns earnedPoints based on finalPosition and scoring rules", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ scoringPattern: "playoff_bracket", finalPosition: 1 })],
|
|
|
|
|
scoringEvents: [{ sportsSeasonId: "ss-1", bracketTemplateId: null }],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
const ssEntry = result.get("ss-1");
|
|
|
|
|
expect(ssEntry).toBeDefined();
|
|
|
|
|
expect(ssEntry?.[0]).toMatchObject({
|
|
|
|
|
id: "p-1",
|
|
|
|
|
name: "Participant One",
|
|
|
|
|
earnedPoints: 100, // pointsFor1st
|
|
|
|
|
currentQP: null,
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("returns null earnedPoints when no finalPosition yet", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ scoringPattern: "playoff_bracket", finalPosition: null })],
|
|
|
|
|
scoringEvents: [{ sportsSeasonId: "ss-1", bracketTemplateId: null }],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({ earnedPoints: null, currentQP: null });
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("groups multiple picks by sportsSeasonId", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [
|
|
|
|
|
makePick({ id: "p-1", name: "Alice", sportsSeasonId: "ss-1", scoringPattern: "playoff_bracket", finalPosition: 1 }),
|
|
|
|
|
makePick({ id: "p-2", name: "Bob", sportsSeasonId: "ss-1", scoringPattern: "playoff_bracket", finalPosition: 2 }),
|
|
|
|
|
makePick({ id: "p-3", name: "Carol", sportsSeasonId: "ss-2", scoringPattern: "playoff_bracket", finalPosition: 1 }),
|
|
|
|
|
],
|
|
|
|
|
scoringEvents: [
|
|
|
|
|
{ sportsSeasonId: "ss-1", bracketTemplateId: null },
|
|
|
|
|
{ sportsSeasonId: "ss-2", bracketTemplateId: null },
|
|
|
|
|
],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")).toHaveLength(2);
|
|
|
|
|
expect(result.get("ss-2")).toHaveLength(1);
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe("qualifying_points pattern — active (no finalPosition)", () => {
|
|
|
|
|
it("returns currentQP from participantQualifyingTotals", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ id: "p-1", sportsSeasonId: "ss-1", scoringPattern: "qualifying_points", finalPosition: null })],
|
|
|
|
|
qualifyingTotals: [{ participantId: "p-1", totalQualifyingPoints: "42.5" }],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({
|
|
|
|
|
earnedPoints: null,
|
|
|
|
|
currentQP: 42.5,
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("returns null currentQP when participant has no QP total row", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ id: "p-1", sportsSeasonId: "ss-1", scoringPattern: "qualifying_points", finalPosition: null })],
|
|
|
|
|
qualifyingTotals: [],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({ earnedPoints: null, currentQP: null });
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe("qualifying_points pattern — finalized (has finalPosition)", () => {
|
|
|
|
|
it("returns earnedPoints via calculateFantasyPoints when finalPosition set", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ id: "p-1", sportsSeasonId: "ss-1", scoringPattern: "qualifying_points", finalPosition: 2 })],
|
|
|
|
|
qualifyingTotals: [{ participantId: "p-1", totalQualifyingPoints: "99" }],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({
|
|
|
|
|
earnedPoints: 75, // pointsFor2nd
|
|
|
|
|
currentQP: null,
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-05-17 21:58:53 -07:00
|
|
|
|
|
|
|
|
it("splits earnedPoints for tied QP placements", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ id: "p-1", sportsSeasonId: "ss-1", scoringPattern: "qualifying_points", finalPosition: 2 })],
|
|
|
|
|
qualifyingTotals: [{ participantId: "p-1", totalQualifyingPoints: "99" }],
|
|
|
|
|
seasonParticipantResults: [
|
|
|
|
|
{ sportsSeasonId: "ss-1", finalPosition: 2 },
|
|
|
|
|
{ sportsSeasonId: "ss-1", finalPosition: 2 },
|
|
|
|
|
],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({
|
Unify tie-split point math across every screen
A participant tied for a scoring placement splits the combined points of
the tied positions. Four code paths computed a pick's points, each
re-implementing the same bracket/qualifying_points/default cascade, and
two of them omitted the qualifying_points arm entirely. A golfer tied for
8th was therefore worth the full 15 points on the team page and draft
board but the split 7.5 in the standings, so a team read 225 on one
screen and 218 on another.
Collapse the cascade into a single calculatePickPoints helper and route
all six call sites through it, backed by one shared getSharedPlacementCounts
loader replacing the two separate tie-count queries. Tie counts span every
participant in the sports season, not just drafted ones, since an
undrafted tie partner still halves the award.
Also round split awards to the nearest whole point in
calculateAveragedPoints. The /rules page states ties are "combined and
split equally among them, rounded to the nearest whole point", and its own
worked example rounds 18.33 down to 18, so this is nearest rather than
ceiling. Season point values are integer columns, making this averaging
the only source of fractional points; rounding here means the standings'
218 is now correct by construction rather than a display artifact, and
per-pick values visibly sum to the team total.
Existing assertions encoding the unrounded results are updated, and the
rules page's two published examples are asserted directly so the code and
the published rule cannot drift apart.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019LZLF1PAfeKdpYog3NKtyz
2026-08-07 07:29:37 +00:00
|
|
|
earnedPoints: 63, // (75 + 50) / 2 = 62.5 → 63
|
2026-05-17 21:58:53 -07:00
|
|
|
currentQP: null,
|
|
|
|
|
});
|
|
|
|
|
});
|
2026-04-23 22:09:25 -07:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
describe("season_standings pattern", () => {
|
|
|
|
|
it("returns earnedPoints via calculateFantasyPoints", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ id: "p-1", sportsSeasonId: "ss-1", scoringPattern: "season_standings", finalPosition: 3 })],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
const result = await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(result.get("ss-1")?.[0]).toMatchObject({
|
|
|
|
|
earnedPoints: 50, // pointsFor3rd
|
|
|
|
|
currentQP: null,
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("does not query scoringEvents when no playoff_bracket picks", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ scoringPattern: "season_standings", finalPosition: 1 })],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
|
|
|
|
expect(db.query.scoringEvents.findMany).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it("does not query participantQualifyingTotals when no qualifying_points picks", async () => {
|
|
|
|
|
const db = makeDb({
|
|
|
|
|
picks: [makePick({ scoringPattern: "playoff_bracket", finalPosition: null })],
|
|
|
|
|
scoringEvents: [{ sportsSeasonId: "ss-1", bracketTemplateId: null }],
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
await getDraftedParticipantsWithPoints("team-1", "season-1", db);
|
|
|
|
|
|
Canonical tournament layer: schema + backfill (1/2) (#365)
* refactor(schema): rename per-window tables to season_* prefix
Renames participants, participant_expected_values, participant_qualifying_totals,
participant_results, participant_surface_elos to season_* prefixed names.
Renames event_results.participant_id to season_participant_id.
Phase 1a of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor: rename participant.ts model file to season-participant.ts
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(models): update model layer to use renamed schema exports
Updated all model files to use the renamed schema exports from Task 1:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantQualifyingTotals → seasonParticipantQualifyingTotals
- participantResults → seasonParticipantResults
- participantSurfaceElos → seasonParticipantSurfaceElos
- eventResults.participantId → eventResults.seasonParticipantId
- db.query relation accessors updated
- Relation field .participant → .seasonParticipant where applicable
- Import paths updated: ./participant → ./season-participant
Files updated (14 model files + 3 test files):
- draft-pick.ts
- draft-utils.ts
- event-result.ts
- group-stage-match.ts
- participant-result.ts
- qualifying-points.ts
- scoring-calculator.ts
- scoring-event.ts
- sports-season.ts
- surface-elo.ts
- team-score-events.ts
- cs2-major-stage.ts
- golf-skills.ts
- participant-expected-value.ts
- __tests__/sports-season.clone.test.ts
- __tests__/auto-pick.test.ts
- __tests__/executeAutoPick.timer.test.ts
Typecheck errors decreased: 779 → 499 (280 fewer)
All model file errors related to renamed schemas resolved.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(routes): update route layer to use renamed schema exports
- Update model import from ~/models/participant to ~/models/season-participant
- Rename schema.participants to schema.seasonParticipants
- Rename schema.participantResults to schema.seasonParticipantResults
- Rename db.query.participants to db.query.seasonParticipants
- Update 9 route files and 1 test file
Affected files:
- admin.sports-seasons.$id.events.$eventId.bracket.server.ts
- admin.sports-seasons.$id.participants.tsx
- api/draft.force-manual-pick.ts
- api/draft.make-pick.ts
- api/draft.replace-pick.ts
- api/seasons.$seasonId.draft.ts
- leagues/$leagueId.draft-board.$seasonId.tsx
- leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
- admin/__tests__/sports-seasons-participants.test.ts
Error count reduced from 499 to 453 (46 errors fixed).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(routes): update route files for schema rename
Update route imports from ~/models/participant to ~/models/season-participant
and fix references to .participant/.participantId on event results to use
.seasonParticipant/.seasonParticipantId after schema rename.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* refactor(services): update simulators and services for renamed schema
Update all simulators, services, and server files to use renamed schema tables:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantResults → seasonParticipantResults
- eventResults.participantId → eventResults.seasonParticipantId
Files updated:
- 20 sport simulators (NBA, NHL, NFL, MLB, etc.)
- probability-updater.ts
- standings-sync/index.ts
- sports-data-sync.server.ts
- server/socket.ts
Typecheck errors reduced from 365 to 0.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* migration: rename per-window tables to season_* prefix
* fix(tests): update mock query keys after participants table rename
Change mock db.query.participants to db.query.seasonParticipants in test
files to match the schema rename from commit 66145a9. This fixes
"Cannot read properties of undefined (reading 'findFirst'/'findMany')"
errors that occurred when production code queries db.query.seasonParticipants
but test mocks only defined the old participants key.
Files updated:
- app/services/simulations/__tests__/world-cup-simulator.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.timer-mode.test.ts
- app/routes/api/__tests__/draft.make-pick.timer-mode.test.ts
- server/__tests__/timer-autodraft.test.ts
- app/models/__tests__/team-score-events.test.ts
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(tests): update remaining mock paths and keys after schema rename
* fix(tests): final two mock stragglers after schema rename
- draft-pick.test.ts: assertion on db.query.participantQualifyingTotals
- process-match-result.test.ts: mock key participants → seasonParticipants
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* chore: add post-phase1a baseline capture (temp, for diff verification)
* chore: capture pre-migration baselines
* chore: remove post-phase1a capture helper after verification
* schema: add canonical tournament & participant tables
Adds tournaments, participants (canonical), tournament_results, and
participant_surface_elos (canonical). Adds nullable tournament_id to
scoring_events and nullable participant_id to season_participants.
Phase 1b of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(models): add canonical tournament, participant, result, surface-elo models
Adds CRUD modules for the canonical tables created in commit 775b905.
Each module mirrors existing app/models conventions (database() from
~/database/context, schema from ~/database/schema, mock-based tests).
Key implementation notes:
- participant.ts exports use "Canonical" prefix (CanonicalParticipant,
createCanonicalParticipant, etc.) to avoid collision with existing
season-participant.ts exports
- All four models include comprehensive unit tests following the
audit-log.test.ts pattern
- Tests use mocked db responses (no real database access)
- Upsert functions use onConflictDoUpdate for appropriate unique constraints
Part of Phase 1b of canonical tournament layer migration.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* migration: create canonical tables, add nullable FKs
* scripts: add extractTournamentIdentity helper for backfill
Pure function that derives canonical (name, year) identity from a
scoring_events row, stripping trailing 4-digit years from the name or
falling back to eventDate. Used by the Phase 2 backfill to group
per-window events into canonical tournaments.
* scripts: add backfill orchestrator for canonical layer
Populates canonical tournaments, participants, tournament_results, and
participant_surface_elos from per-window data for qualifying-points
sports. Skips already-linked rows, is idempotent, and supports dry-run
mode.
Critical invariants enforced by the implementation:
- qualifying_points_awarded is never copied to tournament_results
- season_participant_qualifying_totals is never touched
- conflicting surface-Elo values between windows raise a loud error
(recorded in report.errors) rather than overwriting
* scripts: add backfill CLI with dry-run default
Wires backfill-canonical-layer.ts to a CLI entry point exposed as
`npm run backfill:canonical`. Defaults to --dry-run; requires --apply
to actually write. Supports --sport=<uuid> to limit to a single sport.
Exits 2 if the backfill reports errors (e.g., surface-Elo conflicts).
* fix(backfill-cli): wrap runBackfill in DatabaseContext.run
The orchestrator uses database() from ~/database/context, which requires
AsyncLocalStorage to be populated. Wrap the CLI invocation with
DatabaseContext.run(db, ...) using server/db's cached connection pool.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* fix(backfill-cli): exit 0 on success so pg pool doesn't block
The cached postgres connection pool keeps the Node event loop open after
main() returns. Explicit process.exit(0) on success mirrors the pattern
in scripts/capture-baseline.ts.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
---------
Co-authored-by: Chris Parsons <chrisp@extrahop.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-01 20:13:18 -07:00
|
|
|
expect(db.query.seasonParticipantQualifyingTotals.findMany).not.toHaveBeenCalled();
|
2026-04-23 22:09:25 -07:00
|
|
|
});
|
|
|
|
|
});
|