chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions

style: improve code formatting and readability in league route component

Browse source
This commit is contained in:
Chris Parsons 2025-10-14 21:24:58 -07:00
parent 61929536a1
commit 1b790ed5bc
1 changed files with 42 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
app/routes/leagues/$leagueId.tsx
View file

@ -40,51 +40,69 @@ export async function loader(args: Route.LoaderArgs) {
const commissioners = await findCommissionersByLeagueId(leagueId);
// Check if current user is a commissioner
const isUserCommissioner = userId ? await isCommissioner(leagueId, userId) : false;
const isUserCommissioner = userId
? await isCommissioner(leagueId, userId)
: false;
// Check if user is a member (has a team in current season)
const isUserMember = userId ? await isUserLeagueMember(leagueId, userId) : false;
const isUserMember = userId
? await isUserLeagueMember(leagueId, userId)
: false;
// Check access: user must be a commissioner, a member, or an admin
// If not logged in or not authorized, throw 403
if (!userId) {
throw new Response("You must be logged in to view this league", { status: 401 });
throw new Response("You must be logged in to view this league", {
status: 401,
});
}
if (!isUserCommissioner && !isUserMember) {
throw new Response("You do not have access to this league", { status: 403 });
throw new Response("You do not have access to this league", {
status: 403,
});
}
// Fetch teams for current season
const teams = season ? await findTeamsBySeasonId(season.id) : [];
// Fetch user data for team owners
const ownerIds = teams.map(t => t.ownerId).filter((id): id is string => id !== null);
const ownerIds = teams
.map((t) => t.ownerId)
.filter((id): id is string => id !== null);
const uniqueOwnerIds = [...new Set(ownerIds)];
const owners = await Promise.all(
uniqueOwnerIds.map(async (ownerId) => {
const user = await findUserByClerkId(ownerId);
return user ? { clerkId: ownerId, name: user.username || user.displayName } : null;
return user
? { clerkId: ownerId, name: user.username || user.displayName }
: null;
})
);
const ownerMap = new Map(
owners.filter((o): o is NonNullable<typeof o> => o !== null).map(o => [o.clerkId, o.name])
owners
.filter((o): o is NonNullable<typeof o> => o !== null)
.map((o) => [o.clerkId, o.name])
);
// Fetch user data for commissioners
const commissionerIds = commissioners.map(c => c.userId);
const commissionerIds = commissioners.map((c) => c.userId);
const commissionerUsers = await Promise.all(
commissionerIds.map(async (commissionerId) => {
const user = await findUserByClerkId(commissionerId);
return user ? { clerkId: commissionerId, name: user.username || user.displayName } : null;
return user
? { clerkId: commissionerId, name: user.username || user.displayName }
: null;
})
);
const commissionerMap = new Map(
commissionerUsers.filter((c): c is NonNullable<typeof c> => c !== null).map(c => [c.clerkId, c.name])
commissionerUsers
.filter((c): c is NonNullable<typeof c> => c !== null)
.map((c) => [c.clerkId, c.name])
);
// Count available teams
const availableTeamCount = teams.filter(t => !t.ownerId).length;
const availableTeamCount = teams.filter((t) => !t.ownerId).length;
return {
league,
@ -134,7 +152,7 @@ export default function LeagueHome({ loaderData }: Route.ComponentProps) {
setCopied(true);
toast.success("Invite link copied to clipboard!");
setTimeout(() => setCopied(false), 2000);
} catch (err) {
} catch {
toast.error("Failed to copy invite link");
}
};
@ -171,7 +189,9 @@ export default function LeagueHome({ loaderData }: Route.ComponentProps) {
<CardHeader>
<CardTitle>Invite Link</CardTitle>
<CardDescription>
Share this link to invite people to join your league ({availableTeamCount} spot{availableTeamCount !== 1 ? "s" : ""} available)
Share this link to invite people to join your league (
{availableTeamCount} spot{availableTeamCount !== 1 ? "s" : ""}{" "}
available)
</CardDescription>
</CardHeader>
<CardContent className="space-y-3">
@ -266,7 +286,8 @@ export default function LeagueHome({ loaderData }: Route.ComponentProps) {
<CardHeader>
<CardTitle>Commissioners</CardTitle>
<CardDescription>
{commissioners.length} commissioner{commissioners.length !== 1 ? "s" : ""}
{commissioners.length} commissioner
{commissioners.length !== 1 ? "s" : ""}
</CardDescription>
</CardHeader>
<CardContent>