{allSportsSeasons.length > 0 ? (
- allSportsSeasons.map((season) => (
-
+ allSportsSeasons.map((ss) => (
+
handleSportToggle(season.id)}
+ value={ss.id}
+ checked={selectedSports.has(ss.id)}
+ onCheckedChange={() => handleSportToggle(ss.id)}
disabled={!canEditSports}
/>
diff --git a/app/routes/leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts b/app/routes/leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
index 32c8ea3..5fba189 100644
--- a/app/routes/leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
+++ b/app/routes/leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
@@ -163,8 +163,7 @@ export async function loader(args: Route.LoaderArgs) {
if (events.length > 0) {
const eventIds = events.map((e) => e.id);
const matches = await db.query.playoffMatches.findMany({
- where: (playoffMatches, { inArray }) =>
- inArray(playoffMatches.scoringEventId, eventIds),
+ where: (pm) => inArray(pm.scoringEventId, eventIds),
with: {
participant1: true,
participant2: true,
@@ -219,7 +218,7 @@ export async function loader(args: Route.LoaderArgs) {
})
.map((r) => ({
participantId: r.participantId,
- points: calculateBracketPoints(r.finalPosition!, scoringRules, templateId),
+ points: calculateBracketPoints(r.finalPosition ?? 0, scoringRules, templateId),
}));
// Track which participants have provisional (floor) scores — still competing
diff --git a/app/routes/leagues/__tests__/draft-reconnection-sync.test.ts b/app/routes/leagues/__tests__/draft-reconnection-sync.test.ts
index 20c19a6..dd5dfa7 100644
--- a/app/routes/leagues/__tests__/draft-reconnection-sync.test.ts
+++ b/app/routes/leagues/__tests__/draft-reconnection-sync.test.ts
@@ -628,7 +628,8 @@ describe("full mobile reconnection scenario", () => {
const serverPicks = Array.from({ length: 24 }, (_, i) => {
const pickNum = i + 1;
const teamIdx = getTeamForPick(pickNum, draftSlots);
- return makePick(pickNum, teamIdx!.team.id, `player-${pickNum}`);
+ if (!teamIdx) throw new Error(`No team for pick ${pickNum}`);
+ return makePick(pickNum, teamIdx.team.id, `player-${pickNum}`);
});
// Simulate draft-state-sync handler
diff --git a/app/routes/leagues/new.tsx b/app/routes/leagues/new.tsx
index 99b7167..3d77e8a 100644
--- a/app/routes/leagues/new.tsx
+++ b/app/routes/leagues/new.tsx
@@ -182,9 +182,9 @@ export async function action(args: Route.ActionArgs) {
// Create teams with fun random names
const joinAsPlayer = formData.get("joinAsPlayer") === "on";
const teamNames = generateUniqueTeamNames(teamCountNum);
- const teams = teamNames.map((name, i) => ({
+ const teams = teamNames.map((teamName, i) => ({
seasonId: season.id,
- name,
+ name: teamName,
ownerId: joinAsPlayer && i === 0 ? userId : null,
}));
diff --git a/app/services/__tests__/bracket-simulator.test.ts b/app/services/__tests__/bracket-simulator.test.ts
index 3419977..cf04d82 100644
--- a/app/services/__tests__/bracket-simulator.test.ts
+++ b/app/services/__tests__/bracket-simulator.test.ts
@@ -51,8 +51,9 @@ describe('bracket-simulator', () => {
const results = simulateBracketSync(teams, 'nhl-8', 10000);
- const strongDist = results.get('strong')!;
- const weakDist = results.get('weak')!;
+ const strongDist = results.get('strong');
+ const weakDist = results.get('weak');
+ if (!strongDist || !weakDist) throw new Error('strong or weak result not found');
// Strong team should have higher championship probability
expect(strongDist[0]).toBeGreaterThan(weakDist[0]);
@@ -76,7 +77,8 @@ describe('bracket-simulator', () => {
const results = simulateBracketSync(teams, 'nhl-8', 10000);
- const championDist = results.get('champion')!;
+ const championDist = results.get('champion');
+ if (!championDist) throw new Error('champion result not found');
// Dominant team should win very often
expect(championDist[0]).toBeGreaterThan(0.6); // >60% championship probability
@@ -139,8 +141,9 @@ describe('bracket-simulator', () => {
const results2 = simulateBracketSync(teams, 'nhl-8', 1000);
// Results won't be identical due to randomness, but should be in same ballpark
- const dist1 = results1.get('1')!;
- const dist2 = results2.get('1')!;
+ const dist1 = results1.get('1');
+ const dist2 = results2.get('1');
+ if (!dist1 || !dist2) throw new Error('Result for participant 1 not found');
// Championship probabilities should be within 10% of each other
expect(Math.abs(dist1[0] - dist2[0])).toBeLessThan(0.1);
@@ -257,8 +260,9 @@ describe('bracket-simulator', () => {
const results = await simulateBracket(teams, 'nhl-8', 10000);
- const colDist = results.get('COL')!;
- const nyiDist = results.get('NYI')!;
+ const colDist = results.get('COL');
+ const nyiDist = results.get('NYI');
+ if (!colDist || !nyiDist) throw new Error('COL or NYI result not found');
// Colorado should have highest championship probability
expect(colDist[0]).toBeGreaterThan(0.15); // >15%
diff --git a/app/services/__tests__/icm-calculator.test.ts b/app/services/__tests__/icm-calculator.test.ts
index 8993140..e7e2ad4 100644
--- a/app/services/__tests__/icm-calculator.test.ts
+++ b/app/services/__tests__/icm-calculator.test.ts
@@ -45,8 +45,11 @@ describe('icm-calculator', () => {
const results = calculateICM(participants);
- const strongProbs = icmResultToArray(results.get('strong')!);
- const weakProbs = icmResultToArray(results.get('weak')!);
+ const strongResult = results.get('strong');
+ const weakResult = results.get('weak');
+ if (!strongResult || !weakResult) throw new Error('Expected results not found');
+ const strongProbs = icmResultToArray(strongResult);
+ const weakProbs = icmResultToArray(weakResult);
// Strong team should have higher P(1st) than weak team
expect(strongProbs[0]).toBeGreaterThan(weakProbs[0]);
@@ -81,11 +84,15 @@ describe('icm-calculator', () => {
expect(results.size).toBe(32);
// Colorado (favorite) should have highest P(1st)
- const colProbs = icmResultToArray(results.get('COL')!);
+ const colResult32 = results.get('COL');
+ if (!colResult32) throw new Error('COL result not found');
+ const colProbs = icmResultToArray(colResult32);
expect(colProbs[0]).toBeGreaterThan(0.05); // Should have >5% chance of 1st
// Even the worst team should have some probability for all placements
- const worstProbs = icmResultToArray(results.get('TEAM32')!);
+ const worstResult = results.get('TEAM32');
+ if (!worstResult) throw new Error('TEAM32 result not found');
+ const worstProbs = icmResultToArray(worstResult);
worstProbs.forEach(p => {
expect(p).toBeGreaterThan(0); // Not zero
expect(p).toBeLessThan(1); // Valid probability
@@ -111,7 +118,9 @@ describe('icm-calculator', () => {
expect(results.size).toBe(1);
- const probs = icmResultToArray(results.get('1')!);
+ const singleResult = results.get('1');
+ if (!singleResult) throw new Error('Result for participant 1 not found');
+ const probs = icmResultToArray(singleResult);
// With 1 participant, only 1st place is filled (removed from pool after)
expect(probs[0]).toBeCloseTo(1.0, 1); // 100% chance of 1st
const sum = probs.reduce((acc, p) => acc + p, 0);
@@ -167,8 +176,11 @@ describe('icm-calculator', () => {
}
// Participant 1 (higher prob) should have higher P(1st)
- const probs1 = icmResultToArray(results.get('1')!);
- const probs2 = icmResultToArray(results.get('2')!);
+ const r1 = results.get('1');
+ const r2 = results.get('2');
+ if (!r1 || !r2) throw new Error('Results for participants 1 and 2 not found');
+ const probs1 = icmResultToArray(r1);
+ const probs2 = icmResultToArray(r2);
expect(probs1[0]).toBeGreaterThan(probs2[0]);
});
@@ -187,10 +199,15 @@ describe('icm-calculator', () => {
const results = calculateICM(participants);
- const first = icmResultToArray(results.get('1st')!);
- const second = icmResultToArray(results.get('2nd')!);
- const third = icmResultToArray(results.get('3rd')!);
- const fourth = icmResultToArray(results.get('4th')!);
+ const rFirst = results.get('1st');
+ const rSecond = results.get('2nd');
+ const rThird = results.get('3rd');
+ const rFourth = results.get('4th');
+ if (!rFirst || !rSecond || !rThird || !rFourth) throw new Error('Expected results not found');
+ const first = icmResultToArray(rFirst);
+ const second = icmResultToArray(rSecond);
+ const third = icmResultToArray(rThird);
+ const fourth = icmResultToArray(rFourth);
// P(1st place) should be ordered
expect(first[0]).toBeGreaterThan(second[0]);
@@ -212,8 +229,11 @@ describe('icm-calculator', () => {
expect(results.size).toBe(3);
// Colorado should have better odds than Arizona
- const colProbs = icmResultToArray(results.get('COL')!);
- const ariProbs = icmResultToArray(results.get('ARI')!);
+ const colResultOdds = results.get('COL');
+ const ariResult = results.get('ARI');
+ if (!colResultOdds || !ariResult) throw new Error('COL or ARI result not found');
+ const colProbs = icmResultToArray(colResultOdds);
+ const ariProbs = icmResultToArray(ariResult);
expect(colProbs[0]).toBeGreaterThan(ariProbs[0]);
@@ -229,8 +249,11 @@ describe('icm-calculator', () => {
const results = calculateICMFromOdds(odds);
- const favProbs = icmResultToArray(results.get('FAV')!);
- const dogProbs = icmResultToArray(results.get('DOG')!);
+ const favResult = results.get('FAV');
+ const dogResult = results.get('DOG');
+ if (!favResult || !dogResult) throw new Error('FAV or DOG result not found');
+ const favProbs = icmResultToArray(favResult);
+ const dogProbs = icmResultToArray(dogResult);
// Favorite should have higher P(1st)
expect(favProbs[0]).toBeGreaterThan(dogProbs[0]);
@@ -303,17 +326,21 @@ describe('icm-calculator', () => {
expect(results.size).toBe(32);
// Favorite (Colorado) should have reasonable championship probability
- const colProbs = icmResultToArray(results.get('COL')!);
+ const colResultInteg = results.get('COL');
+ const detResult = results.get('DET');
+ const longResult = results.get('TEAM32');
+ if (!colResultInteg || !detResult || !longResult) throw new Error('Expected results not found');
+ const colProbs = icmResultToArray(colResultInteg);
expect(colProbs[0]).toBeGreaterThan(0.05); // >5% for 1st
expect(colProbs[0]).toBeLessThan(0.35); // <35% for 1st (not guaranteed)
// Middle team (Detroit) should have middling probabilities
- const detProbs = icmResultToArray(results.get('DET')!);
+ const detProbs = icmResultToArray(detResult);
expect(detProbs[0]).toBeGreaterThan(0); // Some chance
expect(detProbs[0]).toBeLessThan(0.10); // But not high
// Longshot should have very small but non-zero probabilities
- const longProbs = icmResultToArray(results.get('TEAM32')!);
+ const longProbs = icmResultToArray(longResult);
expect(longProbs[0]).toBeGreaterThan(0); // Not impossible
expect(longProbs[0]).toBeLessThan(0.05); // But unlikely (with 32 teams, even worst has ~3% uniform)
diff --git a/app/services/__tests__/probability-engine.test.ts b/app/services/__tests__/probability-engine.test.ts
index a3495e9..2917801 100644
--- a/app/services/__tests__/probability-engine.test.ts
+++ b/app/services/__tests__/probability-engine.test.ts
@@ -200,8 +200,8 @@ describe('probability-engine', () => {
const eloRatings = convertFuturesToElo(odds, 'american');
expect(eloRatings.size).toBe(3);
- expect(eloRatings.get('1')).toBeGreaterThan(eloRatings.get('2')!);
- expect(eloRatings.get('2')).toBeGreaterThan(eloRatings.get('3')!);
+ expect(eloRatings.get('1')).toBeGreaterThan(eloRatings.get('2') ?? 0);
+ expect(eloRatings.get('2')).toBeGreaterThan(eloRatings.get('3') ?? 0);
// Strongest team should be near max Elo
expect(eloRatings.get('1')).toBeGreaterThan(1600);
@@ -220,8 +220,8 @@ describe('probability-engine', () => {
const eloRatings = convertFuturesToElo(odds, 'decimal');
expect(eloRatings.size).toBe(3);
- expect(eloRatings.get('1')).toBeGreaterThan(eloRatings.get('2')!);
- expect(eloRatings.get('2')).toBeGreaterThan(eloRatings.get('3')!);
+ expect(eloRatings.get('1')).toBeGreaterThan(eloRatings.get('2') ?? 0);
+ expect(eloRatings.get('2')).toBeGreaterThan(eloRatings.get('3') ?? 0);
});
it('uses custom calibration parameters', () => {
@@ -302,8 +302,8 @@ describe('probability-engine', () => {
];
const eloRatings = convertFuturesToElo(odds, 'american');
- const colElo = eloRatings.get('col')!;
- const nyiElo = eloRatings.get('nyi')!;
+ const colElo = eloRatings.get('col') ?? 1500;
+ const nyiElo = eloRatings.get('nyi') ?? 1500;
// Calculate predicted game line
const predicted = eloWinProbability(colElo, nyiElo);
diff --git a/app/services/bracket-simulator.ts b/app/services/bracket-simulator.ts
index ac5ba93..4b605cd 100644
--- a/app/services/bracket-simulator.ts
+++ b/app/services/bracket-simulator.ts
@@ -132,7 +132,8 @@ function simulate8TeamBracket(teams: TeamForSimulation[]): SimulationResult {
// Finals: 2 → 1
const champion = simulateMatchup(finalists[0], finalists[1]);
- const runnerUp = finalists.find(t => t.participantId !== champion.participantId)!;
+ const runnerUp = finalists.find(t => t.participantId !== champion.participantId);
+ if (!runnerUp) throw new Error("Runner-up not found in finalists");
placements.set(champion.participantId, 1);
placements.set(runnerUp.participantId, 2);
diff --git a/app/services/icm-calculator.ts b/app/services/icm-calculator.ts
index 470b9c8..0e01faa 100644
--- a/app/services/icm-calculator.ts
+++ b/app/services/icm-calculator.ts
@@ -133,7 +133,8 @@ export function calculateICM(
// Record results
for (let pos = 0; pos < placements.length; pos++) {
- counts.get(placements[pos])![pos]++;
+ const participantCounts = counts.get(placements[pos]);
+ if (participantCounts) participantCounts[pos]++;
}
// Progress logging every 10,000 iterations
@@ -149,7 +150,7 @@ export function calculateICM(
const results = new Map
();
for (const p of normalized) {
- const participantCounts = counts.get(p.participantId)!;
+ const participantCounts = counts.get(p.participantId) ?? Array(scoringPlaces).fill(0);
const probabilities = participantCounts.map(count => count / iterations);
results.set(p.participantId, {
diff --git a/app/services/probability-updater.ts b/app/services/probability-updater.ts
index 359f19f..ab0c894 100644
--- a/app/services/probability-updater.ts
+++ b/app/services/probability-updater.ts
@@ -127,7 +127,7 @@ export async function updateProbabilitiesAfterResult(
const finishedMap = new Map(
results
.filter(r => r.finalPosition !== null)
- .map(r => [r.participantId, r.finalPosition!])
+ .map(r => [r.participantId, r.finalPosition ?? 0])
);
// Update finished participants
@@ -263,7 +263,7 @@ export async function previewProbabilityUpdate(
const finishedMap = new Map(
results
.filter(r => r.finalPosition !== null)
- .map(r => [r.participantId, r.finalPosition!])
+ .map(r => [r.participantId, r.finalPosition ?? 0])
);
const comparisons: ProbabilityComparison[] = [];
diff --git a/app/services/simulations/__tests__/ucl-simulator.test.ts b/app/services/simulations/__tests__/ucl-simulator.test.ts
index cbafde7..45b65a1 100644
--- a/app/services/simulations/__tests__/ucl-simulator.test.ts
+++ b/app/services/simulations/__tests__/ucl-simulator.test.ts
@@ -306,18 +306,18 @@ describe("UCLSimulator.simulate()", () => {
// Actually: QF1: team-1 beats team-4; QF2: team-6 beats team-8; etc.
const qfMatches = Array.from({ length: 4 }, (_, i) => {
const matchNum = i + 1;
- const r16w1 = r16Matches[(matchNum - 1) * 2].winnerId!;
- const r16w2 = r16Matches[(matchNum - 1) * 2 + 1].winnerId!;
+ const r16w1 = r16Matches[(matchNum - 1) * 2].winnerId ?? "";
+ const r16w2 = r16Matches[(matchNum - 1) * 2 + 1].winnerId ?? "";
const winner = matchNum === 1 ? r16w1 : r16w2;
const loser = matchNum === 1 ? r16w2 : r16w1;
return makeQFMatch(matchNum, { winnerId: winner, loserId: loser, isComplete: true });
});
// SF: QF1 winner (team-1) + QF2 winner → SF1: team-1 wins
- const sf1Winner = qfMatches[0].winnerId!;
- const sf1Loser = qfMatches[1].winnerId!;
- const sf2Winner = qfMatches[2].winnerId!;
- const sf2Loser = qfMatches[3].winnerId!;
+ const sf1Winner = qfMatches[0].winnerId ?? "";
+ const sf1Loser = qfMatches[1].winnerId ?? "";
+ const sf2Winner = qfMatches[2].winnerId ?? "";
+ const sf2Loser = qfMatches[3].winnerId ?? "";
const sfMatches = [
makeSFMatch(1, { winnerId: sf1Winner, loserId: sf1Loser, isComplete: true }),
makeSFMatch(2, { winnerId: sf2Winner, loserId: sf2Loser, isComplete: true }),
@@ -335,8 +335,9 @@ describe("UCLSimulator.simulate()", () => {
const sim = new UCLSimulator();
const results = await sim.simulate("season-1");
- const championResult = results.find((r) => r.participantId === actualChampion)!;
- const finalistResult = results.find((r) => r.participantId === actualFinalist)!;
+ const championResult = results.find((r) => r.participantId === actualChampion);
+ const finalistResult = results.find((r) => r.participantId === actualFinalist);
+ if (!championResult || !finalistResult) throw new Error('Champion or finalist result not found');
// Champion must have probFirst = 1.0
expect(championResult.probabilities.probFirst).toBeCloseTo(1.0, 3);
@@ -347,8 +348,9 @@ describe("UCLSimulator.simulate()", () => {
expect(finalistResult.probabilities.probSecond).toBeCloseTo(1.0, 3);
// R16 losers (teams that lost in R16) must have all probs = 0
- const r16LoserId = r16Matches[0].loserId!; // team-2 lost in R16 match 1
- const r16LoserResult = results.find((r) => r.participantId === r16LoserId)!;
+ const r16LoserId = r16Matches[0].loserId ?? ""; // team-2 lost in R16 match 1
+ const r16LoserResult = results.find((r) => r.participantId === r16LoserId);
+ if (!r16LoserResult) throw new Error('R16 loser result not found');
const r16Sum = Object.values(r16LoserResult.probabilities).reduce((a, b) => a + b, 0);
expect(r16Sum).toBeCloseTo(0, 5);
diff --git a/app/services/simulations/auto-racing-simulator.ts b/app/services/simulations/auto-racing-simulator.ts
index 0aec9db..ee73f14 100644
--- a/app/services/simulations/auto-racing-simulator.ts
+++ b/app/services/simulations/auto-racing-simulator.ts
@@ -174,7 +174,8 @@ export class AutoRacingSimulator implements Simulator {
for (let sim = 0; sim < NUM_SIMULATIONS; sim++) {
const finishOrder = weightedDrawWithoutReplacement(ids, weights);
for (let rank = 0; rank < Math.min(8, finishOrder.length); rank++) {
- rankCounts.get(finishOrder[rank])![rank]++;
+ const counts = rankCounts.get(finishOrder[rank]);
+ if (counts) counts[rank]++;
}
}
} else {
@@ -219,26 +220,30 @@ export class AutoRacingSimulator implements Simulator {
.map(([id]) => id);
for (let rank = 0; rank < Math.min(8, finalOrder.length); rank++) {
- rankCounts.get(finalOrder[rank])![rank]++;
+ const counts = rankCounts.get(finalOrder[rank]);
+ if (counts) counts[rank]++;
}
}
}
// 8. Convert counts → probability distributions
- const results: SimulationResult[] = participants.map((p) => ({
- participantId: p.id,
- probabilities: {
- probFirst: rankCounts.get(p.id)![0] / NUM_SIMULATIONS,
- probSecond: rankCounts.get(p.id)![1] / NUM_SIMULATIONS,
- probThird: rankCounts.get(p.id)![2] / NUM_SIMULATIONS,
- probFourth: rankCounts.get(p.id)![3] / NUM_SIMULATIONS,
- probFifth: rankCounts.get(p.id)![4] / NUM_SIMULATIONS,
- probSixth: rankCounts.get(p.id)![5] / NUM_SIMULATIONS,
- probSeventh: rankCounts.get(p.id)![6] / NUM_SIMULATIONS,
- probEighth: rankCounts.get(p.id)![7] / NUM_SIMULATIONS,
- },
- source: this.source,
- }));
+ const results: SimulationResult[] = participants.map((p) => {
+ const counts = rankCounts.get(p.id) ?? [0,0,0,0,0,0,0,0];
+ return {
+ participantId: p.id,
+ probabilities: {
+ probFirst: counts[0] / NUM_SIMULATIONS,
+ probSecond: counts[1] / NUM_SIMULATIONS,
+ probThird: counts[2] / NUM_SIMULATIONS,
+ probFourth: counts[3] / NUM_SIMULATIONS,
+ probFifth: counts[4] / NUM_SIMULATIONS,
+ probSixth: counts[5] / NUM_SIMULATIONS,
+ probSeventh: counts[6] / NUM_SIMULATIONS,
+ probEighth: counts[7] / NUM_SIMULATIONS,
+ },
+ source: this.source,
+ };
+ });
// 9. Per-position normalization: each column should sum to exactly 1.0 but
// floating-point division (count / 10000) accumulates small errors across
diff --git a/app/services/simulations/bracket-simulator.ts b/app/services/simulations/bracket-simulator.ts
index 83b9f9d..80cd30b 100644
--- a/app/services/simulations/bracket-simulator.ts
+++ b/app/services/simulations/bracket-simulator.ts
@@ -47,7 +47,7 @@ export class BracketSimulator implements Simulator {
if (hasOdds) {
const oddsInput = evRows
.filter((r) => r.sourceOdds !== null)
- .map((r) => ({ participantId: r.participantId, odds: r.sourceOdds! }));
+ .map((r) => ({ participantId: r.participantId, odds: r.sourceOdds ?? 0 }));
eloMap = convertFuturesToElo(oddsInput);
} else {
// Fall back: treat probFirst (as %) as championship win probability,
@@ -71,7 +71,7 @@ export class BracketSimulator implements Simulator {
.filter((r) => eloMap.has(r.participantId))
.map((r) => ({
participantId: r.participantId,
- elo: eloMap.get(r.participantId)!,
+ elo: eloMap.get(r.participantId) ?? 1500,
}));
if (teamsForSimulation.length === 0) {
diff --git a/app/services/simulations/nba-simulator.ts b/app/services/simulations/nba-simulator.ts
index 147ecfc..89a658d 100644
--- a/app/services/simulations/nba-simulator.ts
+++ b/app/services/simulations/nba-simulator.ts
@@ -240,6 +240,12 @@ interface TeamEntry {
data: NbaTeamData | undefined;
}
+/** Get Elo for a team entry.
+ * Fallback 1400 = conservative below-average estimate for unknown/unrecognized teams. */
+function elo(entry: TeamEntry): number {
+ return entry.data?.elo ?? 1400;
+}
+
// ─── Simulator ────────────────────────────────────────────────────────────────
export class NBASimulator implements Simulator {
@@ -297,10 +303,6 @@ export class NBASimulator implements Simulator {
return 11; // Missed playoffs
};
- /** Get Elo for a team entry.
- * Fallback 1400 = conservative below-average estimate for unknown/unrecognized teams. */
- const elo = (entry: TeamEntry): number => entry.data?.elo ?? 1400;
-
/** Simulate a single playoff game. Returns the winner. */
const simGame = (a: TeamEntry, b: TeamEntry): TeamEntry =>
Math.random() < eloWinProbability(elo(a), elo(b)) ? a : b;
@@ -383,12 +385,12 @@ export class NBASimulator implements Simulator {
const { winner: champion, loser: finalist } = simSeries(eastChamp, westChamp);
// ── Record counts (maps are pre-populated so .get() is always defined) ───
- championCounts.set(champion.id, championCounts.get(champion.id)! + 1);
- finalistCounts.set(finalist.id, finalistCounts.get(finalist.id)! + 1);
- confFinalLoserCounts.set(eastCFLoser.id, confFinalLoserCounts.get(eastCFLoser.id)! + 1);
- confFinalLoserCounts.set(westCFLoser.id, confFinalLoserCounts.get(westCFLoser.id)! + 1);
+ championCounts.set(champion.id, (championCounts.get(champion.id) ?? 0) + 1);
+ finalistCounts.set(finalist.id, (finalistCounts.get(finalist.id) ?? 0) + 1);
+ confFinalLoserCounts.set(eastCFLoser.id, (confFinalLoserCounts.get(eastCFLoser.id) ?? 0) + 1);
+ confFinalLoserCounts.set(westCFLoser.id, (confFinalLoserCounts.get(westCFLoser.id) ?? 0) + 1);
for (const loser of [...eastR2Losers, ...westR2Losers]) {
- confSemiLoserCounts.set(loser.id, confSemiLoserCounts.get(loser.id)! + 1);
+ confSemiLoserCounts.set(loser.id, (confSemiLoserCounts.get(loser.id) ?? 0) + 1);
}
// Round 1 losers are not counted (0 points per scoring rules).
}
@@ -400,10 +402,10 @@ export class NBASimulator implements Simulator {
// probFifth–Eighth → confSemiLoserCounts / (4*N) — 4 conf semi losers per sim
const N = NUM_SIMULATIONS;
const results: SimulationResult[] = participantIds.map((participantId) => {
- const c = championCounts.get(participantId)!;
- const f = finalistCounts.get(participantId)!;
- const cf = confFinalLoserCounts.get(participantId)!;
- const cs = confSemiLoserCounts.get(participantId)!;
+ const c = championCounts.get(participantId) ?? 0;
+ const f = finalistCounts.get(participantId) ?? 0;
+ const cf = confFinalLoserCounts.get(participantId) ?? 0;
+ const cs = confSemiLoserCounts.get(participantId) ?? 0;
return {
participantId,
probabilities: {
diff --git a/app/services/simulations/ncaam-simulator.ts b/app/services/simulations/ncaam-simulator.ts
index 12d4aba..eb35850 100644
--- a/app/services/simulations/ncaam-simulator.ts
+++ b/app/services/simulations/ncaam-simulator.ts
@@ -296,6 +296,10 @@ export function kenpomWinProbability(netrtgA: number, netrtgB: number): number {
return 1 / (1 + Math.exp(-(netrtgA - netrtgB) / KENPOM_SCALE_FACTOR));
}
+function sortByMatchNumber(matches: T[]): T[] {
+ return [...matches].toSorted((a, b) => a.matchNumber - b.matchNumber);
+}
+
// ─── Simulator ────────────────────────────────────────────────────────────────
export class NCAAMSimulator implements Simulator {
@@ -339,19 +343,24 @@ export class NCAAMSimulator implements Simulator {
const byRound = new Map();
for (const m of allMatches) {
if (!byRound.has(m.round)) byRound.set(m.round, []);
- byRound.get(m.round)!.push(m);
+ byRound.get(m.round)?.push(m);
}
- const sortByMatchNumber = (matches: typeof allMatches) =>
- [...matches].toSorted((a, b) => a.matchNumber - b.matchNumber);
+ const rawFirstFour = byRound.get("First Four");
+ const rawR64 = byRound.get("Round of 64");
+ const rawR32 = byRound.get("Round of 32");
+ const rawS16 = byRound.get("Sweet Sixteen");
+ const rawE8 = byRound.get("Elite Eight");
+ const rawFF = byRound.get("Final Four");
+ const rawChamp = byRound.get("Championship");
- const firstFourMatches = byRound.has("First Four") ? sortByMatchNumber(byRound.get("First Four")!) : [];
- const r64Matches = byRound.has("Round of 64") ? sortByMatchNumber(byRound.get("Round of 64")!) : null;
- const r32Matches = byRound.has("Round of 32") ? sortByMatchNumber(byRound.get("Round of 32")!) : null;
- const s16Matches = byRound.has("Sweet Sixteen") ? sortByMatchNumber(byRound.get("Sweet Sixteen")!) : null;
- const e8Matches = byRound.has("Elite Eight") ? sortByMatchNumber(byRound.get("Elite Eight")!) : null;
- const ffMatches = byRound.has("Final Four") ? sortByMatchNumber(byRound.get("Final Four")!) : null;
- const champMatches = byRound.has("Championship") ? sortByMatchNumber(byRound.get("Championship")!) : null;
+ const firstFourMatches = rawFirstFour ? sortByMatchNumber(rawFirstFour) : [];
+ const r64Matches = rawR64 ? sortByMatchNumber(rawR64) : null;
+ const r32Matches = rawR32 ? sortByMatchNumber(rawR32) : null;
+ const s16Matches = rawS16 ? sortByMatchNumber(rawS16) : null;
+ const e8Matches = rawE8 ? sortByMatchNumber(rawE8) : null;
+ const ffMatches = rawFF ? sortByMatchNumber(rawFF) : null;
+ const champMatches = rawChamp ? sortByMatchNumber(rawChamp) : null;
if (!r64Matches || !r32Matches || !s16Matches || !e8Matches || !ffMatches || !champMatches) {
const found = [...byRound.keys()].join(", ");
@@ -403,7 +412,7 @@ export class NCAAMSimulator implements Simulator {
const regions =
(bracketEvent.bracketRegionConfig as BracketRegion[] | null) ??
// Fall back to the template's built-in regions — single source of truth
- NCAA_68.regions!;
+ NCAA_68.regions ?? [];
const slotMap = buildNCAA68SlotMap(regions);
for (let i = 0; i < slotMap.playInOffsets.length; i++) {
@@ -532,23 +541,25 @@ export class NCAAMSimulator implements Simulator {
// ffSimWinners: Map for the null participant2Id slots
const ffSimWinners = new Map();
for (const [ffMatchNum, r64MatchNum] of ffToR64) {
- const m = firstFourByNum.get(ffMatchNum)!;
+ const m = firstFourByNum.get(ffMatchNum);
+ if (!m) continue;
const winner = m.isComplete && m.winnerId
? m.winnerId
- : simMatch(m.participant1Id!, m.participant2Id!).winner;
+ : simMatch(m.participant1Id ?? "", m.participant2Id ?? "").winner;
ffSimWinners.set(r64MatchNum, winner);
}
// ── Round of 64 (32 matches → 32 winners) ────────────────────────────
const r64Winners: string[] = [];
for (let i = 1; i <= 32; i++) {
- const m = r64ByNum.get(i)!;
+ const m = r64ByNum.get(i);
+ if (!m) continue;
// participant2Id may be null if this slot is filled by a First Four winner
const p2 = m.participant2Id ?? ffSimWinners.get(i) ?? null;
if (m.isComplete && m.winnerId) {
r64Winners.push(m.winnerId);
} else {
- r64Winners.push(simMatch(m.participant1Id!, p2!).winner);
+ r64Winners.push(simMatch(m.participant1Id ?? "", p2 ?? "").winner);
}
}
@@ -590,8 +601,8 @@ export class NCAAMSimulator implements Simulator {
// Derive loser from stored participants if loserId is missing
loser = dbMatch.loserId ??
(dbMatch.participant1Id === dbMatch.winnerId
- ? dbMatch.participant2Id!
- : dbMatch.participant1Id!);
+ ? dbMatch.participant2Id ?? ""
+ : dbMatch.participant1Id ?? "");
} else {
const p1 = s16Winners[(i - 1) * 2];
const p2 = s16Winners[(i - 1) * 2 + 1];
@@ -611,8 +622,8 @@ export class NCAAMSimulator implements Simulator {
winner = dbMatch.winnerId;
loser = dbMatch.loserId ??
(dbMatch.participant1Id === dbMatch.winnerId
- ? dbMatch.participant2Id!
- : dbMatch.participant1Id!);
+ ? dbMatch.participant2Id ?? ""
+ : dbMatch.participant1Id ?? "");
} else {
const p1 = e8Winners[(i - 1) * 2];
const p2 = e8Winners[(i - 1) * 2 + 1];
@@ -629,8 +640,8 @@ export class NCAAMSimulator implements Simulator {
champion = champMatch.winnerId;
finalist = champMatch.loserId ??
(champMatch.participant1Id === champMatch.winnerId
- ? champMatch.participant2Id!
- : champMatch.participant1Id!);
+ ? champMatch.participant2Id ?? ""
+ : champMatch.participant1Id ?? "");
} else {
({ winner: champion, loser: finalist } = simMatch(ffWinners[0], ffWinners[1]));
}
@@ -645,10 +656,10 @@ export class NCAAMSimulator implements Simulator {
// probFifth–Eighth → e8LoserCounts / (4*N) → 4 losers * 1/(4N) = 1
const N = NUM_SIMULATIONS;
const results: SimulationResult[] = participantIds.map((participantId) => {
- const c = championCounts.get(participantId)!;
- const f = finalistCounts.get(participantId)!;
- const ff = ffLoserCounts.get(participantId)!;
- const e8 = e8LoserCounts.get(participantId)!;
+ const c = championCounts.get(participantId) ?? 0;
+ const f = finalistCounts.get(participantId) ?? 0;
+ const ff = ffLoserCounts.get(participantId) ?? 0;
+ const e8 = e8LoserCounts.get(participantId) ?? 0;
return {
participantId,
probabilities: {
diff --git a/app/services/simulations/ncaaw-simulator.ts b/app/services/simulations/ncaaw-simulator.ts
index 78452f8..e0769db 100644
--- a/app/services/simulations/ncaaw-simulator.ts
+++ b/app/services/simulations/ncaaw-simulator.ts
@@ -276,6 +276,10 @@ export function barthagWinProbability(barthagA: number, barthagB: number): numbe
return pA / total;
}
+function sortByMatchNumber(matches: T[]): T[] {
+ return [...matches].toSorted((a, b) => a.matchNumber - b.matchNumber);
+}
+
// ─── Simulator ────────────────────────────────────────────────────────────────
export class NCAAWSimulator implements Simulator {
@@ -316,19 +320,24 @@ export class NCAAWSimulator implements Simulator {
const byRound = new Map();
for (const m of allMatches) {
if (!byRound.has(m.round)) byRound.set(m.round, []);
- byRound.get(m.round)!.push(m);
+ byRound.get(m.round)?.push(m);
}
- const sortByMatchNumber = (matches: typeof allMatches) =>
- [...matches].toSorted((a, b) => a.matchNumber - b.matchNumber);
+ const rawFirstFour = byRound.get("First Four");
+ const rawR64 = byRound.get("Round of 64");
+ const rawR32 = byRound.get("Round of 32");
+ const rawS16 = byRound.get("Sweet Sixteen");
+ const rawE8 = byRound.get("Elite Eight");
+ const rawFF = byRound.get("Final Four");
+ const rawChamp = byRound.get("Championship");
- const firstFourMatches = byRound.has("First Four") ? sortByMatchNumber(byRound.get("First Four")!) : [];
- const r64Matches = byRound.has("Round of 64") ? sortByMatchNumber(byRound.get("Round of 64")!) : null;
- const r32Matches = byRound.has("Round of 32") ? sortByMatchNumber(byRound.get("Round of 32")!) : null;
- const s16Matches = byRound.has("Sweet Sixteen") ? sortByMatchNumber(byRound.get("Sweet Sixteen")!) : null;
- const e8Matches = byRound.has("Elite Eight") ? sortByMatchNumber(byRound.get("Elite Eight")!) : null;
- const ffMatches = byRound.has("Final Four") ? sortByMatchNumber(byRound.get("Final Four")!) : null;
- const champMatches = byRound.has("Championship") ? sortByMatchNumber(byRound.get("Championship")!) : null;
+ const firstFourMatches = rawFirstFour ? sortByMatchNumber(rawFirstFour) : [];
+ const r64Matches = rawR64 ? sortByMatchNumber(rawR64) : null;
+ const r32Matches = rawR32 ? sortByMatchNumber(rawR32) : null;
+ const s16Matches = rawS16 ? sortByMatchNumber(rawS16) : null;
+ const e8Matches = rawE8 ? sortByMatchNumber(rawE8) : null;
+ const ffMatches = rawFF ? sortByMatchNumber(rawFF) : null;
+ const champMatches = rawChamp ? sortByMatchNumber(rawChamp) : null;
if (!r64Matches || !r32Matches || !s16Matches || !e8Matches || !ffMatches || !champMatches) {
const found = [...byRound.keys()].join(", ");
@@ -370,7 +379,7 @@ export class NCAAWSimulator implements Simulator {
const regions =
(bracketEvent.bracketRegionConfig as BracketRegion[] | null) ??
// Fall back to the template's built-in regions — single source of truth
- NCAA_68.regions!;
+ NCAA_68.regions ?? [];
const slotMap = buildNCAA68SlotMap(regions);
for (let i = 0; i < slotMap.playInOffsets.length; i++) {
@@ -494,22 +503,24 @@ export class NCAAWSimulator implements Simulator {
// ── First Four ────────────────────────────────────────────────────────
const ffSimWinners = new Map();
for (const [ffMatchNum, r64MatchNum] of ffToR64) {
- const m = firstFourByNum.get(ffMatchNum)!;
+ const m = firstFourByNum.get(ffMatchNum);
+ if (!m) continue;
const winner = m.isComplete && m.winnerId
? m.winnerId
- : simMatch(m.participant1Id!, m.participant2Id!).winner;
+ : simMatch(m.participant1Id ?? "", m.participant2Id ?? "").winner;
ffSimWinners.set(r64MatchNum, winner);
}
// ── Round of 64 ───────────────────────────────────────────────────────
const r64Winners: string[] = [];
for (let i = 1; i <= 32; i++) {
- const m = r64ByNum.get(i)!;
+ const m = r64ByNum.get(i);
+ if (!m) continue;
const p2 = m.participant2Id ?? ffSimWinners.get(i) ?? null;
if (m.isComplete && m.winnerId) {
r64Winners.push(m.winnerId);
} else {
- r64Winners.push(simMatch(m.participant1Id!, p2!).winner);
+ r64Winners.push(simMatch(m.participant1Id ?? "", p2 ?? "").winner);
}
}
@@ -550,8 +561,8 @@ export class NCAAWSimulator implements Simulator {
// Derive loser from stored participants if loserId is missing
loser = dbMatch.loserId ??
(dbMatch.participant1Id === dbMatch.winnerId
- ? dbMatch.participant2Id!
- : dbMatch.participant1Id!);
+ ? dbMatch.participant2Id ?? ""
+ : dbMatch.participant1Id ?? "");
} else {
const p1 = s16Winners[(i - 1) * 2];
const p2 = s16Winners[(i - 1) * 2 + 1];
@@ -571,8 +582,8 @@ export class NCAAWSimulator implements Simulator {
winner = dbMatch.winnerId;
loser = dbMatch.loserId ??
(dbMatch.participant1Id === dbMatch.winnerId
- ? dbMatch.participant2Id!
- : dbMatch.participant1Id!);
+ ? dbMatch.participant2Id ?? ""
+ : dbMatch.participant1Id ?? "");
} else {
const p1 = e8Winners[(i - 1) * 2];
const p2 = e8Winners[(i - 1) * 2 + 1];
@@ -589,8 +600,8 @@ export class NCAAWSimulator implements Simulator {
champion = champMatch.winnerId;
finalist = champMatch.loserId ??
(champMatch.participant1Id === champMatch.winnerId
- ? champMatch.participant2Id!
- : champMatch.participant1Id!);
+ ? champMatch.participant2Id ?? ""
+ : champMatch.participant1Id ?? "");
} else {
({ winner: champion, loser: finalist } = simMatch(ffWinners[0], ffWinners[1]));
}
@@ -601,10 +612,10 @@ export class NCAAWSimulator implements Simulator {
// 10. Convert integer counts to probability distributions.
const N = NUM_SIMULATIONS;
const results: SimulationResult[] = participantIds.map((participantId) => {
- const c = championCounts.get(participantId)!;
- const f = finalistCounts.get(participantId)!;
- const ff = ffLoserCounts.get(participantId)!;
- const e8 = e8LoserCounts.get(participantId)!;
+ const c = championCounts.get(participantId) ?? 0;
+ const f = finalistCounts.get(participantId) ?? 0;
+ const ff = ffLoserCounts.get(participantId) ?? 0;
+ const e8 = e8LoserCounts.get(participantId) ?? 0;
return {
participantId,
probabilities: {
diff --git a/app/services/simulations/nhl-simulator.ts b/app/services/simulations/nhl-simulator.ts
index e296af3..9b042c1 100644
--- a/app/services/simulations/nhl-simulator.ts
+++ b/app/services/simulations/nhl-simulator.ts
@@ -291,6 +291,37 @@ type DivisionSeedings = {
third: TeamEntry;
};
+/** Get Elo for a team entry. Fallback 1400 for unknown teams. */
+function elo(entry: TeamEntry): number {
+ return entry.data?.elo ?? 1400;
+}
+
+/**
+ * Weighted pick without replacement.
+ * Draws one team from `pool` using the given seeding weight key, excluding `excluded`.
+ * Returns undefined if no eligible team has positive weight — the caller should
+ * treat that as a degenerate draw and skip the iteration.
+ */
+function weightedPick(
+ pool: TeamEntry[],
+ weightKey: "p_div1" | "p_div2" | "p_div3" | "p_wc1" | "p_wc2",
+ excluded: Set
+): TeamEntry | undefined {
+ const eligible = pool.filter((t) => !excluded.has(t));
+ if (eligible.length === 0) return undefined;
+
+ const weights = eligible.map((t) => t.data?.[weightKey] ?? 0);
+ const total = weights.reduce((s, w) => s + w, 0);
+ if (total === 0) return undefined;
+
+ let r = Math.random() * total;
+ for (let i = 0; i < eligible.length; i++) {
+ r -= weights[i];
+ if (r <= 0) return eligible[i];
+ }
+ return eligible[eligible.length - 1];
+}
+
// ─── Simulator ────────────────────────────────────────────────────────────────
export class NHLSimulator implements Simulator {
@@ -348,9 +379,6 @@ export class NHLSimulator implements Simulator {
// ─── Helpers (defined once, outside the hot loop) ─────────────────────────
- /** Get Elo for a team entry. Fallback 1400 for unknown teams. */
- const elo = (entry: TeamEntry): number => entry.data?.elo ?? 1400;
-
/** Simulate a best-of-7 series. Returns winner and loser. */
const simSeries = (a: TeamEntry, b: TeamEntry): { winner: TeamEntry; loser: TeamEntry } => {
const winProb = eloWinProbability(elo(a), elo(b));
@@ -362,32 +390,6 @@ export class NHLSimulator implements Simulator {
return winsA === 4 ? { winner: a, loser: b } : { winner: b, loser: a };
};
- /**
- * Weighted pick without replacement.
- * Draws one team from `pool` using the given seeding weight key, excluding `excluded`.
- * Returns undefined if no eligible team has positive weight — the caller should
- * treat that as a degenerate draw and skip the iteration.
- */
- const weightedPick = (
- pool: TeamEntry[],
- weightKey: "p_div1" | "p_div2" | "p_div3" | "p_wc1" | "p_wc2",
- excluded: Set
- ): TeamEntry | undefined => {
- const eligible = pool.filter((t) => !excluded.has(t));
- if (eligible.length === 0) return undefined;
-
- const weights = eligible.map((t) => t.data?.[weightKey] ?? 0);
- const total = weights.reduce((s, w) => s + w, 0);
- if (total === 0) return undefined; // no team has positive weight for this slot
-
- let r = Math.random() * total;
- for (let i = 0; i < eligible.length; i++) {
- r -= weights[i];
- if (r <= 0) return eligible[i];
- }
- return eligible[eligible.length - 1];
- };
-
/**
* Draw the top-3 playoff seeds for a single division.
* Returns undefined for each position if no team has weight for that slot
@@ -491,7 +493,7 @@ export class NHLSimulator implements Simulator {
// Conference Final.
const eastCF = simSeries(eastR2m1.winner, eastR2m2.winner);
const eastChamp = eastCF.winner;
- confFinalLoserCounts.set(eastCF.loser.id, confFinalLoserCounts.get(eastCF.loser.id)! + 1);
+ confFinalLoserCounts.set(eastCF.loser.id, (confFinalLoserCounts.get(eastCF.loser.id) ?? 0) + 1);
// ── Western Conference ────────────────────────────────────────────────────
const westR1Winners = westBracket.map(([a, b]) => simSeries(a, b).winner);
@@ -499,16 +501,16 @@ export class NHLSimulator implements Simulator {
const westR2m2 = simSeries(westR1Winners[1], westR1Winners[3]);
const westCF = simSeries(westR2m1.winner, westR2m2.winner);
const westChamp = westCF.winner;
- confFinalLoserCounts.set(westCF.loser.id, confFinalLoserCounts.get(westCF.loser.id)! + 1);
+ confFinalLoserCounts.set(westCF.loser.id, (confFinalLoserCounts.get(westCF.loser.id) ?? 0) + 1);
// ── Stanley Cup Final ─────────────────────────────────────────────────────
const final = simSeries(eastChamp, westChamp);
- championCounts.set(final.winner.id, championCounts.get(final.winner.id)! + 1);
- finalistCounts.set(final.loser.id, finalistCounts.get(final.loser.id)! + 1);
+ championCounts.set(final.winner.id, (championCounts.get(final.winner.id) ?? 0) + 1);
+ finalistCounts.set(final.loser.id, (finalistCounts.get(final.loser.id) ?? 0) + 1);
// Round 2 losers (4 per sim). Round 1 losers are not counted (0 points).
for (const loser of [eastR2m1.loser, eastR2m2.loser, westR2m1.loser, westR2m2.loser]) {
- r2LoserCounts.set(loser.id, r2LoserCounts.get(loser.id)! + 1);
+ r2LoserCounts.set(loser.id, (r2LoserCounts.get(loser.id) ?? 0) + 1);
}
}
@@ -527,10 +529,10 @@ export class NHLSimulator implements Simulator {
//
const N = effectiveN;
const results: SimulationResult[] = participantIds.map((participantId) => {
- const c = championCounts.get(participantId)!;
- const f = finalistCounts.get(participantId)!;
- const cf = confFinalLoserCounts.get(participantId)!;
- const r2 = r2LoserCounts.get(participantId)!;
+ const c = championCounts.get(participantId) ?? 0;
+ const f = finalistCounts.get(participantId) ?? 0;
+ const cf = confFinalLoserCounts.get(participantId) ?? 0;
+ const r2 = r2LoserCounts.get(participantId) ?? 0;
return {
participantId,
probabilities: {
diff --git a/app/services/simulations/ucl-simulator.ts b/app/services/simulations/ucl-simulator.ts
index c5af2db..18e6008 100644
--- a/app/services/simulations/ucl-simulator.ts
+++ b/app/services/simulations/ucl-simulator.ts
@@ -99,7 +99,7 @@ export class UCLSimulator implements Simulator {
const byRound = new Map();
for (const m of allMatches) {
if (!byRound.has(m.round)) byRound.set(m.round, []);
- byRound.get(m.round)!.push(m);
+ byRound.get(m.round)?.push(m);
}
const sortedRoundMatches = [...byRound.values()]
@@ -139,7 +139,7 @@ export class UCLSimulator implements Simulator {
// r16Matches is sorted by matchNumber, so participantIds[0..1] = match 1, [2..3] = match 2, …
const participantIds: string[] = [];
for (const m of r16Matches) {
- participantIds.push(m.participant1Id!, m.participant2Id!);
+ participantIds.push(m.participant1Id ?? "", m.participant2Id ?? "");
}
const participantSet = new Set(participantIds);
const fallbackProb = 1 / participantIds.length;
@@ -164,7 +164,7 @@ export class UCLSimulator implements Simulator {
if (hasOdds) {
const oddsInput = evRows
.filter((r) => r.sourceOdds !== null && participantSet.has(r.participantId))
- .map((r) => ({ participantId: r.participantId, odds: r.sourceOdds! }));
+ .map((r) => ({ participantId: r.participantId, odds: r.sourceOdds ?? 0 }));
eloMap = convertFuturesToElo(oddsInput, "american");
} else {
// No odds stored — all teams get equal Elo (coin-flip bracket)
@@ -227,11 +227,12 @@ export class UCLSimulator implements Simulator {
// R16 losers: no count added (0 points per scoring rules)
const r16Winners: string[] = [];
for (let i = 1; i <= 8; i++) {
- const m = r16ByNum.get(i)!;
+ const m = r16ByNum.get(i);
+ if (!m) continue;
if (m.isComplete && m.winnerId) {
r16Winners.push(m.winnerId);
} else {
- const { winner } = simMatch(m.participant1Id!, m.participant2Id!);
+ const { winner } = simMatch(m.participant1Id ?? "", m.participant2Id ?? "");
r16Winners.push(winner);
}
}
@@ -255,9 +256,7 @@ export class UCLSimulator implements Simulator {
}
qfWinners.push(winner);
- if (qfLoserCounts.has(loser)) {
- qfLoserCounts.set(loser, qfLoserCounts.get(loser)! + 1);
- }
+ qfLoserCounts.set(loser, (qfLoserCounts.get(loser) ?? 0) + 1);
}
// ── Semifinals ───────────────────────────────────────────────────────
@@ -278,9 +277,7 @@ export class UCLSimulator implements Simulator {
}
sfWinners.push(winner);
- if (sfLoserCounts.has(loser)) {
- sfLoserCounts.set(loser, sfLoserCounts.get(loser)! + 1);
- }
+ sfLoserCounts.set(loser, (sfLoserCounts.get(loser) ?? 0) + 1);
}
// ── Final ─────────────────────────────────────────────────────────────
@@ -294,12 +291,8 @@ export class UCLSimulator implements Simulator {
({ winner: champion, loser: finalist } = simMatch(sfWinners[0], sfWinners[1]));
}
- if (championCounts.has(champion)) {
- championCounts.set(champion, championCounts.get(champion)! + 1);
- }
- if (finalistCounts.has(finalist)) {
- finalistCounts.set(finalist, finalistCounts.get(finalist)! + 1);
- }
+ championCounts.set(champion, (championCounts.get(champion) ?? 0) + 1);
+ finalistCounts.set(finalist, (finalistCounts.get(finalist) ?? 0) + 1);
}
// 11. Convert counts to probability distributions.
@@ -309,10 +302,10 @@ export class UCLSimulator implements Simulator {
// probFifth–Eighth → qfLoserCounts / (4*N) — 4 QF losers per sim
const N = NUM_SIMULATIONS;
const results: SimulationResult[] = participantIds.map((participantId) => {
- const c = championCounts.get(participantId)!;
- const f = finalistCounts.get(participantId)!;
- const sf = sfLoserCounts.get(participantId)!;
- const qf = qfLoserCounts.get(participantId)!;
+ const c = championCounts.get(participantId) ?? 0;
+ const f = finalistCounts.get(participantId) ?? 0;
+ const sf = sfLoserCounts.get(participantId) ?? 0;
+ const qf = qfLoserCounts.get(participantId) ?? 0;
return {
participantId,
probabilities: {
diff --git a/app/services/standings-sync/__tests__/nba.test.ts b/app/services/standings-sync/__tests__/nba.test.ts
index 39a5e70..ad8aef0 100644
--- a/app/services/standings-sync/__tests__/nba.test.ts
+++ b/app/services/standings-sync/__tests__/nba.test.ts
@@ -95,7 +95,8 @@ describe("NbaStandingsAdapter", () => {
expect(records).toHaveLength(3);
- const okc = records.find((r) => r.teamName === "Oklahoma City Thunder")!;
+ const okc = records.find((r) => r.teamName === "Oklahoma City Thunder");
+ if (!okc) throw new Error("Oklahoma City Thunder record not found");
expect(okc).toBeDefined();
expect(okc.wins).toBe(58);
expect(okc.losses).toBe(10);
@@ -113,7 +114,8 @@ describe("NbaStandingsAdapter", () => {
const adapter = new NbaStandingsAdapter();
const records = await adapter.fetchStandings();
- const bos = records.find((r) => r.teamName === "Boston Celtics")!;
+ const bos = records.find((r) => r.teamName === "Boston Celtics");
+ if (!bos) throw new Error("Boston Celtics record not found");
expect(bos.conference).toBe("Eastern Conference");
expect(bos.division).toBe("Atlantic Division");
});
@@ -127,10 +129,12 @@ describe("NbaStandingsAdapter", () => {
const adapter = new NbaStandingsAdapter();
const records = await adapter.fetchStandings();
- const bos = records.find((r) => r.teamName === "Boston Celtics")!;
+ const bos = records.find((r) => r.teamName === "Boston Celtics");
+ if (!bos) throw new Error("Boston Celtics record not found");
expect(bos.streak).toBe("W5");
- const tor = records.find((r) => r.teamName === "Toronto Raptors")!;
+ const tor = records.find((r) => r.teamName === "Toronto Raptors");
+ if (!tor) throw new Error("Toronto Raptors record not found");
expect(tor.streak).toBe("L2");
});
diff --git a/app/services/standings-sync/index.ts b/app/services/standings-sync/index.ts
index 9ee3093..5720e3d 100644
--- a/app/services/standings-sync/index.ts
+++ b/app/services/standings-sync/index.ts
@@ -70,7 +70,7 @@ export async function syncStandings(sportsSeasonId: string): Promise
const participantByName = new Map(participants.map((p) => [p.name, p]));
// Build a map of externalId → participant for ID-first matching
const participantByExternalId = new Map(
- participants.filter((p) => p.externalId).map((p) => [p.externalId!, p])
+ participants.filter((p) => p.externalId).map((p) => [p.externalId ?? "", p])
);
const toUpsert: Parameters[0] = [];
@@ -84,9 +84,9 @@ export async function syncStandings(sportsSeasonId: string): Promise
// Fall back to name matching
const matchedName = findMatchingTeamName(record.teamName, participantNames);
if (matchedName) {
- participant = participantByName.get(matchedName)!;
+ participant = participantByName.get(matchedName) ?? null;
// Write-back: persist externalId so future syncs skip name matching for this team
- if (!participant.externalId) {
+ if (participant && !participant.externalId) {
await updateParticipant(participant.id, { externalId: record.externalTeamId });
}
}
diff --git a/cypress/support/e2e.ts b/cypress/support/e2e.ts
index e8d4e2d..beb10f7 100644
--- a/cypress/support/e2e.ts
+++ b/cypress/support/e2e.ts
@@ -19,4 +19,3 @@ declare global {
}
}
-export {};
diff --git a/server/socket.ts b/server/socket.ts
index c44fe8a..9633867 100644
--- a/server/socket.ts
+++ b/server/socket.ts
@@ -163,7 +163,8 @@ export function initializeSocketIO(httpServer: HTTPServer): SocketIOServer {
}
// Get current connected teams for this season
- const seasonConnectedTeams = connectedTeams.get(seasonId)!;
+ const seasonConnectedTeams = connectedTeams.get(seasonId) ?? new Set();
+ if (!connectedTeams.has(seasonId)) connectedTeams.set(seasonId, seasonConnectedTeams);
// Send the list of already-connected teams to this socket
socket.emit("connected-teams-list", { teamIds: Array.from(seasonConnectedTeams) });
@@ -172,7 +173,7 @@ export function initializeSocketIO(httpServer: HTTPServer): SocketIOServer {
seasonConnectedTeams.add(teamId);
// Broadcast to everyone else that this team connected
- io!.to(`draft-${seasonId}`).emit("team-connected", { teamId });
+ io?.to(`draft-${seasonId}`).emit("team-connected", { teamId });
console.log(`Team ${teamId} connected to draft-${seasonId}. Total connected: ${seasonConnectedTeams.size}`);
}
@@ -269,7 +270,7 @@ export function initializeSocketIO(httpServer: HTTPServer): SocketIOServer {
}
}
- io!.to(`draft-${seasonId}`).emit("team-disconnected", { teamId: currentTeamId });
+ io?.to(`draft-${seasonId}`).emit("team-disconnected", { teamId: currentTeamId });
console.log(`Team ${currentTeamId} disconnected from draft-${seasonId}`);
}
});
@@ -304,7 +305,7 @@ export function initializeSocketIO(httpServer: HTTPServer): SocketIOServer {
}
}
- io!.to(`draft-${currentSeasonId}`).emit("team-disconnected", { teamId: currentTeamId });
+ io?.to(`draft-${currentSeasonId}`).emit("team-disconnected", { teamId: currentTeamId });
console.log(`Team ${currentTeamId} disconnected from draft-${currentSeasonId}`);
}
});