chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions

Remove redundant processPlayoffEvent loop from finalize-bracket action

Browse source 
All bracket rounds are already processed (with scoring and Discord
notifications) as each match winner is set via set-winner/set-round-winners.
By the time the Finalize button is clicked, placements are current and
standings are up to date. The re-processing loop was firing recalculations
and Discord notifications once per round needlessly.

The finalize action now only assigns 0 points to non-bracket participants,
marks the event complete, and runs one final standings recalculation.

https://claude.ai/code/session_01RhQS6FQRh6iYtVNaryCEf5
This commit is contained in:
Claude 2026-04-05 21:57:31 +00:00
parent a71e256bfd
commit 5e88853260
No known key found for this signature in database
1 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/routes/admin.sports-seasons.$id.events.$eventId.bracket.server.ts
View file

@ -712,20 +712,7 @@ export async function action({ request, params }: Route.ActionArgs) {
matches.flatMap((m) => [m.participant1Id, m.participant2Id].filter(Boolean))
);
// Process all rounds in order
const db = database();
for (const round of template.rounds) {
const roundMatches = matches.filter((m) => m.round === round.name);
if (roundMatches.length === 0) continue;
// Set playoffRound and process this round
await db
.update(schema.scoringEvents)
.set({ playoffRound: round.name, updatedAt: new Date() })
.where(eq(schema.scoringEvents.id, params.eventId));
await processPlayoffEvent(params.eventId, db);
}
// Assign 0 points to participants not in the bracket (Q20)
for (const participant of allParticipants) {