chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: correct test expectations for ICM edge cases and duplicate text queries

Browse source 
- ICM tests: fix single participant, zero probabilities, and 2-participant
  tests to account for simulation only filling min(participants, 8) positions
- TeamScoreBreakdown tests: use getAllByText for "150.0" which now appears
  in both the header and the Actual Points summary card

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Parsons 2026-02-17 14:24:07 -08:00
parent 96b4c5a350
commit 9211cad7d1
2 changed files with 22 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/components/standings/__tests__/TeamScoreBreakdown.test.tsx
View file

@ -152,7 +152,7 @@ describe("TeamScoreBreakdown", () => {
); );
expect(screen.getByText("Test Team")).toBeInTheDocument(); expect(screen.getByText("Test Team")).toBeInTheDocument();
expect(screen.getByText("150.0")).toBeInTheDocument(); expect(screen.getAllByText("150.0").length).toBeGreaterThanOrEqual(1);
}); });
it("should show team rank badge", () => { it("should show team rank badge", () => {
@ -432,7 +432,7 @@ describe("TeamScoreBreakdown", () => {
// Should still show team name and points // Should still show team name and points
expect(screen.getByText("Test Team")).toBeInTheDocument(); expect(screen.getByText("Test Team")).toBeInTheDocument();
expect(screen.getByText("150.0")).toBeInTheDocument(); expect(screen.getAllByText("150.0").length).toBeGreaterThanOrEqual(1);
// But not show rank badge // But not show rank badge
expect(screen.queryByText(/Rank #/)).not.toBeInTheDocument(); expect(screen.queryByText(/Rank #/)).not.toBeInTheDocument();

28
app/services/__tests__/icm-calculator.test.ts
View file

@ -112,9 +112,10 @@ describe('icm-calculator', () => {
expect(results.size).toBe(1); expect(results.size).toBe(1);
const probs = icmResultToArray(results.get('1')!); const probs = icmResultToArray(results.get('1')!);
// With 1 team and 8 positions, each column gets 100%, so row sums to 800% // With 1 participant, only 1st place is filled (removed from pool after)
expect(probs[0]).toBeCloseTo(1.0, 1); // 100% chance of 1st
const sum = probs.reduce((acc, p) => acc + p, 0); const sum = probs.reduce((acc, p) => acc + p, 0);
expect(sum).toBeCloseTo(8.0, 1); // 8 positions * 100% each expect(sum).toBeCloseTo(1.0, 1);
}); });
it('handles zero championship probabilities gracefully', () => { it('handles zero championship probabilities gracefully', () => {
@ -129,12 +130,17 @@ describe('icm-calculator', () => {
expect(results.size).toBe(3); expect(results.size).toBe(3);
// Should give equal probabilities when all have zero odds // Should give equal probabilities when all have zero odds
// With 3 teams and 8 positions, each position has 33.33% per team // With 3 teams, only positions 0-2 are filled (each team removed after placement)
results.forEach((result) => { results.forEach((result) => {
const probs = icmResultToArray(result); const probs = icmResultToArray(result);
probs.forEach(p => { // First 3 positions should each have ~1/3
expect(p).toBeCloseTo(1/3, 2); // Each team gets equal share of each position for (let i = 0; i < 3; i++) {
}); expect(probs[i]).toBeCloseTo(1/3, 1);
}
// Positions 3-7 are 0 (no participants left to fill them)
for (let i = 3; i < 8; i++) {
expect(probs[i]).toBe(0);
}
}); });
}); });
@ -149,8 +155,9 @@ describe('icm-calculator', () => {
expect(results.size).toBe(2); expect(results.size).toBe(2);
// Verify columns sum to 1.0 // With 2 participants, only positions 0-1 are filled
for (let place = 0; place < 8; place++) { // Verify those columns sum to 1.0
for (let place = 0; place < 2; place++) {
let colSum = 0; let colSum = 0;
results.forEach((result) => { results.forEach((result) => {
const probs = icmResultToArray(result); const probs = icmResultToArray(result);
@ -158,6 +165,11 @@ describe('icm-calculator', () => {
}); });
expect(colSum).toBeCloseTo(1.0, 2); expect(colSum).toBeCloseTo(1.0, 2);
} }
// Participant 1 (higher prob) should have higher P(1st)
const probs1 = icmResultToArray(results.get('1')!);
const probs2 = icmResultToArray(results.get('2')!);
expect(probs1[0]).toBeGreaterThan(probs2[0]);
}); });
it('returns empty map for empty input', () => { it('returns empty map for empty input', () => {