From a18868e02bdba391e28f6e6ffc216589d445443c Mon Sep 17 00:00:00 2001
From: Chris Parsons <chrisparsons1127@gmail.com>
Date: Tue, 24 Mar 2026 21:42:02 -0700
Subject: [PATCH] Fix oxlint errors: no-non-null-assertion and eqeqeq

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 app/models/golf-skills.ts                                 | 2 +-
 app/services/simulations/__tests__/golf-simulator.test.ts | 4 ++--
 app/services/simulations/golf-simulator.ts                | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/models/golf-skills.ts b/app/models/golf-skills.ts
index 531ff36..7f08591 100644
--- a/app/models/golf-skills.ts
+++ b/app/models/golf-skills.ts
@@ -120,7 +120,7 @@ export async function batchUpsertGolfSkills(
         participantId,
         sportsSeasonId,
         // decimal columns are stored/passed as strings in Drizzle
-        sgTotal: sgTotal != null ? String(sgTotal) : null,
+        sgTotal: sgTotal !== null && sgTotal !== undefined ? String(sgTotal) : null,
         datagolfRank: datagolfRank ?? null,
         mastersOdds: mastersOdds ?? null,
         usOpenOdds: usOpenOdds ?? null,
diff --git a/app/services/simulations/__tests__/golf-simulator.test.ts b/app/services/simulations/__tests__/golf-simulator.test.ts
index 423d461..851fe7e 100644
--- a/app/services/simulations/__tests__/golf-simulator.test.ts
+++ b/app/services/simulations/__tests__/golf-simulator.test.ts
@@ -29,8 +29,8 @@ describe("americanToImplied", () => {
   it("returns probability in (0, 1] for valid odds", () => {
     const p = americanToImplied(200);
     expect(p).not.toBeNull();
-    expect(p!).toBeGreaterThan(0);
-    expect(p!).toBeLessThanOrEqual(1);
+    expect(p).toBeGreaterThan(0);
+    expect(p).toBeLessThanOrEqual(1);
   });
 });
 
diff --git a/app/services/simulations/golf-simulator.ts b/app/services/simulations/golf-simulator.ts
index e9729f0..3011de1 100644
--- a/app/services/simulations/golf-simulator.ts
+++ b/app/services/simulations/golf-simulator.ts
@@ -100,12 +100,12 @@ export function resolveSkill(
   skills: GolfSkillsRecord | undefined,
   oddsKey: keyof Pick<GolfSkillsRecord, "mastersOdds" | "usOpenOdds" | "openChampionshipOdds" | "pgaChampionshipOdds"> | null
 ): number {
-  if (skills?.sgTotal != null) {
+  if (skills?.sgTotal !== null && skills?.sgTotal !== undefined) {
     return skills.sgTotal;
   }
   if (oddsKey && skills) {
     const rawOdds = skills[oddsKey];
-    if (rawOdds != null) {
+    if (rawOdds !== null && rawOdds !== undefined) {
       const implied = americanToImplied(rawOdds);
       if (implied !== null) {
         // Convert implied win probability to SG-equivalent: