chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix lint errors in simulator-config tests and probability-engine

Browse source 
- Replace non-null assertions (`!`) with optional chaining (`?.`) in simulator-config tests
- Remove redundant type annotations on default parameters in probability-engine

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Parsons 2026-04-17 11:39:10 -07:00
parent ec3e090e70
commit b425173165
2 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/services/probability-engine.ts
View file

@ -319,8 +319,8 @@ export function calculatePredictionError(
export function projectedWinsToElo( export function projectedWinsToElo(
projectedWins: number, projectedWins: number,
totalGames: number, totalGames: number,
parityFactor: number = 400, parityFactor = 400,
averageElo: number = 1500 averageElo = 1500
): number { ): number {
if (totalGames <= 0) { if (totalGames <= 0) {
throw new Error('Total games must be positive'); throw new Error('Total games must be positive');
@ -362,8 +362,8 @@ export function projectedWinsToElo(
export function eloToProjectedWins( export function eloToProjectedWins(
elo: number, elo: number,
totalGames: number, totalGames: number,
parityFactor: number = 400, parityFactor = 400,
averageElo: number = 1500 averageElo = 1500
): number { ): number {
const winProb = 1 / (1 + Math.pow(10, (averageElo - elo) / parityFactor)); const winProb = 1 / (1 + Math.pow(10, (averageElo - elo) / parityFactor));
return winProb * totalGames; return winProb * totalGames;

18
app/services/simulations/__tests__/simulator-config.test.ts
View file

@ -6,35 +6,35 @@ describe("simulator-config", () => {
it("returns config for afl_bracket", () => { it("returns config for afl_bracket", () => {
const config = getSimulatorConfig("afl_bracket"); const config = getSimulatorConfig("afl_bracket");
expect(config).not.toBeNull(); expect(config).not.toBeNull();
expect(config!.seasonGames).toBe(23); expect(config?.seasonGames).toBe(23);
expect(config!.parityFactor).toBe(450); expect(config?.parityFactor).toBe(450);
expect(config!.averageOpponentElo).toBe(1500); expect(config?.averageOpponentElo).toBe(1500);
}); });
it("returns config for nfl_bracket", () => { it("returns config for nfl_bracket", () => {
const config = getSimulatorConfig("nfl_bracket"); const config = getSimulatorConfig("nfl_bracket");
expect(config).not.toBeNull(); expect(config).not.toBeNull();
expect(config!.seasonGames).toBe(17); expect(config?.seasonGames).toBe(17);
expect(config!.parityFactor).toBe(400); expect(config?.parityFactor).toBe(400);
}); });
it("returns config for nba_bracket", () => { it("returns config for nba_bracket", () => {
const config = getSimulatorConfig("nba_bracket"); const config = getSimulatorConfig("nba_bracket");
expect(config).not.toBeNull(); expect(config).not.toBeNull();
expect(config!.seasonGames).toBe(82); expect(config?.seasonGames).toBe(82);
}); });
it("returns config for nhl_bracket", () => { it("returns config for nhl_bracket", () => {
const config = getSimulatorConfig("nhl_bracket"); const config = getSimulatorConfig("nhl_bracket");
expect(config).not.toBeNull(); expect(config).not.toBeNull();
expect(config!.seasonGames).toBe(82); expect(config?.seasonGames).toBe(82);
expect(config!.parityFactor).toBe(1000); expect(config?.parityFactor).toBe(1000);
}); });
it("returns config for mlb_bracket", () => { it("returns config for mlb_bracket", () => {
const config = getSimulatorConfig("mlb_bracket"); const config = getSimulatorConfig("mlb_bracket");
expect(config).not.toBeNull(); expect(config).not.toBeNull();
expect(config!.seasonGames).toBe(162); expect(config?.seasonGames).toBe(162);
}); });
it("returns null for snooker_bracket", () => { it("returns null for snooker_bracket", () => {