From f46c88824c05e0745c5a425de13ca6330c80e85b Mon Sep 17 00:00:00 2001
From: Chris Parsons <chrisparsons1127@gmail.com>
Date: Tue, 5 May 2026 14:14:33 -0700
Subject: [PATCH] Remove type asserting

---
 app/routes/leagues/$leagueId.settings.tsx | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/app/routes/leagues/$leagueId.settings.tsx b/app/routes/leagues/$leagueId.settings.tsx
index 9318bf2..7f77288 100644
--- a/app/routes/leagues/$leagueId.settings.tsx
+++ b/app/routes/leagues/$leagueId.settings.tsx
@@ -64,8 +64,12 @@ function getInitialScoringPreset(season: LoaderSeason) {
   return "custom" as const;
 }
 
+function hasFantasySeasonId(season: object): boolean {
+  return "fantasySeasonId" in season && typeof season.fantasySeasonId === "string" && season.fantasySeasonId.length > 0;
+}
+
 function findTemplateBrackt(seasons: LoaderSportsSeason[]): LoaderSportsSeason | undefined {
-  return seasons.find((ss) => ss.sport.slug === BRACKT_SLUG && !ss.fantasySeasonId);
+  return seasons.find((ss) => ss.sport.slug === BRACKT_SLUG && !hasFantasySeasonId(ss));
 }
 
 function getInitialSelectedSports({
@@ -75,10 +79,10 @@ function getInitialSelectedSports({
   season: LoaderSeason;
   allSportsSeasons: LoaderSportsSeason[];
 }) {
-  const linkedSeasons = (season?.seasonSports?.map((s) => s.sportsSeason) ?? []) as LoaderSportsSeason[];
+  const linkedSeasons = season?.seasonSports?.map((s) => s.sportsSeason) ?? [];
   const linkedIds = linkedSeasons.map((ss) => ss.id);
   const templateBrackt = findTemplateBrackt(allSportsSeasons);
-  const privateBrackt = linkedSeasons.find((ss) => ss.sport.slug === BRACKT_SLUG && !!ss.fantasySeasonId);
+  const privateBrackt = linkedSeasons.find((ss) => ss.sport.slug === BRACKT_SLUG && hasFantasySeasonId(ss));
 
   if (templateBrackt && privateBrackt) {
     return new Set(linkedIds.map((id) => (id === privateBrackt.id ? templateBrackt.id : id)));
@@ -211,7 +215,7 @@ export default function LeagueSettings({ loaderData, actionData }: Route.Compone
   const displaySportsSeasons = (() => {
     const templateBrackt = findTemplateBrackt(allSportsSeasons);
     if (!templateBrackt) return allSportsSeasons;
-    return allSportsSeasons.filter((ss) => !(ss.sport.slug === BRACKT_SLUG && !!ss.fantasySeasonId));
+    return allSportsSeasons.filter((ss) => !(ss.sport.slug === BRACKT_SLUG && hasFantasySeasonId(ss)));
   })();
 
   useBeforeUnload(