Fix snake draft Discord pick numbering and small UX tweaks #2

Merged

chrisp merged 3 commits from chore/draft-ux-tweaks into main 2026-05-22 04:18:12 +00:00

Conversation 0 Commits 3 Files changed 8 +35 -15

chrisp commented 2026-05-22 04:02:39 +00:00

Owner

Copy link

Summary

• Discord snake draft fix: pick notifications now show the sequential pick-in-round (e.g. "Round 2, Pick 9") rather than the snake-adjusted slot position ("Round 2, Pick 5"). Also removes the now-unused `pickInRound` param from `notifyPickMadeOnDiscord` and adds a regression test for the 13-team case.
• League card: league name in draft-in-progress cards is now a link to the league homepage (the Enter Draft button still goes to the draft room).
• Overnight pause label: shortened to "🌙 Pause" — the "Resumes 4:00 AM" line below already provides context, so "Overnight" was just causing wrapping.
• Queue & Picks backgrounds: items use `bg-card` instead of `bg-muted` for better visual separation from the panel background.

Test plan

• Discord: in a snake draft, verify pick #22 of 13 shows "Round 2, Pick 9" in Discord
• League card: dashboard with a draft-in-progress league — click name → league homepage, click Enter Draft → draft room
• Overnight pause: pause a draft overnight — cell shows "🌙 Pause" on one line, "Resumes X:XX" below
• Queue/Picks: open draft room and confirm queue items and recent picks visually pop from the sidebar background
• Unit tests: npm run test:run passes (13 discord tests)

## Summary - **Discord snake draft fix**: pick notifications now show the sequential pick-in-round (e.g. "Round 2, Pick 9") rather than the snake-adjusted slot position ("Round 2, Pick 5"). Also removes the now-unused \`pickInRound\` param from \`notifyPickMadeOnDiscord\` and adds a regression test for the 13-team case. - **League card**: league name in draft-in-progress cards is now a link to the league homepage (the Enter Draft button still goes to the draft room). - **Overnight pause label**: shortened to "🌙 Pause" — the "Resumes 4:00 AM" line below already provides context, so "Overnight" was just causing wrapping. - **Queue & Picks backgrounds**: items use \`bg-card\` instead of \`bg-muted\` for better visual separation from the panel background. ## Test plan - [x] Discord: in a snake draft, verify pick #22 of 13 shows "Round 2, Pick 9" in Discord - [x] League card: dashboard with a draft-in-progress league — click name → league homepage, click Enter Draft → draft room - [x] Overnight pause: pause a draft overnight — cell shows "🌙 Pause" on one line, "Resumes X:XX" below - [x] Queue/Picks: open draft room and confirm queue items and recent picks visually pop from the sidebar background - [x] Unit tests: `npm run test:run` passes (13 discord tests)

chrisp added 1 commit 2026-05-22 04:02:40 +00:00

Fix snake draft Discord pick numbering and small UX tweaks ... 172302cad6

- Discord pick notifications now show the sequential pick-in-round
  (e.g. "Round 2, Pick 9") rather than the snake-adjusted slot position
  ("Round 2, Pick 5") — fixes confusing numbers on even rounds
- Remove unused pickInRound param from notifyPickMadeOnDiscord; add
  regression test for the 13-team snake draft case
- League name in draft-in-progress card is now a link to the league
  homepage alongside the existing Enter Draft button
- Overnight pause cell label shortened to "🌙 Pause" (resumesAt line
  below it already provides the time context)
- Queue and recent picks items use bg-card instead of bg-muted for
  better visual separation from the panel background

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp added 1 commit 2026-05-22 04:06:37 +00:00

Fix queue/picks item background and top-align pick number badge ... f3c1ad52ec

bg-card and bg-muted resolve to the same hex value, so swap to
bg-white/[0.06] for a visible lift against the sidebar background.
Also top-aligns the pick number badge in recent picks items.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp added 1 commit 2026-05-22 04:11:43 +00:00

Fix calculatePickInfo return type to include rawPickInRound ... 94ae720b08

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp merged commit 841760541d into main 2026-05-22 04:18:12 +00:00

chrisp deleted branch chore/draft-ux-tweaks 2026-05-22 04:18:12 +00:00

chrisp referenced this pull request from a commit 2026-05-22 04:18:13 +00:00

Fix snake draft Discord pick numbering and small UX tweaks (#2)

chrisp referenced this pull request from a commit 2026-06-19 00:00:05 +00:00

Fix code-review findings on qualifying-bracket QP scoring

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

admin

Admin page tooling

  

defect

Something isn't working

  

draft

Related to the draft room

  

feature

New feature or request

  

infrastructure

Related to database/site infrastructure

  

new sport

Issue to add a new sport to the rotation

  

security

Things that can cause security issues

  

tech debt

Cleaning up things that will make us have a better life

  

ux

User interface or marketing

No labels

admin

defect

draft

feature

infrastructure

new sport

security

tech debt

ux

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chrisp/brackt#2

No description provided.