Fix MLB standings 406 error and refactor ESPN adapter shared code #62

Merged

chrisp merged 3 commits from fix/mlb-standings-espn-refactor into main 2026-06-01 03:31:19 +00:00

Conversation 0 Commits 3 Files changed 9 +413 -545

chrisp commented 2026-06-01 01:18:34 +00:00

Owner

Copy link

Summary

• Root cause: statsapi.mlb.com returns 406 (deprecated). Switched MLB to ESPN's free standings API (site.api.espn.com/apis/v2/sports/baseball/mlb/standings), consistent with NBA, WNBA, and MLS.
• Refactor: Extracted a shared espn.ts utility module, eliminating 4× duplication of statsMap(), flattenEspnStandings(), ESPN interfaces, and the playoffSeed → conference rank logic across adapters.
• Bug fixes found during review and applied across all affected adapters:
  • parseConferenceRank: || undefined falsy-zero bug replaced with isNaN guard
  • Sort comparators: stable alphabetical tiebreaker added to MLB, NBA, WNBA
  • winPct: falls back to wins/(wins+losses) if ESPN omits the stat (was silently 0)
  • statsMap pre-built once per entry before sorting in all adapters (was rebuilt per comparison)
  • WNBA parseEntry: accepts pre-computed sm instead of rebuilding it internally
  • MLB gamesBack: tests updated to reflect ESPN returns numeric 0 for division leaders (old API used "-" → undefined)

Test plan

• All 60 standings-sync unit tests pass (npm run test:run -- app/services/standings-sync)
• Trigger MLB standings sync from admin panel and confirm it returns data without a 406
• Confirm NBA, WNBA, MLS syncs still work (adapters touched but behaviour unchanged)

🤖 Generated with Claude Code

## Summary - **Root cause**: `statsapi.mlb.com` returns 406 (deprecated). Switched MLB to ESPN's free standings API (`site.api.espn.com/apis/v2/sports/baseball/mlb/standings`), consistent with NBA, WNBA, and MLS. - **Refactor**: Extracted a shared `espn.ts` utility module, eliminating 4× duplication of `statsMap()`, `flattenEspnStandings()`, ESPN interfaces, and the `playoffSeed` → conference rank logic across adapters. - **Bug fixes** found during review and applied across all affected adapters: - `parseConferenceRank`: `|| undefined` falsy-zero bug replaced with `isNaN` guard - Sort comparators: stable alphabetical tiebreaker added to MLB, NBA, WNBA - `winPct`: falls back to `wins/(wins+losses)` if ESPN omits the stat (was silently 0) - statsMap pre-built once per entry before sorting in all adapters (was rebuilt per comparison) - WNBA `parseEntry`: accepts pre-computed `sm` instead of rebuilding it internally - MLB `gamesBack`: tests updated to reflect ESPN returns numeric `0` for division leaders (old API used `"-"` → `undefined`) ## Test plan - [ ] All 60 standings-sync unit tests pass (`npm run test:run -- app/services/standings-sync`) - [ ] Trigger MLB standings sync from admin panel and confirm it returns data without a 406 - [ ] Confirm NBA, WNBA, MLS syncs still work (adapters touched but behaviour unchanged) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

chrisp added 1 commit 2026-06-01 01:18:35 +00:00

Fix MLB standings 406 error and refactor ESPN adapter shared code ... e353c17a0b

- Switch MLB standings from deprecated statsapi.mlb.com to ESPN API
  (same source as NBA, WNBA, MLS — no auth required)
- Extract shared espn.ts utility: EspnStat/Team/Entry/Group/Response
  interfaces, statsMap(), flattenEspnStandings(), parseConferenceRank(),
  sortByWinLoss(); removes 4× duplication across adapters
- Fix parseConferenceRank falsy-zero bug (|| undefined → isNaN guard)
- Add stable alphabetical tiebreaker to MLB, NBA, WNBA sort comparators
- Fix winPct silent-zero: fall back to wins/(wins+losses) if ESPN omits stat
- Pre-build statsMap once per entry before sorting in all adapters
- Fix WNBA parseEntry to accept pre-computed sm instead of rebuilding it
- Restore and update gamesBack tests (ESPN returns numeric 0 for leaders,
  not the old API's "-" string)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp added 1 commit 2026-06-01 02:54:27 +00:00

Fix TypeScript errors: cast response.json() to EspnStandingsResponse ... 880b7faa6b

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp added 1 commit 2026-06-01 03:20:28 +00:00

Fix intermittent test timeouts in simulator-inputs and llws-simulator ... 3ebdd16b60

simulator-inputs: move dynamic import to top level so heavy module
initialization happens during file load (no timeout) instead of inside
the test body.

llws-simulator: make iteration count injectable via constructor
(default 50_000 for production, tests pass 1_000). Cuts test suite
from ~4s per test to <150ms for all 21 tests combined.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chrisp merged commit add196902b into main 2026-06-01 03:31:19 +00:00

chrisp referenced this pull request from a commit 2026-06-01 03:31:19 +00:00

Fix MLB standings 406 error and refactor ESPN adapter shared code (#62)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

admin

Admin page tooling

  

defect

Something isn't working

  

draft

Related to the draft room

  

feature

New feature or request

  

infrastructure

Related to database/site infrastructure

  

new sport

Issue to add a new sport to the rotation

  

security

Things that can cause security issues

  

tech debt

Cleaning up things that will make us have a better life

  

ux

User interface or marketing

No labels

admin

defect

draft

feature

infrastructure

new sport

security

tech debt

ux

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chrisp/brackt#62

No description provided.