app/services/__tests__/discord.test.ts

@@ -675,17 +675,12 @@ describe("sendDraftOrderNotification", () => {
   });
 });
 
-describe("sendQualifyingPointsUpdateNotification", () => {
+// The caller now supplies each entry's rank in the FULL season field. This helper
-  beforeEach(() => {
+// mirrors the production ranking (qualifying-points-discord.server.ts): sort by
-    vi.stubGlobal("fetch", mockFetch(204));
+// qpTotal desc, competition ranking with ties sharing the lower rank, so existing
-  });
+// tests keep asserting ranks derived from qpTotal.
-
+function withRanks<T extends { qpTotal: number }>(entries: T[]) {
-  // The caller now supplies each entry's rank in the FULL season field. This helper
+  const sorted = [...entries].toSorted((a, b) => b.qpTotal - a.qpTotal);
-  // mirrors the production ranking (qualifying-points-discord.server.ts): sort by
-  // qpTotal desc, competition ranking with ties sharing the lower rank, so existing
-  // tests keep asserting ranks derived from qpTotal.
-  function withRanks<T extends { qpTotal: number }>(entries: T[]) {
-    const sorted = [...entries].sort((a, b) => b.qpTotal - a.qpTotal);
   const rankByTotal = new Map<number, number>();
   let prevTotal = Number.NaN;
   let prevRank = 0;
@@ -702,7 +697,12 @@ describe("sendQualifyingPointsUpdateNotification", () => {
     globalRank: rankByTotal.get(e.qpTotal) ?? 0,
     globalRankTied: (countByTotal.get(e.qpTotal) ?? 0) > 1,
   }));
-  }
+}
+
+describe("sendQualifyingPointsUpdateNotification", () => {
+  beforeEach(() => {
+    vi.stubGlobal("fetch", mockFetch(204));
+  });
 
   const BASE_ENTRIES = withRanks([
     { participantName: "Novak Djokovic", qpEarned: 20, qpTotal: 45, ownerUsername: "alex" },

app/services/qualifying-points-discord.server.ts

@@ -102,7 +102,7 @@ export async function notifyQualifyingPointsUpdate(
   // ahead therefore render as T9, not T1 among just the two of them.
   const rankedField = [...qpTotalById.entries()]
     .map(([id, total]) => ({ id, total }))
-    .sort((a, b) => b.total - a.total);
+    .toSorted((a, b) => b.total - a.total);
   const globalRankById = new Map<string, number>();
   let prevTotal = Number.NaN;
   let prevRank = 0;