brackt/app/components/league/settings/PeopleSection.tsx
Chris Parsons 4bbcac1949
fix: resolve all 48 WCAG 2.2 AA accessibility issues (#439)
* fix: resolve all 48 WCAG 2.2 AA accessibility issues

Critical fixes:
- Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection)
- Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay
- Add aria-live region and connection status announcement to ConnectionOverlay

Serious fixes:
- Add skip-to-content link in root.tsx with id="main-content" on <main>
- Add aria-label to UserMenu trigger button
- Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password)
- Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans
- Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators
- Add aria-live="polite" to draft room countdown timer
- Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content
- Fix Footer text contrast (changed from 28% to text-muted-foreground)
- Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons
- Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button
- Add aria-label to PeopleSection owner and commissioner selects
- Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons
- Add role="radiogroup"+aria-checked to AutodraftSettings option buttons
- Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper

Moderate fixes:
- Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region
- Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel"
- Add role="radiogroup"+aria-checked to TimerModeSelector
- Add aria-current="page" + aria-label to SettingsDesktopNav
- Add aria-label="Admin navigation" to admin sidebar nav
- Add scope="col" + <caption> to StandingsTable and ScoringTables
- Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid

Minor fixes:
- Add aria-hidden="true" to decorative trend icons in StandingsTable
- Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection
- Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection
- Add aria-label to NotificationSettings switchOnly Switch
- Add prefers-reduced-motion check to SlotMachineHeadline JS animation
- Bump --muted-foreground from 55% to 62% opacity for improved contrast margin

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix code review findings from WCAG compliance pass

- Add Arrow key navigation + roving tabindex to all role=radiogroup
  components (AutodraftSettings x2, TimerModeSelector,
  OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern
- Extract shared focus-trap logic into useFocusTrap hook; update
  ConnectionOverlay and AuthRecoveryOverlay to use it
- Add tabIndex={-1} to ConnectionOverlay Card so focus can land in
  spinner-only state (no interactive children)
- Replace aria-live on loading dots container with sr-only span so
  status changes are announced by text content, not aria-label
- Remove contradictory aria-hidden+role=columnheader from
  AvailableParticipantsSection visual-only header row
- Remove invalid scope="col" from div[role=columnheader] in
  DraftSummaryView (scope is only valid on <th>)
- Remove redundant aria-label from ParticipantSelectionDialog sport
  select (htmlFor label is sufficient)
- Change WizardStepper connector <li> to role=presentation
- Revert muted-foreground from 62% to 55% (original already passes
  contrast; footer was fixed separately via text-muted-foreground)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix lint error and update tests for WCAG role changes

- Replace el! non-null assertion with optional chaining in useFocusTrap
- Update AutodraftSettings tests to query role="radio" instead of
  role="button" (buttons have an explicit radio role since the WCAG pass)
- Update AvailableParticipantsSection watchlist tests to use
  getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist
  buttons now use aria-label instead of title)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-05-17 20:11:38 -07:00

156 lines
6.3 KiB
TypeScript

import { Crown, Users } from "lucide-react";
import { Form } from "react-router";
import { Button } from "~/components/ui/button";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "~/components/ui/select";
import { SettingsSection, SettingsStatusPill } from "./SettingsSection";
type Team = { id: string; name: string; ownerId: string | null };
type Commissioner = { id: string; userId: string; userName: string };
type LeagueMember = { id: string; name: string | null };
export function PeopleSection({
active,
teams,
ownerMap,
commissioners,
currentUserId,
teamCountValue,
teamsWithOwners,
leagueMembers,
isAdmin,
navigationState,
}: {
active: boolean;
teams: Team[];
ownerMap: Record<string, string | null>;
commissioners: Commissioner[];
currentUserId: string;
teamCountValue: number;
teamsWithOwners: number;
leagueMembers: LeagueMember[];
isAdmin: boolean;
navigationState: "idle" | "loading" | "submitting";
}) {
return (
<SettingsSection
id="people"
icon={Users}
title="People"
description="Manage team owners and commissioners. Team capacity is saved from League Basics."
status={<SettingsStatusPill tone="default">{teamsWithOwners}/{teamCountValue} filled</SettingsStatusPill>}
className={active ? undefined : "hidden"}
>
<div className="space-y-3">
{teams.map((team) => {
const ownerName = team.ownerId ? ownerMap[team.ownerId] : null;
return (
<div key={team.id} className="flex flex-col gap-3 rounded-lg border p-3 sm:flex-row sm:items-center sm:justify-between">
<div className="min-w-0">
<p className="truncate font-medium">{team.name}</p>
<p className="text-sm text-muted-foreground">
{team.ownerId ? `Owner: ${ownerName || "Unknown"}` : "No owner"}
</p>
</div>
<div className="flex flex-col gap-2 sm:flex-row">
{team.ownerId && (
<Form method="post">
<input type="hidden" name="intent" value="remove-team-owner" />
<input type="hidden" name="teamId" value={team.id} />
<Button type="submit" variant="outline" size="sm" disabled={navigationState === "submitting"}>
Remove Owner
</Button>
</Form>
)}
{isAdmin && (
<Form method="post" className="flex flex-col gap-2 sm:flex-row">
<input type="hidden" name="intent" value="assign-team-owner" />
<input type="hidden" name="teamId" value={team.id} />
<Select name="userId" required aria-label={`Assign owner for ${team.name}`}>
<SelectTrigger className="h-9 sm:w-[190px]">
<SelectValue placeholder="Select user" />
</SelectTrigger>
<SelectContent>
{leagueMembers.map((member) => {
const userOwnsTeam = teams.some((t) => t.ownerId === member.id);
return (
<SelectItem key={member.id} value={member.id} disabled={userOwnsTeam}>
{member.name || "Unknown"}
{userOwnsTeam && " (already has team)"}
</SelectItem>
);
})}
</SelectContent>
</Select>
<Button type="submit" variant="outline" size="sm" disabled={navigationState === "submitting"}>
Assign
</Button>
</Form>
)}
</div>
</div>
);
})}
</div>
<div className="border-t pt-5">
<div className="mb-3 flex items-center gap-2">
<Crown className="h-4 w-4 text-muted-foreground" />
<h3 className="font-semibold">Commissioners</h3>
</div>
<div className="space-y-3">
{commissioners.map((commissioner) => (
<div key={commissioner.id} className="flex flex-col gap-3 rounded-lg border p-3 sm:flex-row sm:items-center sm:justify-between">
<div>
<p className="font-medium">
{commissioner.userName}
{commissioner.userId === currentUserId && <span className="ml-2 text-xs text-muted-foreground">(you)</span>}
</p>
{!teams.some((t) => t.ownerId === commissioner.userId) && (
<p className="text-xs text-muted-foreground">No team in current season</p>
)}
</div>
{commissioners.length > 1 && commissioner.userId !== currentUserId && (
<Form method="post">
<input type="hidden" name="intent" value="remove-commissioner" />
<input type="hidden" name="commissionerUserId" value={commissioner.userId} />
<Button type="submit" variant="outline" size="sm" disabled={navigationState === "submitting"}>
Remove
</Button>
</Form>
)}
</div>
))}
</div>
<Form method="post" className="mt-4 flex flex-col gap-2 sm:flex-row">
<input type="hidden" name="intent" value="add-commissioner" />
<Select name="userId" required aria-label="Add commissioner">
<SelectTrigger className="flex-1">
<SelectValue placeholder="Add commissioner from league members" />
</SelectTrigger>
<SelectContent>
{leagueMembers.map((member) => {
const alreadyCommissioner = commissioners.some((c) => c.userId === member.id);
return (
<SelectItem key={member.id} value={member.id} disabled={alreadyCommissioner}>
{member.name || "Unknown"}
{alreadyCommissioner && " (already commissioner)"}
</SelectItem>
);
})}
</SelectContent>
</Select>
<Button type="submit" variant="outline" disabled={navigationState === "submitting"}>
Add
</Button>
</Form>
</div>
</SettingsSection>
);
}