brackt/app/routes/leagues
chrisp 079ecec129
All checks were successful
🚀 Deploy / 🧪 Test (push) Successful in 2m35s
🚀 Deploy / ʦ🔍 Typecheck & Lint (push) Successful in 1m23s
🚀 Deploy / 🐳 Build (push) Successful in 1m11s
🚀 Deploy / 🚀 Deploy (push) Successful in 10s
Fix draft timer display drifting due to server-client clock skew (#74)
## Summary

- The countdown display used `data.expiresAt` (server-side Unix timestamp) subtracted from `client Date.now()`. When the server clock runs ~2-3s ahead of the client (observed in production), the display was inflated by that delta.
- Fixes three linked symptoms: timer starting at 2:02 instead of 2:00, chess-clock increment crediting 1:54 instead of 1:55, and the commissioner's adjust-time-bank dialog disagreeing with the visible countdown.
- Fix: replace all server `expiresAt` timestamps with a client-local expiry from the server-provided `timeRemaining` integer (`Date.now() + timeRemaining * 1000`). The skew then cancels algebraically when the server computes credit.

## Sites changed

- `handleTimerPickStarted` — fires after every pick (the main fix)
- `handleDraftStateSync` — reconnect path
- `useState` initializer in the draft room — initial page load seed from loader data (uses `loaderTimerNow` server timestamp to compute remaining server-side, then re-anchors to client clock)

## Test plan

- [ ] Start a chess-clock draft (2:00 bank, 15s increment) — timer should show exactly **2:00** when a team goes on the clock
- [ ] Pick at 1:40 — new bank should show **1:55** (100 + 15s)
- [ ] Commissioner adjust-time-bank dialog — displayed remaining should match the countdown
- [ ] Force autopick at any displayed time T — new bank should be T + increment
- [ ] Reconnect mid-pick — timer should resume at the correct remaining time

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Chris Parsons <chrisparsons1127@gmail.com>
Reviewed-on: #74
2026-06-06 07:30:45 +00:00
..
__tests__ Add Discord draft pick announcements (#460) 2026-05-20 19:55:48 -07:00
$leagueId.audit-log.tsx Migrate auth from Clerk to BetterAuth (#354) 2026-04-29 10:03:50 -07:00
$leagueId.draft-board.$seasonId.tsx Fix mobile spacing for draft board and dashboard layout (#13, #329) (#404) 2026-05-10 19:51:34 -07:00
$leagueId.draft-queue.$seasonId.tsx Rename queue page to Set Pre-Draft Queue, remove VORP, fix re-add race condition (#436) 2026-05-15 18:47:36 -07:00
$leagueId.draft.$seasonId.tsx Fix draft timer display drifting due to server-client clock skew (#74) 2026-06-06 07:30:45 +00:00
$leagueId.server.ts Fix invite link showing http and show draft board card during live draft 2026-05-22 22:31:52 -07:00
$leagueId.settings.server.ts Enforce unique team names within a season 2026-05-23 16:55:08 -07:00
$leagueId.settings.tsx Add Discord draft pick announcements (#460) 2026-05-20 19:55:48 -07:00
$leagueId.sports-seasons.$sportsSeasonId.server.ts Canonical tournament layer: schema + backfill (1/2) (#365) 2026-05-01 20:13:18 -07:00
$leagueId.sports-seasons.$sportsSeasonId.tsx Fix World Cup group stage display and upcoming events (#55) 2026-05-27 05:43:08 +00:00
$leagueId.standings.$seasonId.teams.$teamId.tsx Fix draft order initialization for teams added mid-season (#449) 2026-05-19 18:22:47 -07:00
$leagueId.standings.$seasonId.tsx Fix standings page team icons to use selected team avatar (#388) 2026-05-06 18:08:46 -07:00
$leagueId.tsx Fix invite link showing http and show draft board card during live draft 2026-05-22 22:31:52 -07:00
$leagueId.upcoming-events.tsx Migrate authentication from Clerk to BetterAuth (#324) 2026-04-24 22:00:49 -07:00
creating.tsx Extract reusable league wizard components; wire settings page (#350) 2026-04-28 22:24:13 -07:00
new.tsx claude/sports-templates-conversion-ILWAM (#71) 2026-06-04 21:31:49 +00:00