brackt/app/components/__tests__/AutodraftSettings.test.tsx
Chris Parsons 4bffa40606
Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196)
* Fix no-shadow and consistent-function-scoping lint violations

Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.

no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).

consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix no-non-null-assertion lint violations and promote to error

Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.

Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers

Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.

- prefer-add-event-listener: converted onchange/onclick/onload
  assignments to addEventListener in useDraftNotifications.ts and
  admin.data-sync.tsx; stored changeHandler ref for proper cleanup
  with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
  side-effect imports (*.css, @testing-library/jest-dom,
  @testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
  cypress/support/e2e.ts (file already has an import)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix TypeScript errors from no-non-null-assertion fixes

Two fixes introduced by the non-null assertion cleanup produced type
errors:

- scoring-event.ts: `?? ""` was wrong type for a participant object map;
  restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
  truthy guarantee, causing TS18047 on the write-back block; added
  `participant &&` guard before accessing its properties

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add npm run typecheck as Stop hook in Claude settings

Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-21 10:59:51 -07:00

262 lines
11 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { AutodraftSettings } from '~/components/AutodraftSettings';
vi.mock('sonner', () => ({
toast: { success: vi.fn(), error: vi.fn(), info: vi.fn() },
}));
global.fetch = vi.fn();
describe('AutodraftSettings Component', () => {
const defaultProps = {
seasonId: 'season-123',
teamId: 'team-456',
isEnabled: false,
mode: 'next_pick' as const,
queueOnly: false,
isMyTurn: false,
onUpdate: vi.fn(),
};
beforeEach(() => {
vi.clearAllMocks();
(global.fetch as any).mockResolvedValue({
ok: true,
json: async () => ({ success: true }),
});
});
// ─── Rendering ────────────────────────────────────────────────────────────
describe('Rendering', () => {
it('renders all four option buttons', () => {
render(<AutodraftSettings {...defaultProps} />);
expect(screen.getByRole('button', { name: 'Off' })).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'Next in Queue' })).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'All in Queue' })).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'All Picks' })).toBeInTheDocument();
});
it('does not render a queue-only toggle switch', () => {
render(<AutodraftSettings {...defaultProps} isEnabled={true} />);
expect(screen.queryByRole('switch')).not.toBeInTheDocument();
});
it('shows "You\'re on the clock!" when isMyTurn=true', () => {
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
expect(screen.getByText(/You're on the clock!/i)).toBeInTheDocument();
});
it('marks Off as active (muted border) when isEnabled=false', () => {
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
expect(screen.getByRole('button', { name: 'Off' }).className).toContain(
'border-l-muted-foreground'
);
});
it('marks Next in Queue as active when isEnabled=true, mode=next_pick', () => {
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} />);
expect(screen.getByRole('button', { name: 'Next in Queue' }).className).toContain('bg-electric');
});
it('marks All in Queue as active when isEnabled=true, mode=while_on, queueOnly=true', () => {
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="while_on" queueOnly={true} />);
expect(screen.getByRole('button', { name: 'All in Queue' }).className).toContain('bg-electric');
});
it('marks All Picks as active when isEnabled=true, mode=while_on, queueOnly=false', () => {
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="while_on" queueOnly={false} />);
expect(screen.getByRole('button', { name: 'All Picks' }).className).toContain('bg-electric');
});
});
// ─── Interaction ──────────────────────────────────────────────────────────
describe('Button interaction', () => {
it('switches to Next in Queue and calls onUpdate with correct args', async () => {
const onUpdate = vi.fn();
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
await waitFor(() => {
expect(global.fetch).toHaveBeenCalledWith(
'/api/autodraft/update',
expect.objectContaining({ method: 'POST' })
);
});
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'next_pick', true));
});
it('switches to All in Queue and calls onUpdate with correct args', async () => {
const onUpdate = vi.fn();
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
fireEvent.click(screen.getByRole('button', { name: 'All in Queue' }));
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'while_on', true));
});
it('switches to All Picks and calls onUpdate with correct args', async () => {
const onUpdate = vi.fn();
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
fireEvent.click(screen.getByRole('button', { name: 'All Picks' }));
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'while_on', false));
});
it('switches to Off and calls onUpdate with isEnabled=false', async () => {
const onUpdate = vi.fn();
render(
<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} onUpdate={onUpdate} />
);
fireEvent.click(screen.getByRole('button', { name: 'Off' }));
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(false, 'next_pick', false));
});
it('disables all buttons when isMyTurn=true', () => {
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
expect(screen.getByRole('button', { name: 'Off' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'Next in Queue' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'All in Queue' })).toBeDisabled();
expect(screen.getByRole('button', { name: 'All Picks' })).toBeDisabled();
});
it('does not call fetch when a button is clicked during the user\'s turn', () => {
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
expect(global.fetch).not.toHaveBeenCalled();
});
it('does not re-fire when the already-active option is clicked', async () => {
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
fireEvent.click(screen.getByRole('button', { name: 'Off' }));
expect(global.fetch).not.toHaveBeenCalled();
});
});
// ─── Optimistic UI ────────────────────────────────────────────────────────
describe('Optimistic UI', () => {
it('does not disable buttons while a fetch is in flight', async () => {
let resolve: ((v: any) => void) | undefined;
(global.fetch as any).mockReturnValueOnce(new Promise((r) => { resolve = r; }));
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
// Buttons stay enabled — optimistic UI does not block interaction
expect(screen.getByRole('button', { name: 'Off' })).not.toBeDisabled();
resolve?.({ ok: true, json: async () => ({ success: true }) });
});
it('fires a fetch for every rapid click, aborting previous in-flight requests', async () => {
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
fireEvent.click(screen.getByRole('button', { name: 'All in Queue' }));
fireEvent.click(screen.getByRole('button', { name: 'Off' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalledTimes(3));
});
});
// ─── Error handling ───────────────────────────────────────────────────────
describe('Error handling', () => {
it('reverts to the previous state on a non-ok API response', async () => {
(global.fetch as any).mockResolvedValueOnce({ ok: false });
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
await waitFor(() => {
expect(screen.getByRole('button', { name: 'Off' }).className).toContain(
'border-l-muted-foreground'
);
});
});
it('reverts to the previous state on a network error', async () => {
(global.fetch as any).mockRejectedValueOnce(new Error('Network error'));
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
await waitFor(() => {
expect(screen.getByRole('button', { name: 'Off' }).className).toContain(
'border-l-muted-foreground'
);
});
});
});
// ─── API payload ──────────────────────────────────────────────────────────
describe('API payload', () => {
it('posts correct formData for Next in Queue (next_pick, queueOnly=true)', async () => {
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
expect(body.get('seasonId')).toBe('season-123');
expect(body.get('teamId')).toBe('team-456');
expect(body.get('isEnabled')).toBe('true');
expect(body.get('mode')).toBe('next_pick');
expect(body.get('queueOnly')).toBe('true');
});
it('posts correct formData for All in Queue (while_on, queueOnly=true)', async () => {
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'All in Queue' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
expect(body.get('isEnabled')).toBe('true');
expect(body.get('mode')).toBe('while_on');
expect(body.get('queueOnly')).toBe('true');
});
it('posts correct formData for All Picks (while_on, queueOnly=false)', async () => {
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'All Picks' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
expect(body.get('isEnabled')).toBe('true');
expect(body.get('mode')).toBe('while_on');
expect(body.get('queueOnly')).toBe('false');
});
it('posts isEnabled=false for Off', async () => {
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} />);
fireEvent.click(screen.getByRole('button', { name: 'Off' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
expect(body.get('isEnabled')).toBe('false');
});
it('passes an AbortSignal to fetch', async () => {
render(<AutodraftSettings {...defaultProps} />);
fireEvent.click(screen.getByRole('button', { name: 'Next in Queue' }));
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
const options = (global.fetch as any).mock.calls[0][1];
expect(options.signal).toBeInstanceOf(AbortSignal);
});
});
});