f3d63922d0
A participant tied for a scoring placement splits the combined points of the tied positions. Four code paths computed a pick's points, each re-implementing the same bracket/qualifying_points/default cascade, and two of them omitted the qualifying_points arm entirely. A golfer tied for 8th was therefore worth the full 15 points on the team page and draft board but the split 7.5 in the standings, so a team read 225 on one screen and 218 on another. Collapse the cascade into a single calculatePickPoints helper and route all six call sites through it, backed by one shared getSharedPlacementCounts loader replacing the two separate tie-count queries. Tie counts span every participant in the sports season, not just drafted ones, since an undrafted tie partner still halves the award. Also round split awards to the nearest whole point in calculateAveragedPoints. The /rules page states ties are "combined and split equally among them, rounded to the nearest whole point", and its own worked example rounds 18.33 down to 18, so this is nearest rather than ceiling. Season point values are integer columns, making this averaging the only source of fractional points; rounding here means the standings' 218 is now correct by construction rather than a display artifact, and per-pick values visibly sum to the team total. Existing assertions encoding the unrounded results are updated, and the rules page's two published examples are asserted directly so the code and the published rule cannot drift apart. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LZLF1PAfeKdpYog3NKtyz
85 lines
2.6 KiB
TypeScript
85 lines
2.6 KiB
TypeScript
import { calculatePickPoints } from "~/models/scoring-rules";
|
|
|
|
export type CoronaState =
|
|
| { type: "eliminated"; points: 0 }
|
|
| { type: "pending" }
|
|
| { type: "scored"; brightness: number; points: number };
|
|
|
|
interface PickEntry {
|
|
participant: { id: string; sportsSeasonId: string };
|
|
scoringPattern: string | null;
|
|
}
|
|
|
|
interface ResultEntry {
|
|
participantId: string;
|
|
finalPosition: number | null;
|
|
isPartialScore: boolean | null;
|
|
}
|
|
|
|
interface ScoringRules {
|
|
pointsFor1st: number;
|
|
pointsFor2nd: number;
|
|
pointsFor3rd: number;
|
|
pointsFor4th: number;
|
|
pointsFor5th: number;
|
|
pointsFor6th: number;
|
|
pointsFor7th: number;
|
|
pointsFor8th: number;
|
|
}
|
|
|
|
/**
|
|
* Corona badge state for every pick on the draft board.
|
|
*
|
|
* @param sharedPlacementCountsBySportsSeason - sportsSeasonId → (finalPosition →
|
|
* how many participants share it), from getSharedPlacementCounts. Required for
|
|
* qualifying_points picks: a golfer tied for 8th earns the split award, and
|
|
* omitting this would show him at full value here while the standings show the
|
|
* split — the exact inconsistency this parameter exists to prevent.
|
|
*/
|
|
export function computeCoronaStates(
|
|
picks: PickEntry[],
|
|
resultByParticipant: Map<string, ResultEntry>,
|
|
bracketTemplateBySportsSeason: Map<string, string | null>,
|
|
scoringRules: ScoringRules,
|
|
maxPoints: number,
|
|
sharedPlacementCountsBySportsSeason: Map<string, Map<number, number>>,
|
|
): Record<string, CoronaState> {
|
|
const coronaStates: Record<string, CoronaState> = {};
|
|
|
|
for (const pick of picks) {
|
|
const result = resultByParticipant.get(pick.participant.id);
|
|
|
|
if (!result || result.finalPosition === null) {
|
|
coronaStates[pick.participant.id] = { type: "pending" };
|
|
continue;
|
|
}
|
|
|
|
if (result.finalPosition === 0 && !result.isPartialScore) {
|
|
coronaStates[pick.participant.id] = { type: "eliminated", points: 0 };
|
|
continue;
|
|
}
|
|
|
|
if (result.finalPosition > 0) {
|
|
const points = calculatePickPoints(
|
|
result.finalPosition,
|
|
pick.scoringPattern,
|
|
scoringRules,
|
|
{
|
|
bracketTemplateId:
|
|
bracketTemplateBySportsSeason.get(pick.participant.sportsSeasonId) ?? null,
|
|
tiedParticipants:
|
|
sharedPlacementCountsBySportsSeason
|
|
.get(pick.participant.sportsSeasonId)
|
|
?.get(result.finalPosition) ?? 1,
|
|
}
|
|
);
|
|
const brightness = maxPoints > 0 ? Math.min(points / maxPoints, 1) : 0;
|
|
coronaStates[pick.participant.id] = { type: "scored", brightness, points };
|
|
continue;
|
|
}
|
|
|
|
coronaStates[pick.participant.id] = { type: "pending" };
|
|
}
|
|
|
|
return coronaStates;
|
|
}
|