* Fix no-shadow and consistent-function-scoping lint violations
Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.
no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).
consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix no-non-null-assertion lint violations and promote to error
Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.
Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers
Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.
- prefer-add-event-listener: converted onchange/onclick/onload
assignments to addEventListener in useDraftNotifications.ts and
admin.data-sync.tsx; stored changeHandler ref for proper cleanup
with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
side-effect imports (*.css, @testing-library/jest-dom,
@testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
cypress/support/e2e.ts (file already has an import)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix TypeScript errors from no-non-null-assertion fixes
Two fixes introduced by the non-null assertion cleanup produced type
errors:
- scoring-event.ts: `?? ""` was wrong type for a participant object map;
restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
truthy guarantee, causing TS18047 on the write-back block; added
`participant &&` guard before accessing its properties
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add npm run typecheck as Stop hook in Claude settings
Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
166 lines
5.9 KiB
TypeScript
166 lines
5.9 KiB
TypeScript
import {
|
|
Table,
|
|
TableBody,
|
|
TableCell,
|
|
TableHead,
|
|
TableHeader,
|
|
TableRow,
|
|
} from "~/components/ui/table";
|
|
import { Badge } from "~/components/ui/badge";
|
|
import { TrendingUp, TrendingDown, Minus, Trophy, Medal, Award } from "lucide-react";
|
|
|
|
export interface StandingsRow {
|
|
teamId: string;
|
|
teamName: string;
|
|
totalPoints: number;
|
|
currentRank: number;
|
|
previousRank?: number | null;
|
|
firstPlaceCount: number;
|
|
secondPlaceCount: number;
|
|
thirdPlaceCount: number;
|
|
fourthPlaceCount: number;
|
|
fifthPlaceCount: number;
|
|
sixthPlaceCount: number;
|
|
seventhPlaceCount: number;
|
|
eighthPlaceCount: number;
|
|
participantsRemaining: number;
|
|
}
|
|
|
|
interface StandingsTableProps {
|
|
standings: StandingsRow[];
|
|
showMovement?: boolean;
|
|
showPlacementBreakdown?: boolean;
|
|
}
|
|
|
|
function getRankBadge(rank: number) {
|
|
if (rank === 1) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Trophy className="h-5 w-5 text-yellow-500" />
|
|
<span className="font-bold text-lg">{rank}</span>
|
|
</div>
|
|
);
|
|
} else if (rank === 2) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Medal className="h-5 w-5 text-gray-400" />
|
|
<span className="font-semibold">{rank}</span>
|
|
</div>
|
|
);
|
|
} else if (rank === 3) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Award className="h-5 w-5 text-amber-700" />
|
|
<span className="font-semibold">{rank}</span>
|
|
</div>
|
|
);
|
|
} else {
|
|
return <span className="font-medium">{rank}</span>;
|
|
}
|
|
}
|
|
|
|
export function StandingsTable({
|
|
standings,
|
|
showMovement = true,
|
|
showPlacementBreakdown = false,
|
|
}: StandingsTableProps) {
|
|
const getMovementIndicator = (current: number, previous?: number | null) => {
|
|
if (!showMovement || !previous) return null;
|
|
|
|
const change = previous - current; // Positive means moved up
|
|
|
|
if (change > 0) {
|
|
return (
|
|
<div className="flex items-center gap-1 text-emerald-400">
|
|
<TrendingUp className="h-3 w-3" />
|
|
<span className="text-xs">+{change}</span>
|
|
</div>
|
|
);
|
|
} else if (change < 0) {
|
|
return (
|
|
<div className="flex items-center gap-1 text-coral-accent">
|
|
<TrendingDown className="h-3 w-3" />
|
|
<span className="text-xs">{change}</span>
|
|
</div>
|
|
);
|
|
} else {
|
|
return (
|
|
<div className="flex items-center gap-1 text-muted-foreground">
|
|
<Minus className="h-3 w-3" />
|
|
<span className="text-xs">-</span>
|
|
</div>
|
|
);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<Table>
|
|
<TableHeader>
|
|
<TableRow>
|
|
<TableHead className="w-16">Rank</TableHead>
|
|
{showMovement && <TableHead className="w-20">Change</TableHead>}
|
|
<TableHead>Team</TableHead>
|
|
<TableHead className="text-right">Total Points</TableHead>
|
|
{showPlacementBreakdown && (
|
|
<>
|
|
<TableHead className="text-center w-12" title="1st place finishes">🥇</TableHead>
|
|
<TableHead className="text-center w-12" title="2nd place finishes">🥈</TableHead>
|
|
<TableHead className="text-center w-12" title="3rd place finishes">🥉</TableHead>
|
|
<TableHead className="text-center w-12" title="4th place finishes">4th</TableHead>
|
|
<TableHead className="text-center w-12" title="5th place finishes">5th</TableHead>
|
|
<TableHead className="text-center w-12" title="6th place finishes">6th</TableHead>
|
|
<TableHead className="text-center w-12" title="7th place finishes">7th</TableHead>
|
|
<TableHead className="text-center w-12" title="8th place finishes">8th</TableHead>
|
|
</>
|
|
)}
|
|
<TableHead className="text-right">Remaining</TableHead>
|
|
</TableRow>
|
|
</TableHeader>
|
|
<TableBody>
|
|
{standings.length === 0 ? (
|
|
<TableRow>
|
|
<TableCell colSpan={showPlacementBreakdown ? 13 : 5} className="text-center text-muted-foreground">
|
|
No standings data available yet
|
|
</TableCell>
|
|
</TableRow>
|
|
) : (
|
|
standings.map((row) => (
|
|
<TableRow key={row.teamId} className={row.currentRank <= 3 ? "bg-muted/30" : undefined}>
|
|
<TableCell>
|
|
{getRankBadge(row.currentRank)}
|
|
</TableCell>
|
|
{showMovement && (
|
|
<TableCell>
|
|
{getMovementIndicator(row.currentRank, row.previousRank)}
|
|
</TableCell>
|
|
)}
|
|
<TableCell className="font-medium">{row.teamName}</TableCell>
|
|
<TableCell className="text-right font-semibold">
|
|
{row.totalPoints.toFixed(2)}
|
|
</TableCell>
|
|
{showPlacementBreakdown && (
|
|
<>
|
|
<TableCell className="text-center">{row.firstPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.secondPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.thirdPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.fourthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.fifthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.sixthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.seventhPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.eighthPlaceCount || "-"}</TableCell>
|
|
</>
|
|
)}
|
|
<TableCell className="text-right">
|
|
{row.participantsRemaining > 0 ? (
|
|
<Badge variant="secondary">{row.participantsRemaining}</Badge>
|
|
) : (
|
|
<span className="text-muted-foreground">-</span>
|
|
)}
|
|
</TableCell>
|
|
</TableRow>
|
|
))
|
|
)}
|
|
</TableBody>
|
|
</Table>
|
|
);
|
|
}
|