brackt/app/components/sport-season/__tests__/RegularSeasonStandings.test.tsx
Chris Parsons 2e2d8db777
Add MLB playoff simulator with AL/NL division standings, fixes #121 (#225)
* Add MLB playoff simulator with AL/NL division standings, fixes #121

- New `mlb-simulator.ts`: 50k Monte Carlo sim drawing division winners
  (weighted by p_div) and 3 WC teams per league, then simulating
  WC best-of-3 → DS best-of-5 → LCS best-of-7 → World Series.
  Elo parity factor 350; blends Vegas odds 30/70 when sourceOdds available.
- New `standings-sync/mlb.ts`: adapter for free statsapi.mlb.com API,
  mapping AL/NL conferences, division ranks, streaks, home/away/L10 splits.
- New `mlb-divisions` display mode in RegularSeasonStandings: shows 1 division
  winner per division section + Wild Card section with 3-spot playoff line,
  headings read "AL/NL League" instead of "Conference".
- Refactored buildNhlSections/buildMlbSections into shared buildDivisionSections
  (divisionSpots + wcSpots params); conferenceLabel now flows through group
  objects rather than being derived from displayMode in the render.
- DB migration 0062 adds `mlb_bracket` to simulator_type enum.
- 37 new tests across simulator, adapter, and component.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix flaky tennis simulator test: increase trials and lower threshold

500 trials with a ~3–5% expected win rate had enough variance to
occasionally land below the 0.03 threshold (~2% failure rate).
Bumping to 2000 trials reduces the std dev by 2x; lowering the
threshold to 0.02 keeps the assertion meaningful (still well above
random 0.78%) while eliminating the flakiness.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-25 08:47:02 -07:00

285 lines
11 KiB
TypeScript

import { describe, it, expect } from "vitest";
import { render, screen } from "@testing-library/react";
import { RegularSeasonStandings } from "../RegularSeasonStandings";
function makeRow(overrides: Partial<{
id: string;
participantId: string;
wins: number;
losses: number;
otLosses: number | null;
gamesPlayed: number;
winPct: string | null;
gamesBack: string | null;
conference: string | null;
division: string | null;
conferenceRank: number | null;
divisionRank: number | null;
leagueRank: number | null;
streak: string | null;
lastTen: string | null;
homeRecord: string | null;
awayRecord: string | null;
syncedAt: string | null;
participant: { id: string; name: string; shortName?: string | null };
}> = {}) {
return {
id: overrides.id ?? "row-1",
participantId: overrides.participantId ?? "p-1",
wins: overrides.wins ?? 40,
losses: overrides.losses ?? 28,
otLosses: overrides.otLosses ?? null,
gamesPlayed: overrides.gamesPlayed ?? 68,
winPct: overrides.winPct ?? "0.5882",
gamesBack: overrides.gamesBack ?? null,
conference: overrides.conference ?? null,
division: overrides.division ?? null,
conferenceRank: overrides.conferenceRank ?? null,
divisionRank: overrides.divisionRank ?? null,
leagueRank: overrides.leagueRank ?? 1,
streak: overrides.streak ?? null,
lastTen: overrides.lastTen ?? null,
homeRecord: overrides.homeRecord ?? null,
awayRecord: overrides.awayRecord ?? null,
syncedAt: overrides.syncedAt ?? null,
participant: overrides.participant ?? { id: "p-1", name: "Boston Celtics" },
};
}
const NO_OWNERSHIPS = {};
const NO_USER_IDS: string[] = [];
describe("RegularSeasonStandings", () => {
it("renders nothing when standings array is empty", () => {
const { container } = render(
<RegularSeasonStandings
standings={[]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
expect(container.firstChild).toBeNull();
});
it("renders team names", () => {
render(
<RegularSeasonStandings
standings={[
makeRow({ participant: { id: "p-1", name: "Boston Celtics" } }),
makeRow({ id: "row-2", participantId: "p-2", participant: { id: "p-2", name: "Toronto Raptors" } }),
]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
expect(screen.getByText("Boston Celtics")).toBeInTheDocument();
expect(screen.getByText("Toronto Raptors")).toBeInTheDocument();
});
it("shows OTL column when showOtLosses=true", () => {
render(
<RegularSeasonStandings
standings={[makeRow({ otLosses: 5 })]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
showOtLosses={true}
/>
);
expect(screen.getByText("OTL")).toBeInTheDocument();
});
it("hides OTL column when showOtLosses=false (default)", () => {
render(
<RegularSeasonStandings
standings={[makeRow()]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
expect(screen.queryByText("OTL")).not.toBeInTheDocument();
});
it("renders conference headings and inline division labels when present", () => {
render(
<RegularSeasonStandings
standings={[
makeRow({ conference: "Eastern", division: "Atlantic", conferenceRank: 1, participant: { id: "p-1", name: "Boston Celtics" } }),
makeRow({ id: "row-2", participantId: "p-2", conference: "Western", division: "Pacific", conferenceRank: 1, participant: { id: "p-2", name: "LA Lakers" } }),
]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
// Conference group headings are rendered as <h3>
expect(screen.getByText(/Eastern Conference/i)).toBeInTheDocument();
expect(screen.getByText(/Western Conference/i)).toBeInTheDocument();
// Division is now shown as an inline label per row (not a section header)
expect(screen.getAllByText(/Atlantic/i).length).toBeGreaterThan(0);
expect(screen.getAllByText(/Pacific/i).length).toBeGreaterThan(0);
});
it("shows ownership badge for drafted teams", () => {
render(
<RegularSeasonStandings
standings={[makeRow({ participantId: "p-1" })]}
teamOwnerships={{
"p-1": { teamName: "Team Alpha", ownerName: "Alice", teamId: "t-1" },
}}
userParticipantIds={NO_USER_IDS}
/>
);
expect(screen.getByText("Alice")).toBeInTheDocument();
});
it("does not show badge for undrafted teams", () => {
render(
<RegularSeasonStandings
standings={[makeRow({ participantId: "p-1" })]}
teamOwnerships={{}}
userParticipantIds={NO_USER_IDS}
/>
);
// No owner badge should be present
expect(screen.queryByText(/Alice/i)).not.toBeInTheDocument();
});
it("applies different styling for user's own team", () => {
const { container } = render(
<RegularSeasonStandings
standings={[makeRow({ participantId: "p-1" })]}
teamOwnerships={{}}
userParticipantIds={["p-1"]}
/>
);
// The user's row should have a primary styling class
const userRow = container.querySelector("tr.bg-primary\\/5");
expect(userRow).not.toBeNull();
});
it("renders streak with correct color class for wins", () => {
render(
<RegularSeasonStandings
standings={[makeRow({ streak: "W5" })]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
const streakEl = screen.getByText("W5");
expect(streakEl.className).toContain("emerald");
});
it("renders streak with destructive class for losses", () => {
render(
<RegularSeasonStandings
standings={[makeRow({ streak: "L3" })]}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
/>
);
const streakEl = screen.getByText("L3");
expect(streakEl.className).toContain("destructive");
});
});
// ─── mlb-divisions display mode ───────────────────────────────────────────────
function makeAlDivisionRows() {
return [
// AL East — division winner (divisionRank=1) + 2 WC candidates (divisionRank=2,3)
makeRow({ id: "r1", participantId: "p1", conference: "AL", division: "AL East", divisionRank: 1, conferenceRank: 1, participant: { id: "p1", name: "Baltimore Orioles" } }),
makeRow({ id: "r2", participantId: "p2", conference: "AL", division: "AL East", divisionRank: 2, conferenceRank: 4, participant: { id: "p2", name: "Boston Red Sox" } }),
// AL Central — division winner
makeRow({ id: "r3", participantId: "p3", conference: "AL", division: "AL Central", divisionRank: 1, conferenceRank: 2, participant: { id: "p3", name: "Cleveland Guardians" } }),
makeRow({ id: "r4", participantId: "p4", conference: "AL", division: "AL Central", divisionRank: 2, conferenceRank: 5, participant: { id: "p4", name: "Minnesota Twins" } }),
// AL West — division winner
makeRow({ id: "r5", participantId: "p5", conference: "AL", division: "AL West", divisionRank: 1, conferenceRank: 3, participant: { id: "p5", name: "Houston Astros" } }),
makeRow({ id: "r6", participantId: "p6", conference: "AL", division: "AL West", divisionRank: 2, conferenceRank: 6, participant: { id: "p6", name: "Seattle Mariners" } }),
// NL East
makeRow({ id: "r7", participantId: "p7", conference: "NL", division: "NL East", divisionRank: 1, conferenceRank: 1, participant: { id: "p7", name: "Philadelphia Phillies" } }),
makeRow({ id: "r8", participantId: "p8", conference: "NL", division: "NL East", divisionRank: 2, conferenceRank: 4, participant: { id: "p8", name: "Atlanta Braves" } }),
// NL Central
makeRow({ id: "r9", participantId: "p9", conference: "NL", division: "NL Central", divisionRank: 1, conferenceRank: 2, participant: { id: "p9", name: "Milwaukee Brewers" } }),
makeRow({ id: "r10", participantId: "p10", conference: "NL", division: "NL Central", divisionRank: 2, conferenceRank: 5, participant: { id: "p10", name: "Chicago Cubs" } }),
// NL West
makeRow({ id: "r11", participantId: "p11", conference: "NL", division: "NL West", divisionRank: 1, conferenceRank: 3, participant: { id: "p11", name: "Los Angeles Dodgers" } }),
makeRow({ id: "r12", participantId: "p12", conference: "NL", division: "NL West", divisionRank: 2, conferenceRank: 6, participant: { id: "p12", name: "San Diego Padres" } }),
];
}
describe("RegularSeasonStandings mlb-divisions mode", () => {
it("renders 'AL League' and 'NL League' headings (not Conference)", () => {
render(
<RegularSeasonStandings
standings={makeAlDivisionRows()}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
displayMode="mlb-divisions"
/>
);
expect(screen.getByText(/AL League/i)).toBeInTheDocument();
expect(screen.getByText(/NL League/i)).toBeInTheDocument();
expect(screen.queryByText(/AL Conference/i)).not.toBeInTheDocument();
expect(screen.queryByText(/NL Conference/i)).not.toBeInTheDocument();
});
it("renders division section headings", () => {
render(
<RegularSeasonStandings
standings={makeAlDivisionRows()}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
displayMode="mlb-divisions"
/>
);
expect(screen.getByText("AL East Division")).toBeInTheDocument();
expect(screen.getByText("AL Central Division")).toBeInTheDocument();
expect(screen.getByText("AL West Division")).toBeInTheDocument();
});
it("renders Wild Card section heading", () => {
render(
<RegularSeasonStandings
standings={makeAlDivisionRows()}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
displayMode="mlb-divisions"
/>
);
expect(screen.getAllByText("Wild Card").length).toBeGreaterThan(0);
});
it("division section contains only the division winner (divisionRank=1)", () => {
render(
<RegularSeasonStandings
standings={makeAlDivisionRows()}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
displayMode="mlb-divisions"
/>
);
// Division winners should be rendered
expect(screen.getByText("Baltimore Orioles")).toBeInTheDocument();
expect(screen.getByText("Cleveland Guardians")).toBeInTheDocument();
expect(screen.getByText("Houston Astros")).toBeInTheDocument();
// Wild card teams (rank > 1) also rendered in Wild Card section
expect(screen.getByText("Boston Red Sox")).toBeInTheDocument();
});
it("shows 'Playoff Line' after 3 teams in the Wild Card section", () => {
// Add enough WC teams to trigger the playoff line (need >3 in the WC section)
const standings = [
...makeAlDivisionRows(),
makeRow({ id: "r13", participantId: "p13", conference: "AL", division: "AL East", divisionRank: 3, conferenceRank: 7, participant: { id: "p13", name: "Tampa Bay Rays" } }),
makeRow({ id: "r14", participantId: "p14", conference: "AL", division: "AL Central", divisionRank: 3, conferenceRank: 8, participant: { id: "p14", name: "Detroit Tigers" } }),
];
render(
<RegularSeasonStandings
standings={standings}
teamOwnerships={NO_OWNERSHIPS}
userParticipantIds={NO_USER_IDS}
displayMode="mlb-divisions"
/>
);
expect(screen.getAllByText(/Playoff Line/i).length).toBeGreaterThan(0);
});
});