brackt/app/components/user/settings
Claude 2f5d36ae48
Address code review feedback on email notification feature
- sendOnTheClockEmail now fetches season (and currentPickNumber) internally,
  removing the blocking postChainSeason pre-fetch from both make-pick.ts and
  executeAutoPick; callers are now true fire-and-forget with no IIFE needed
- Parallel Promise.all for team, autodraftSettings, and league queries reduces
  sequential DB round-trips from 5 to 3
- Remove team.ownerId type cast; assign to local after the null guard
- Combine the two calculatePickInfo calls for the same pick into one
- Fix popoverOpen/enabled divergence: remove the {enabled && ...} guard on
  PopoverContent so popoverOpen is the sole visibility control
- Unify NotificationsSection feedback pattern: both Discord and email sections
  now read success/error directly from their respective fetcher data via a
  shared feedbackFromFetcher helper; removes the success/error props and the
  verbose cast that was used for email
- Add 13 unit tests for sendOnTheClockEmail covering: early-exit paths
  (no season, past totalPicks, no owner, notifications disabled, autodraft
  enabled, no league), single vs back-to-back subject selection, draft room
  link presence, error logging without throwing, and parallel query execution

https://claude.ai/code/session_01LMGxgYvtE3CF8Jf3u2pXgA
2026-05-20 22:23:30 +00:00
..
__tests__ Add Discord account linking from settings page (#457) 2026-05-20 13:38:44 -07:00
AccountSection.tsx Add Discord account linking from settings page (#457) 2026-05-20 13:38:44 -07:00
ApiSection.tsx Refactor user profile to comprehensive settings page (#403) 2026-05-10 17:26:14 -07:00
NotificationsSection.tsx Address code review feedback on email notification feature 2026-05-20 22:23:30 +00:00
PrivacySection.tsx Refactor user profile to comprehensive settings page (#403) 2026-05-10 17:26:14 -07:00
ProfileSection.tsx Add opt-in Discord pings to standings notifications (#429) 2026-05-15 10:06:54 -07:00