brackt/app/components/league/OvernightPauseSettings.tsx
Chris Parsons 4bbcac1949
fix: resolve all 48 WCAG 2.2 AA accessibility issues (#439)
* fix: resolve all 48 WCAG 2.2 AA accessibility issues

Critical fixes:
- Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection)
- Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay
- Add aria-live region and connection status announcement to ConnectionOverlay

Serious fixes:
- Add skip-to-content link in root.tsx with id="main-content" on <main>
- Add aria-label to UserMenu trigger button
- Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password)
- Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans
- Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators
- Add aria-live="polite" to draft room countdown timer
- Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content
- Fix Footer text contrast (changed from 28% to text-muted-foreground)
- Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons
- Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button
- Add aria-label to PeopleSection owner and commissioner selects
- Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons
- Add role="radiogroup"+aria-checked to AutodraftSettings option buttons
- Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper

Moderate fixes:
- Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region
- Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel"
- Add role="radiogroup"+aria-checked to TimerModeSelector
- Add aria-current="page" + aria-label to SettingsDesktopNav
- Add aria-label="Admin navigation" to admin sidebar nav
- Add scope="col" + <caption> to StandingsTable and ScoringTables
- Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid

Minor fixes:
- Add aria-hidden="true" to decorative trend icons in StandingsTable
- Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection
- Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection
- Add aria-label to NotificationSettings switchOnly Switch
- Add prefers-reduced-motion check to SlotMachineHeadline JS animation
- Bump --muted-foreground from 55% to 62% opacity for improved contrast margin

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix code review findings from WCAG compliance pass

- Add Arrow key navigation + roving tabindex to all role=radiogroup
  components (AutodraftSettings x2, TimerModeSelector,
  OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern
- Extract shared focus-trap logic into useFocusTrap hook; update
  ConnectionOverlay and AuthRecoveryOverlay to use it
- Add tabIndex={-1} to ConnectionOverlay Card so focus can land in
  spinner-only state (no interactive children)
- Replace aria-live on loading dots container with sr-only span so
  status changes are announced by text content, not aria-label
- Remove contradictory aria-hidden+role=columnheader from
  AvailableParticipantsSection visual-only header row
- Remove invalid scope="col" from div[role=columnheader] in
  DraftSummaryView (scope is only valid on <th>)
- Remove redundant aria-label from ParticipantSelectionDialog sport
  select (htmlFor label is sufficient)
- Change WizardStepper connector <li> to role=presentation
- Revert muted-foreground from 62% to 55% (original already passes
  contrast; footer was fixed separately via text-muted-foreground)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix lint error and update tests for WCAG role changes

- Replace el! non-null assertion with optional chaining in useFocusTrap
- Update AutodraftSettings tests to query role="radio" instead of
  role="button" (buttons have an explicit radio role since the WCAG pass)
- Update AvailableParticipantsSection watchlist tests to use
  getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist
  buttons now use aria-label instead of title)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-05-17 20:11:38 -07:00

143 lines
5.2 KiB
TypeScript

import React from "react";
import { Ban, Globe, Moon, Sun, Users } from "lucide-react";
import { GradientIcon } from "~/components/ui/GradientIcon";
import { Input } from "~/components/ui/input";
import { Label } from "~/components/ui/label";
import { TimezoneSelect } from "~/components/league/TimezoneSelect";
import { cn } from "~/lib/utils";
export interface OvernightPauseSettingsProps {
show: boolean;
mode: "none" | "league" | "per_user";
onModeChange: (v: "none" | "league" | "per_user") => void;
start: string;
onStartChange: (v: string) => void;
end: string;
onEndChange: (v: string) => void;
timezone: string;
onTimezoneChange: (v: string) => void;
commishTimezone?: string | null;
disabled?: boolean;
}
const PAUSE_MODES = [
{ value: "none" as const, icon: Ban, label: "No Pause", sub: "Timer always runs" },
{ value: "league" as const, icon: Globe, label: "League", sub: "Same pause for everyone" },
{ value: "per_user" as const, icon: Users, label: "Per Player", sub: "Pauses in each player's timezone" },
];
export function OvernightPauseSettings({
show,
mode,
onModeChange,
start,
onStartChange,
end,
onEndChange,
timezone,
onTimezoneChange,
commishTimezone,
disabled,
}: OvernightPauseSettingsProps) {
if (!show) return null;
const PAUSE_VALUES = PAUSE_MODES.map((m) => m.value);
function handleGroupKeyDown(e: React.KeyboardEvent<HTMLDivElement>) {
if (disabled) return;
if (!["ArrowDown", "ArrowRight", "ArrowUp", "ArrowLeft"].includes(e.key)) return;
e.preventDefault();
const idx = PAUSE_VALUES.indexOf(mode);
const next = e.key === "ArrowDown" || e.key === "ArrowRight"
? (idx + 1) % PAUSE_VALUES.length
: (idx - 1 + PAUSE_VALUES.length) % PAUSE_VALUES.length;
const nextValue = PAUSE_VALUES[next];
onModeChange(nextValue);
e.currentTarget.querySelector<HTMLElement>(`[data-radio-value="${nextValue}"]`)?.focus();
}
return (
<div className="space-y-4">
<Label>Overnight Pause</Label>
<div role="radiogroup" aria-label="Pause mode" onKeyDown={handleGroupKeyDown} className="grid grid-cols-3 gap-2">
{PAUSE_MODES.map(({ value, icon: Icon, label, sub }) => {
const selected = mode === value;
return (
<button
key={value}
type="button"
role="radio"
aria-checked={selected}
tabIndex={selected ? 0 : -1}
data-radio-value={value}
disabled={disabled}
onClick={() => onModeChange(value)}
className={cn(
"flex flex-col items-center gap-1 py-3 px-2 rounded-lg border-2 transition-all",
selected ? "border-primary" : "border-border hover:border-primary/60",
disabled && "opacity-50 cursor-not-allowed"
)}
>
<GradientIcon
icon={Icon}
className="h-5 w-5"
style={selected ? undefined : { stroke: "var(--muted-foreground)" }}
/>
<span className="text-xs font-semibold">{label}</span>
<span className="text-xs text-muted-foreground text-center leading-tight">{sub}</span>
</button>
);
})}
</div>
{mode !== "none" && (
<div className="space-y-3">
<div className="grid grid-cols-2 gap-3">
<div className="space-y-1">
<div className="flex items-center gap-1.5">
<Moon className="h-3.5 w-3.5 text-indigo-400 shrink-0" aria-hidden="true" />
<Label htmlFor="overnight-pause-start" className="text-xs">Draft pauses</Label>
</div>
<Input
id="overnight-pause-start"
type="time"
value={start}
disabled={disabled}
onChange={(e) => onStartChange(e.target.value)}
/>
</div>
<div className="space-y-1">
<div className="flex items-center gap-1.5">
<Sun className="h-3.5 w-3.5 text-yellow-400 shrink-0" aria-hidden="true" />
<Label htmlFor="overnight-pause-end" className="text-xs">Draft resumes</Label>
</div>
<Input
id="overnight-pause-end"
type="time"
value={end}
disabled={disabled}
onChange={(e) => onEndChange(e.target.value)}
/>
</div>
</div>
<div className="space-y-1">
<Label className="text-sm">
{mode === "per_user" ? "Default Timezone" : "Timezone"}
</Label>
{mode === "per_user" && (
<p className="text-xs text-muted-foreground">
Each player&apos;s profile timezone is used. Players without one fall back to the timezone below.
{!commishTimezone && (
<> You haven&apos;t set your timezone yet <a href="/profile" className="font-medium underline underline-offset-2">set it in your profile</a>.</>
)}
</p>
)}
<TimezoneSelect value={timezone} onChange={onTimezoneChange} disabled={disabled} />
</div>
</div>
)}
</div>
);
}