* fix: resolve all 48 WCAG 2.2 AA accessibility issues Critical fixes: - Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection) - Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay - Add aria-live region and connection status announcement to ConnectionOverlay Serious fixes: - Add skip-to-content link in root.tsx with id="main-content" on <main> - Add aria-label to UserMenu trigger button - Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password) - Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans - Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators - Add aria-live="polite" to draft room countdown timer - Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content - Fix Footer text contrast (changed from 28% to text-muted-foreground) - Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons - Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button - Add aria-label to PeopleSection owner and commissioner selects - Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons - Add role="radiogroup"+aria-checked to AutodraftSettings option buttons - Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper Moderate fixes: - Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region - Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel" - Add role="radiogroup"+aria-checked to TimerModeSelector - Add aria-current="page" + aria-label to SettingsDesktopNav - Add aria-label="Admin navigation" to admin sidebar nav - Add scope="col" + <caption> to StandingsTable and ScoringTables - Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid Minor fixes: - Add aria-hidden="true" to decorative trend icons in StandingsTable - Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection - Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection - Add aria-label to NotificationSettings switchOnly Switch - Add prefers-reduced-motion check to SlotMachineHeadline JS animation - Bump --muted-foreground from 55% to 62% opacity for improved contrast margin https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix code review findings from WCAG compliance pass - Add Arrow key navigation + roving tabindex to all role=radiogroup components (AutodraftSettings x2, TimerModeSelector, OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern - Extract shared focus-trap logic into useFocusTrap hook; update ConnectionOverlay and AuthRecoveryOverlay to use it - Add tabIndex={-1} to ConnectionOverlay Card so focus can land in spinner-only state (no interactive children) - Replace aria-live on loading dots container with sr-only span so status changes are announced by text content, not aria-label - Remove contradictory aria-hidden+role=columnheader from AvailableParticipantsSection visual-only header row - Remove invalid scope="col" from div[role=columnheader] in DraftSummaryView (scope is only valid on <th>) - Remove redundant aria-label from ParticipantSelectionDialog sport select (htmlFor label is sufficient) - Change WizardStepper connector <li> to role=presentation - Revert muted-foreground from 62% to 55% (original already passes contrast; footer was fixed separately via text-muted-foreground) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix lint error and update tests for WCAG role changes - Replace el! non-null assertion with optional chaining in useFocusTrap - Update AutodraftSettings tests to query role="radio" instead of role="button" (buttons have an explicit radio role since the WCAG pass) - Update AvailableParticipantsSection watchlist tests to use getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist buttons now use aria-label instead of title) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 --------- Co-authored-by: Claude <noreply@anthropic.com>
173 lines
6.4 KiB
TypeScript
173 lines
6.4 KiB
TypeScript
import { useMemo } from "react";
|
|
import {
|
|
Table,
|
|
TableBody,
|
|
TableCell,
|
|
TableHead,
|
|
TableHeader,
|
|
TableRow,
|
|
} from "~/components/ui/table";
|
|
import { Badge } from "~/components/ui/badge";
|
|
import { TrendingUp, TrendingDown, Minus, Trophy, Medal, Award } from "lucide-react";
|
|
import { buildTiedRankChecker } from "~/lib/standings-display";
|
|
|
|
export interface StandingsRow {
|
|
teamId: string;
|
|
teamName: string;
|
|
totalPoints: number;
|
|
currentRank: number;
|
|
previousRank?: number | null;
|
|
firstPlaceCount: number;
|
|
secondPlaceCount: number;
|
|
thirdPlaceCount: number;
|
|
fourthPlaceCount: number;
|
|
fifthPlaceCount: number;
|
|
sixthPlaceCount: number;
|
|
seventhPlaceCount: number;
|
|
eighthPlaceCount: number;
|
|
participantsRemaining: number;
|
|
}
|
|
|
|
interface StandingsTableProps {
|
|
standings: StandingsRow[];
|
|
showMovement?: boolean;
|
|
showPlacementBreakdown?: boolean;
|
|
}
|
|
|
|
function getRankBadge(rank: number, isTied?: boolean) {
|
|
const t = isTied ? "T" : "";
|
|
if (rank === 1) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Trophy className="h-5 w-5 text-yellow-500" />
|
|
<span className="font-bold text-lg">{t}{rank}</span>
|
|
</div>
|
|
);
|
|
} else if (rank === 2) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Medal className="h-5 w-5 text-gray-400" />
|
|
<span className="font-semibold">{t}{rank}</span>
|
|
</div>
|
|
);
|
|
} else if (rank === 3) {
|
|
return (
|
|
<div className="flex items-center gap-2">
|
|
<Award className="h-5 w-5 text-amber-700" />
|
|
<span className="font-semibold">{t}{rank}</span>
|
|
</div>
|
|
);
|
|
} else {
|
|
return <span className="font-medium">{t}{rank}</span>;
|
|
}
|
|
}
|
|
|
|
export function StandingsTable({
|
|
standings,
|
|
showMovement = true,
|
|
showPlacementBreakdown = false,
|
|
}: StandingsTableProps) {
|
|
const isTied = useMemo(
|
|
() => buildTiedRankChecker(standings.map((s) => s.currentRank)),
|
|
[standings]
|
|
);
|
|
const getMovementIndicator = (current: number, previous?: number | null) => {
|
|
if (!showMovement || !previous) return null;
|
|
|
|
const change = previous - current; // Positive means moved up
|
|
|
|
if (change > 0) {
|
|
return (
|
|
<div className="flex items-center gap-1 text-emerald-400">
|
|
<TrendingUp className="h-3 w-3" aria-hidden="true" />
|
|
<span className="text-xs">+{change}</span>
|
|
</div>
|
|
);
|
|
} else if (change < 0) {
|
|
return (
|
|
<div className="flex items-center gap-1 text-coral-accent">
|
|
<TrendingDown className="h-3 w-3" aria-hidden="true" />
|
|
<span className="text-xs">{change}</span>
|
|
</div>
|
|
);
|
|
} else {
|
|
return (
|
|
<div className="flex items-center gap-1 text-muted-foreground">
|
|
<Minus className="h-3 w-3" aria-hidden="true" />
|
|
<span className="text-xs">-</span>
|
|
</div>
|
|
);
|
|
}
|
|
};
|
|
|
|
return (
|
|
<Table aria-label="Standings">
|
|
<TableHeader>
|
|
<TableRow>
|
|
<TableHead scope="col" className="w-16">Rank</TableHead>
|
|
{showMovement && <TableHead scope="col" className="w-20">Change</TableHead>}
|
|
<TableHead scope="col">Team</TableHead>
|
|
<TableHead scope="col" className="text-right">Total Points</TableHead>
|
|
{showPlacementBreakdown && (
|
|
<>
|
|
<TableHead scope="col" aria-label="1st place finishes" className="text-center w-12"><span aria-hidden="true">🥇</span></TableHead>
|
|
<TableHead scope="col" aria-label="2nd place finishes" className="text-center w-12"><span aria-hidden="true">🥈</span></TableHead>
|
|
<TableHead scope="col" aria-label="3rd place finishes" className="text-center w-12"><span aria-hidden="true">🥉</span></TableHead>
|
|
<TableHead scope="col" className="text-center w-12">4th</TableHead>
|
|
<TableHead scope="col" className="text-center w-12">5th</TableHead>
|
|
<TableHead scope="col" className="text-center w-12">6th</TableHead>
|
|
<TableHead scope="col" className="text-center w-12">7th</TableHead>
|
|
<TableHead scope="col" className="text-center w-12">8th</TableHead>
|
|
</>
|
|
)}
|
|
<TableHead scope="col" className="text-right">Remaining</TableHead>
|
|
</TableRow>
|
|
</TableHeader>
|
|
<TableBody>
|
|
{standings.length === 0 ? (
|
|
<TableRow>
|
|
<TableCell colSpan={showPlacementBreakdown ? 13 : 5} className="text-center text-muted-foreground">
|
|
No standings data available yet
|
|
</TableCell>
|
|
</TableRow>
|
|
) : (
|
|
standings.map((row) => (
|
|
<TableRow key={row.teamId} className={row.currentRank <= 3 ? "bg-muted/30" : undefined}>
|
|
<TableCell>
|
|
{getRankBadge(row.currentRank, isTied(row.currentRank))}
|
|
</TableCell>
|
|
{showMovement && (
|
|
<TableCell>
|
|
{getMovementIndicator(row.currentRank, row.previousRank)}
|
|
</TableCell>
|
|
)}
|
|
<TableCell className="font-medium">{row.teamName}</TableCell>
|
|
<TableCell className="text-right font-semibold">
|
|
{row.totalPoints.toFixed(2)}
|
|
</TableCell>
|
|
{showPlacementBreakdown && (
|
|
<>
|
|
<TableCell className="text-center">{row.firstPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.secondPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.thirdPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.fourthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.fifthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.sixthPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.seventhPlaceCount || "-"}</TableCell>
|
|
<TableCell className="text-center">{row.eighthPlaceCount || "-"}</TableCell>
|
|
</>
|
|
)}
|
|
<TableCell className="text-right">
|
|
{row.participantsRemaining > 0 ? (
|
|
<Badge variant="secondary">{row.participantsRemaining}</Badge>
|
|
) : (
|
|
<span className="text-muted-foreground">-</span>
|
|
)}
|
|
</TableCell>
|
|
</TableRow>
|
|
))
|
|
)}
|
|
</TableBody>
|
|
</Table>
|
|
);
|
|
}
|