* fix: resolve all 48 WCAG 2.2 AA accessibility issues Critical fixes: - Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection) - Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay - Add aria-live region and connection status announcement to ConnectionOverlay Serious fixes: - Add skip-to-content link in root.tsx with id="main-content" on <main> - Add aria-label to UserMenu trigger button - Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password) - Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans - Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators - Add aria-live="polite" to draft room countdown timer - Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content - Fix Footer text contrast (changed from 28% to text-muted-foreground) - Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons - Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button - Add aria-label to PeopleSection owner and commissioner selects - Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons - Add role="radiogroup"+aria-checked to AutodraftSettings option buttons - Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper Moderate fixes: - Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region - Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel" - Add role="radiogroup"+aria-checked to TimerModeSelector - Add aria-current="page" + aria-label to SettingsDesktopNav - Add aria-label="Admin navigation" to admin sidebar nav - Add scope="col" + <caption> to StandingsTable and ScoringTables - Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid Minor fixes: - Add aria-hidden="true" to decorative trend icons in StandingsTable - Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection - Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection - Add aria-label to NotificationSettings switchOnly Switch - Add prefers-reduced-motion check to SlotMachineHeadline JS animation - Bump --muted-foreground from 55% to 62% opacity for improved contrast margin https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix code review findings from WCAG compliance pass - Add Arrow key navigation + roving tabindex to all role=radiogroup components (AutodraftSettings x2, TimerModeSelector, OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern - Extract shared focus-trap logic into useFocusTrap hook; update ConnectionOverlay and AuthRecoveryOverlay to use it - Add tabIndex={-1} to ConnectionOverlay Card so focus can land in spinner-only state (no interactive children) - Replace aria-live on loading dots container with sr-only span so status changes are announced by text content, not aria-label - Remove contradictory aria-hidden+role=columnheader from AvailableParticipantsSection visual-only header row - Remove invalid scope="col" from div[role=columnheader] in DraftSummaryView (scope is only valid on <th>) - Remove redundant aria-label from ParticipantSelectionDialog sport select (htmlFor label is sufficient) - Change WizardStepper connector <li> to role=presentation - Revert muted-foreground from 62% to 55% (original already passes contrast; footer was fixed separately via text-muted-foreground) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix lint error and update tests for WCAG role changes - Replace el! non-null assertion with optional chaining in useFocusTrap - Update AutodraftSettings tests to query role="radio" instead of role="button" (buttons have an explicit radio role since the WCAG pass) - Update AvailableParticipantsSection watchlist tests to use getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist buttons now use aria-label instead of title) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 --------- Co-authored-by: Claude <noreply@anthropic.com>
262 lines
11 KiB
TypeScript
262 lines
11 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
|
|
import { AutodraftSettings } from '~/components/AutodraftSettings';
|
|
|
|
vi.mock('sonner', () => ({
|
|
toast: { success: vi.fn(), error: vi.fn(), info: vi.fn() },
|
|
}));
|
|
|
|
global.fetch = vi.fn();
|
|
|
|
describe('AutodraftSettings Component', () => {
|
|
const defaultProps = {
|
|
seasonId: 'season-123',
|
|
teamId: 'team-456',
|
|
isEnabled: false,
|
|
mode: 'next_pick' as const,
|
|
queueOnly: false,
|
|
isMyTurn: false,
|
|
onUpdate: vi.fn(),
|
|
};
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
(global.fetch as any).mockResolvedValue({
|
|
ok: true,
|
|
json: async () => ({ success: true }),
|
|
});
|
|
});
|
|
|
|
// ─── Rendering ────────────────────────────────────────────────────────────
|
|
|
|
describe('Rendering', () => {
|
|
it('renders all four option buttons', () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
|
|
expect(screen.getByRole('radio', { name: 'Off' })).toBeInTheDocument();
|
|
expect(screen.getByRole('radio', { name: 'Next in Queue' })).toBeInTheDocument();
|
|
expect(screen.getByRole('radio', { name: 'All in Queue' })).toBeInTheDocument();
|
|
expect(screen.getByRole('radio', { name: 'All Picks' })).toBeInTheDocument();
|
|
});
|
|
|
|
it('does not render a queue-only toggle switch', () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={true} />);
|
|
expect(screen.queryByRole('switch')).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('shows "You\'re on the clock!" when isMyTurn=true', () => {
|
|
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
|
|
expect(screen.getByText(/You're on the clock!/i)).toBeInTheDocument();
|
|
});
|
|
|
|
it('marks Off as active (muted border) when isEnabled=false', () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
|
|
expect(screen.getByRole('radio', { name: 'Off' }).className).toContain(
|
|
'border-l-muted-foreground'
|
|
);
|
|
});
|
|
|
|
it('marks Next in Queue as active when isEnabled=true, mode=next_pick', () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} />);
|
|
expect(screen.getByRole('radio', { name: 'Next in Queue' }).className).toContain('bg-electric');
|
|
});
|
|
|
|
it('marks All in Queue as active when isEnabled=true, mode=while_on, queueOnly=true', () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="while_on" queueOnly={true} />);
|
|
expect(screen.getByRole('radio', { name: 'All in Queue' }).className).toContain('bg-electric');
|
|
});
|
|
|
|
it('marks All Picks as active when isEnabled=true, mode=while_on, queueOnly=false', () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="while_on" queueOnly={false} />);
|
|
expect(screen.getByRole('radio', { name: 'All Picks' }).className).toContain('bg-electric');
|
|
});
|
|
});
|
|
|
|
// ─── Interaction ──────────────────────────────────────────────────────────
|
|
|
|
describe('Button interaction', () => {
|
|
it('switches to Next in Queue and calls onUpdate with correct args', async () => {
|
|
const onUpdate = vi.fn();
|
|
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
|
|
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
await waitFor(() => {
|
|
expect(global.fetch).toHaveBeenCalledWith(
|
|
'/api/autodraft/update',
|
|
expect.objectContaining({ method: 'POST' })
|
|
);
|
|
});
|
|
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'next_pick', true));
|
|
});
|
|
|
|
it('switches to All in Queue and calls onUpdate with correct args', async () => {
|
|
const onUpdate = vi.fn();
|
|
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
|
|
|
|
fireEvent.click(screen.getByRole('radio', { name: 'All in Queue' }));
|
|
|
|
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'while_on', true));
|
|
});
|
|
|
|
it('switches to All Picks and calls onUpdate with correct args', async () => {
|
|
const onUpdate = vi.fn();
|
|
render(<AutodraftSettings {...defaultProps} onUpdate={onUpdate} />);
|
|
|
|
fireEvent.click(screen.getByRole('radio', { name: 'All Picks' }));
|
|
|
|
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(true, 'while_on', false));
|
|
});
|
|
|
|
it('switches to Off and calls onUpdate with isEnabled=false', async () => {
|
|
const onUpdate = vi.fn();
|
|
render(
|
|
<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} onUpdate={onUpdate} />
|
|
);
|
|
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Off' }));
|
|
|
|
await waitFor(() => expect(onUpdate).toHaveBeenCalledWith(false, 'next_pick', false));
|
|
});
|
|
|
|
it('disables all buttons when isMyTurn=true', () => {
|
|
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
|
|
|
|
expect(screen.getByRole('radio', { name: 'Off' })).toBeDisabled();
|
|
expect(screen.getByRole('radio', { name: 'Next in Queue' })).toBeDisabled();
|
|
expect(screen.getByRole('radio', { name: 'All in Queue' })).toBeDisabled();
|
|
expect(screen.getByRole('radio', { name: 'All Picks' })).toBeDisabled();
|
|
});
|
|
|
|
it('does not call fetch when a button is clicked during the user\'s turn', () => {
|
|
render(<AutodraftSettings {...defaultProps} isMyTurn={true} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
expect(global.fetch).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('does not re-fire when the already-active option is clicked', async () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Off' }));
|
|
expect(global.fetch).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
// ─── Optimistic UI ────────────────────────────────────────────────────────
|
|
|
|
describe('Optimistic UI', () => {
|
|
it('does not disable buttons while a fetch is in flight', async () => {
|
|
let resolve: ((v: any) => void) | undefined;
|
|
(global.fetch as any).mockReturnValueOnce(new Promise((r) => { resolve = r; }));
|
|
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
// Buttons stay enabled — optimistic UI does not block interaction
|
|
expect(screen.getByRole('radio', { name: 'Off' })).not.toBeDisabled();
|
|
|
|
resolve?.({ ok: true, json: async () => ({ success: true }) });
|
|
});
|
|
|
|
it('fires a fetch for every rapid click, aborting previous in-flight requests', async () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
fireEvent.click(screen.getByRole('radio', { name: 'All in Queue' }));
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Off' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalledTimes(3));
|
|
});
|
|
});
|
|
|
|
// ─── Error handling ───────────────────────────────────────────────────────
|
|
|
|
describe('Error handling', () => {
|
|
it('reverts to the previous state on a non-ok API response', async () => {
|
|
(global.fetch as any).mockResolvedValueOnce({ ok: false });
|
|
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
await waitFor(() => {
|
|
expect(screen.getByRole('radio', { name: 'Off' }).className).toContain(
|
|
'border-l-muted-foreground'
|
|
);
|
|
});
|
|
});
|
|
|
|
it('reverts to the previous state on a network error', async () => {
|
|
(global.fetch as any).mockRejectedValueOnce(new Error('Network error'));
|
|
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={false} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
await waitFor(() => {
|
|
expect(screen.getByRole('radio', { name: 'Off' }).className).toContain(
|
|
'border-l-muted-foreground'
|
|
);
|
|
});
|
|
});
|
|
});
|
|
|
|
// ─── API payload ──────────────────────────────────────────────────────────
|
|
|
|
describe('API payload', () => {
|
|
it('posts correct formData for Next in Queue (next_pick, queueOnly=true)', async () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
|
|
|
|
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
|
|
expect(body.get('seasonId')).toBe('season-123');
|
|
expect(body.get('teamId')).toBe('team-456');
|
|
expect(body.get('isEnabled')).toBe('true');
|
|
expect(body.get('mode')).toBe('next_pick');
|
|
expect(body.get('queueOnly')).toBe('true');
|
|
});
|
|
|
|
it('posts correct formData for All in Queue (while_on, queueOnly=true)', async () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'All in Queue' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
|
|
|
|
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
|
|
expect(body.get('isEnabled')).toBe('true');
|
|
expect(body.get('mode')).toBe('while_on');
|
|
expect(body.get('queueOnly')).toBe('true');
|
|
});
|
|
|
|
it('posts correct formData for All Picks (while_on, queueOnly=false)', async () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'All Picks' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
|
|
|
|
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
|
|
expect(body.get('isEnabled')).toBe('true');
|
|
expect(body.get('mode')).toBe('while_on');
|
|
expect(body.get('queueOnly')).toBe('false');
|
|
});
|
|
|
|
it('posts isEnabled=false for Off', async () => {
|
|
render(<AutodraftSettings {...defaultProps} isEnabled={true} mode="next_pick" queueOnly={true} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Off' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
|
|
|
|
const body = (global.fetch as any).mock.calls[0][1].body as FormData;
|
|
expect(body.get('isEnabled')).toBe('false');
|
|
});
|
|
|
|
it('passes an AbortSignal to fetch', async () => {
|
|
render(<AutodraftSettings {...defaultProps} />);
|
|
fireEvent.click(screen.getByRole('radio', { name: 'Next in Queue' }));
|
|
|
|
await waitFor(() => expect(global.fetch).toHaveBeenCalled());
|
|
|
|
const options = (global.fetch as any).mock.calls[0][1];
|
|
expect(options.signal).toBeInstanceOf(AbortSignal);
|
|
});
|
|
});
|
|
});
|