brackt/app/components/league/settings/DraftSetupSection.tsx
Chris Parsons 4bbcac1949
fix: resolve all 48 WCAG 2.2 AA accessibility issues (#439)
* fix: resolve all 48 WCAG 2.2 AA accessibility issues

Critical fixes:
- Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection)
- Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay
- Add aria-live region and connection status announcement to ConnectionOverlay

Serious fixes:
- Add skip-to-content link in root.tsx with id="main-content" on <main>
- Add aria-label to UserMenu trigger button
- Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password)
- Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans
- Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators
- Add aria-live="polite" to draft room countdown timer
- Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content
- Fix Footer text contrast (changed from 28% to text-muted-foreground)
- Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons
- Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button
- Add aria-label to PeopleSection owner and commissioner selects
- Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons
- Add role="radiogroup"+aria-checked to AutodraftSettings option buttons
- Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper

Moderate fixes:
- Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region
- Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel"
- Add role="radiogroup"+aria-checked to TimerModeSelector
- Add aria-current="page" + aria-label to SettingsDesktopNav
- Add aria-label="Admin navigation" to admin sidebar nav
- Add scope="col" + <caption> to StandingsTable and ScoringTables
- Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid

Minor fixes:
- Add aria-hidden="true" to decorative trend icons in StandingsTable
- Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection
- Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection
- Add aria-label to NotificationSettings switchOnly Switch
- Add prefers-reduced-motion check to SlotMachineHeadline JS animation
- Bump --muted-foreground from 55% to 62% opacity for improved contrast margin

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix code review findings from WCAG compliance pass

- Add Arrow key navigation + roving tabindex to all role=radiogroup
  components (AutodraftSettings x2, TimerModeSelector,
  OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern
- Extract shared focus-trap logic into useFocusTrap hook; update
  ConnectionOverlay and AuthRecoveryOverlay to use it
- Add tabIndex={-1} to ConnectionOverlay Card so focus can land in
  spinner-only state (no interactive children)
- Replace aria-live on loading dots container with sr-only span so
  status changes are announced by text content, not aria-label
- Remove contradictory aria-hidden+role=columnheader from
  AvailableParticipantsSection visual-only header row
- Remove invalid scope="col" from div[role=columnheader] in
  DraftSummaryView (scope is only valid on <th>)
- Remove redundant aria-label from ParticipantSelectionDialog sport
  select (htmlFor label is sufficient)
- Change WizardStepper connector <li> to role=presentation
- Revert muted-foreground from 62% to 55% (original already passes
  contrast; footer was fixed separately via text-muted-foreground)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

* Fix lint error and update tests for WCAG role changes

- Replace el! non-null assertion with optional chaining in useFocusTrap
- Update AutodraftSettings tests to query role="radio" instead of
  role="button" (buttons have an explicit radio role since the WCAG pass)
- Update AvailableParticipantsSection watchlist tests to use
  getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist
  buttons now use aria-label instead of title)

https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-05-17 20:11:38 -07:00

216 lines
8.3 KiB
TypeScript

import { Swords, CalendarIcon } from "lucide-react";
import { useLocalTimezone } from "~/hooks/useLocalTimezone";
import { format } from "date-fns";
import { Label } from "~/components/ui/label";
import { Input } from "~/components/ui/input";
import { Button } from "~/components/ui/button";
import { Badge } from "~/components/ui/badge";
import { Calendar } from "~/components/ui/calendar";
import { Popover, PopoverContent, PopoverTrigger } from "~/components/ui/popover";
import { cn } from "~/lib/utils";
import { TimerModeSelector } from "~/components/league/TimerModeSelector";
import { DraftSpeedPicker } from "~/components/league/DraftSpeedPicker";
import { OvernightPauseSettings } from "~/components/league/OvernightPauseSettings";
import { StepperInput } from "~/components/league/StepperInput";
import { Checkbox } from "~/components/ui/checkbox";
import { SettingsSection, SettingsStatusPill } from "./SettingsSection";
export function DraftSetupSection({
active,
canEditDraftRounds,
minRounds,
recommendedRounds,
flexSpots,
draftRounds,
onDraftRoundsChange,
draftDate,
onDraftDateChange,
draftTime,
onDraftTimeChange,
autoStartDraft,
onAutoStartDraftChange,
timerMode,
onTimerModeChange,
draftSpeed,
onDraftSpeedChange,
overnightMode,
onOvernightModeChange,
overnightStart,
onOvernightStartChange,
overnightEnd,
onOvernightEndChange,
overnightTimezone,
onOvernightTimezoneChange,
commishTimezone,
}: {
active: boolean;
canEditDraftRounds: boolean;
minRounds: number;
recommendedRounds: number;
flexSpots: number;
draftRounds: number;
onDraftRoundsChange: (v: number) => void;
draftDate: Date | undefined;
onDraftDateChange: (v: Date | undefined) => void;
draftTime: string;
onDraftTimeChange: (v: string) => void;
autoStartDraft: boolean;
onAutoStartDraftChange: (v: boolean) => void;
timerMode: "chess_clock" | "standard";
onTimerModeChange: (v: "chess_clock" | "standard") => void;
draftSpeed: string;
onDraftSpeedChange: (v: string) => void;
overnightMode: "none" | "league" | "per_user";
onOvernightModeChange: (v: "none" | "league" | "per_user") => void;
overnightStart: string;
onOvernightStartChange: (v: string) => void;
overnightEnd: string;
onOvernightEndChange: (v: string) => void;
overnightTimezone: string;
onOvernightTimezoneChange: (v: string) => void;
commishTimezone: string | null;
}) {
const localTz = useLocalTimezone();
return (
<SettingsSection
id="draft-setup"
icon={Swords}
title="Draft Settings"
description="Configure the draft format, timing, overnight protections, and pick order."
status={<SettingsStatusPill tone={canEditDraftRounds ? "success" : "locked"}>{canEditDraftRounds ? "Editable" : "Locked"}</SettingsStatusPill>}
className={active ? undefined : "hidden"}
>
<input type="hidden" name="draftRounds" value={draftRounds} />
<input type="hidden" name="draftTimerMode" value={timerMode} />
<input type="hidden" name="draftSpeed" value={draftSpeed} />
<input type="hidden" name="overnightPauseMode" value={overnightMode} />
<input type="hidden" name="overnightPauseStart" value={overnightStart} />
<input type="hidden" name="overnightPauseEnd" value={overnightEnd} />
<input type="hidden" name="overnightPauseTimezone" value={overnightTimezone} />
{draftDate && draftTime ? (
<input
type="hidden"
name="draftDateTime"
value={new Date(`${format(draftDate, "yyyy-MM-dd")}T${draftTime}`).toISOString()}
/>
) : (
<input type="hidden" name="draftDateTime" value="" />
)}
<div className="space-y-8">
<div className="space-y-8">
<div className="rounded-lg border p-5 sm:p-6">
<div className="mb-5 flex items-start justify-between gap-3">
<div>
<Label>Draft Rounds</Label>
<p className="text-sm text-muted-foreground">Minimum {minRounds}; recommended {recommendedRounds}.</p>
</div>
<Badge variant="outline">{flexSpots} flex</Badge>
</div>
<StepperInput
value={draftRounds}
min={canEditDraftRounds ? Math.max(1, minRounds) : draftRounds}
max={canEditDraftRounds ? 50 : draftRounds}
onChange={onDraftRoundsChange}
decrementLabel="Decrease draft rounds"
incrementLabel="Increase draft rounds"
/>
{!canEditDraftRounds && (
<p className="mt-3 text-sm text-muted-foreground">Round count cannot be changed after draft starts.</p>
)}
</div>
<div className="rounded-lg border p-5 sm:p-6">
<Label>Draft Date & Time</Label>
<div className="mt-5 grid gap-3 sm:grid-cols-2">
<Popover>
<PopoverTrigger asChild>
<Button
aria-label={draftDate ? `Draft date: ${format(draftDate, "PPP")}. Click to change.` : "Pick a draft date"}
variant="outline"
className={cn("justify-start text-left font-normal", !draftDate && "text-muted-foreground")}
disabled={!canEditDraftRounds}
>
<CalendarIcon className="mr-2 h-4 w-4" />
{draftDate ? format(draftDate, "PPP") : <span>Pick a date</span>}
</Button>
</PopoverTrigger>
<PopoverContent className="w-auto p-0">
<Calendar
mode="single"
selected={draftDate}
onSelect={(date) => onDraftDateChange(date)}
disabled={(date) => date < new Date(new Date().setHours(0, 0, 0, 0))}
/>
</PopoverContent>
</Popover>
<Input
id="draftTime"
type="time"
aria-label="Draft time"
value={draftTime}
onChange={(e) => onDraftTimeChange(e.target.value)}
disabled={!canEditDraftRounds}
/>
</div>
<p className="mt-4 text-sm text-muted-foreground">
Set this before starting the draft room.
{localTz && <> Times are in your local timezone ({localTz}).</>}
</p>
{draftDate && draftTime && (
<div className="mt-4 flex items-center gap-3">
<Checkbox
id="autoStartDraft"
checked={autoStartDraft}
onCheckedChange={(v) => onAutoStartDraftChange(v === true)}
disabled={!canEditDraftRounds}
/>
<Label htmlFor="autoStartDraft" className="font-normal cursor-pointer">
Auto-start at scheduled time
</Label>
</div>
)}
<input type="hidden" name="autoStartDraft" value={draftDate && draftTime && autoStartDraft ? "on" : ""} />
</div>
<div className="space-y-8 rounded-lg border p-5 sm:p-6">
<div className="space-y-4">
<Label>Timer Mode</Label>
<TimerModeSelector
value={timerMode}
onChange={onTimerModeChange}
disabled={!canEditDraftRounds}
/>
</div>
<div className="border-t pt-8 space-y-4">
<Label>Draft Speed</Label>
<DraftSpeedPicker
timerMode={timerMode}
value={draftSpeed}
onChange={onDraftSpeedChange}
disabled={!canEditDraftRounds}
/>
</div>
</div>
</div>
<div className="rounded-lg border p-5 sm:p-6">
<OvernightPauseSettings
show={true}
mode={overnightMode}
onModeChange={onOvernightModeChange}
start={overnightStart}
onStartChange={onOvernightStartChange}
end={overnightEnd}
onEndChange={onOvernightEndChange}
timezone={overnightTimezone}
onTimezoneChange={onOvernightTimezoneChange}
commishTimezone={commishTimezone}
disabled={!canEditDraftRounds}
/>
</div>
</div>
</SettingsSection>
);
}