4bffa40606
* Fix no-shadow and consistent-function-scoping lint violations
Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.
no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).
consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix no-non-null-assertion lint violations and promote to error
Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.
Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers
Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.
- prefer-add-event-listener: converted onchange/onclick/onload
assignments to addEventListener in useDraftNotifications.ts and
admin.data-sync.tsx; stored changeHandler ref for proper cleanup
with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
side-effect imports (*.css, @testing-library/jest-dom,
@testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
cypress/support/e2e.ts (file already has an import)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix TypeScript errors from no-non-null-assertion fixes
Two fixes introduced by the non-null assertion cleanup produced type
errors:
- scoring-event.ts: `?? ""` was wrong type for a participant object map;
restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
truthy guarantee, causing TS18047 on the write-back block; added
`participant &&` guard before accessing its properties
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add npm run typecheck as Stop hook in Claude settings
Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
66 lines
1.7 KiB
JSON
66 lines
1.7 KiB
JSON
{
|
|
"$schema": "./node_modules/oxlint/configuration_schema.json",
|
|
"plugins": ["react", "typescript", "vitest", "unicorn", "import"],
|
|
"env": {
|
|
"browser": true,
|
|
"node": true,
|
|
"es2022": true
|
|
},
|
|
"categories": {
|
|
"correctness": "error",
|
|
"suspicious": "warn"
|
|
},
|
|
"rules": {
|
|
"no-console": "warn",
|
|
"no-var": "error",
|
|
"prefer-const": "error",
|
|
"eqeqeq": ["error", "always"],
|
|
"no-unused-vars": "off",
|
|
"no-undef": "off",
|
|
|
|
"typescript/no-unused-vars": [
|
|
"error",
|
|
{ "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }
|
|
],
|
|
"typescript/no-explicit-any": "error",
|
|
"typescript/no-non-null-assertion": "error",
|
|
"typescript/consistent-type-imports": [
|
|
"error",
|
|
{ "prefer": "type-imports" }
|
|
],
|
|
|
|
"react/react-in-jsx-scope": "off",
|
|
"react/rules-of-hooks": "error",
|
|
"react/exhaustive-deps": "error",
|
|
"react/jsx-key": "error",
|
|
"react/no-array-index-key": "error",
|
|
"react/self-closing-comp": "warn",
|
|
|
|
"import/no-duplicates": "error",
|
|
"import/no-unassigned-import": ["error", {
|
|
"allow": ["**/*.css", "@testing-library/jest-dom", "@testing-library/cypress/add-commands"]
|
|
}],
|
|
|
|
"no-shadow": "error",
|
|
"unicorn/consistent-function-scoping": "error",
|
|
"unicorn/prefer-add-event-listener": "error",
|
|
"unicorn/require-module-specifiers": "error"
|
|
},
|
|
"overrides": [
|
|
{
|
|
"files": ["**/__tests__/**", "**/*.test.ts", "**/*.test.tsx", "cypress/**"],
|
|
"rules": {
|
|
"no-console": "off",
|
|
"typescript/no-explicit-any": "off"
|
|
}
|
|
}
|
|
],
|
|
"ignorePatterns": [
|
|
"build/**",
|
|
"dist/**",
|
|
"node_modules/**",
|
|
"drizzle/**",
|
|
".react-router/**",
|
|
"cypress/fixtures/**"
|
|
]
|
|
}
|