brackt/app/components/draft/TeamsDraftedGrid.tsx
Chris Parsons 4bffa40606
Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196)
* Fix no-shadow and consistent-function-scoping lint violations

Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.

no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).

consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix no-non-null-assertion lint violations and promote to error

Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.

Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers

Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.

- prefer-add-event-listener: converted onchange/onclick/onload
  assignments to addEventListener in useDraftNotifications.ts and
  admin.data-sync.tsx; stored changeHandler ref for proper cleanup
  with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
  side-effect imports (*.css, @testing-library/jest-dom,
  @testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
  cypress/support/e2e.ts (file already has an import)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix TypeScript errors from no-non-null-assertion fixes

Two fixes introduced by the non-null assertion cleanup produced type
errors:

- scoring-event.ts: `?? ""` was wrong type for a participant object map;
  restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
  truthy guarantee, causing TS18047 on the write-back block; added
  `participant &&` guard before accessing its properties

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add npm run typecheck as Stop hook in Claude settings

Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-21 10:59:51 -07:00

169 lines
5.5 KiB
TypeScript

import { memo, useMemo } from "react";
import { Badge } from "~/components/ui/badge";
interface TeamsDraftedGridProps {
draftSlots: Array<{
id: string;
team: {
id: string;
name: string;
};
}>;
ownerMap?: Record<string, string>;
picks: Array<{
id: string;
team: {
id: string;
name: string;
};
participant: {
id: string;
name: string;
};
sport: {
id: string;
name: string;
};
}>;
sports: Array<{
id: string;
name: string;
}>;
season: {
numFlexPicks: number;
};
}
export const TeamsDraftedGrid = memo(function TeamsDraftedGrid({
draftSlots,
picks,
sports,
season,
ownerMap = {},
}: TeamsDraftedGridProps) {
// Calculate picks by team and sport
const picksByTeamAndSport = useMemo(() => {
const map = new Map<string, Map<string, typeof picks>>();
picks.forEach((pick) => {
if (!map.has(pick.team.id)) {
map.set(pick.team.id, new Map());
}
const teamMap = map.get(pick.team.id) ?? new Map<string, typeof picks>();
if (!map.has(pick.team.id)) map.set(pick.team.id, teamMap);
if (!teamMap.has(pick.sport.id)) {
teamMap.set(pick.sport.id, []);
}
teamMap.get(pick.sport.id)?.push(pick);
});
return map;
}, [picks]);
// Calculate flex picks used by each team
const flexPicksByTeam = useMemo(() => {
const map = new Map<string, number>();
draftSlots.forEach((slot) => {
const teamPicks = picks.filter((p) => p.team.id === slot.team.id);
const uniqueSportsPicked = new Set(teamPicks.map((p) => p.sport.id)).size;
const flexUsed = Math.max(0, teamPicks.length - uniqueSportsPicked);
map.set(slot.team.id, flexUsed);
});
return map;
}, [picks, draftSlots]);
if (sports.length === 0) {
return (
<div className="flex items-center justify-center h-full p-8 text-muted-foreground">
<p>No sports have been configured for this season.</p>
</div>
);
}
return (
<div className="w-full h-full overflow-auto">
<table className="w-full border-collapse">
<thead className="sticky top-0 bg-background z-10">
<tr>
<th className="border-r border-b border-border p-2 text-left font-semibold min-w-[150px] bg-muted/50 sticky left-0 z-20">
Sport
</th>
{draftSlots.map((slot, index) => {
const flexUsed = flexPicksByTeam.get(slot.team.id) || 0;
const isLast = index === draftSlots.length - 1;
return (
<th
key={slot.id}
className={`border-b border-border p-2 text-left font-semibold min-w-[180px] bg-muted/50 ${!isLast ? 'border-r' : ''}`}
>
<div className="flex flex-col gap-1">
<div className="font-semibold text-sm">
{ownerMap[slot.team.id] || slot.team.name}
</div>
<div className="text-xs text-muted-foreground font-normal">
{flexUsed} of {season.numFlexPicks} flex
</div>
</div>
</th>
);
})}
</tr>
</thead>
<tbody className="border-b border-border">
{sports.map((sport, sportIndex) => {
const isLastRow = sportIndex === sports.length - 1;
return (
<tr key={sport.id}>
<td className={`border-r border-border p-2 font-medium bg-muted/30 sticky left-0 z-10 ${!isLastRow ? 'border-b' : ''}`}>
{sport.name}
</td>
{draftSlots.map((slot, slotIndex) => {
const teamSportPicks =
picksByTeamAndSport
.get(slot.team.id)
?.get(sport.id) || [];
const hasMultiplePicks = teamSportPicks.length > 1;
const isLastCol = slotIndex === draftSlots.length - 1;
return (
<td
key={`${slot.team.id}-${sport.id}`}
className={`border-border p-2 ${
hasMultiplePicks
? "bg-accent/30 font-semibold"
: "bg-background"
} ${!isLastRow ? 'border-b' : ''} ${!isLastCol ? 'border-r' : ''}`}
>
{teamSportPicks.length > 0 ? (
<div className="flex flex-col gap-1">
{teamSportPicks.map((pick, i) => (
<div
key={pick.id}
className="text-sm flex items-center gap-1"
>
<span>{pick.participant.name}</span>
{hasMultiplePicks && (
<Badge
variant="secondary"
className="text-xs px-1 py-0"
>
{i + 1}
</Badge>
)}
</div>
))}
</div>
) : null}
</td>
);
})}
</tr>
);
})}
</tbody>
</table>
</div>
);
});