brackt/app/services/standings-sync/index.ts
Chris Parsons 766ba948e1
Add MLS standings sync and fix simulator conference resolution (#423)
* Add MLS standings sync and fix simulator conference resolution

- New MlsStandingsAdapter using ESPN's free soccer API (no key required),
  returning Eastern/Western conference data, W/D/L/GF/GA/GD/PTS, conference
  rank, and home/away records; registered under mls_bracket
- Display route now shows soccer table columns and a 9-team playoff cutoff
  line for mls_bracket (top 9 per conference qualify for MLS Cup Playoffs)
- MLS simulator gains a third conference fallback: reads externalId="Eastern"
  or "Western" on the participant, mirroring the LLWS pool-assignment pattern
  so admins can bootstrap conference data before the first standings sync
- 9 unit tests covering stat mapping, conference normalization, rank ordering,
  and error paths

https://claude.ai/code/session_01WhzXHpv6taXdHzhgvnv83u

* Address code review feedback on MLS standings + simulator

1. Update mls-simulator.ts module comment to document the new step-3
   externalId fallback in the conference resolution order
2. Tighten normalizeConference to exact-match "Eastern"/"Western
   Conference" instead of broad substring, preventing false matches
   on names like "Northeast"
3. Pre-parse statsMap for each entry before the sort so it isn't
   rebuilt O(n log n) times during comparison
4. Document the externalId name-matching tradeoff on
   parseConferenceFromExternalId
5. Try ESPN's gamesPlayed stat before falling back to wins+losses+ties
   sum; export parseConferenceFromExternalId for direct testing
6. Add tests: normalizeConference passthrough, winPct=0 at preseason,
   and parseConferenceFromExternalId (case-insensitivity, null/undefined,
   numeric ESPN IDs, unrecognized strings)

https://claude.ai/code/session_01WhzXHpv6taXdHzhgvnv83u

* Fix lint: replace != null with !== null && !== undefined

oxlint enforces eqeqeq; the five != null checks in mls.ts were flagged.

https://claude.ai/code/session_01WhzXHpv6taXdHzhgvnv83u

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-05-14 15:39:40 -07:00

159 lines
5.9 KiB
TypeScript

import { database } from "~/database/context";
import { eq } from "drizzle-orm";
import * as schema from "~/database/schema";
import { findParticipantsBySportsSeasonId, updateParticipant } from "~/models/season-participant";
import { upsertRegularSeasonStandings } from "~/models/regular-season-standings";
import { upsertPendingStandingsMappings } from "~/models/pending-standings-mappings";
import { findMatchingTeamName } from "~/lib/normalize-team-name";
import { NhlStandingsAdapter } from "./nhl";
import { NbaStandingsAdapter } from "./nba";
import { AflStandingsAdapter } from "./afl";
import { MlbStandingsAdapter } from "./mlb";
import { WnbaStandingsAdapter } from "./wnba";
import { EplStandingsAdapter } from "./epl";
import { MlsStandingsAdapter } from "./mls";
import type { StandingsSyncAdapter, SyncResult, UnmatchedTeam } from "./types";
/**
* Map a simulator type to its standings sync adapter.
* Returns null for sports that don't use regularSeasonStandings
* (e.g. season_standings sports like F1 will use a different path when implemented).
*/
function getAdapter(simulatorType: string): StandingsSyncAdapter {
switch (simulatorType) {
case "nba_bracket":
return new NbaStandingsAdapter();
case "nhl_bracket":
return new NhlStandingsAdapter();
case "afl_bracket":
return new AflStandingsAdapter();
case "epl_standings":
return new EplStandingsAdapter();
case "mls_bracket":
return new MlsStandingsAdapter();
case "mlb_bracket":
return new MlbStandingsAdapter();
case "wnba_bracket":
return new WnbaStandingsAdapter();
case "f1_standings":
throw new Error(
"F1 standings sync is not yet implemented. Use the manual standings page."
);
case "indycar_standings":
throw new Error(
"IndyCar standings sync is not yet implemented. Use the manual standings page."
);
default:
throw new Error(
`No standings sync adapter available for simulator type "${simulatorType}". ` +
"NBA, NHL, AFL, MLB, WNBA, EPL, and MLS are currently supported."
);
}
}
/**
* Sync current standings from the appropriate external API for a sports season.
* Matches API team names to participants by name and bulk-upserts the results.
*
* Returns the count of synced teams and any API team names that couldn't be matched.
*/
export async function syncStandings(sportsSeasonId: string): Promise<SyncResult> {
const db = database();
// Load sports season with sport relation
const sportsSeason = await db.query.sportsSeasons.findFirst({
where: eq(schema.sportsSeasons.id, sportsSeasonId),
with: { sport: true },
});
if (!sportsSeason) {
throw new Error(`Sports season ${sportsSeasonId} not found`);
}
const simulatorType = sportsSeason.sport?.simulatorType;
if (!simulatorType) {
const sportName = sportsSeason.sport?.name ?? "(no sport linked)";
throw new Error(`Sport "${sportName}" has no simulator type configured`);
}
const adapter = getAdapter(simulatorType);
const fetchedRecords = await adapter.fetchStandings();
// Load all participants for this season
const participants = await findParticipantsBySportsSeasonId(sportsSeasonId);
const participantNames = participants.map((p) => p.name);
const participantByName = new Map(participants.map((p) => [p.name, p]));
// Build a map of externalId → participant for ID-first matching
const participantByExternalId = new Map(
participants.filter((p) => p.externalId).map((p) => [p.externalId ?? "", p])
);
const toUpsert: Parameters<typeof upsertRegularSeasonStandings>[0] = [];
const unmatchedRecords: typeof fetchedRecords = [];
for (const record of fetchedRecords) {
// Strategy A: try externalId-first (bypasses name matching entirely after first sync)
let participant = participantByExternalId.get(record.externalTeamId) ?? null;
if (!participant) {
// Fall back to name matching
const matchedName = findMatchingTeamName(record.teamName, participantNames);
if (matchedName) {
participant = participantByName.get(matchedName) ?? null;
// Write-back: persist externalId so future syncs skip name matching for this team
if (participant && !participant.externalId) {
await updateParticipant(participant.id, { externalId: record.externalTeamId });
}
}
}
if (!participant) {
unmatchedRecords.push(record);
continue;
}
toUpsert.push({
participantId: participant.id,
sportsSeasonId,
wins: record.wins,
losses: record.losses,
otLosses: record.otLosses ?? null,
ties: record.ties ?? null,
tablePoints: record.tablePoints ?? null,
goalsFor: record.goalsFor ?? null,
goalsAgainst: record.goalsAgainst ?? null,
goalDifference: record.goalDifference ?? null,
winPct: record.winPct,
gamesPlayed: record.gamesPlayed,
gamesBack: record.gamesBack ?? null,
conference: record.conference ?? null,
division: record.division ?? null,
conferenceRank: record.conferenceRank ?? null,
divisionRank: record.divisionRank ?? null,
leagueRank: record.leagueRank,
streak: record.streak ?? null,
lastTen: record.lastTen ?? null,
homeRecord: record.homeRecord ?? null,
awayRecord: record.awayRecord ?? null,
externalTeamId: record.externalTeamId,
srs: record.srs ?? null,
syncedAt: new Date(),
});
}
if (toUpsert.length > 0) {
await upsertRegularSeasonStandings(toUpsert);
}
// Persist unmatched records so admin can resolve them without losing data on page reload
if (unmatchedRecords.length > 0) {
await upsertPendingStandingsMappings(sportsSeasonId, unmatchedRecords);
}
const unmatched: UnmatchedTeam[] = unmatchedRecords.map((r) => ({
teamName: r.teamName,
externalTeamId: r.externalTeamId,
}));
return { synced: toUpsert.length, unmatched };
}