brackt/app/models/sports-season.ts
Chris Parsons 4bffa40606
Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196)
* Fix no-shadow and consistent-function-scoping lint violations

Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.

no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).

consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix no-non-null-assertion lint violations and promote to error

Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.

Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers

Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.

- prefer-add-event-listener: converted onchange/onclick/onload
  assignments to addEventListener in useDraftNotifications.ts and
  admin.data-sync.tsx; stored changeHandler ref for proper cleanup
  with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
  side-effect imports (*.css, @testing-library/jest-dom,
  @testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
  cypress/support/e2e.ts (file already has an import)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix TypeScript errors from no-non-null-assertion fixes

Two fixes introduced by the non-null assertion cleanup produced type
errors:

- scoring-event.ts: `?? ""` was wrong type for a participant object map;
  restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
  truthy guarantee, causing TS18047 on the write-back block; added
  `participant &&` guard before accessing its properties

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add npm run typecheck as Stop hook in Claude settings

Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-21 10:59:51 -07:00

154 lines
4.5 KiB
TypeScript

import { eq } from "drizzle-orm";
import { database } from "~/database/context";
import * as schema from "~/database/schema";
export type SportsSeason = typeof schema.sportsSeasons.$inferSelect;
export type NewSportsSeason = typeof schema.sportsSeasons.$inferInsert;
export type SportsSeasonWithSport = SportsSeason & {
sport: typeof schema.sports.$inferSelect;
};
export type SportsSeasonStatus = "upcoming" | "active" | "completed";
export type ScoringType = "playoffs" | "regular_season" | "majors";
export async function createSportsSeason(data: NewSportsSeason): Promise<SportsSeason> {
const db = database();
const [sportsSeason] = await db
.insert(schema.sportsSeasons)
.values(data)
.returning();
return sportsSeason;
}
export async function findSportsSeasonById(id: string): Promise<SportsSeasonWithSport | undefined> {
const db = database();
return await db.query.sportsSeasons.findFirst({
where: eq(schema.sportsSeasons.id, id),
with: {
sport: true,
},
}) as SportsSeasonWithSport | undefined;
}
export async function findSportsSeasonsBySportId(sportId: string): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
where: eq(schema.sportsSeasons.sportId, sportId),
orderBy: (sportsSeasons, { desc }) => [desc(sportsSeasons.year)],
with: {
sport: true,
},
});
}
export async function findActiveSportsSeasonsBySportId(sportId: string): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
where: (ss, { and }) =>
and(
eq(ss.sportId, sportId),
eq(ss.status, "active")
),
orderBy: (sportsSeasons, { desc }) => [desc(sportsSeasons.year)],
with: {
sport: true,
},
});
}
export async function findSportsSeasonsByYear(year: number): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
where: eq(schema.sportsSeasons.year, year),
orderBy: (sportsSeasons, { asc }) => [asc(sportsSeasons.name)],
with: {
sport: true,
},
});
}
export async function findSportsSeasonsByStatus(status: SportsSeasonStatus): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
where: eq(schema.sportsSeasons.status, status),
orderBy: (sportsSeasons, { desc }) => [desc(sportsSeasons.year)],
with: {
sport: true,
},
});
}
export async function findAllSportsSeasons(): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
orderBy: (sportsSeasons, { desc, asc }) => [desc(sportsSeasons.year), asc(sportsSeasons.name)],
with: {
sport: true,
participants: {
columns: {
id: true,
},
},
},
});
}
export async function findDraftableSportsSeasons(): Promise<SportsSeason[]> {
const db = database();
return await db.query.sportsSeasons.findMany({
where: eq(schema.sportsSeasons.isDraftable, true),
orderBy: (sportsSeasons, { desc, asc }) => [desc(sportsSeasons.year), asc(sportsSeasons.name)],
with: {
sport: true,
},
});
}
export async function updateSportsSeason(
id: string,
data: Partial<NewSportsSeason>
): Promise<SportsSeason> {
const db = database();
const [sportsSeason] = await db
.update(schema.sportsSeasons)
.set({ ...data, updatedAt: new Date() })
.where(eq(schema.sportsSeasons.id, id))
.returning();
return sportsSeason;
}
export async function updateSportsSeasonStatus(
id: string,
status: SportsSeasonStatus
): Promise<SportsSeason> {
return await updateSportsSeason(id, { status });
}
export async function deleteSportsSeason(id: string): Promise<void> {
const db = database();
await db.delete(schema.sportsSeasons).where(eq(schema.sportsSeasons.id, id));
}
export async function copyParticipantsFromPreviousSeason(
currentSeasonId: string,
previousSeasonId: string
): Promise<void> {
const db = database();
// Get all participants from previous season
const previousParticipants = await db.query.participants.findMany({
where: eq(schema.participants.sportsSeasonId, previousSeasonId),
});
// Insert them into the current season
if (previousParticipants.length > 0) {
await db.insert(schema.participants).values(
previousParticipants.map((p) => ({
sportsSeasonId: currentSeasonId,
name: p.name,
shortName: p.shortName,
externalId: p.externalId,
expectedValue: p.expectedValue,
}))
);
}
}