brackt/app
Claude 65593c82cf
Fix recalculate-floors incorrectly eliminating play-in losers who still advance
The playoff_matches.isScoring column defaults to true in the database. Brackets
created before this column was added (or before the migration set correct values)
have isScoring=true on play-in rounds that should be false. When recalculate-floors
replayed those matches, it took the "scoring round" path; since "Play-In Round 1"
isn't in ROUND_CONFIG, config===null, and the loser was assigned finalPosition=0
regardless of loserAdvances — permanently eliminating teams like the Suns who had
a second play-in game remaining.

Fix: build a round→isScoring lookup from the bracket template before replaying
matches and use it as the source of truth, falling back to the DB field only when
the template doesn't define the round. This ensures non-scoring play-in rounds
are always processed with isScoring=false so the loserAdvances guard fires
correctly.

Also revert unrelated socket changes from the previous (wrong) commit.

https://claude.ai/code/session_01D3NbnVQdaH82Fk7Jm8y3sB
2026-04-15 17:44:09 +00:00
..
components Fix qualifying points league display. 2026-04-12 17:06:20 -07:00
contexts feat: implement middleware and context provider for Express integration 2025-10-11 20:56:00 -07:00
hooks Fix oxlint errors. 2026-03-22 20:41:44 -07:00
lib fix: league settings sports swap and audit log detail improvements (#294) 2026-04-14 21:41:05 -07:00
models Fix NBA Play-In Round 1 loser advancement logic (#296) 2026-04-15 09:40:53 -07:00
routes Fix recalculate-floors incorrectly eliminating play-in losers who still advance 2026-04-15 17:44:09 +00:00
services fix: NBA play-in bracket advancement bugs (#292) 2026-04-12 22:25:32 -07:00
test Add oxlint linting setup with zero errors (#194) 2026-03-21 09:44:05 -07:00
types Redesign standings page with sortable table, 7-day change, and chart repositioned (#205) 2026-03-22 11:05:13 -07:00
utils Replace isDraftable boolean with draftOn/draftOff date range (#263) 2026-04-05 22:09:52 -04:00
welcome Redesign to dark-mode-only with navy palette and accent colors (#13) 2026-02-20 19:26:11 -08:00
app.css Add NProgress navigation progress bar (#139) 2026-03-11 22:02:48 -07:00
entry.client.tsx Filter unnecessary sentry css and js errors. 2026-03-15 10:24:57 -07:00
entry.server.tsx Replace console.* with structured logger, fix no-inferrable-types (closes #98) (#199) 2026-03-21 13:41:39 -07:00
root.tsx Add NProgress navigation progress bar (#139) 2026-03-11 22:02:48 -07:00
routes.ts Add audit logging for commissioner actions (#293) 2026-04-13 15:45:39 -07:00