brackt/app/hooks
chrisp 079ecec129
All checks were successful
🚀 Deploy / 🧪 Test (push) Successful in 2m35s
🚀 Deploy / ʦ🔍 Typecheck & Lint (push) Successful in 1m23s
🚀 Deploy / 🐳 Build (push) Successful in 1m11s
🚀 Deploy / 🚀 Deploy (push) Successful in 10s
Fix draft timer display drifting due to server-client clock skew (#74)
## Summary

- The countdown display used `data.expiresAt` (server-side Unix timestamp) subtracted from `client Date.now()`. When the server clock runs ~2-3s ahead of the client (observed in production), the display was inflated by that delta.
- Fixes three linked symptoms: timer starting at 2:02 instead of 2:00, chess-clock increment crediting 1:54 instead of 1:55, and the commissioner's adjust-time-bank dialog disagreeing with the visible countdown.
- Fix: replace all server `expiresAt` timestamps with a client-local expiry from the server-provided `timeRemaining` integer (`Date.now() + timeRemaining * 1000`). The skew then cancels algebraically when the server computes credit.

## Sites changed

- `handleTimerPickStarted` — fires after every pick (the main fix)
- `handleDraftStateSync` — reconnect path
- `useState` initializer in the draft room — initial page load seed from loader data (uses `loaderTimerNow` server timestamp to compute remaining server-side, then re-anchors to client clock)

## Test plan

- [ ] Start a chess-clock draft (2:00 bank, 15s increment) — timer should show exactly **2:00** when a team goes on the clock
- [ ] Pick at 1:40 — new bank should show **1:55** (100 + 15s)
- [ ] Commissioner adjust-time-bank dialog — displayed remaining should match the countdown
- [ ] Force autopick at any displayed time T — new bank should be T + increment
- [ ] Reconnect mid-pick — timer should resume at the correct remaining time

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Chris Parsons <chrisparsons1127@gmail.com>
Reviewed-on: #74
2026-06-06 07:30:45 +00:00
..
__tests__ Fix unhandled rejection from session ping when network is unavailable (#56) 2026-05-27 16:14:14 +00:00
useDraftAuthRecovery.ts Fix unhandled rejection from session ping when network is unavailable (#56) 2026-05-27 16:14:14 +00:00
useDraftNotifications.ts Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196) 2026-03-21 10:59:51 -07:00
useDraftRoomState.ts Show "Syncing Draft State..." overlay during draft reconnection (#361) 2026-04-30 20:33:00 -07:00
useDraftSocket.ts Change Socket.IO connection error logging from error to log level (#448) 2026-05-19 15:47:41 -07:00
useDraftSocketEvents.ts Fix draft timer display drifting due to server-client clock skew (#74) 2026-06-06 07:30:45 +00:00
useFocusTrap.ts fix: resolve all 48 WCAG 2.2 AA accessibility issues (#439) 2026-05-17 20:11:38 -07:00
useLocalTimezone.ts Simplify sports season display and add local timezone hints (#434) 2026-05-15 16:04:07 -07:00
useMediaQuery.ts fix: eliminate queue tab flash on mobile by using useSyncExternalStore (#46) 2026-02-28 09:54:14 -08:00
useRoundTransition.ts Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
useSortableData.ts Fix oxlint errors. 2026-03-22 20:41:44 -07:00