* fix: resolve all 48 WCAG 2.2 AA accessibility issues Critical fixes: - Add aria-label to all unlabeled inputs/selects in draft dialogs (ParticipantSelectionDialog, TimeBankAdjustmentDialog, AvailableParticipantsSection) - Add role="dialog" + aria-modal + focus trap to ConnectionOverlay and AuthRecoveryOverlay - Add aria-live region and connection status announcement to ConnectionOverlay Serious fixes: - Add skip-to-content link in root.tsx with id="main-content" on <main> - Add aria-label to UserMenu trigger button - Add aria-describedby + role="alert" to all auth form error messages (login, register, onboarding, forgot-password, reset-password) - Replace emoji column headers in StandingsTable with aria-label + aria-hidden spans - Add aria-live="assertive" to "It's your turn" desktop and mobile on-clock indicators - Add aria-live="polite" to draft room countdown timer - Add pause button to SportTicker (WCAG 2.2.2); add aria-hidden to ticker content - Fix Footer text contrast (changed from 28% to text-muted-foreground) - Fix OvernightPauseSettings: add htmlFor/id pairs and role="radiogroup"+aria-checked to mode buttons - Fix DraftSetupSection: replace broken htmlFor with aria-label on date picker button - Add aria-label to PeopleSection owner and commissioner selects - Add labels to ScoringPresetPicker score inputs; add role="radiogroup"+aria-checked to preset buttons - Add role="radiogroup"+aria-checked to AutodraftSettings option buttons - Add accessible names, aria-current="step", and <ol> list semantics to WizardStepper Moderate fixes: - Add aria-controls to RecentPicksFeed toggle button; wrap picks list in aria-live region - Add role="tab"+aria-selected+aria-controls to mobile board sub-tabs + role="tabpanel" - Add role="radiogroup"+aria-checked to TimerModeSelector - Add aria-current="page" + aria-label to SettingsDesktopNav - Add aria-label="Admin navigation" to admin sidebar nav - Add scope="col" + <caption> to StandingsTable and ScoringTables - Add ARIA table roles (role="table/rowgroup/row/columnheader/rowheader/cell") to DraftSummaryView CSS grid Minor fixes: - Add aria-hidden="true" to decorative trend icons in StandingsTable - Add aria-hidden="true" to desktop column header labels row in AvailableParticipantsSection - Replace title with aria-label on all icon-only buttons (watchlist, queue) in AvailableParticipantsSection - Add aria-label to NotificationSettings switchOnly Switch - Add prefers-reduced-motion check to SlotMachineHeadline JS animation - Bump --muted-foreground from 55% to 62% opacity for improved contrast margin https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix code review findings from WCAG compliance pass - Add Arrow key navigation + roving tabindex to all role=radiogroup components (AutodraftSettings x2, TimerModeSelector, OvernightPauseSettings, ScoringPresetPicker) per ARIA radio pattern - Extract shared focus-trap logic into useFocusTrap hook; update ConnectionOverlay and AuthRecoveryOverlay to use it - Add tabIndex={-1} to ConnectionOverlay Card so focus can land in spinner-only state (no interactive children) - Replace aria-live on loading dots container with sr-only span so status changes are announced by text content, not aria-label - Remove contradictory aria-hidden+role=columnheader from AvailableParticipantsSection visual-only header row - Remove invalid scope="col" from div[role=columnheader] in DraftSummaryView (scope is only valid on <th>) - Remove redundant aria-label from ParticipantSelectionDialog sport select (htmlFor label is sufficient) - Change WizardStepper connector <li> to role=presentation - Revert muted-foreground from 62% to 55% (original already passes contrast; footer was fixed separately via text-muted-foreground) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 * Fix lint error and update tests for WCAG role changes - Replace el! non-null assertion with optional chaining in useFocusTrap - Update AutodraftSettings tests to query role="radio" instead of role="button" (buttons have an explicit radio role since the WCAG pass) - Update AvailableParticipantsSection watchlist tests to use getByRole/getAllByRole instead of getByTitle/getAllByTitle (watchlist buttons now use aria-label instead of title) https://claude.ai/code/session_01JXajpFxhqLf8aPCncP81k3 --------- Co-authored-by: Claude <noreply@anthropic.com>
73 lines
2.8 KiB
TypeScript
73 lines
2.8 KiB
TypeScript
import { memo, useEffect, useRef, useState } from "react";
|
|
import { ChevronDown } from "lucide-react";
|
|
|
|
type Pick = {
|
|
id: string;
|
|
pickNumber: number;
|
|
participant: { name: string };
|
|
sport: { name: string };
|
|
team: { name: string };
|
|
};
|
|
|
|
export const RecentPicksFeed = memo(function RecentPicksFeed({ picks }: { picks: Pick[] }) {
|
|
const recentPicks = picks.slice(-3).toReversed();
|
|
const prevNewestIdRef = useRef<string | undefined>(picks.at(-1)?.id);
|
|
const [animatingId, setAnimatingId] = useState<string | undefined>(undefined);
|
|
const [isExpanded, setIsExpanded] = useState(true);
|
|
|
|
useEffect(() => {
|
|
const newest = recentPicks[0];
|
|
if (newest && newest.id !== prevNewestIdRef.current) {
|
|
prevNewestIdRef.current = newest.id;
|
|
setAnimatingId(newest.id);
|
|
const t = setTimeout(() => setAnimatingId(undefined), 450);
|
|
return () => clearTimeout(t);
|
|
}
|
|
}, [recentPicks]);
|
|
|
|
return (
|
|
<div className="flex flex-col px-3 pt-2 pb-1 overflow-hidden border-b">
|
|
<button
|
|
className="flex items-center justify-between w-full mb-0.5 py-0.5"
|
|
onClick={() => setIsExpanded((prev) => !prev)}
|
|
aria-expanded={isExpanded}
|
|
aria-controls="recent-picks-list"
|
|
aria-label="Toggle latest picks"
|
|
>
|
|
<p className="text-[10px] font-semibold uppercase tracking-widest text-muted-foreground/60">Latest Picks</p>
|
|
<ChevronDown
|
|
className={`h-3 w-3 text-muted-foreground/60 transition-transform duration-200 ${isExpanded ? "rotate-180" : ""}`}
|
|
/>
|
|
</button>
|
|
{isExpanded && (
|
|
<div id="recent-picks-list" aria-live="polite" aria-label="Latest picks" className="flex flex-col gap-1 mt-0.5">
|
|
{picks.length === 0 ? (
|
|
<p className="text-xs text-muted-foreground py-1">No picks yet</p>
|
|
) : (
|
|
recentPicks.map((pick, index) => (
|
|
<div
|
|
key={pick.id}
|
|
className={`w-full ${index === 0 && animatingId === pick.id ? "rpf-animate" : ""} bg-muted rounded-lg px-3 py-1.5 flex items-center gap-2`}
|
|
>
|
|
<span className="text-xs font-bold text-muted-foreground shrink-0 tabular-nums">
|
|
#{pick.pickNumber}
|
|
</span>
|
|
<div className="flex flex-col flex-1 min-w-0">
|
|
<span className="text-sm font-medium truncate">
|
|
{pick.participant.name}
|
|
</span>
|
|
<span className="text-xs text-muted-foreground/70 truncate">
|
|
{pick.sport.name}
|
|
</span>
|
|
</div>
|
|
<span className="text-xs text-muted-foreground truncate max-w-[90px] text-right shrink-0">
|
|
{pick.team.name}
|
|
</span>
|
|
</div>
|
|
))
|
|
)}
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
});
|