brackt/server/__tests__/timer-autodraft.test.ts
Chris Parsons 2848231235
Canonical tournament layer: schema + backfill (1/2) (#365)
* refactor(schema): rename per-window tables to season_* prefix

Renames participants, participant_expected_values, participant_qualifying_totals,
participant_results, participant_surface_elos to season_* prefixed names.
Renames event_results.participant_id to season_participant_id.
Phase 1a of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor: rename participant.ts model file to season-participant.ts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(models): update model layer to use renamed schema exports

Updated all model files to use the renamed schema exports from Task 1:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantQualifyingTotals → seasonParticipantQualifyingTotals
- participantResults → seasonParticipantResults
- participantSurfaceElos → seasonParticipantSurfaceElos
- eventResults.participantId → eventResults.seasonParticipantId
- db.query relation accessors updated
- Relation field .participant → .seasonParticipant where applicable
- Import paths updated: ./participant → ./season-participant

Files updated (14 model files + 3 test files):
- draft-pick.ts
- draft-utils.ts
- event-result.ts
- group-stage-match.ts
- participant-result.ts
- qualifying-points.ts
- scoring-calculator.ts
- scoring-event.ts
- sports-season.ts
- surface-elo.ts
- team-score-events.ts
- cs2-major-stage.ts
- golf-skills.ts
- participant-expected-value.ts
- __tests__/sports-season.clone.test.ts
- __tests__/auto-pick.test.ts
- __tests__/executeAutoPick.timer.test.ts

Typecheck errors decreased: 779 → 499 (280 fewer)
All model file errors related to renamed schemas resolved.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(routes): update route layer to use renamed schema exports

- Update model import from ~/models/participant to ~/models/season-participant
- Rename schema.participants to schema.seasonParticipants
- Rename schema.participantResults to schema.seasonParticipantResults
- Rename db.query.participants to db.query.seasonParticipants
- Update 9 route files and 1 test file

Affected files:
- admin.sports-seasons.$id.events.$eventId.bracket.server.ts
- admin.sports-seasons.$id.participants.tsx
- api/draft.force-manual-pick.ts
- api/draft.make-pick.ts
- api/draft.replace-pick.ts
- api/seasons.$seasonId.draft.ts
- leagues/$leagueId.draft-board.$seasonId.tsx
- leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
- admin/__tests__/sports-seasons-participants.test.ts

Error count reduced from 499 to 453 (46 errors fixed).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(routes): update route files for schema rename

Update route imports from ~/models/participant to ~/models/season-participant
and fix references to .participant/.participantId on event results to use
.seasonParticipant/.seasonParticipantId after schema rename.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(services): update simulators and services for renamed schema

Update all simulators, services, and server files to use renamed schema tables:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantResults → seasonParticipantResults
- eventResults.participantId → eventResults.seasonParticipantId

Files updated:
- 20 sport simulators (NBA, NHL, NFL, MLB, etc.)
- probability-updater.ts
- standings-sync/index.ts
- sports-data-sync.server.ts
- server/socket.ts

Typecheck errors reduced from 365 to 0.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* migration: rename per-window tables to season_* prefix

* fix(tests): update mock query keys after participants table rename

Change mock db.query.participants to db.query.seasonParticipants in test
files to match the schema rename from commit 66145a9. This fixes
"Cannot read properties of undefined (reading 'findFirst'/'findMany')"
errors that occurred when production code queries db.query.seasonParticipants
but test mocks only defined the old participants key.

Files updated:
- app/services/simulations/__tests__/world-cup-simulator.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.timer-mode.test.ts
- app/routes/api/__tests__/draft.make-pick.timer-mode.test.ts
- server/__tests__/timer-autodraft.test.ts
- app/models/__tests__/team-score-events.test.ts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(tests): update remaining mock paths and keys after schema rename

* fix(tests): final two mock stragglers after schema rename

- draft-pick.test.ts: assertion on db.query.participantQualifyingTotals
- process-match-result.test.ts: mock key participants → seasonParticipants

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* chore: add post-phase1a baseline capture (temp, for diff verification)

* chore: capture pre-migration baselines

* chore: remove post-phase1a capture helper after verification

* schema: add canonical tournament & participant tables

Adds tournaments, participants (canonical), tournament_results, and
participant_surface_elos (canonical). Adds nullable tournament_id to
scoring_events and nullable participant_id to season_participants.
Phase 1b of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(models): add canonical tournament, participant, result, surface-elo models

Adds CRUD modules for the canonical tables created in commit 775b905.
Each module mirrors existing app/models conventions (database() from
~/database/context, schema from ~/database/schema, mock-based tests).

Key implementation notes:
- participant.ts exports use "Canonical" prefix (CanonicalParticipant,
  createCanonicalParticipant, etc.) to avoid collision with existing
  season-participant.ts exports
- All four models include comprehensive unit tests following the
  audit-log.test.ts pattern
- Tests use mocked db responses (no real database access)
- Upsert functions use onConflictDoUpdate for appropriate unique constraints

Part of Phase 1b of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* migration: create canonical tables, add nullable FKs

* scripts: add extractTournamentIdentity helper for backfill

Pure function that derives canonical (name, year) identity from a
scoring_events row, stripping trailing 4-digit years from the name or
falling back to eventDate. Used by the Phase 2 backfill to group
per-window events into canonical tournaments.

* scripts: add backfill orchestrator for canonical layer

Populates canonical tournaments, participants, tournament_results, and
participant_surface_elos from per-window data for qualifying-points
sports. Skips already-linked rows, is idempotent, and supports dry-run
mode.

Critical invariants enforced by the implementation:
- qualifying_points_awarded is never copied to tournament_results
- season_participant_qualifying_totals is never touched
- conflicting surface-Elo values between windows raise a loud error
  (recorded in report.errors) rather than overwriting

* scripts: add backfill CLI with dry-run default

Wires backfill-canonical-layer.ts to a CLI entry point exposed as
`npm run backfill:canonical`. Defaults to --dry-run; requires --apply
to actually write. Supports --sport=<uuid> to limit to a single sport.
Exits 2 if the backfill reports errors (e.g., surface-Elo conflicts).

* fix(backfill-cli): wrap runBackfill in DatabaseContext.run

The orchestrator uses database() from ~/database/context, which requires
AsyncLocalStorage to be populated. Wrap the CLI invocation with
DatabaseContext.run(db, ...) using server/db's cached connection pool.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(backfill-cli): exit 0 on success so pg pool doesn't block

The cached postgres connection pool keeps the Node event loop open after
main() returns. Explicit process.exit(0) on success mirrors the pattern
in scripts/capture-baseline.ts.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Chris Parsons <chrisp@extrahop.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-01 20:13:18 -07:00

342 lines
14 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest';
// Mock dependencies before imports
vi.mock('drizzle-orm/postgres-js', () => ({
drizzle: vi.fn(() => mockDb),
}));
vi.mock('postgres', () => ({
default: vi.fn(() => ({})),
}));
vi.mock('../socket', () => ({
getSocketIO: vi.fn(() => mockSocketIO),
}));
let mockDb: any;
let mockSocketIO: any;
// Setup mocks
beforeEach(() => {
mockSocketIO = {
to: vi.fn().mockReturnThis(),
emit: vi.fn(),
};
mockDb = {
query: {
seasons: { findMany: vi.fn(), findFirst: vi.fn() },
draftSlots: { findMany: vi.fn() },
draftTimers: { findFirst: vi.fn() },
autodraftSettings: { findFirst: vi.fn() },
draftPicks: { findMany: vi.fn(), findFirst: vi.fn() },
draftQueue: { findMany: vi.fn() },
seasonParticipants: { findMany: vi.fn() },
seasonTemplateSports: { findMany: vi.fn() },
},
update: vi.fn().mockReturnThis(),
set: vi.fn().mockReturnThis(),
where: vi.fn().mockReturnThis(),
returning: vi.fn(),
insert: vi.fn().mockReturnThis(),
values: vi.fn().mockReturnThis(),
delete: vi.fn().mockReturnThis(),
select: vi.fn().mockReturnThis(),
from: vi.fn().mockReturnThis(),
innerJoin: vi.fn().mockReturnThis(),
orderBy: vi.fn().mockReturnThis(),
limit: vi.fn().mockReturnThis(),
};
});
describe('Timer Autodraft Integration', () => {
describe('Autodraft Settings Check', () => {
it('should check autodraft settings when timer expires', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
mockDb.query.seasons.findMany.mockResolvedValue([{
id: seasonId, status: 'draft', draftPaused: false,
currentPickNumber: 1, draftInitialTime: 120, draftIncrementTime: 30, draftRounds: 10,
}]);
mockDb.query.draftSlots.findMany.mockResolvedValue([
{ id: 'slot-1', teamId, draftOrder: 1 },
{ id: 'slot-2', teamId: 'team-2', draftOrder: 2 },
]);
mockDb.query.draftTimers.findFirst.mockResolvedValue({ id: 'timer-1', seasonId, teamId, timeRemaining: 0 });
mockDb.query.autodraftSettings.findFirst.mockResolvedValue({
id: 'settings-1', seasonId, teamId, isEnabled: true, mode: 'next_pick', queueOnly: false,
});
expect(mockDb.query.autodraftSettings.findFirst).toBeDefined();
});
it('should use regular auto-pick when autodraft is disabled', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
mockDb.query.autodraftSettings.findFirst.mockResolvedValue({
id: 'settings-1', seasonId, teamId, isEnabled: false, mode: 'next_pick', queueOnly: false,
});
const settings = await mockDb.query.autodraftSettings.findFirst();
expect(settings.isEnabled).toBe(false);
});
it('should handle missing autodraft settings', async () => {
mockDb.query.autodraftSettings.findFirst.mockResolvedValue(null);
const settings = await mockDb.query.autodraftSettings.findFirst();
expect(settings).toBeNull();
});
});
describe('Autodraft Mode Handling', () => {
it('should disable autodraft after pick when mode is next_pick', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
const autodraftSettings = { id: 'settings-1', seasonId, teamId, isEnabled: true, mode: 'next_pick', queueOnly: false };
mockDb.returning.mockResolvedValue([{ ...autodraftSettings, isEnabled: false, updatedAt: new Date() }]);
if (autodraftSettings.isEnabled && autodraftSettings.mode === 'next_pick') {
await mockDb.update();
await mockDb.set({ isEnabled: false, updatedAt: new Date() });
await mockDb.where();
const result = await mockDb.returning();
expect(result[0].isEnabled).toBe(false);
}
});
it('should keep autodraft enabled when mode is while_on (All Picks)', async () => {
const autodraftSettings = { isEnabled: true, mode: 'while_on', queueOnly: false };
if (autodraftSettings.mode === 'while_on') {
expect(autodraftSettings.isEnabled).toBe(true);
}
});
});
describe('Autodraft Pick Logic', () => {
it('should pick from queue first when autodraft is enabled', async () => {
mockDb.query.draftQueue.findMany.mockResolvedValue([
{ id: 'queue-1', participantId: 'participant-1', queuePosition: 1 },
{ id: 'queue-2', participantId: 'participant-2', queuePosition: 2 },
]);
mockDb.query.draftPicks.findMany.mockResolvedValue([]);
const queueItems = await mockDb.query.draftQueue.findMany();
const draftedPicks = await mockDb.query.draftPicks.findMany();
const draftedParticipantIds = draftedPicks.map((p: any) => p.participantId);
const availableQueueItem = queueItems.find((item: any) => !draftedParticipantIds.includes(item.participantId));
expect(availableQueueItem).toBeDefined();
expect(availableQueueItem.participantId).toBe('participant-1');
});
it('should skip drafted participants in queue and try next', async () => {
mockDb.query.draftQueue.findMany.mockResolvedValue([
{ id: 'queue-1', participantId: 'participant-1', queuePosition: 1 },
{ id: 'queue-2', participantId: 'participant-2', queuePosition: 2 },
]);
mockDb.query.draftPicks.findMany.mockResolvedValue([{ id: 'pick-1', participantId: 'participant-1' }]);
const queueItems = await mockDb.query.draftQueue.findMany();
const draftedPicks = await mockDb.query.draftPicks.findMany();
const draftedParticipantIds = draftedPicks.map((p: any) => p.participantId);
const availableQueueItem = queueItems.find((item: any) => !draftedParticipantIds.includes(item.participantId));
expect(availableQueueItem.participantId).toBe('participant-2');
});
it('should fall back to highest EV when queue is empty and queueOnly is OFF', async () => {
mockDb.query.draftQueue.findMany.mockResolvedValue([]);
mockDb.query.seasonParticipants.findMany.mockResolvedValue([
{ id: 'participant-high-ev', name: 'High EV Participant', expectedValue: 1000 },
]);
const queueItems = await mockDb.query.draftQueue.findMany();
expect(queueItems.length).toBe(0);
const queueOnly = false;
const availableParticipants = await mockDb.query.seasonParticipants.findMany();
const selectedParticipant = queueOnly ? null : availableParticipants[0];
expect(selectedParticipant).not.toBeNull();
expect(selectedParticipant?.expectedValue).toBe(1000);
});
});
describe('Queue-Only Constraint (AC2 & AC3)', () => {
it('should NOT fall back to highest EV when queueOnly is ON and queue is empty', async () => {
mockDb.query.draftQueue.findMany.mockResolvedValue([]);
const queueItems = await mockDb.query.draftQueue.findMany();
expect(queueItems.length).toBe(0);
const queueOnly = true;
const selectedParticipant = queueOnly ? null : { id: 'participant-high-ev' };
expect(selectedParticipant).toBeNull();
});
it('should disable autodraft when queueOnly is ON and queue becomes empty (AC3)', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
const autodraftSettings = { id: 'settings-1', seasonId, teamId, isEnabled: true, mode: 'next_pick', queueOnly: true };
mockDb.returning.mockResolvedValue([{ ...autodraftSettings, isEnabled: false, updatedAt: new Date() }]);
const participantId = null; // empty queue + queueOnly
if (!participantId && autodraftSettings.queueOnly) {
await mockDb.update();
await mockDb.set({ isEnabled: false, updatedAt: new Date() });
await mockDb.where();
const result = await mockDb.returning();
expect(result[0].isEnabled).toBe(false);
mockSocketIO.to(`draft-${seasonId}`).emit('autodraft-updated', {
teamId, isEnabled: false, mode: autodraftSettings.mode, queueOnly: autodraftSettings.queueOnly,
});
expect(mockSocketIO.emit).toHaveBeenCalledWith('autodraft-updated', {
teamId, isEnabled: false, mode: 'next_pick', queueOnly: true,
});
}
});
it('should skip drafted queue items and continue to next available item', async () => {
const queue = [
{ id: 'queue-1', participantId: 'participant-1', queuePosition: 1 },
{ id: 'queue-2', participantId: 'participant-2', queuePosition: 2 },
];
const drafted = new Set(['participant-1']);
const availableQueueItem = queue.find((item) => !drafted.has(item.participantId));
expect(availableQueueItem?.participantId).toBe('participant-2');
});
it('should auto-disable when all queue items are drafted and queueOnly is ON', async () => {
const queue = [
{ id: 'queue-1', participantId: 'participant-1', queuePosition: 1 },
{ id: 'queue-2', participantId: 'participant-2', queuePosition: 2 },
];
const drafted = new Set(['participant-1', 'participant-2']);
const queueOnly = true;
const availableQueueItem = queue.find((item) => !drafted.has(item.participantId));
expect(availableQueueItem).toBeUndefined();
const selectedParticipant = queueOnly ? null : { id: 'fallback-ev' };
expect(selectedParticipant).toBeNull();
});
});
describe('Three-State Autodraft (AC1)', () => {
it('should map Off state to isEnabled=false', () => {
const offState = { isEnabled: false, mode: 'next_pick', queueOnly: false };
expect(offState.isEnabled).toBe(false);
});
it('should map Next Pick state to isEnabled=true, mode=next_pick', () => {
const nextPickState = { isEnabled: true, mode: 'next_pick', queueOnly: false };
expect(nextPickState.isEnabled).toBe(true);
expect(nextPickState.mode).toBe('next_pick');
});
it('should map All Picks state to isEnabled=true, mode=while_on', () => {
const allPicksState = { isEnabled: true, mode: 'while_on', queueOnly: false };
expect(allPicksState.isEnabled).toBe(true);
expect(allPicksState.mode).toBe('while_on');
});
it('should transition Off → Next Pick correctly', () => {
const initial = { isEnabled: false, mode: 'next_pick' };
const updated = { isEnabled: true, mode: 'next_pick' };
expect(updated.isEnabled).not.toBe(initial.isEnabled);
expect(updated.mode).toBe('next_pick');
});
it('should transition Next Pick → All Picks correctly', () => {
const nextPick = { isEnabled: true, mode: 'next_pick' };
const allPicks = { ...nextPick, mode: 'while_on' };
expect(allPicks.mode).toBe('while_on');
expect(allPicks.isEnabled).toBe(true);
});
it('should auto-disable if queue is empty and queueOnly is ON (AC3)', () => {
const settings = { isEnabled: true, mode: 'next_pick', queueOnly: true };
const queue: any[] = [];
const shouldAutoDisable = settings.queueOnly && queue.length === 0;
const finalSettings = shouldAutoDisable ? { ...settings, isEnabled: false } : settings;
expect(finalSettings.isEnabled).toBe(false);
});
it('should NOT auto-disable if queue is empty and queueOnly is OFF', () => {
const settings = { isEnabled: true, mode: 'next_pick', queueOnly: false };
const queue: any[] = [];
const shouldAutoDisable = settings.queueOnly && queue.length === 0;
const finalSettings = shouldAutoDisable ? { ...settings, isEnabled: false } : settings;
expect(finalSettings.isEnabled).toBe(true);
});
});
describe('Socket Event Emission', () => {
it('should emit autodraft-updated with queueOnly when disabling next_pick mode', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
mockSocketIO.to(`draft-${seasonId}`).emit('autodraft-updated', {
teamId, isEnabled: false, mode: 'next_pick', queueOnly: false,
});
expect(mockSocketIO.emit).toHaveBeenCalledWith('autodraft-updated', {
teamId, isEnabled: false, mode: 'next_pick', queueOnly: false,
});
});
it('should emit pick-made event after autodraft pick', async () => {
const seasonId = 'season-123';
const pickData = { pick: { id: 'pick-1', participantId: 'participant-1', pickNumber: 1 }, nextPickNumber: 2, isDraftComplete: false };
mockSocketIO.to(`draft-${seasonId}`).emit('pick-made', pickData);
expect(mockSocketIO.emit).toHaveBeenCalledWith('pick-made', pickData);
});
it('should emit autodraft-updated with queueOnly preserved on auto-disable (AC3)', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
mockSocketIO.to(`draft-${seasonId}`).emit('autodraft-updated', {
teamId, isEnabled: false, mode: 'next_pick', queueOnly: true,
});
expect(mockSocketIO.emit).toHaveBeenCalledWith('autodraft-updated', {
teamId, isEnabled: false, mode: 'next_pick', queueOnly: true,
});
});
});
describe('Back-to-Back Picks', () => {
it('should only autodraft first pick when mode is next_pick', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
const autodraftSettings = { id: 'settings-1', seasonId, teamId, isEnabled: true, mode: 'next_pick', queueOnly: false };
if (autodraftSettings.isEnabled && autodraftSettings.mode === 'next_pick') {
const updatedSettings = { ...autodraftSettings, isEnabled: false };
expect(updatedSettings.isEnabled).toBe(false);
}
const settingsForSecondPick = { ...autodraftSettings, isEnabled: false };
expect(settingsForSecondPick.isEnabled).toBe(false);
});
it('should continue autodrafting consecutive picks when mode is while_on (All Picks)', async () => {
const autodraftSettings = { isEnabled: true, mode: 'while_on', queueOnly: false };
if (autodraftSettings.mode === 'while_on') expect(autodraftSettings.isEnabled).toBe(true);
expect(autodraftSettings.isEnabled).toBe(true);
});
});
describe('Time Increment', () => {
it('should add increment time after autodraft pick', () => {
expect(0 + 30).toBe(30);
});
it('should emit timer-update after adding increment', async () => {
const seasonId = 'season-123';
const teamId = 'team-456';
mockSocketIO.to(`draft-${seasonId}`).emit('timer-update', {
seasonId, teamId, timeRemaining: 30, currentPickNumber: 1,
});
expect(mockSocketIO.emit).toHaveBeenCalledWith('timer-update', {
seasonId, teamId, timeRemaining: 30, currentPickNumber: 1,
});
});
});
});