brackt/app/components/scoring
Claude ac33e9e223
Some checks failed
🚀 Deploy / 🧪 Test (pull_request) Successful in 2m50s
🚀 Deploy / ʦ🔍 Typecheck & Lint (pull_request) Failing after 51s
🚀 Deploy / 🐳 Build (pull_request) Has been skipped
🚀 Deploy / 🚀 Deploy (pull_request) Has been skipped
fix: address 10 code review issues in match sync system
- Fix 1 (CRITICAL): CS2 "Sync from API" button was always 401 because it
  POSTed to /admin/jobs/sync-matches which requires a cron secret header
  that browsers can't send. Added sync-matches intent to cs2-setup action.

- Fix 2 (CRITICAL): loserAdvances was hardcoded false in match-sync/index.ts,
  breaking NBA Play-In scoring. Now calls doesLoserAdvance().

- Fix 3: ESPN score "0" was falsy → stored as null. Non-numeric strings
  like "F/OT" produced NaN. Added parseScore() helper.

- Fix 4: ESPN limit=1000 silently truncated MLB/NBA playoff games. Added
  seasonType param to EspnScheduleAdapter; all *_bracket types pass 3
  (postseason only).

- Fix 5: Cron job was syncing completed seasons unnecessarily. Added
  active status filter.

- Fix 6: hasLiveMatches triggered perpetual 30s polling for unseeded
  brackets. Added participant presence check.

- Fix 7: autoCompleteRoundIfDone was duplicated between bracket.server.ts
  and scoring-calculator.ts. Removed inline copy, imported shared version.

- Fix 8: MatchSchedule date grouping never ran for ESPN sports (no matchday
  field). Removed hasMatchdays gate, always call groupByMatchday with
  stable UTC date key.

- Fix 9: Silent failure when bracket matches exist but no scoring events.
  Added warning log.

- Fix 10: Added 3 tests — zero score preservation, NaN from non-numeric
  score, seasonType in URL.

https://claude.ai/code/session_01WUUM7uWzFoSkGcZRhnEKG6
2026-06-12 21:53:06 +00:00
..
__tests__ Fix NBA play-in elimination display and consolidate bracket reprocessing (#299) 2026-04-15 14:56:33 -07:00
BracketTreePaginated.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
BracketTreeView.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
Cs2TournamentBracket.tsx feat: add match sync service, cron job, public tournament display (Phases 2-4) 2026-06-12 20:46:30 +00:00
GroupStageDisplay.tsx User/chris/bracket UI redesign (#95) 2026-03-09 22:44:33 -07:00
MatchSchedule.tsx fix: address 10 code review issues in match sync system 2026-06-12 21:53:06 +00:00
NbaBracketLayout.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
PlayoffBracket.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
QualifyingPointsStandings.tsx Fix QP standings: filter to drafted/points-earning participants with correct global ranks 2026-06-06 09:38:47 -07:00
RankingsRow.stories.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
RankingsRow.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00
ScoringRulesEditor.tsx Redesign to dark-mode-only with navy palette and accent colors (#13) 2026-02-20 19:26:11 -08:00
SeasonStandings.tsx Fix IndyCar standings: correct ESPN stat key, update title, restore finalized badge 2026-06-10 09:17:23 -07:00
SportSeasonDisplay.tsx Fix IndyCar standings: correct ESPN stat key, update title, restore finalized badge 2026-06-10 09:17:23 -07:00
TabbedBracketLayout.tsx Add Storybook stories for new components from staged changes (#321) 2026-04-23 22:09:25 -07:00