chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions 2
brackt/app/routes/api
History
Claude c036cf6e28
Code review fixes: type safety, security hardening, and dead code removal 
- Fix Socket.IO event types: draft-paused and draft-resumed were typed as
  () => void but are emitted with { seasonId, paused } data payloads

- Fix draft.force-manual-pick: add missing season.status === "draft" guard
  so commissioners cannot force picks outside an active draft; add duplicate
  pick-number check so a slot cannot be assigned two picks (the previous
  code only checked participant uniqueness, not slot uniqueness)

- Replace args: any with ActionFunctionArgs / Route.LoaderArgs across all
  API routes and league loaders; replace (auth as any).userId casts with
  proper const { userId } = await getAuth(args) destructuring

- Remove unused isSnakeDraft = true dead variable from draft.make-pick

- Replace autodraftSettings: any and draftSlots: any[] in draft-utils with
  properly typed InferSelectModel / DraftSlot types

- Update force-manual-pick tests: sequence draftPicks.findFirst mock for
  the two-call flow; add new tests for status-check and slot-uniqueness

https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
2026-02-23 02:41:43 +00:00
..
__tests__ Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
webhooks refactor: simplify user update logic in Clerk webhook handler to reuse findOrCreateUser 2025-10-14 21:50:07 -07:00
autodraft.update.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.adjust-time-bank.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.force-autopick.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.force-manual-pick.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.make-pick.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.pause.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.replace-pick.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.resume.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.rollback.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
draft.start.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
queue.add.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
queue.clear.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
queue.remove.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00
queue.reorder.ts Code review fixes: type safety, security hardening, and dead code removal 2026-02-23 02:41:43 +00:00