brackt/app/models/__tests__/participant-expected-value.test.ts
Chris Parsons 2848231235
Canonical tournament layer: schema + backfill (1/2) (#365)
* refactor(schema): rename per-window tables to season_* prefix

Renames participants, participant_expected_values, participant_qualifying_totals,
participant_results, participant_surface_elos to season_* prefixed names.
Renames event_results.participant_id to season_participant_id.
Phase 1a of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor: rename participant.ts model file to season-participant.ts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(models): update model layer to use renamed schema exports

Updated all model files to use the renamed schema exports from Task 1:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantQualifyingTotals → seasonParticipantQualifyingTotals
- participantResults → seasonParticipantResults
- participantSurfaceElos → seasonParticipantSurfaceElos
- eventResults.participantId → eventResults.seasonParticipantId
- db.query relation accessors updated
- Relation field .participant → .seasonParticipant where applicable
- Import paths updated: ./participant → ./season-participant

Files updated (14 model files + 3 test files):
- draft-pick.ts
- draft-utils.ts
- event-result.ts
- group-stage-match.ts
- participant-result.ts
- qualifying-points.ts
- scoring-calculator.ts
- scoring-event.ts
- sports-season.ts
- surface-elo.ts
- team-score-events.ts
- cs2-major-stage.ts
- golf-skills.ts
- participant-expected-value.ts
- __tests__/sports-season.clone.test.ts
- __tests__/auto-pick.test.ts
- __tests__/executeAutoPick.timer.test.ts

Typecheck errors decreased: 779 → 499 (280 fewer)
All model file errors related to renamed schemas resolved.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(routes): update route layer to use renamed schema exports

- Update model import from ~/models/participant to ~/models/season-participant
- Rename schema.participants to schema.seasonParticipants
- Rename schema.participantResults to schema.seasonParticipantResults
- Rename db.query.participants to db.query.seasonParticipants
- Update 9 route files and 1 test file

Affected files:
- admin.sports-seasons.$id.events.$eventId.bracket.server.ts
- admin.sports-seasons.$id.participants.tsx
- api/draft.force-manual-pick.ts
- api/draft.make-pick.ts
- api/draft.replace-pick.ts
- api/seasons.$seasonId.draft.ts
- leagues/$leagueId.draft-board.$seasonId.tsx
- leagues/$leagueId.sports-seasons.$sportsSeasonId.server.ts
- admin/__tests__/sports-seasons-participants.test.ts

Error count reduced from 499 to 453 (46 errors fixed).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(routes): update route files for schema rename

Update route imports from ~/models/participant to ~/models/season-participant
and fix references to .participant/.participantId on event results to use
.seasonParticipant/.seasonParticipantId after schema rename.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(services): update simulators and services for renamed schema

Update all simulators, services, and server files to use renamed schema tables:
- participants → seasonParticipants
- participantExpectedValues → seasonParticipantExpectedValues
- participantResults → seasonParticipantResults
- eventResults.participantId → eventResults.seasonParticipantId

Files updated:
- 20 sport simulators (NBA, NHL, NFL, MLB, etc.)
- probability-updater.ts
- standings-sync/index.ts
- sports-data-sync.server.ts
- server/socket.ts

Typecheck errors reduced from 365 to 0.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* migration: rename per-window tables to season_* prefix

* fix(tests): update mock query keys after participants table rename

Change mock db.query.participants to db.query.seasonParticipants in test
files to match the schema rename from commit 66145a9. This fixes
"Cannot read properties of undefined (reading 'findFirst'/'findMany')"
errors that occurred when production code queries db.query.seasonParticipants
but test mocks only defined the old participants key.

Files updated:
- app/services/simulations/__tests__/world-cup-simulator.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.test.ts
- app/routes/api/__tests__/draft.force-manual-pick.timer-mode.test.ts
- app/routes/api/__tests__/draft.make-pick.timer-mode.test.ts
- server/__tests__/timer-autodraft.test.ts
- app/models/__tests__/team-score-events.test.ts

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(tests): update remaining mock paths and keys after schema rename

* fix(tests): final two mock stragglers after schema rename

- draft-pick.test.ts: assertion on db.query.participantQualifyingTotals
- process-match-result.test.ts: mock key participants → seasonParticipants

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* chore: add post-phase1a baseline capture (temp, for diff verification)

* chore: capture pre-migration baselines

* chore: remove post-phase1a capture helper after verification

* schema: add canonical tournament & participant tables

Adds tournaments, participants (canonical), tournament_results, and
participant_surface_elos (canonical). Adds nullable tournament_id to
scoring_events and nullable participant_id to season_participants.
Phase 1b of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(models): add canonical tournament, participant, result, surface-elo models

Adds CRUD modules for the canonical tables created in commit 775b905.
Each module mirrors existing app/models conventions (database() from
~/database/context, schema from ~/database/schema, mock-based tests).

Key implementation notes:
- participant.ts exports use "Canonical" prefix (CanonicalParticipant,
  createCanonicalParticipant, etc.) to avoid collision with existing
  season-participant.ts exports
- All four models include comprehensive unit tests following the
  audit-log.test.ts pattern
- Tests use mocked db responses (no real database access)
- Upsert functions use onConflictDoUpdate for appropriate unique constraints

Part of Phase 1b of canonical tournament layer migration.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* migration: create canonical tables, add nullable FKs

* scripts: add extractTournamentIdentity helper for backfill

Pure function that derives canonical (name, year) identity from a
scoring_events row, stripping trailing 4-digit years from the name or
falling back to eventDate. Used by the Phase 2 backfill to group
per-window events into canonical tournaments.

* scripts: add backfill orchestrator for canonical layer

Populates canonical tournaments, participants, tournament_results, and
participant_surface_elos from per-window data for qualifying-points
sports. Skips already-linked rows, is idempotent, and supports dry-run
mode.

Critical invariants enforced by the implementation:
- qualifying_points_awarded is never copied to tournament_results
- season_participant_qualifying_totals is never touched
- conflicting surface-Elo values between windows raise a loud error
  (recorded in report.errors) rather than overwriting

* scripts: add backfill CLI with dry-run default

Wires backfill-canonical-layer.ts to a CLI entry point exposed as
`npm run backfill:canonical`. Defaults to --dry-run; requires --apply
to actually write. Supports --sport=<uuid> to limit to a single sport.
Exits 2 if the backfill reports errors (e.g., surface-Elo conflicts).

* fix(backfill-cli): wrap runBackfill in DatabaseContext.run

The orchestrator uses database() from ~/database/context, which requires
AsyncLocalStorage to be populated. Wrap the CLI invocation with
DatabaseContext.run(db, ...) using server/db's cached connection pool.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(backfill-cli): exit 0 on success so pg pool doesn't block

The cached postgres connection pool keeps the Node event loop open after
main() returns. Explicit process.exit(0) on success mirrors the pattern
in scripts/capture-baseline.ts.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Chris Parsons <chrisp@extrahop.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-01 20:13:18 -07:00

247 lines
8.7 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

import { describe, it, expect, vi, beforeEach } from "vitest";
import type { ProbabilityDistribution, ScoringRules } from "~/services/ev-calculator";
/**
* Participant Expected Value Model Tests
* Phase 5.1.3: Probability Storage Model Functions
*
* These are documentation tests that describe the expected behavior of the model functions.
* The core EV calculation logic is thoroughly tested in app/services/__tests__/ev-calculator.test.ts (20 tests).
* The model layer provides database persistence for probabilities and EVs.
* Full integration tests are in the E2E test suite.
*/
// Mock database context
const mockUpdate = vi.fn();
const mockSet = vi.fn();
const _mockWhere = vi.fn();
const mockDb = {
update: mockUpdate,
select: vi.fn(),
};
vi.mock("~/database/context", () => ({
database: () => mockDb,
}));
vi.mock("~/database/schema", () => ({
seasonParticipants: { id: "id" },
seasonParticipantExpectedValues: {
participantId: "participantId",
sportsSeasonId: "sportsSeasonId",
},
}));
const mockSqlFn = Object.assign(vi.fn(() => ({})), {
join: vi.fn(() => ({})),
});
vi.mock("drizzle-orm", () => ({
eq: vi.fn((field, value) => ({ field, value })),
and: vi.fn((...args) => ({ and: args })),
count: vi.fn(() => ({ count: true })),
sql: mockSqlFn,
}));
describe("participant-expected-value model", () => {
const _defaultScoring: ScoringRules = {
pointsFor1st: 100,
pointsFor2nd: 70,
pointsFor3rd: 50,
pointsFor4th: 40,
pointsFor5th: 25,
pointsFor6th: 25,
pointsFor7th: 15,
pointsFor8th: 15,
};
const _validProbabilities: ProbabilityDistribution = {
probFirst: 20,
probSecond: 20,
probThird: 15,
probFourth: 15,
probFifth: 10,
probSixth: 10,
probSeventh: 5,
probEighth: 5,
};
describe("upsertParticipantEV", () => {
it("should create new participant EV with calculated expected value", () => {
// Function validates probabilities sum to 100%, calculates EV, and inserts/updates database record
// Expected EV for validProbabilities with defaultScoring: 54 points
// EV = 20% × 100 + 20% × 70 + 15% × 50 + 15% × 40 + 10% × 25 + 10% × 25 + 5% × 15 + 5% × 15
// = 20 + 14 + 7.5 + 6 + 2.5 + 2.5 + 0.75 + 0.75 = 54
expect(true).toBe(true);
});
it("should update existing participant EV", () => {
// Function checks for existing record by (participantId, seasonId) and updates if found
expect(true).toBe(true);
});
it("should reject invalid probabilities that don't sum to 100%", () => {
// Function throws error if validateProbabilities returns false
// Tolerance is ±0.1% by default
expect(true).toBe(true);
});
it("should default source to 'manual' if not provided", () => {
// Function sets source = 'manual' when not specified
expect(true).toBe(true);
});
});
describe("upsertParticipantEVWithNormalization", () => {
it("should normalize probabilities before upserting", () => {
// Function calls normalizeProbabilities to scale probabilities to sum to 100%
// Then calls upsertParticipantEV with normalized values
expect(true).toBe(true);
});
});
describe("getParticipantEV", () => {
it("should retrieve participant EV by participantId and seasonId", () => {
// Function returns ParticipantEV record or null if not found
expect(true).toBe(true);
});
});
describe("getAllParticipantEVsForSeason", () => {
it("should retrieve all EVs for a season", () => {
// Function returns array of ParticipantEV records for all participants in a season
expect(true).toBe(true);
});
});
describe("deleteParticipantEV", () => {
it("should delete participant EV record", () => {
// Function deletes record matching (participantId, seasonId)
expect(true).toBe(true);
});
});
describe("batchUpsertParticipantEVs", () => {
it("should upsert multiple participants in batches", () => {
// Function processes inputs in batches of 50 to avoid overwhelming database
// Returns array of all upserted ParticipantEV records
expect(true).toBe(true);
});
});
describe("toProbabilityDistribution", () => {
it("should convert database record to ProbabilityDistribution", () => {
// Function converts string fields (probFirst, probSecond, etc.) to numbers
// Returns ProbabilityDistribution object
expect(true).toBe(true);
});
});
describe("recalculateEV", () => {
it("should recalculate EV with new scoring rules", () => {
// Function retrieves existing probabilities and recalculates EV with new scoring
// Keeps probabilities unchanged, only updates expectedValue field
expect(true).toBe(true);
});
it("should return null if participant EV doesn't exist", () => {
// Function returns null when no record is found
expect(true).toBe(true);
});
});
describe("recalculateAllEVsForSeason", () => {
it("should recalculate all EVs for a season", () => {
// Function retrieves all participant EVs for season
// Calls recalculateEV for each participant
// Returns count of participants updated
expect(true).toBe(true);
});
});
describe("syncVorpForSeason", () => {
beforeEach(() => {
vi.clearAllMocks();
});
it("should calculate correct VORP values for 14 participants with EVs 100 down to 35 (step 5)", async () => {
// 14 participants: EVs = 100, 95, 90, 85, 80, 75, 70, 65, 60, 55, 50, 45, 40, 35
// Sorted descending (already sorted)
// Replacement level = avg of positions 12-14 (0-indexed 11-13) = avg(45, 40, 35) = 40
// VORP(100) = 60, VORP(35) = -5
const { calculateReplacementLevel, calculateVORP } = await import("~/services/ev-calculator");
const evValues = Array.from({ length: 14 }, (_, i) => 100 - i * 5);
// [100, 95, 90, 85, 80, 75, 70, 65, 60, 55, 50, 45, 40, 35]
const replacementLevel = calculateReplacementLevel(evValues);
expect(replacementLevel).toBe(40); // avg(45, 40, 35) = 40
const vorpFirst = calculateVORP(100, replacementLevel);
expect(vorpFirst).toBe(60);
const vorpLast = calculateVORP(35, replacementLevel);
expect(vorpLast).toBe(-5);
});
it("should return early when no EVs exist for the season", async () => {
// Re-mock getAllParticipantEVsForSeason to return empty array
// The function should do nothing and return without calling db.update
const { syncVorpForSeason } = await import("../participant-expected-value");
// Patch the module's getAllParticipantEVsForSeason to return []
// Since we can't easily spy on module-internal calls, we verify via db mock:
// If 0 EVs returned, db.update should not be called
// Setup: db.select chain for getAllParticipantEVsForSeason returns []
const mockSelectChain = {
from: vi.fn().mockReturnThis(),
where: vi.fn().mockResolvedValue([]),
};
mockDb.select = vi.fn().mockReturnValue(mockSelectChain);
await syncVorpForSeason("season-empty");
// db.update should NOT have been called (no participants to update)
expect(mockUpdate).not.toHaveBeenCalled();
});
it("should call db.update with correct vorpValue for each participant", async () => {
const { syncVorpForSeason } = await import("../participant-expected-value");
// 3 participants with EVs: 100, 70, 40
// sorted: [100, 70, 40]
// replacement level = avg of positions 12-14, but only 3 participants
// startIdx = min(11, 2) = 2, endIdx = min(13, 2) = 2 → slice = [40]
// replacementLevel = 40
// VORP: 100→60, 70→30, 40→0
const mockEvRecords = [
{ participantId: "p1", expectedValue: "100", sportsSeasonId: "season-1" },
{ participantId: "p2", expectedValue: "70", sportsSeasonId: "season-1" },
{ participantId: "p3", expectedValue: "40", sportsSeasonId: "season-1" },
];
const mockSelectChain = {
from: vi.fn().mockReturnThis(),
where: vi.fn().mockResolvedValue(mockEvRecords),
};
mockDb.select = vi.fn().mockReturnValue(mockSelectChain);
const mockWhereResolved = vi.fn().mockResolvedValue([]);
mockSet.mockReturnValue({ where: mockWhereResolved });
mockUpdate.mockReturnValue({ set: mockSet });
await syncVorpForSeason("season-1");
// Bulk update: db.update is called once for all participants
expect(mockUpdate).toHaveBeenCalledTimes(1);
// set() is called once with a CASE expression for vorpValue
expect(mockSet).toHaveBeenCalledTimes(1);
const setArg = mockSet.mock.calls[0][0];
expect(setArg).toHaveProperty("vorpValue");
expect(setArg).toHaveProperty("updatedAt");
});
});
});