brackt/app/models/sport.ts
Chris Parsons 4bffa40606
Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196)
* Fix no-shadow and consistent-function-scoping lint violations

Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.

no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).

consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix no-non-null-assertion lint violations and promote to error

Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.

Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers

Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.

- prefer-add-event-listener: converted onchange/onclick/onload
  assignments to addEventListener in useDraftNotifications.ts and
  admin.data-sync.tsx; stored changeHandler ref for proper cleanup
  with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
  side-effect imports (*.css, @testing-library/jest-dom,
  @testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
  cypress/support/e2e.ts (file already has an import)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix TypeScript errors from no-non-null-assertion fixes

Two fixes introduced by the non-null assertion cleanup produced type
errors:

- scoring-event.ts: `?? ""` was wrong type for a participant object map;
  restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
  truthy guarantee, causing TS18047 on the write-back block; added
  `participant &&` guard before accessing its properties

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Add npm run typecheck as Stop hook in Claude settings

Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-21 10:59:51 -07:00

93 lines
2.5 KiB
TypeScript

import { eq } from "drizzle-orm";
import { database } from "~/database/context";
import * as schema from "~/database/schema";
export type Sport = typeof schema.sports.$inferSelect;
export type NewSport = typeof schema.sports.$inferInsert;
export type SportType = "team" | "individual";
export type SportWithActiveSeasons = Sport & {
activeSeasons: Array<{ id: string; name: string; year: number }>;
};
export async function createSport(data: NewSport): Promise<Sport> {
const db = database();
const [sport] = await db
.insert(schema.sports)
.values(data)
.returning();
return sport;
}
export async function findSportById(id: string): Promise<Sport | undefined> {
const db = database();
return await db.query.sports.findFirst({
where: eq(schema.sports.id, id),
});
}
export async function findSportBySlug(slug: string): Promise<Sport | undefined> {
const db = database();
return await db.query.sports.findFirst({
where: eq(schema.sports.slug, slug),
});
}
export async function findAllSports(): Promise<Sport[]> {
const db = database();
return await db.query.sports.findMany({
orderBy: (s, { asc }) => [asc(s.name)],
});
}
export async function findAllSportsWithActiveSeasons(): Promise<SportWithActiveSeasons[]> {
const db = database();
const sports = await db.query.sports.findMany({
orderBy: (s, { asc }) => [asc(s.name)],
with: {
sportsSeasons: {
where: (ss, { or }) =>
or(
eq(ss.status, "active"),
eq(ss.status, "upcoming")
),
orderBy: (ss, { desc }) => [desc(ss.year)],
},
},
});
return sports.map((sport) => ({
...sport,
activeSeasons: sport.sportsSeasons.map((season) => ({
id: season.id,
name: season.name,
year: season.year,
})),
}));
}
export async function findSportsByType(type: SportType): Promise<Sport[]> {
const db = database();
return await db.query.sports.findMany({
where: eq(schema.sports.type, type),
orderBy: (s, { asc }) => [asc(s.name)],
});
}
export async function updateSport(
id: string,
data: Partial<NewSport>
): Promise<Sport> {
const db = database();
const [sport] = await db
.update(schema.sports)
.set({ ...data, updatedAt: new Date() })
.where(eq(schema.sports.id, id))
.returning();
return sport;
}
export async function deleteSport(id: string): Promise<void> {
const db = database();
await db.delete(schema.sports).where(eq(schema.sports.id, id));
}