* Add oxlint and fix all lint errors - Install oxlint, add .oxlintrc.json with rules for TypeScript/React - Add npm run lint / lint:fix scripts - Add Claude PostToolUse hook to run oxlint on every edited file - Fix 101 errors: unused vars/imports, eqeqeq, prefer-const, no-new-array - Fix no-array-index-key (use stable keys or suppress positional cases) - Fix exhaustive-deps missing dependency in useEffect - Promote exhaustive-deps and no-array-index-key to errors - Fix Map.get() !== null bug in $leagueId.server.ts (should be !== undefined) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix no-explicit-any warnings and upgrade tsconfig to ES2023 - Replace all `any` types with proper types or `unknown` across ~20 files - Add typed socket payload interfaces in draft route and useDraftSocket - Use any[] with eslint-disable for socket.io callbacks (legitimate escape hatch) - Bump all tsconfigs from ES2022 → ES2023 to support toSorted/toReversed - Fix cascading type errors uncovered by removing any: Map.get narrowing, participant relation types, ChartDataPoint, Partial<NewSeason> indexing - Add ParticipantResultWithParticipant type to participant-result model - Fix test fixtures to match updated interfaces (DraftCell, ParticipantResult) - Fix duplicate getQPStandings import in sportsSeasonId.server.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Promote no-explicit-any to error Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
170 lines
5 KiB
TypeScript
170 lines
5 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { render, screen } from '@testing-library/react';
|
|
import { DraftGrid } from '../DraftGrid';
|
|
import { mockDraftSlots } from '~/test/fixtures/team';
|
|
|
|
describe('DraftGrid Component', () => {
|
|
const mockGrid = [
|
|
[
|
|
{ pickNumber: 1, participant: { id: 'p1', name: 'Player 1' }, sport: { id: 's1', name: 'NFL' }, team: { id: 't1', name: 'Team 1' } },
|
|
null,
|
|
],
|
|
[
|
|
null,
|
|
{ pickNumber: 4, participant: { id: 'p2', name: 'Player 2' }, sport: { id: 's2', name: 'NBA' }, team: { id: 't2', name: 'Team 2' } },
|
|
],
|
|
];
|
|
|
|
describe('Rendering', () => {
|
|
it('should render team names in headers', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={2}
|
|
/>
|
|
);
|
|
|
|
expect(screen.getByText('Team 1')).toBeInTheDocument();
|
|
expect(screen.getByText('Team 2')).toBeInTheDocument();
|
|
});
|
|
|
|
it('should render draft grid with correct structure', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={2}
|
|
/>
|
|
);
|
|
|
|
// Should have cells for all picks
|
|
const cells = screen.getAllByTitle(/Overall Pick/i);
|
|
expect(cells.length).toBeGreaterThan(0);
|
|
});
|
|
|
|
it('should display picked players', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={2}
|
|
/>
|
|
);
|
|
|
|
expect(screen.getByText('Player 1')).toBeInTheDocument();
|
|
expect(screen.getByText('NFL')).toBeInTheDocument();
|
|
expect(screen.getByText('Player 2')).toBeInTheDocument();
|
|
expect(screen.getByText('NBA')).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
describe('Current Pick Highlighting', () => {
|
|
it('should highlight current pick with "On Clock" text', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={2}
|
|
/>
|
|
);
|
|
|
|
expect(screen.getByText('On Clock')).toBeInTheDocument();
|
|
});
|
|
|
|
it('should apply correct styling to current pick', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={2}
|
|
/>
|
|
);
|
|
|
|
const currentPickCell = screen.getByText('On Clock').parentElement;
|
|
expect(currentPickCell).toHaveClass('border-electric');
|
|
expect(currentPickCell).toHaveClass('bg-electric/15');
|
|
});
|
|
});
|
|
|
|
describe('Pick Numbering', () => {
|
|
it('should display round and pick numbers', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={1}
|
|
/>
|
|
);
|
|
|
|
// Should show format like "1.01", "1.02", etc.
|
|
expect(screen.getByText(/1\.01/)).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
describe('Optional Features', () => {
|
|
it('should render with title when provided', () => {
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={1}
|
|
title="Draft Board"
|
|
/>
|
|
);
|
|
|
|
expect(screen.getByText('Draft Board')).toBeInTheDocument();
|
|
});
|
|
|
|
it('should display timers when provided', () => {
|
|
const formatTime = (seconds: number | undefined) => {
|
|
if (seconds === undefined) return '--:--';
|
|
const mins = Math.floor(seconds / 60);
|
|
const secs = seconds % 60;
|
|
return `${mins}:${secs.toString().padStart(2, '0')}`;
|
|
};
|
|
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={mockGrid}
|
|
currentPick={1}
|
|
teamTimers={{ 'team-1': 120, 'team-2': 90 }}
|
|
formatTime={formatTime}
|
|
/>
|
|
);
|
|
|
|
expect(screen.getByText('2:00')).toBeInTheDocument();
|
|
expect(screen.getByText('1:30')).toBeInTheDocument();
|
|
});
|
|
});
|
|
|
|
describe('Snake Draft Order', () => {
|
|
it('should reverse picks on even rounds', () => {
|
|
const snakeGrid = [
|
|
[
|
|
{ pickNumber: 1, participant: { id: 'p1', name: 'Pick 1' }, sport: { id: 's1', name: 'NFL' }, team: { id: 't1', name: 'Team 1' } },
|
|
{ pickNumber: 2, participant: { id: 'p2', name: 'Pick 2' }, sport: { id: 's2', name: 'NBA' }, team: { id: 't2', name: 'Team 2' } },
|
|
],
|
|
[
|
|
{ pickNumber: 3, participant: { id: 'p3', name: 'Pick 4' }, sport: { id: 's1', name: 'MLB' }, team: { id: 't2', name: 'Team 2' } },
|
|
{ pickNumber: 4, participant: { id: 'p4', name: 'Pick 3' }, sport: { id: 's2', name: 'NHL' }, team: { id: 't1', name: 'Team 1' } },
|
|
],
|
|
];
|
|
|
|
render(
|
|
<DraftGrid
|
|
draftSlots={mockDraftSlots}
|
|
draftGrid={snakeGrid}
|
|
currentPick={5}
|
|
/>
|
|
);
|
|
|
|
// All picks should be visible
|
|
expect(screen.getByText('Pick 1')).toBeInTheDocument();
|
|
expect(screen.getByText('Pick 2')).toBeInTheDocument();
|
|
expect(screen.getByText('Pick 3')).toBeInTheDocument();
|
|
expect(screen.getByText('Pick 4')).toBeInTheDocument();
|
|
});
|
|
});
|
|
});
|