e5295812f6
Introduces three new schema tables (simulator_profiles, sports_season_simulator_configs, season_participant_simulator_inputs), a central model layer (app/models/simulator.ts), and a single runner entry point so every simulator run follows the same prepare → simulate → persist → snapshot → recalculate flow. Key additions: - manifest.ts: per-simulator display names, default configs, required/ optional inputs, derivable-input declarations, and setup sections - input-policy.ts: resolves sourceElo from projectedWins, projectedTablePoints, or sourceOdds; resolves ratings from sourceOdds; supports block / fallbackElo / averageKnown / worstKnownMinus strategies - runner.ts: single entry point for admin simulation runs; materialises derived inputs, normalises result columns, zeroes omitted participants, snapshots EVs, and recalculates linked fantasy standings - /admin/simulators: inventory page with per-season readiness and bulk run - /admin/sports-seasons/:id/simulator: per-season setup page with readiness summary, input-policy editor, raw JSON config override, and CSV bulk input - NCAAM/NCAAW simulators now read ratings from season_participant_simulator_inputs, falling back to the hardcoded name-keyed maps while DB data is being populated - Clone flow copies simulator config by default; volatile inputs (odds, Elo) only copied when explicitly requested Code-review fixes included in this commit: - source field in compatibility bridge checked with !== null instead of !== undefined - sourceEloRequirementLabel no longer appends "configured fallback" when the participant is already excluded from all resolved sources - Duplicate inline label maps in input-policy.ts replaced with simulatorInputLabel - save-config preserves existing inputPolicy when the submitted JSON omits it - Input table truncation label added (Showing 20 of N) - CSV description notes values must not contain commas - N+1 comment added to listSportsSeasonSimulatorSummaries - assertRegistrySchemaDriftFree called in manifest tests - Runner test suite added covering happy path, already-running guard, readiness failure, empty results, and error recovery with status reset Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
93 lines
3.1 KiB
TypeScript
93 lines
3.1 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
vi.mock("~/models/sport", () => ({
|
|
createSport: vi.fn(),
|
|
findAllSports: vi.fn(),
|
|
isSportIconUrlUsed: vi.fn(),
|
|
}));
|
|
vi.mock("~/lib/cloudinary.server", () => ({
|
|
deleteCloudinaryImageByUrl: vi.fn().mockResolvedValue(undefined),
|
|
}));
|
|
vi.mock("~/lib/logger", () => ({
|
|
logger: { error: vi.fn(), info: vi.fn(), warn: vi.fn() },
|
|
}));
|
|
|
|
import { action } from "../admin.sports.new";
|
|
import { deleteCloudinaryImageByUrl } from "~/lib/cloudinary.server";
|
|
import { createSport, isSportIconUrlUsed } from "~/models/sport";
|
|
|
|
function makeRequest(iconUrl: string) {
|
|
const formData = new URLSearchParams();
|
|
formData.set("name", "NFL");
|
|
formData.set("type", "team");
|
|
formData.set("slug", "nfl");
|
|
formData.set("description", "Football");
|
|
formData.set("iconUrl", iconUrl);
|
|
|
|
return new Request("http://test/admin/sports/new", {
|
|
method: "POST",
|
|
headers: { "Content-Type": "application/x-www-form-urlencoded" },
|
|
body: formData.toString(),
|
|
});
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
vi.mocked(createSport).mockResolvedValue({} as never);
|
|
vi.mocked(isSportIconUrlUsed).mockResolvedValue(false);
|
|
});
|
|
|
|
describe("admin sport create action", () => {
|
|
it("rejects arbitrary icon URLs", async () => {
|
|
const response = await action({
|
|
request: makeRequest("https://example.com/icon.svg"),
|
|
params: {},
|
|
context: {},
|
|
} as never);
|
|
|
|
expect(response).toEqual({ error: "Sport icon must be an uploaded SVG icon." });
|
|
expect(createSport).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("deletes a newly uploaded icon when create fails", async () => {
|
|
const iconUrl = "https://res.cloudinary.com/demo/image/upload/v1/sports-icons/nfl.svg";
|
|
vi.mocked(createSport).mockRejectedValue(new Error("duplicate"));
|
|
|
|
await action({
|
|
request: makeRequest(iconUrl),
|
|
params: {},
|
|
context: {},
|
|
} as never);
|
|
|
|
expect(deleteCloudinaryImageByUrl).toHaveBeenCalledWith(iconUrl);
|
|
});
|
|
|
|
it("does not delete a reused existing icon when create fails", async () => {
|
|
const iconUrl = "https://res.cloudinary.com/demo/image/upload/v1/sports-icons/nfl.svg";
|
|
vi.mocked(createSport).mockRejectedValue(new Error("duplicate"));
|
|
vi.mocked(isSportIconUrlUsed).mockResolvedValue(true);
|
|
|
|
await action({
|
|
request: makeRequest(iconUrl),
|
|
params: {},
|
|
context: {},
|
|
} as never);
|
|
|
|
expect(deleteCloudinaryImageByUrl).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("returns the create error when icon reuse lookup fails during cleanup", async () => {
|
|
const iconUrl = "https://res.cloudinary.com/demo/image/upload/v1/sports-icons/nfl.svg";
|
|
vi.mocked(createSport).mockRejectedValue(new Error("database unavailable"));
|
|
vi.mocked(isSportIconUrlUsed).mockRejectedValue(new Error("database unavailable"));
|
|
|
|
const response = await action({
|
|
request: makeRequest(iconUrl),
|
|
params: {},
|
|
context: {},
|
|
} as never);
|
|
|
|
expect(response).toEqual({ error: "Failed to create sport. The slug might already exist." });
|
|
expect(deleteCloudinaryImageByUrl).not.toHaveBeenCalled();
|
|
});
|
|
});
|