Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
import { useLoaderData , Link , useRevalidator } from "react-router" ;
2026-02-28 09:54:14 -08:00
import { useAuth } from "@clerk/react-router" ;
2025-10-18 14:55:26 -07:00
import { eq , and , asc , desc , inArray } from "drizzle-orm" ;
2025-10-17 12:30:58 -07:00
import { database } from "~/database/context" ;
import * as schema from "~/database/schema" ;
import { useDraftSocket } from "~/hooks/useDraftSocket" ;
2026-03-21 13:41:39 -07:00
import { logger } from "~/lib/logger" ;
2026-03-01 19:33:03 -08:00
import { useCallback , useEffect , useState , useMemo , useRef } from "react" ;
2025-10-17 12:45:30 -07:00
import { Button } from "~/components/ui/button" ;
2025-10-25 03:23:41 -07:00
import { Tabs , TabsContent , TabsList , TabsTrigger } from "~/components/ui/tabs" ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
import { Dialog , DialogContent , DialogDescription , DialogFooter , DialogHeader , DialogTitle } from "~/components/ui/dialog" ;
2025-10-17 12:45:30 -07:00
import { getAuth } from "@clerk/react-router/server" ;
import { getTeamQueue } from "~/models/draft-queue" ;
2026-02-22 16:56:07 -08:00
import { buildOwnerMap } from "~/lib/owner-map" ;
2025-10-25 03:23:41 -07:00
import { DraftSidebar } from "~/components/DraftSidebar" ;
2026-03-02 16:46:35 -08:00
import { TeamRosterView } from "~/components/draft/TeamRosterView" ;
import { DraftSummaryView } from "~/components/draft/DraftSummaryView" ;
2025-10-25 03:23:41 -07:00
import { QueueSection } from "~/components/draft/QueueSection" ;
import { AvailableParticipantsSection } from "~/components/draft/AvailableParticipantsSection" ;
2025-10-25 18:25:26 -07:00
import { SidebarRecentPicks } from "~/components/draft/SidebarRecentPicks" ;
2025-10-25 03:23:41 -07:00
import { DraftGridSection } from "~/components/draft/DraftGridSection" ;
2025-10-26 21:01:12 -07:00
import { ConnectionOverlay } from "~/components/draft/ConnectionOverlay" ;
2026-03-01 19:33:03 -08:00
import { AuthRecoveryOverlay } from "~/components/draft/AuthRecoveryOverlay" ;
2026-02-27 23:46:09 -08:00
import { ParticipantSelectionDialog } from "~/components/draft/ParticipantSelectionDialog" ;
2025-10-26 21:09:30 -07:00
import { calculateDraftEligibility } from "~/lib/draft-eligibility" ;
2026-02-20 19:30:53 -08:00
import { getTeamForPick } from "~/lib/draft-order" ;
import { useDraftNotifications } from "~/hooks/useDraftNotifications" ;
2026-02-22 22:36:12 -08:00
import { useMediaQuery } from "~/hooks/useMediaQuery" ;
2026-02-20 19:30:53 -08:00
import { NotificationSettings } from "~/components/NotificationSettings" ;
2026-03-03 20:14:38 -08:00
import { AutodraftSettings , getAutodraftLabel } from "~/components/AutodraftSettings" ;
2025-10-25 21:02:16 -07:00
import { toast } from "sonner" ;
Add draft clock UI, Fischer increment timer logic, and security fixes (#19)
- Add prominent clock badge to tab bar (lights up on your turn) with
correct Fischer increment chess-clock model: bank starts at initialTime,
+= incrementTime after each pick, other teams' banks untouched
- Extract pure timer helpers to app/lib/draft-timer.ts and add 29 unit
tests covering formatClockTime, calculateTimeAfterPick, getTimerColorClass,
and full snake-draft lifecycle regression scenarios
- Fix make-pick.ts: add status !== 'draft' and draftPaused server guards
- Fix draft-utils.ts: replace (global as any).__socketIO with getSocketIO(),
fix timeUsed to store actual timeRemaining at pick moment (not always 120),
add null timer warning, move timer fetch before pick insert
- Fix draft.start.ts: batch timer inserts, guard against empty draftSlots
- Fix DraftGridSection: memoize currentTeamId, widen teamTimers type to
Record<string, number | undefined>
- Fix duplicate animate-pulse (getTimerColorClass already includes it)
- Clamp negative seconds in formatClockTime to guard against timer drift
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-21 16:51:12 -08:00
import { formatClockTime , getTimerColorClass } from "~/lib/draft-timer" ;
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
import { Users , LayoutGrid , ListChecks , Settings , ListOrdered } from "lucide-react" ;
Claude/fix pick timer ghll n (#29)
* Fix force-manual-pick resetting next team's timer to initial time
When a commissioner forced a manual pick, the next team's timer was
being reset to the initial time (2 minutes) instead of carrying
forward their existing time bank balance.
This aligns force-manual-pick with the behavior of regular user picks
and force-autopick: the picking team gets their increment added, and
the next team's timer is left untouched so their bank carries forward.
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add regression tests for draft.force-manual-pick timer behavior
18 tests across 5 describe blocks covering:
- Authorization (401/403)
- Input validation (missing fields, bad participant, ineligible sport)
- Successful pick (response shape, draft-complete detection, socket events)
- Timer behavior (increment added to picking team, new timer creation, additive not reset)
- Two regression tests confirming the next team's timer is never touched:
draftTimers.findFirst called exactly once, no timer-update emitted for
next team, db.update called exactly twice (not three times)
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add TypeScript types and improve draft validation (#28)
* Code review fixes: type safety, security hardening, and dead code removal
- Fix Socket.IO event types: draft-paused and draft-resumed were typed as
() => void but are emitted with { seasonId, paused } data payloads
- Fix draft.force-manual-pick: add missing season.status === "draft" guard
so commissioners cannot force picks outside an active draft; add duplicate
pick-number check so a slot cannot be assigned two picks (the previous
code only checked participant uniqueness, not slot uniqueness)
- Replace args: any with ActionFunctionArgs / Route.LoaderArgs across all
API routes and league loaders; replace (auth as any).userId casts with
proper const { userId } = await getAuth(args) destructuring
- Remove unused isSnakeDraft = true dead variable from draft.make-pick
- Replace autodraftSettings: any and draftSlots: any[] in draft-utils with
properly typed InferSelectModel / DraftSlot types
- Update force-manual-pick tests: sequence draftPicks.findFirst mock for
the two-call flow; add new tests for status-check and slot-uniqueness
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
* Fix RouterContextProvider type errors in action test files
Cast context argument to RouterContextProvider in test helpers so
ActionFunctionArgs strict typing is satisfied without weakening the
production action signatures back to any.
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
---------
Co-authored-by: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-22 19:29:29 -08:00
import type { Route } from "./+types/$leagueId.draft.$seasonId" ;
2025-10-17 12:30:58 -07:00
2026-03-10 12:10:52 -07:00
export function meta ( { data } : Route . MetaArgs ) : Route . MetaDescriptors {
return [ { title : ` Draft — ${ data ? . season ? . league ? . name ? ? "League" } - Brackt ` } ] ;
}
2026-02-24 11:31:25 -08:00
type QueueItem = typeof schema . draftQueue . $inferSelect ;
2026-03-03 20:14:38 -08:00
type AutodraftStatusEntry = {
isEnabled : boolean ;
mode : "next_pick" | "while_on" ;
queueOnly : boolean ;
} ;
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
const MOBILE_TABS_BASE = [
{ id : "available" as const , label : "Available" , Icon : Users } ,
2026-02-22 22:36:12 -08:00
{ id : "board" as const , label : "Board" , Icon : LayoutGrid } ,
2026-03-02 16:46:35 -08:00
{ id : "teams" as const , label : "Teams" , Icon : ListChecks } ,
2026-02-22 22:36:12 -08:00
{ id : "controls" as const , label : "Controls" , Icon : Settings } ,
] ;
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
const QUEUE_TAB = { id : "queue" as const , label : "Queue" , Icon : ListOrdered } ;
Claude/fix pick timer ghll n (#29)
* Fix force-manual-pick resetting next team's timer to initial time
When a commissioner forced a manual pick, the next team's timer was
being reset to the initial time (2 minutes) instead of carrying
forward their existing time bank balance.
This aligns force-manual-pick with the behavior of regular user picks
and force-autopick: the picking team gets their increment added, and
the next team's timer is left untouched so their bank carries forward.
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add regression tests for draft.force-manual-pick timer behavior
18 tests across 5 describe blocks covering:
- Authorization (401/403)
- Input validation (missing fields, bad participant, ineligible sport)
- Successful pick (response shape, draft-complete detection, socket events)
- Timer behavior (increment added to picking team, new timer creation, additive not reset)
- Two regression tests confirming the next team's timer is never touched:
draftTimers.findFirst called exactly once, no timer-update emitted for
next team, db.update called exactly twice (not three times)
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add TypeScript types and improve draft validation (#28)
* Code review fixes: type safety, security hardening, and dead code removal
- Fix Socket.IO event types: draft-paused and draft-resumed were typed as
() => void but are emitted with { seasonId, paused } data payloads
- Fix draft.force-manual-pick: add missing season.status === "draft" guard
so commissioners cannot force picks outside an active draft; add duplicate
pick-number check so a slot cannot be assigned two picks (the previous
code only checked participant uniqueness, not slot uniqueness)
- Replace args: any with ActionFunctionArgs / Route.LoaderArgs across all
API routes and league loaders; replace (auth as any).userId casts with
proper const { userId } = await getAuth(args) destructuring
- Remove unused isSnakeDraft = true dead variable from draft.make-pick
- Replace autodraftSettings: any and draftSlots: any[] in draft-utils with
properly typed InferSelectModel / DraftSlot types
- Update force-manual-pick tests: sequence draftPicks.findFirst mock for
the two-call flow; add new tests for status-check and slot-uniqueness
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
* Fix RouterContextProvider type errors in action test files
Cast context argument to RouterContextProvider in test helpers so
ActionFunctionArgs strict typing is satisfied without weakening the
production action signatures back to any.
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
---------
Co-authored-by: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-22 19:29:29 -08:00
export async function loader ( args : Route.LoaderArgs ) {
2025-10-17 12:45:30 -07:00
const { params } = args ;
const { seasonId , leagueId } = params ;
Claude/fix pick timer ghll n (#29)
* Fix force-manual-pick resetting next team's timer to initial time
When a commissioner forced a manual pick, the next team's timer was
being reset to the initial time (2 minutes) instead of carrying
forward their existing time bank balance.
This aligns force-manual-pick with the behavior of regular user picks
and force-autopick: the picking team gets their increment added, and
the next team's timer is left untouched so their bank carries forward.
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add regression tests for draft.force-manual-pick timer behavior
18 tests across 5 describe blocks covering:
- Authorization (401/403)
- Input validation (missing fields, bad participant, ineligible sport)
- Successful pick (response shape, draft-complete detection, socket events)
- Timer behavior (increment added to picking team, new timer creation, additive not reset)
- Two regression tests confirming the next team's timer is never touched:
draftTimers.findFirst called exactly once, no timer-update emitted for
next team, db.update called exactly twice (not three times)
https://claude.ai/code/session_01X7gwWmafUSEvVHcV7Raz5p
* Add TypeScript types and improve draft validation (#28)
* Code review fixes: type safety, security hardening, and dead code removal
- Fix Socket.IO event types: draft-paused and draft-resumed were typed as
() => void but are emitted with { seasonId, paused } data payloads
- Fix draft.force-manual-pick: add missing season.status === "draft" guard
so commissioners cannot force picks outside an active draft; add duplicate
pick-number check so a slot cannot be assigned two picks (the previous
code only checked participant uniqueness, not slot uniqueness)
- Replace args: any with ActionFunctionArgs / Route.LoaderArgs across all
API routes and league loaders; replace (auth as any).userId casts with
proper const { userId } = await getAuth(args) destructuring
- Remove unused isSnakeDraft = true dead variable from draft.make-pick
- Replace autodraftSettings: any and draftSlots: any[] in draft-utils with
properly typed InferSelectModel / DraftSlot types
- Update force-manual-pick tests: sequence draftPicks.findFirst mock for
the two-call flow; add new tests for status-check and slot-uniqueness
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
* Fix RouterContextProvider type errors in action test files
Cast context argument to RouterContextProvider in test helpers so
ActionFunctionArgs strict typing is satisfied without weakening the
production action signatures back to any.
https://claude.ai/code/session_01FKq2gPFYpgdfxr8cw4Z2AZ
---------
Co-authored-by: Claude <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-22 19:29:29 -08:00
const { userId } = await getAuth ( args ) ;
2025-10-18 14:55:26 -07:00
2025-10-17 12:30:58 -07:00
if ( ! seasonId ) {
throw new Response ( "Season ID is required" , { status : 400 } ) ;
}
const db = database ( ) ;
// Get season details
const season = await db . query . seasons . findFirst ( {
where : eq ( schema . seasons . id , seasonId ) ,
with : {
league : true ,
teams : true ,
} ,
} ) ;
if ( ! season ) {
throw new Response ( "Season not found" , { status : 404 } ) ;
}
2026-02-23 12:00:04 -08:00
// Resolve user's team and commissioner status (null userId means neither)
const userTeam = userId
2026-03-21 09:44:05 -07:00
? season . teams . find ( ( team ) = > team . ownerId === userId )
2026-02-23 12:00:04 -08:00
: undefined ;
const isCommissioner = userId
? await db . query . commissioners . findFirst ( {
where : and (
eq ( schema . commissioners . leagueId , leagueId ) ,
eq ( schema . commissioners . userId , userId )
) ,
} )
: null ;
2025-10-17 12:45:30 -07:00
2026-02-23 12:00:04 -08:00
// Access control: if draft board is not public, require authentication and membership
if ( ! season . league . isPublicDraftBoard ) {
if ( ! userId ) {
throw new Response ( "You must be logged in to view the draft room" , {
status : 401 ,
} ) ;
}
if ( ! userTeam && ! isCommissioner ) {
throw new Response ( "You do not have access to this draft room" , {
status : 403 ,
} ) ;
}
2025-10-17 12:45:30 -07:00
}
2025-10-17 12:30:58 -07:00
// Get draft slots (draft order) - using select instead of query builder
const draftSlots = await db
. select ( {
id : schema.draftSlots.id ,
draftOrder : schema.draftSlots.draftOrder ,
team : schema.teams ,
} )
. from ( schema . draftSlots )
. innerJoin ( schema . teams , eq ( schema . draftSlots . teamId , schema . teams . id ) )
. where ( eq ( schema . draftSlots . seasonId , seasonId ) )
. orderBy ( asc ( schema . draftSlots . draftOrder ) ) ;
// Get all draft picks - using select instead of query builder
const draftPicks = await db
. select ( {
id : schema.draftPicks.id ,
pickNumber : schema.draftPicks.pickNumber ,
round : schema.draftPicks.round ,
pickInRound : schema.draftPicks.pickInRound ,
timeUsed : schema.draftPicks.timeUsed ,
team : schema.teams ,
participant : schema.participants ,
sport : schema.sports ,
} )
. from ( schema . draftPicks )
. innerJoin ( schema . teams , eq ( schema . draftPicks . teamId , schema . teams . id ) )
2025-10-18 14:55:26 -07:00
. innerJoin (
schema . participants ,
eq ( schema . draftPicks . participantId , schema . participants . id )
)
. innerJoin (
schema . sportsSeasons ,
eq ( schema . participants . sportsSeasonId , schema . sportsSeasons . id )
)
. innerJoin (
schema . sports ,
eq ( schema . sportsSeasons . sportId , schema . sports . id )
)
2025-10-17 12:30:58 -07:00
. where ( eq ( schema . draftPicks . seasonId , seasonId ) )
. orderBy ( asc ( schema . draftPicks . pickNumber ) ) ;
2025-10-17 16:58:35 -07:00
// Get sports seasons for this season
const seasonSports = await db . query . seasonSports . findMany ( {
where : eq ( schema . seasonSports . seasonId , seasonId ) ,
} ) ;
2025-10-18 14:55:26 -07:00
2025-10-17 16:58:35 -07:00
const sportsSeasonIds = seasonSports . map ( ( ss ) = > ss . sportsSeasonId ) ;
2025-10-18 14:55:26 -07:00
// Get ALL participants (both drafted and undrafted) - sorted by EV desc, then name
// Filtering will be done on the client side based on the "Show Drafted" toggle
2026-02-20 21:26:27 -08:00
const availableParticipants = sportsSeasonIds . length > 0
? await db
. select ( {
id : schema.participants.id ,
name : schema.participants.name ,
sport : schema.sports ,
} )
. from ( schema . participants )
. innerJoin (
schema . sportsSeasons ,
eq ( schema . participants . sportsSeasonId , schema . sportsSeasons . id )
)
. innerJoin (
schema . sports ,
eq ( schema . sportsSeasons . sportId , schema . sports . id )
)
. where (
sportsSeasonIds . length === 1
? eq ( schema . participants . sportsSeasonId , sportsSeasonIds [ 0 ] )
: inArray ( schema . participants . sportsSeasonId , sportsSeasonIds )
)
. orderBy (
desc ( schema . participants . expectedValue ) ,
asc ( schema . participants . name )
)
: [ ] ;
2025-10-17 12:30:58 -07:00
2025-10-17 12:45:30 -07:00
// Load user's team queue if they have a team
2026-02-23 23:23:24 -08:00
const userQueue = userTeam
? await getTeamQueue ( userTeam . id ) . catch ( ( err ) = > {
2026-03-21 13:41:39 -07:00
logger . error ( "[DraftLoader] Failed to load queue, defaulting to empty:" , err ) ;
2026-02-23 23:23:24 -08:00
return [ ] ;
} )
: [ ] ;
2025-10-17 12:45:30 -07:00
2025-10-18 23:13:04 -07:00
// Load draft timers for all teams
const timers = await db . query . draftTimers . findMany ( {
where : eq ( schema . draftTimers . seasonId , seasonId ) ,
} ) ;
2025-10-21 23:22:17 -07:00
// Load autodraft settings for all teams
const autodraftSettings = await db . query . autodraftSettings . findMany ( {
where : eq ( schema . autodraftSettings . seasonId , seasonId ) ,
} ) ;
2026-02-20 21:10:26 -08:00
// Derive user's autodraft settings from the already-loaded list
2025-10-21 23:22:17 -07:00
const userAutodraftSettings = userTeam
2026-02-20 21:10:26 -08:00
? ( autodraftSettings . find ( ( s ) = > s . teamId === userTeam . id ) ? ? null )
2025-10-21 23:22:17 -07:00
: null ;
2026-02-22 16:56:07 -08:00
const ownerMap = await buildOwnerMap ( draftSlots ) ;
2025-10-17 12:30:58 -07:00
return {
season ,
draftSlots ,
draftPicks ,
availableParticipants ,
2025-10-17 12:45:30 -07:00
userTeam ,
userQueue ,
2025-10-18 23:13:04 -07:00
timers ,
2025-10-21 23:22:17 -07:00
autodraftSettings ,
userAutodraftSettings ,
2025-10-17 12:45:30 -07:00
isCommissioner : ! ! isCommissioner ,
currentUserId : userId ,
2026-02-22 16:56:07 -08:00
ownerMap ,
2025-10-17 12:30:58 -07:00
} ;
}
export default function DraftRoom() {
2025-10-18 14:55:26 -07:00
const {
season ,
draftSlots ,
draftPicks ,
availableParticipants ,
userTeam ,
userQueue ,
2025-10-18 23:13:04 -07:00
timers ,
2025-10-21 23:22:17 -07:00
autodraftSettings ,
userAutodraftSettings ,
2025-10-18 14:55:26 -07:00
isCommissioner ,
2026-02-20 19:30:53 -08:00
currentUserId ,
2026-02-22 16:56:07 -08:00
ownerMap ,
2025-10-18 14:55:26 -07:00
} = useLoaderData < typeof loader > ( ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
const { revalidate , state : revalidatorState } = useRevalidator ( ) ;
2026-03-01 19:33:03 -08:00
const { userId : clerkUserId , getToken } = useAuth ( ) ;
2026-03-02 13:18:47 -08:00
const { isConnected , connectionError , isReconnecting , reconnectCount , socketVersion , on , off } = useDraftSocket ( season . id , userTeam ? . id ) ;
2026-02-20 19:30:53 -08:00
const {
permissionState : notificationsPermission ,
enabled : notificationsEnabled ,
setEnabled : setNotificationsEnabled ,
mode : notificationsMode ,
setMode : setNotificationsMode ,
sendNotification ,
2026-02-23 12:00:04 -08:00
} = useDraftNotifications ( season . id , currentUserId ? ? "" ) ;
2026-02-20 19:30:53 -08:00
// Use refs so the socket effect doesn't re-register all handlers when the user
// changes notification settings (which would change the sendNotification reference).
const sendNotificationRef = useRef ( sendNotification ) ;
useEffect ( ( ) = > {
sendNotificationRef . current = sendNotification ;
} , [ sendNotification ] ) ;
const notificationsModeRef = useRef ( notificationsMode ) ;
useEffect ( ( ) = > {
notificationsModeRef . current = notificationsMode ;
} , [ notificationsMode ] ) ;
2026-02-24 12:24:04 -08:00
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
// Track current autodraft state for detecting server-initiated auto-disable
const [ userAutodraft , setUserAutodraft ] = useState ( {
isEnabled : userAutodraftSettings?.isEnabled || false ,
mode : ( userAutodraftSettings ? . mode || "next_pick" ) as "next_pick" | "while_on" ,
queueOnly : userAutodraftSettings?.queueOnly || false ,
} ) ;
const userAutodraftRef = useRef ( userAutodraft ) ;
useEffect ( ( ) = > {
userAutodraftRef . current = userAutodraft ;
} , [ userAutodraft ] ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Re-fetch loader data after each reconnect so stale picks/timers are refreshed.
// Schedule a delayed retry so that if the first attempt fails (common on mobile
// where the network may not be fully restored yet), we get another chance.
const revalidationRetryRef = useRef < ReturnType < typeof setTimeout > | null > ( null ) ;
2026-02-24 12:24:04 -08:00
useEffect ( ( ) = > {
if ( reconnectCount > 0 ) {
revalidate ( ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Clear any pending retry from a previous reconnect
if ( revalidationRetryRef . current ) {
clearTimeout ( revalidationRetryRef . current ) ;
}
revalidationRetryRef . current = setTimeout ( ( ) = > {
revalidate ( ) ;
revalidationRetryRef . current = null ;
} , 3000 ) ;
2026-02-24 12:24:04 -08:00
}
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
return ( ) = > {
if ( revalidationRetryRef . current ) {
clearTimeout ( revalidationRetryRef . current ) ;
}
} ;
2026-02-24 12:24:04 -08:00
} , [ reconnectCount , revalidate ] ) ;
2026-03-02 20:55:42 -08:00
// Guard against Clerk JWT expiry race: if the loader ran without a userId
// (expired short-lived JWT) but the Clerk client SDK has a valid session,
// revalidate so the loader re-runs with a fresh token and returns correct
// userTeam/userQueue data. This can happen repeatedly on mobile when the
// user backgrounds and foregrounds the app, so we don't limit it to a
// single attempt. Instead we debounce to avoid rapid-fire revalidations.
//
// Cap at 3 attempts to avoid an infinite loop if the server consistently
// fails to resolve a userId (e.g. clock skew, misconfigured Clerk keys).
// After 3 failures we fall through to the authDegraded overlay.
const authRecoveryTimerRef = useRef < ReturnType < typeof setTimeout > | undefined > ( undefined ) ;
const authRecoveryAttemptsRef = useRef ( 0 ) ;
const MAX_AUTH_RECOVERY_ATTEMPTS = 3 ;
2026-02-28 09:54:14 -08:00
useEffect ( ( ) = > {
2026-03-02 20:55:42 -08:00
if ( clerkUserId && ! currentUserId ) {
if ( authRecoveryAttemptsRef . current >= MAX_AUTH_RECOVERY_ATTEMPTS ) {
setAuthDegraded ( true ) ;
return ;
}
// Small debounce so we don't fire multiple times in quick succession
// (e.g. visibility change + socket reconnect both updating deps).
clearTimeout ( authRecoveryTimerRef . current ) ;
authRecoveryTimerRef . current = setTimeout ( ( ) = > {
authRecoveryAttemptsRef . current += 1 ;
revalidate ( ) ;
} , 100 ) ;
} else if ( currentUserId ) {
// Auth recovered — reset the counter for the next background cycle.
authRecoveryAttemptsRef . current = 0 ;
2026-02-28 09:54:14 -08:00
}
2026-03-02 20:55:42 -08:00
return ( ) = > clearTimeout ( authRecoveryTimerRef . current ) ;
2026-02-28 09:54:14 -08:00
} , [ clerkUserId , currentUserId , revalidate ] ) ;
2026-03-01 19:33:03 -08:00
// Auth session protection: proactively refresh the Clerk JWT to prevent
// silent logout during long-running draft sessions.
const [ authDegraded , setAuthDegraded ] = useState ( false ) ;
// Fetch wrapper that detects 401 responses and shows the auth recovery
// overlay instead of letting each handler deal with it individually.
// Returns null on 401 so callers can bail with `if (!response) return;`.
const authFetch = useCallback ( async ( url : string , init? : RequestInit ) : Promise < Response | null > = > {
const response = await fetch ( url , init ) ;
if ( response . status === 401 ) {
setAuthDegraded ( true ) ;
return null ;
}
return response ;
} , [ ] ) ;
// Refresh the Clerk JWT when the tab becomes visible again. Browsers
// throttle/suspend intervals in background tabs, so the SDK's automatic
// 60-second refresh may not have run. Getting a fresh token here prevents
2026-03-02 20:55:42 -08:00
// the next user action from hitting a 401. After a successful refresh we
// also revalidate the loader so it re-runs with the fresh token — without
// this, userTeam/userQueue stay stale from the previous (possibly
// unauthenticated) loader run.
2026-03-01 19:33:03 -08:00
useEffect ( ( ) = > {
2026-03-02 13:18:47 -08:00
// Nothing to do once auth is fully degraded — avoid re-registering a
// listener that would immediately exit on every future visibility change.
if ( authDegraded ) return ;
let aborted = false ;
let inFlight = false ;
2026-03-01 19:33:03 -08:00
const handleVisibilityChange = async ( ) = > {
2026-03-02 13:18:47 -08:00
// Ignore hide events, and skip if another invocation is already running
// (rapid tab switching) or this effect has been cleaned up.
if ( document . visibilityState !== "visible" || ! clerkUserId || inFlight ) return ;
inFlight = true ;
2026-03-01 19:33:03 -08:00
try {
const token = await getToken ( { skipCache : true } ) ;
2026-03-02 13:18:47 -08:00
if ( aborted ) return ;
2026-03-02 20:55:42 -08:00
if ( token !== null ) {
// Token refreshed successfully. Only revalidate if the loader is
// missing auth (currentUserId is null) — if the loader already has
// a valid user there's no stale state to fix and the extra round
// trip just adds unnecessary server load.
if ( ! currentUserId ) {
revalidate ( ) ;
}
} else {
// Retry after a longer delay — mobile networks may take a few
// seconds to fully wake up after background suspension.
await new Promise ( ( r ) = > setTimeout ( r , 2500 ) ) ;
2026-03-02 13:18:47 -08:00
if ( aborted ) return ;
2026-03-01 19:33:03 -08:00
const retryToken = await getToken ( { skipCache : true } ) ;
2026-03-02 13:18:47 -08:00
if ( aborted ) return ;
2026-03-02 20:55:42 -08:00
if ( retryToken !== null ) {
revalidate ( ) ;
} else {
setAuthDegraded ( true ) ;
}
2026-03-01 19:33:03 -08:00
}
} catch {
try {
2026-03-02 20:55:42 -08:00
await new Promise ( ( r ) = > setTimeout ( r , 2500 ) ) ;
2026-03-02 13:18:47 -08:00
if ( aborted ) return ;
2026-03-01 19:33:03 -08:00
const retryToken = await getToken ( { skipCache : true } ) ;
2026-03-02 13:18:47 -08:00
if ( aborted ) return ;
2026-03-02 20:55:42 -08:00
if ( retryToken !== null ) {
revalidate ( ) ;
} else {
setAuthDegraded ( true ) ;
}
2026-03-01 19:33:03 -08:00
} catch {
2026-03-02 13:18:47 -08:00
if ( ! aborted ) setAuthDegraded ( true ) ;
2026-03-01 19:33:03 -08:00
}
2026-03-02 13:18:47 -08:00
} finally {
inFlight = false ;
2026-03-01 19:33:03 -08:00
}
} ;
document . addEventListener ( "visibilitychange" , handleVisibilityChange ) ;
2026-03-02 13:18:47 -08:00
return ( ) = > {
aborted = true ;
2026-03-01 19:33:03 -08:00
document . removeEventListener ( "visibilitychange" , handleVisibilityChange ) ;
2026-03-02 13:18:47 -08:00
} ;
2026-03-02 20:55:42 -08:00
} , [ clerkUserId , currentUserId , getToken , authDegraded , revalidate ] ) ;
2026-03-01 19:33:03 -08:00
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
// Track revalidation lifecycle to sync local state from fresh loader data.
//
// The problem: `picks` and `currentPick` are local state initialized once
// from useLoaderData(). When revalidate() runs after a reconnect, React
// Router re-fetches `draftPicks`/`season` — but those updates never flow
// back into the local useState copies automatically.
//
// Race condition: a `pick-made` socket event that arrives *during* the
// revalidation window would normally be applied to the stale prev state and
// then overwritten when we sync from the DB snapshot. We prevent that by
// buffering live picks while revalidation is in flight and merging them
// (deduplicated by ID) after the DB snapshot lands.
const revalidatorStateRef = useRef ( revalidatorState ) ;
const isRevalidatingRef = useRef ( false ) ;
2026-03-21 09:44:05 -07:00
const pendingPicksDuringRevalidationRef = useRef < ( typeof draftPicks ) [ number ] [ ] > ( [ ] ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Track the draftPicks reference when revalidation starts. If it hasn't
// changed by the time revalidation completes, the loader didn't return new
// data (e.g. network failure) and we should NOT overwrite state that may
// have been freshly set by draft-state-sync.
const draftPicksAtRevalidationStartRef = useRef ( draftPicks ) ;
2026-03-04 21:39:54 -08:00
// Same pattern for userQueue: only sync from loader if the reference changed,
// meaning the fetch actually returned fresh data. Prevents overwriting
// socket-applied queue changes (queue-updated, participant-removed-from-queues)
// with stale loader data when a revalidation fetch fails.
const userQueueAtRevalidationStartRef = useRef ( userQueue ) ;
// Tracks how many queue mutations are in-flight from this window. While > 0,
// incoming queue-updated socket events are ignored so that the server echo
// doesn't clobber a more-recent optimistic update (e.g. rapid drag-reorders).
// The initiating window uses the HTTP response as the authoritative state;
// other windows use the socket event.
const pendingQueueMutationsRef = useRef ( 0 ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
useEffect ( ( ) = > {
const prev = revalidatorStateRef . current ;
revalidatorStateRef . current = revalidatorState ;
if ( prev !== "loading" && revalidatorState === "loading" ) {
// Revalidation just started — buffer any live picks to avoid loss
isRevalidatingRef . current = true ;
pendingPicksDuringRevalidationRef . current = [ ] ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
draftPicksAtRevalidationStartRef . current = draftPicks ;
2026-03-04 21:39:54 -08:00
userQueueAtRevalidationStartRef . current = userQueue ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
} else if ( prev === "loading" && revalidatorState === "idle" ) {
// Revalidation just completed — merge DB snapshot with buffered picks
isRevalidatingRef . current = false ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// If draftPicks is the same reference as when revalidation started, the
// loader didn't actually update (likely a failed fetch). Skip the sync
// to avoid overwriting fresh draft-state-sync data with stale state.
if ( draftPicks === draftPicksAtRevalidationStartRef . current ) {
pendingPicksDuringRevalidationRef . current = [ ] ;
return ;
}
2026-03-21 09:44:05 -07:00
const dbPickIds = new Set ( draftPicks . map ( ( p ) = > p . id ) ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
const missedPicks = pendingPicksDuringRevalidationRef . current . filter (
2026-03-21 09:44:05 -07:00
( p ) = > ! dbPickIds . has ( p . id )
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
) ;
pendingPicksDuringRevalidationRef . current = [ ] ;
setPicks ( [ . . . draftPicks , . . . missedPicks ] ) ;
setCurrentPick ( season . currentPickNumber || 1 ) ;
setIsPaused ( season . draftPaused || false ) ;
setIsDraftComplete (
season . status === "active" || season . status === "completed"
) ;
2026-03-04 21:39:54 -08:00
// Sync the queue if the loader returned fresh data for it. Using reference
// equality (same pattern as draftPicks above): drizzle always returns a new
// array on a successful fetch, so a changed reference means the fetch
// succeeded and we can trust the value. A same reference means the fetch
// failed and we must NOT overwrite socket-applied changes (queue-updated,
// participant-removed-from-queues) with stale data.
2026-03-02 20:55:42 -08:00
//
2026-03-04 21:39:54 -08:00
// Guard: skip if the loader ran unauthenticated (currentUserId null) to avoid
// overwriting with an empty userQueue returned for an expired JWT session.
if ( currentUserId && userQueue !== userQueueAtRevalidationStartRef . current ) {
2026-03-02 20:55:42 -08:00
setQueue ( userQueue ) ;
}
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Sync timers — the server-side timer state may have changed while
// we were disconnected (time bank adjustments, new timers, etc.)
if ( timers . length > 0 ) {
Fix oxlint warnings: no-shadow, consistent-function-scoping, no-non-null-assertion, and others (#196)
* Fix no-shadow and consistent-function-scoping lint violations
Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.
no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).
consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix no-non-null-assertion lint violations and promote to error
Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.
Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers
Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.
- prefer-add-event-listener: converted onchange/onclick/onload
assignments to addEventListener in useDraftNotifications.ts and
admin.data-sync.tsx; stored changeHandler ref for proper cleanup
with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
side-effect imports (*.css, @testing-library/jest-dom,
@testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
cypress/support/e2e.ts (file already has an import)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix TypeScript errors from no-non-null-assertion fixes
Two fixes introduced by the non-null assertion cleanup produced type
errors:
- scoring-event.ts: `?? ""` was wrong type for a participant object map;
restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
truthy guarantee, causing TS18047 on the write-back block; added
`participant &&` guard before accessing its properties
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add npm run typecheck as Stop hook in Claude settings
Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-21 10:59:51 -07:00
setTeamTimers ( ( currentTimers ) = > {
const updated = { . . . currentTimers } ;
2026-03-21 09:44:05 -07:00
timers . forEach ( ( timer ) = > {
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
updated [ timer . teamId ] = timer . timeRemaining ;
} ) ;
return updated ;
} ) ;
}
// Sync autodraft settings — teams may have toggled autodraft while
// we were away.
setAutodraftStatus ( ( ) = > {
2026-03-03 20:14:38 -08:00
const status : Record < string , AutodraftStatusEntry > = { } ;
2026-03-21 09:44:05 -07:00
autodraftSettings . forEach ( ( setting ) = > {
2026-03-03 20:14:38 -08:00
status [ setting . teamId ] = {
isEnabled : setting.isEnabled ,
mode : setting.mode ,
queueOnly : setting.queueOnly ,
} ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
} ) ;
return status ;
} ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
}
2026-03-02 20:55:42 -08:00
} , [ revalidatorState , draftPicks , season , userQueue , timers , autodraftSettings , currentUserId ] ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
2025-10-17 12:30:58 -07:00
const [ picks , setPicks ] = useState ( draftPicks ) ;
const [ currentPick , setCurrentPick ] = useState ( season . currentPickNumber || 1 ) ;
2025-10-17 16:58:35 -07:00
const [ searchQuery , setSearchQuery ] = useState ( "" ) ;
const [ hideDrafted , setHideDrafted ] = useState ( true ) ;
2025-10-26 21:09:30 -07:00
const [ hideIneligible , setHideIneligible ] = useState ( true ) ;
2026-02-28 23:16:06 -08:00
const [ hideCompletedSports , setHideCompletedSports ] = useState ( false ) ;
2026-03-02 00:29:54 -08:00
const [ sportFilters , setSportFilters ] = useState < string [ ] > ( [ ] ) ;
2026-02-24 11:31:25 -08:00
const [ queue , setQueue ] = useState < QueueItem [ ] > ( userQueue ) ;
2025-10-18 23:19:41 -07:00
const [ isPaused , setIsPaused ] = useState ( season . draftPaused || false ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
const [ isDraftComplete , setIsDraftComplete ] = useState (
season . status === "active" || season . status === "completed"
) ;
2025-10-25 03:23:41 -07:00
// Sidebar and tabs state
const [ sidebarCollapsed , setSidebarCollapsed ] = useState ( ( ) = > {
if ( typeof window === "undefined" ) return false ;
const stored = localStorage . getItem ( "draftSidebarCollapsed" ) ;
return stored ? JSON . parse ( stored ) : false ;
} ) ;
2026-03-02 16:46:35 -08:00
const [ activeTab , setActiveTab ] = useState < "participants" | "board" | "rosters" | "summary" > ( "board" ) ;
const [ mobileTab , setMobileTab ] = useState < "available" | "queue" | "board" | "teams" | "controls" > (
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
! userTeam && isCommissioner ? "board" : "available"
2026-02-22 22:36:12 -08:00
) ;
2026-03-02 16:46:35 -08:00
const [ teamsSubTab , setTeamsSubTab ] = useState < "rosters" | "summary" > ( "rosters" ) ;
2026-02-22 22:36:12 -08:00
const isMobile = useMediaQuery ( "(max-width: 767px)" ) ;
2025-10-25 03:23:41 -07:00
2025-10-21 23:22:17 -07:00
// Track autodraft status for all teams
2026-03-03 20:14:38 -08:00
const [ autodraftStatus , setAutodraftStatus ] = useState < Record < string , AutodraftStatusEntry > > ( ( ) = > {
const status : Record < string , AutodraftStatusEntry > = { } ;
2026-03-21 09:44:05 -07:00
autodraftSettings . forEach ( ( setting ) = > {
2026-03-03 20:14:38 -08:00
status [ setting . teamId ] = {
isEnabled : setting.isEnabled ,
mode : setting.mode ,
queueOnly : setting.queueOnly ,
} ;
2025-10-21 23:22:17 -07:00
} ) ;
return status ;
} ) ;
// Track connected teams
const [ connectedTeams , setConnectedTeams ] = useState < Set < string > > ( new Set ( ) ) ;
2025-10-18 23:13:04 -07:00
const [ teamTimers , setTeamTimers ] = useState < Record < string , number > > ( ( ) = > {
2025-10-20 15:03:11 -07:00
// Initialize with timers from loader data, or use initial time if draft hasn't started
2025-10-18 23:13:04 -07:00
const timersMap : Record < string , number > = { } ;
2025-10-20 15:03:11 -07:00
const initialTime = season . draftInitialTime || 120 ;
if ( timers . length > 0 ) {
// Draft has started, use actual timers
2026-03-21 09:44:05 -07:00
timers . forEach ( ( timer ) = > {
2025-10-20 15:03:11 -07:00
timersMap [ timer . teamId ] = timer . timeRemaining ;
} ) ;
} else {
// Draft hasn't started, show initial time for all teams
draftSlots . forEach ( ( slot ) = > {
timersMap [ slot . team . id ] = initialTime ;
} ) ;
}
2025-10-18 23:13:04 -07:00
return timersMap ;
} ) ;
2025-10-18 14:55:26 -07:00
const [ forcePickDialogOpen , setForcePickDialogOpen ] = useState ( false ) ;
const [ selectedPickSlot , setSelectedPickSlot ] = useState < {
pickNumber : number ;
teamId : string ;
} | null > ( null ) ;
2026-02-20 22:47:29 -08:00
// Replace pick dialog state
const [ replacePickDialogOpen , setReplacePickDialogOpen ] = useState ( false ) ;
const [ replacePickSlot , setReplacePickSlot ] = useState < {
pickNumber : number ;
teamId : string ;
oldParticipantId : string ;
} | null > ( null ) ;
// Rollback confirm dialog state
const [ rollbackConfirmOpen , setRollbackConfirmOpen ] = useState ( false ) ;
const [ rollbackPickNumber , setRollbackPickNumber ] = useState < number | null > ( null ) ;
const [ isRollingBack , setIsRollingBack ] = useState ( false ) ;
2026-02-22 16:16:51 -08:00
// Time bank adjustment dialog state
const [ timeBankDialogOpen , setTimeBankDialogOpen ] = useState ( false ) ;
const [ timeBankTeamId , setTimeBankTeamId ] = useState < string | null > ( null ) ;
2026-03-03 20:14:38 -08:00
const [ commissionerAutodraftDialogOpen , setCommissionerAutodraftDialogOpen ] = useState ( false ) ;
const [ commissionerAutodraftTeamId , setCommissionerAutodraftTeamId ] = useState < string | null > ( null ) ;
2026-02-22 16:16:51 -08:00
const [ timeBankAmount , setTimeBankAmount ] = useState ( "1" ) ;
const [ timeBankUnit , setTimeBankUnit ] = useState < "seconds" | "minutes" | "hours" > ( "minutes" ) ;
const [ timeBankDirection , setTimeBankDirection ] = useState < "add" | "remove" > ( "add" ) ;
const [ isAdjustingTimeBank , setIsAdjustingTimeBank ] = useState ( false ) ;
2026-02-20 21:10:26 -08:00
// Shared transforms for eligibility calculations
const transformedPicks = useMemo (
( ) = >
2026-03-21 09:44:05 -07:00
picks . map ( ( p ) = > ( {
2026-02-20 21:10:26 -08:00
teamId : p.team.id ,
participant : {
id : p.participant.id ,
sport : { id : p.sport.id , name : p.sport.name } ,
2025-10-24 21:12:07 -07:00
} ,
2026-02-20 21:10:26 -08:00
} ) ) ,
[ picks ]
) ;
2025-10-24 21:12:07 -07:00
2026-02-20 21:10:26 -08:00
const transformedParticipants = useMemo (
( ) = >
2026-03-21 09:44:05 -07:00
availableParticipants . map ( ( p ) = > ( {
2026-02-20 21:10:26 -08:00
id : p.id ,
sport : { id : p.sport.id , name : p.sport.name } ,
} ) ) ,
[ availableParticipants ]
) ;
2025-10-24 21:12:07 -07:00
2026-02-20 21:10:26 -08:00
const seasonSportsData = useMemo ( ( ) = > {
const sportsMap = new Map < string , { id : string ; name : string } > ( ) ;
2026-02-20 21:26:27 -08:00
availableParticipants . forEach ( ( p ) = > {
2025-10-24 21:12:07 -07:00
if ( ! sportsMap . has ( p . sport . id ) ) {
sportsMap . set ( p . sport . id , { id : p.sport.id , name : p.sport.name } ) ;
}
} ) ;
2026-03-21 09:44:05 -07:00
return Array . from ( sportsMap . values ( ) ) . toSorted ( ( a , b ) = >
2026-02-20 21:26:27 -08:00
a . name . localeCompare ( b . name )
) ;
2026-02-20 21:10:26 -08:00
} , [ availableParticipants ] ) ;
2025-10-24 21:12:07 -07:00
2026-02-20 21:10:26 -08:00
// Calculate draft eligibility for current user's team
const eligibility = useMemo ( ( ) = > {
if ( ! userTeam ) return null ;
const userTeamPicks = transformedPicks . filter (
2026-03-21 09:44:05 -07:00
( p ) = > p . teamId === userTeam . id
2026-02-20 21:10:26 -08:00
) ;
2025-10-24 21:12:07 -07:00
return calculateDraftEligibility (
userTeam . id ,
userTeamPicks ,
transformedPicks ,
transformedParticipants ,
seasonSportsData ,
season . draftRounds ,
season . teams
) ;
2026-02-20 21:10:26 -08:00
} , [ userTeam , transformedPicks , transformedParticipants , seasonSportsData , season ] ) ;
2025-10-24 21:12:07 -07:00
// Calculate eligibility for force manual pick dialog (selected team)
const forcePickEligibility = useMemo ( ( ) = > {
if ( ! selectedPickSlot ) return null ;
const selectedTeamPicks = transformedPicks . filter (
2026-03-21 09:44:05 -07:00
( p ) = > p . teamId === selectedPickSlot . teamId
2025-10-24 21:12:07 -07:00
) ;
return calculateDraftEligibility (
selectedPickSlot . teamId ,
selectedTeamPicks ,
transformedPicks ,
transformedParticipants ,
seasonSportsData ,
season . draftRounds ,
season . teams
) ;
2026-02-20 21:10:26 -08:00
} , [ selectedPickSlot , transformedPicks , transformedParticipants , seasonSportsData , season ] ) ;
2025-10-24 21:12:07 -07:00
2026-02-20 22:47:29 -08:00
// Calculate eligibility for replace pick dialog — exclude the old pick so its slot is free
const replacePickEligibility = useMemo ( ( ) = > {
if ( ! replacePickSlot ) return null ;
const allPicksExcluding = transformedPicks . filter (
2026-03-21 09:44:05 -07:00
( p ) = > p . participant . id !== replacePickSlot . oldParticipantId
2026-02-20 22:47:29 -08:00
) ;
const selectedTeamPicks = allPicksExcluding . filter (
2026-03-21 09:44:05 -07:00
( p ) = > p . teamId === replacePickSlot . teamId
2026-02-20 22:47:29 -08:00
) ;
return calculateDraftEligibility (
replacePickSlot . teamId ,
selectedTeamPicks ,
allPicksExcluding ,
transformedParticipants ,
seasonSportsData ,
season . draftRounds ,
season . teams
) ;
} , [ replacePickSlot , transformedPicks , transformedParticipants , seasonSportsData , season ] ) ;
2025-10-17 12:30:58 -07:00
// Listen for new picks from other users
useEffect ( ( ) = > {
2026-03-21 09:44:05 -07:00
type PickMadePayload = { pick : ( typeof draftPicks ) [ number ] & { team ? : { id? : string ; name? : string } ; participant ? : { name? : string } } ; nextPickNumber : number ; isDraftComplete? : boolean } ;
const handlePickMade = ( data : PickMadePayload ) = > {
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
if ( isRevalidatingRef . current ) {
// Buffer this pick; the revalidation-complete handler will merge it
// into the DB snapshot so it isn't silently dropped.
// Don't update currentPick either — the sync effect will set it from
// fresh season.currentPickNumber once loading → idle, keeping the
// pick counter and the picks list in sync with each other.
pendingPicksDuringRevalidationRef . current . push ( data . pick ) ;
} else {
2026-03-21 09:44:05 -07:00
setPicks ( ( prev ) = > [ . . . prev , data . pick ] ) ;
fix: fully sync local draft state after socket reconnection (#41)
On reconnect, revalidate() re-fetches fresh loader data but the local
useState copies (picks, currentPick, isPaused, isDraftComplete, queue)
never synced with the new values — leaving the UI stale until a manual
refresh.
- Watch revalidatorState (idle→loading→idle) to detect when a
revalidation completes and apply the fresh loader snapshot to all
affected local state
- Buffer pick-made socket events received during the revalidation window
(instead of discarding or double-applying them); merge into the DB
snapshot on completion, deduplicated by pick ID
- Keep setCurrentPick paired with setPicks in handlePickMade so the
"on the clock" indicator and the picks list never desync
- Sync queue state from fresh userQueue after revalidation so
participants drafted while the user was away disappear from their
queue even if the participant-removed-from-queues events were missed
Adds useDraftSocket reconnect test suite (9 tests) covering initial
connect, socket reconnect, visibility-change triggering, network
flapping, error exhaustion, and cleanup.
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-27 22:50:46 -08:00
setCurrentPick ( data . nextPickNumber ) ;
}
2026-02-20 19:30:53 -08:00
// No meaningful "next turn" notification once the draft is over
if ( data . isDraftComplete ) return ;
const notifTitle = ` ${ season . league . name } Draft ` ;
const nextSlot = getTeamForPick ( data . nextPickNumber , draftSlots ) ;
const isNowMyTurn = ! ! (
userTeam && nextSlot && nextSlot . team . id === userTeam . id
) ;
if ( isNowMyTurn ) {
sendNotificationRef . current ( notifTitle , ` It's your turn to pick! ` ) ;
} else if (
notificationsModeRef . current === "all_picks" &&
data . pick ? . team ? . id !== userTeam ? . id
) {
// Only notify about other teams' picks, not the user's own
const pickerName = data . pick ? . team ? . name || "A team" ;
const participantName = data . pick ? . participant ? . name || "a participant" ;
sendNotificationRef . current (
notifTitle ,
` ${ pickerName } picked ${ participantName } `
) ;
}
2025-10-17 12:30:58 -07:00
} ;
2026-03-21 09:44:05 -07:00
const handleTimerUpdate = ( data : { teamId : string ; timeRemaining : number ; currentPickNumber : number | null } ) = > {
2026-03-02 13:18:47 -08:00
// Bail out without creating a new object reference if nothing changed.
// Without this guard the spread `{ ...prev }` always returns a new object,
// causing a full re-render of the DraftRoom tree on every 1-second tick.
setTeamTimers ( ( prev ) = > {
if ( prev [ data . teamId ] === data . timeRemaining ) return prev ;
return { . . . prev , [ data . teamId ] : data . timeRemaining } ;
} ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Also sync the current pick number from the server. This is critical
// for mobile reconnection: timer-update events arrive every second, so
// this ensures currentPick is correct within 1s of reconnecting — even
// if the HTTP revalidation hasn't completed yet.
2026-03-02 13:18:47 -08:00
// React's useState already bails out when the new value equals the old
// one (Object.is comparison on primitives), so no manual guard needed.
2026-03-21 09:44:05 -07:00
if ( data . currentPickNumber !== null ) {
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
setCurrentPick ( data . currentPickNumber ) ;
}
2025-10-18 14:55:26 -07:00
} ;
2025-10-18 23:19:41 -07:00
const handleDraftPaused = ( ) = > {
setIsPaused ( true ) ;
} ;
const handleDraftResumed = ( ) = > {
setIsPaused ( false ) ;
} ;
2025-10-18 23:33:13 -07:00
const handleDraftCompleted = ( ) = > {
setIsDraftComplete ( true ) ;
} ;
2026-03-03 20:14:38 -08:00
const handleAutodraftUpdated = ( data : {
teamId : string ;
isEnabled : boolean ;
mode : "next_pick" | "while_on" ;
queueOnly : boolean ;
source ? : "commissioner" | "user" ;
} ) = > {
2025-10-21 23:22:17 -07:00
setAutodraftStatus ( ( prev ) = > ( {
. . . prev ,
2026-03-03 20:14:38 -08:00
[ data . teamId ] : { isEnabled : data.isEnabled , mode : data.mode , queueOnly : data.queueOnly } ,
2025-10-21 23:22:17 -07:00
} ) ) ;
// Update user's local state if it's their team
if ( userTeam && data . teamId === userTeam . id ) {
2026-03-03 20:14:38 -08:00
if ( data . source === "commissioner" ) {
if ( ! data . isEnabled ) {
toast . info ( "Commissioner turned off your autodraft" ) ;
} else {
toast . info ( ` Commissioner changed your autodraft to " ${ getAutodraftLabel ( data . isEnabled , data . mode , data . queueOnly ) } " ` ) ;
}
} else {
// Detect server-side auto-disable: was enabled with queueOnly, now disabled
const prev = userAutodraftRef . current ;
if ( ! data . isEnabled && prev . isEnabled && prev . queueOnly && prev . mode === "while_on" ) {
toast . info ( "Autodraft disabled — your queue is empty" ) ;
}
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
}
2025-10-21 23:22:17 -07:00
setUserAutodraft ( {
isEnabled : data.isEnabled ,
mode : data.mode ,
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
queueOnly : data.queueOnly ,
2025-10-21 23:22:17 -07:00
} ) ;
}
} ;
const handleTeamConnected = ( data : { teamId : string } ) = > {
setConnectedTeams ( ( prev ) = > new Set ( prev ) . add ( data . teamId ) ) ;
} ;
const handleTeamDisconnected = ( data : { teamId : string } ) = > {
setConnectedTeams ( ( prev ) = > {
const newSet = new Set ( prev ) ;
newSet . delete ( data . teamId ) ;
return newSet ;
} ) ;
} ;
2025-10-24 21:31:57 -07:00
const handleConnectedTeamsList = ( data : { teamIds : string [ ] } ) = > {
setConnectedTeams ( new Set ( data . teamIds ) ) ;
} ;
2025-10-24 21:46:55 -07:00
const handleParticipantRemovedFromQueues = ( data : { participantId : string } ) = > {
2026-03-21 09:44:05 -07:00
setQueue ( ( prev ) = >
prev . filter ( ( item ) = > item . participantId !== data . participantId )
2025-10-24 21:46:55 -07:00
) ;
} ;
feat: proactively prune ineligible queue items after each pick (#59)
After every pick, recalculate draft eligibility for all teams and
remove any queued participants whose sport is no longer eligible
(e.g. a team queued a snooker player but just filled their last flex
slot). Previously this was only caught lazily when autodraft fired,
which could pause the draft or pick an unwanted player.
- Add getAllQueuesForSeason to draft-queue.ts — fetches all queue rows
for a season in one query (Map<teamId, QueueItem[]>) instead of N+1
per-team queries
- Add pruneIneligibleQueueItems to draft-utils.ts — uses Promise.all
for the four required data fetches, collects ineligible items in a
single loop pass, warns on orphaned participant references
- Call from both pick paths: executeAutoPick and draft.make-pick.ts
- Emit queue-eligibility-pruned socket event per affected team so the
client updates the queue UI in real time
- Add 5 tests covering: single ineligible removal, all eligible (no-op),
empty queues (no delete called, getTeamQueue never called), mixed
queue (only ineligible item removed), and unknown participant (warn)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-02 22:07:22 -08:00
const handleQueueEligibilityPruned = ( data : { teamId : string ; removedParticipantIds : string [ ] } ) = > {
if ( data . teamId !== userTeam ? . id ) return ;
const removed = new Set ( data . removedParticipantIds ) ;
2026-03-21 09:44:05 -07:00
setQueue ( ( prev ) = > prev . filter ( ( item ) = > ! removed . has ( item . participantId ) ) ) ;
feat: proactively prune ineligible queue items after each pick (#59)
After every pick, recalculate draft eligibility for all teams and
remove any queued participants whose sport is no longer eligible
(e.g. a team queued a snooker player but just filled their last flex
slot). Previously this was only caught lazily when autodraft fired,
which could pause the draft or pick an unwanted player.
- Add getAllQueuesForSeason to draft-queue.ts — fetches all queue rows
for a season in one query (Map<teamId, QueueItem[]>) instead of N+1
per-team queries
- Add pruneIneligibleQueueItems to draft-utils.ts — uses Promise.all
for the four required data fetches, collects ineligible items in a
single loop pass, warns on orphaned participant references
- Call from both pick paths: executeAutoPick and draft.make-pick.ts
- Emit queue-eligibility-pruned socket event per affected team so the
client updates the queue UI in real time
- Add 5 tests covering: single ineligible removal, all eligible (no-op),
empty queues (no delete called, getTeamQueue never called), mixed
queue (only ineligible item removed), and unknown participant (warn)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-02 22:07:22 -08:00
} ;
2026-03-04 21:39:54 -08:00
// Fired when another window/session changes the user's queue (add/remove/reorder/clear).
// Only received by this team's own sockets (emitted to team-${teamId} private room).
// Ignored while this window has in-flight mutations to prevent the server echo
// from clobbering a more-recent optimistic update.
2026-03-21 09:44:05 -07:00
const handleQueueUpdated = ( data : { queue : QueueItem [ ] } ) = > {
2026-03-04 21:39:54 -08:00
if ( pendingQueueMutationsRef . current > 0 ) return ;
setQueue ( data . queue ) ;
} ;
2026-03-21 09:44:05 -07:00
const handlePickReplaced = ( data : { pickNumber : number ; pick : ( typeof draftPicks ) [ number ] } ) = > {
setPicks ( ( prev ) = >
prev . map ( ( p ) = > ( p . pickNumber === data . pickNumber ? data.pick : p ) )
2026-02-20 22:47:29 -08:00
) ;
} ;
2026-03-21 09:44:05 -07:00
const handleDraftRolledBack = ( data : { pickNumber : number } ) = > {
setPicks ( ( prev ) = >
prev . filter ( ( p ) = > p . pickNumber < data . pickNumber )
2026-02-20 22:47:29 -08:00
) ;
setCurrentPick ( data . pickNumber ) ;
setIsDraftComplete ( false ) ;
setIsPaused ( false ) ;
} ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// Full state sync sent by the server on join-draft. Provides an immediate,
// socket-based path to bring the client up to date — critical for mobile
// reconnection where the HTTP revalidation may be delayed or fail entirely.
2026-03-21 09:44:05 -07:00
const handleDraftStateSync = ( data : { picks : ( typeof draftPicks ) [ number ] [ ] ; currentPickNumber : number ; isPaused : boolean ; status : string ; timers? : Array < { teamId : string ; timeRemaining : number } > ; queue? : QueueItem [ ] } ) = > {
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
// If a revalidation is in-flight, let it complete and handle the merge.
// The revalidation path already buffers picks and deduplicates — layering
// this on top would risk conflicts. But if NOT revalidating, apply the
// server snapshot directly.
if ( ! isRevalidatingRef . current ) {
setPicks ( data . picks ) ;
setCurrentPick ( data . currentPickNumber ) ;
setIsPaused ( data . isPaused ) ;
setIsDraftComplete (
data . status === "active" || data . status === "completed"
) ;
if ( data . timers ) {
setTeamTimers ( ( prev ) = > {
const updated = { . . . prev } ;
2026-03-21 09:44:05 -07:00
data . timers ? . forEach ( ( t ) = > {
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
updated [ t . teamId ] = t . timeRemaining ;
} ) ;
return updated ;
} ) ;
}
2026-03-04 21:39:54 -08:00
if ( data . queue ) {
setQueue ( data . queue ) ;
}
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
}
} ;
2025-10-17 12:30:58 -07:00
on ( "pick-made" , handlePickMade ) ;
2025-10-18 14:55:26 -07:00
on ( "timer-update" , handleTimerUpdate ) ;
2025-10-18 23:19:41 -07:00
on ( "draft-paused" , handleDraftPaused ) ;
on ( "draft-resumed" , handleDraftResumed ) ;
2025-10-18 23:33:13 -07:00
on ( "draft-completed" , handleDraftCompleted ) ;
2025-10-21 23:22:17 -07:00
on ( "autodraft-updated" , handleAutodraftUpdated ) ;
on ( "team-connected" , handleTeamConnected ) ;
on ( "team-disconnected" , handleTeamDisconnected ) ;
2025-10-24 21:31:57 -07:00
on ( "connected-teams-list" , handleConnectedTeamsList ) ;
2025-10-24 21:46:55 -07:00
on ( "participant-removed-from-queues" , handleParticipantRemovedFromQueues ) ;
feat: proactively prune ineligible queue items after each pick (#59)
After every pick, recalculate draft eligibility for all teams and
remove any queued participants whose sport is no longer eligible
(e.g. a team queued a snooker player but just filled their last flex
slot). Previously this was only caught lazily when autodraft fired,
which could pause the draft or pick an unwanted player.
- Add getAllQueuesForSeason to draft-queue.ts — fetches all queue rows
for a season in one query (Map<teamId, QueueItem[]>) instead of N+1
per-team queries
- Add pruneIneligibleQueueItems to draft-utils.ts — uses Promise.all
for the four required data fetches, collects ineligible items in a
single loop pass, warns on orphaned participant references
- Call from both pick paths: executeAutoPick and draft.make-pick.ts
- Emit queue-eligibility-pruned socket event per affected team so the
client updates the queue UI in real time
- Add 5 tests covering: single ineligible removal, all eligible (no-op),
empty queues (no delete called, getTeamQueue never called), mixed
queue (only ineligible item removed), and unknown participant (warn)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-02 22:07:22 -08:00
on ( "queue-eligibility-pruned" , handleQueueEligibilityPruned ) ;
2026-03-04 21:39:54 -08:00
on ( "queue-updated" , handleQueueUpdated ) ;
2026-02-20 22:47:29 -08:00
on ( "pick-replaced" , handlePickReplaced ) ;
on ( "draft-rolled-back" , handleDraftRolledBack ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
on ( "draft-state-sync" , handleDraftStateSync ) ;
2025-10-17 12:30:58 -07:00
return ( ) = > {
off ( "pick-made" , handlePickMade ) ;
2025-10-18 14:55:26 -07:00
off ( "timer-update" , handleTimerUpdate ) ;
2025-10-18 23:19:41 -07:00
off ( "draft-paused" , handleDraftPaused ) ;
off ( "draft-resumed" , handleDraftResumed ) ;
2025-10-18 23:33:13 -07:00
off ( "draft-completed" , handleDraftCompleted ) ;
2025-10-21 23:22:17 -07:00
off ( "autodraft-updated" , handleAutodraftUpdated ) ;
off ( "team-connected" , handleTeamConnected ) ;
off ( "team-disconnected" , handleTeamDisconnected ) ;
2025-10-24 21:31:57 -07:00
off ( "connected-teams-list" , handleConnectedTeamsList ) ;
2025-10-24 21:46:55 -07:00
off ( "participant-removed-from-queues" , handleParticipantRemovedFromQueues ) ;
feat: proactively prune ineligible queue items after each pick (#59)
After every pick, recalculate draft eligibility for all teams and
remove any queued participants whose sport is no longer eligible
(e.g. a team queued a snooker player but just filled their last flex
slot). Previously this was only caught lazily when autodraft fired,
which could pause the draft or pick an unwanted player.
- Add getAllQueuesForSeason to draft-queue.ts — fetches all queue rows
for a season in one query (Map<teamId, QueueItem[]>) instead of N+1
per-team queries
- Add pruneIneligibleQueueItems to draft-utils.ts — uses Promise.all
for the four required data fetches, collects ineligible items in a
single loop pass, warns on orphaned participant references
- Call from both pick paths: executeAutoPick and draft.make-pick.ts
- Emit queue-eligibility-pruned socket event per affected team so the
client updates the queue UI in real time
- Add 5 tests covering: single ineligible removal, all eligible (no-op),
empty queues (no delete called, getTeamQueue never called), mixed
queue (only ineligible item removed), and unknown participant (warn)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-02 22:07:22 -08:00
off ( "queue-eligibility-pruned" , handleQueueEligibilityPruned ) ;
2026-03-04 21:39:54 -08:00
off ( "queue-updated" , handleQueueUpdated ) ;
2026-02-20 22:47:29 -08:00
off ( "pick-replaced" , handlePickReplaced ) ;
off ( "draft-rolled-back" , handleDraftRolledBack ) ;
fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms (#48)
* fix: sync all draft state on mobile reconnection
After a mobile browser returns from a long background period, the draft
room had stale picks, wrong "on the clock" display, and inaccurate
available player lists. The root cause was that reconnection relied
solely on an HTTP revalidation that could fail (expired JWT, flaky
network), and the timer-update handler ignored currentPickNumber.
Changes:
- Server emits draft-state-sync on join-draft with full picks, timers,
and season state, giving the client an immediate socket-based sync
path that doesn't depend on HTTP revalidation
- timer-update handler now syncs currentPickNumber, fixing the "on the
clock" display within 1 second of reconnection
- Revalidation retry with 3s delay ensures the HTTP path succeeds even
when the network is slow to stabilize on mobile return
- Revalidation completion now also syncs teamTimers and autodraftStatus
- Added draft-state-sync client handler that applies the server snapshot
immediately (skipped when revalidation is in-flight to avoid conflicts)
Tests: 32 new tests covering reconnection sync, pick buffering/merge,
timer-update currentPickNumber sync, draft-state-sync handling,
available player filtering, on-the-clock correctness, and revalidation
retry logic.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
* fix: guard against stale revalidation overwriting fresh socket data
Add a reference-equality check so that if HTTP revalidation fails (network
error, expired token), the sync effect does not overwrite fresh data that
draft-state-sync already applied. Also adds missing dependency array entries
(userQueue, timers, autodraftSettings) to the revalidation sync effect.
https://claude.ai/code/session_01JxJ1CYTiFWV4KTPxTnjrms
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-03-01 12:23:24 -08:00
off ( "draft-state-sync" , handleDraftStateSync ) ;
2025-10-17 12:30:58 -07:00
} ;
2026-03-02 13:18:47 -08:00
// `on`/`off` are stable useCallback refs. `socketVersion` increments whenever
// useDraftSocket creates a new socket instance, ensuring this effect re-runs
// and re-registers all handlers on the fresh socket.
// `draftSlots`, `userTeam`, and `season.league.name` are intentionally omitted:
// they come from useLoaderData and are immutable for the lifetime of the page load.
2026-02-24 12:24:04 -08:00
// eslint-disable-next-line react-hooks/exhaustive-deps
2026-03-02 13:18:47 -08:00
} , [ on , off , socketVersion ] ) ;
2025-10-17 12:30:58 -07:00
2025-10-25 03:23:41 -07:00
// Persist sidebar collapsed state
useEffect ( ( ) = > {
if ( typeof window !== "undefined" ) {
localStorage . setItem ( "draftSidebarCollapsed" , JSON . stringify ( sidebarCollapsed ) ) ;
}
} , [ sidebarCollapsed ] ) ;
2025-10-17 17:42:40 -07:00
// Queue handlers
2026-03-02 13:18:47 -08:00
const handleAddToQueue = useCallback ( async ( participantId : string ) = > {
2025-10-17 17:42:40 -07:00
if ( ! userTeam ) return ;
2025-10-25 21:02:16 -07:00
// Check if participant is already in queue (client-side)
2026-02-24 11:31:25 -08:00
const alreadyInQueue = queue . some ( ( item ) = > item . participantId === participantId ) ;
2025-10-25 21:02:16 -07:00
if ( alreadyInQueue ) {
toast . error ( "This participant is already in your queue" ) ;
return ;
}
// Optimistic update - create a temporary queue item
2026-02-24 11:31:25 -08:00
const now = new Date ( ) ;
const tempQueueItem : QueueItem = {
id : ` temp- ${ Date . now ( ) } ` ,
2025-10-25 21:02:16 -07:00
participantId ,
queuePosition : queue.length + 1 ,
2026-02-24 11:31:25 -08:00
seasonId : season.id ,
teamId : userTeam.id ,
createdAt : now ,
updatedAt : now ,
2025-10-25 21:02:16 -07:00
} ;
// Immediately update the UI
2026-02-24 11:31:25 -08:00
setQueue ( ( prev ) = > [ . . . prev , tempQueueItem ] ) ;
2025-10-25 21:02:16 -07:00
2025-10-17 17:42:40 -07:00
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "teamId" , userTeam . id ) ;
formData . append ( "participantId" , participantId ) ;
2026-03-04 21:39:54 -08:00
pendingQueueMutationsRef . current ++ ;
2025-10-25 21:02:16 -07:00
try {
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/queue/add" , {
2025-10-25 21:02:16 -07:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) { setQueue ( ( prev ) = > prev . filter ( ( item ) = > item . id !== tempQueueItem . id ) ) ; return ; }
2025-10-17 17:42:40 -07:00
2025-10-25 21:02:16 -07:00
if ( response . ok ) {
const data = await response . json ( ) ;
// Replace temp item with real item from server
2026-02-24 11:31:25 -08:00
setQueue ( ( prev ) = >
prev . map ( ( item ) = >
2025-10-25 21:02:16 -07:00
item . id === tempQueueItem . id ? data.queueItem : item
)
) ;
} else {
// Revert the optimistic update on error
2026-02-24 11:31:25 -08:00
setQueue ( ( prev ) = > prev . filter ( ( item ) = > item . id !== tempQueueItem . id ) ) ;
2025-10-25 21:02:16 -07:00
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to add to queue" ) ;
}
2026-03-21 09:44:05 -07:00
} catch {
2025-10-25 21:02:16 -07:00
// Revert the optimistic update on network error
2026-02-24 11:31:25 -08:00
setQueue ( ( prev ) = > prev . filter ( ( item ) = > item . id !== tempQueueItem . id ) ) ;
2025-10-25 21:02:16 -07:00
toast . error ( "Network error - failed to add to queue" ) ;
2026-03-04 21:39:54 -08:00
} finally {
pendingQueueMutationsRef . current -- ;
2025-10-17 17:42:40 -07:00
}
2026-03-02 13:18:47 -08:00
// queue is read directly (not via functional updater) for the duplicate check and
// optimistic position, so it must be a dep. This is fine: AvailableParticipantsSection
// already re-renders when queue changes (it receives queue as a prop).
} , [ userTeam , queue , season . id , authFetch ] ) ;
2025-10-17 17:42:40 -07:00
2026-03-02 13:18:47 -08:00
const handleRemoveFromQueue = useCallback ( async ( queueId : string ) = > {
2025-10-17 17:42:40 -07:00
if ( ! userTeam ) return ;
2026-02-24 11:31:25 -08:00
// Optimistically remove the item immediately
let previousQueue : QueueItem [ ] = [ ] ;
setQueue ( ( prev ) = > {
previousQueue = prev ;
return prev . filter ( ( item ) = > item . id !== queueId ) ;
} ) ;
2025-10-17 17:42:40 -07:00
const formData = new FormData ( ) ;
formData . append ( "queueId" , queueId ) ;
formData . append ( "teamId" , userTeam . id ) ;
2026-03-04 21:39:54 -08:00
pendingQueueMutationsRef . current ++ ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
try {
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/queue/remove" , {
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) { setQueue ( previousQueue ) ; return ; }
2025-10-17 17:42:40 -07:00
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
if ( response . ok ) {
const data = await response . json ( ) ;
setQueue ( data . queue ) ;
} else {
2026-02-24 11:31:25 -08:00
setQueue ( previousQueue ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to remove from queue" ) ;
}
} catch {
2026-02-24 11:31:25 -08:00
setQueue ( previousQueue ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
toast . error ( "Network error - failed to remove from queue" ) ;
2026-03-04 21:39:54 -08:00
} finally {
pendingQueueMutationsRef . current -- ;
2025-10-17 17:42:40 -07:00
}
2026-03-02 13:18:47 -08:00
} , [ userTeam , authFetch ] ) ;
2025-10-17 17:42:40 -07:00
2026-03-02 13:18:47 -08:00
const handleReorderQueue = useCallback ( async ( participantIds : string [ ] ) = > {
2025-10-17 17:42:40 -07:00
if ( ! userTeam ) return ;
2026-02-24 11:31:25 -08:00
// Optimistically reorder the queue immediately
let previousQueue : QueueItem [ ] = [ ] ;
setQueue ( ( prev ) = > {
previousQueue = prev ;
return participantIds
. map ( ( pid ) = > prev . find ( ( item ) = > item . participantId === pid ) )
. filter ( ( item ) : item is QueueItem = > item !== undefined ) ;
} ) ;
2025-10-17 17:42:40 -07:00
const formData = new FormData ( ) ;
formData . append ( "teamId" , userTeam . id ) ;
2025-10-25 21:02:16 -07:00
formData . append ( "seasonId" , season . id ) ;
formData . append ( "participantIds" , JSON . stringify ( participantIds ) ) ;
2025-10-17 17:42:40 -07:00
2026-03-04 21:39:54 -08:00
pendingQueueMutationsRef . current ++ ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
try {
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/queue/reorder" , {
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) { setQueue ( previousQueue ) ; return ; }
2025-10-17 17:42:40 -07:00
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
if ( response . ok ) {
const data = await response . json ( ) ;
setQueue ( data . queue ) ;
} else {
const error = await response . json ( ) ;
2026-02-24 11:31:25 -08:00
setQueue ( previousQueue ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
toast . error ( error . error || "Failed to reorder queue" ) ;
}
} catch {
2026-02-24 11:31:25 -08:00
setQueue ( previousQueue ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
toast . error ( "Network error - failed to reorder queue" ) ;
2026-03-04 21:39:54 -08:00
} finally {
pendingQueueMutationsRef . current -- ;
2025-10-17 17:42:40 -07:00
}
2026-03-02 13:18:47 -08:00
} , [ userTeam , season . id , authFetch ] ) ;
2025-10-17 17:42:40 -07:00
2025-10-18 14:55:26 -07:00
const handleStartDraft = async ( ) = > {
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/start" , {
method : "POST" ,
body : formData ,
} ) ;
if ( ! response ) return ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
if ( response . ok ) {
revalidate ( ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to start draft" ) ;
}
} catch {
toast . error ( "Network error - failed to start draft" ) ;
2025-10-18 14:55:26 -07:00
}
} ;
2025-10-18 23:19:41 -07:00
const handlePauseDraft = async ( ) = > {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
try {
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/pause" , {
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) return ;
2025-10-18 23:19:41 -07:00
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
if ( response . ok ) {
setIsPaused ( true ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to pause draft" ) ;
}
} catch {
toast . error ( "Network error - failed to pause draft" ) ;
2025-10-18 23:19:41 -07:00
}
} ;
const handleResumeDraft = async ( ) = > {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
try {
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/resume" , {
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) return ;
2025-10-18 23:19:41 -07:00
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
if ( response . ok ) {
setIsPaused ( false ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to resume draft" ) ;
}
} catch {
toast . error ( "Network error - failed to resume draft" ) ;
2025-10-18 23:19:41 -07:00
}
} ;
2026-03-02 13:18:47 -08:00
const handleMakePick = useCallback ( async ( participantId : string ) = > {
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "participantId" , participantId ) ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/make-pick" , {
method : "POST" ,
body : formData ,
} ) ;
if ( ! response ) return ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
if ( ! response . ok ) {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to make pick" ) ;
}
} catch {
toast . error ( "Network error - failed to make pick" ) ;
2025-10-18 14:55:26 -07:00
}
2026-03-02 13:18:47 -08:00
} , [ season . id , authFetch ] ) ;
2025-10-18 14:55:26 -07:00
2026-03-02 13:18:47 -08:00
const handleForceAutopick = useCallback ( async ( pickNumber : number , teamId : string ) = > {
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "teamId" , teamId ) ;
formData . append ( "pickNumber" , pickNumber . toString ( ) ) ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/force-autopick" , {
method : "POST" ,
body : formData ,
} ) ;
if ( ! response ) return ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
if ( ! response . ok ) {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to force autopick" ) ;
}
} catch {
toast . error ( "Network error - failed to force autopick" ) ;
2025-10-18 14:55:26 -07:00
}
2026-03-02 13:18:47 -08:00
} , [ season . id , authFetch ] ) ;
2025-10-18 14:55:26 -07:00
const handleForceManualPick = async ( participantId : string ) = > {
if ( ! selectedPickSlot ) return ;
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "teamId" , selectedPickSlot . teamId ) ;
formData . append ( "participantId" , participantId ) ;
formData . append ( "pickNumber" , selectedPickSlot . pickNumber . toString ( ) ) ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/force-manual-pick" , {
method : "POST" ,
body : formData ,
} ) ;
if ( ! response ) return ;
2025-10-18 14:55:26 -07:00
2026-03-01 19:33:03 -08:00
if ( response . ok ) {
setForcePickDialogOpen ( false ) ;
setSelectedPickSlot ( null ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to force manual pick" ) ;
}
} catch {
toast . error ( "Network error - failed to force manual pick" ) ;
2025-10-18 14:55:26 -07:00
}
} ;
2026-03-02 13:18:47 -08:00
const handleReplacePickOpen = useCallback ( ( pickNumber : number , teamId : string ) = > {
2026-03-21 09:44:05 -07:00
const pick = picks . find ( ( p ) = > p . pickNumber === pickNumber ) ;
2026-02-20 22:47:29 -08:00
if ( ! pick ) {
toast . error ( "Pick not found — try refreshing the page" ) ;
return ;
}
setReplacePickSlot ( { pickNumber , teamId , oldParticipantId : pick.participant.id } ) ;
setReplacePickDialogOpen ( true ) ;
2026-03-02 13:18:47 -08:00
// picks is read directly to find the pick being replaced.
} , [ picks ] ) ;
2026-02-20 22:47:29 -08:00
const handleReplacePick = async ( participantId : string ) = > {
if ( ! replacePickSlot ) return ;
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "teamId" , replacePickSlot . teamId ) ;
formData . append ( "participantId" , participantId ) ;
formData . append ( "pickNumber" , replacePickSlot . pickNumber . toString ( ) ) ;
2026-02-20 22:47:29 -08:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/replace-pick" , {
method : "POST" ,
body : formData ,
} ) ;
if ( ! response ) return ;
2026-02-20 22:47:29 -08:00
2026-03-01 19:33:03 -08:00
if ( response . ok ) {
setReplacePickDialogOpen ( false ) ;
setReplacePickSlot ( null ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to replace pick" ) ;
}
} catch {
toast . error ( "Network error - failed to replace pick" ) ;
2026-02-20 22:47:29 -08:00
}
} ;
2026-03-02 13:18:47 -08:00
const handleRollbackToPick = useCallback ( ( pickNumber : number ) = > {
2026-02-20 22:47:29 -08:00
setRollbackPickNumber ( pickNumber ) ;
setRollbackConfirmOpen ( true ) ;
2026-03-02 13:18:47 -08:00
} , [ ] ) ;
2026-02-20 22:47:29 -08:00
const handleConfirmRollback = async ( ) = > {
if ( ! rollbackPickNumber || isRollingBack ) return ;
setIsRollingBack ( true ) ;
2026-03-01 19:33:03 -08:00
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "pickNumber" , rollbackPickNumber . toString ( ) ) ;
2026-02-20 22:47:29 -08:00
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/rollback" , {
method : "POST" ,
body : formData ,
} ) ;
2026-02-20 22:47:29 -08:00
2026-03-01 19:33:03 -08:00
setIsRollingBack ( false ) ;
if ( ! response ) return ;
if ( response . ok ) {
setRollbackConfirmOpen ( false ) ;
setRollbackPickNumber ( null ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to roll back draft" ) ;
}
} catch {
setIsRollingBack ( false ) ;
toast . error ( "Network error - failed to roll back draft" ) ;
2026-02-20 22:47:29 -08:00
}
} ;
2026-03-02 13:18:47 -08:00
const handleAdjustTimeBankOpen = useCallback ( ( teamId : string ) = > {
2026-02-22 16:16:51 -08:00
setTimeBankTeamId ( teamId ) ;
setTimeBankAmount ( "1" ) ;
setTimeBankUnit ( "minutes" ) ;
setTimeBankDirection ( "add" ) ;
setTimeBankDialogOpen ( true ) ;
2026-03-02 13:18:47 -08:00
} , [ ] ) ;
2026-02-22 16:16:51 -08:00
2026-03-03 20:14:38 -08:00
const handleSetAutodraftOpen = useCallback ( ( teamId : string ) = > {
setCommissionerAutodraftTeamId ( teamId ) ;
setCommissionerAutodraftDialogOpen ( true ) ;
} , [ ] ) ;
const handleCommissionerAutodraftUpdate = useCallback ( ( ) = > {
setCommissionerAutodraftDialogOpen ( false ) ;
setCommissionerAutodraftTeamId ( null ) ;
} , [ ] ) ;
2026-02-22 16:16:51 -08:00
const handleConfirmAdjustTimeBank = async ( ) = > {
if ( ! timeBankTeamId || isAdjustingTimeBank ) return ;
const amount = parseFloat ( timeBankAmount ) ;
if ( isNaN ( amount ) || amount <= 0 ) {
toast . error ( "Please enter a valid positive amount" ) ;
return ;
}
const unitMultipliers = { seconds : 1 , minutes : 60 , hours : 3600 } ;
const totalSeconds = Math . round ( amount * unitMultipliers [ timeBankUnit ] ) ;
if ( totalSeconds === 0 ) {
toast . error ( "Adjustment rounds to 0 seconds — please enter a larger value" ) ;
return ;
}
const adjustment = timeBankDirection === "add" ? totalSeconds : - totalSeconds ;
setIsAdjustingTimeBank ( true ) ;
try {
const formData = new FormData ( ) ;
formData . append ( "seasonId" , season . id ) ;
formData . append ( "teamId" , timeBankTeamId ) ;
formData . append ( "adjustment" , adjustment . toString ( ) ) ;
2026-03-01 19:33:03 -08:00
const response = await authFetch ( "/api/draft/adjust-time-bank" , {
2026-02-22 16:16:51 -08:00
method : "POST" ,
body : formData ,
} ) ;
2026-03-01 19:33:03 -08:00
if ( ! response ) return ;
2026-02-22 16:16:51 -08:00
if ( response . ok ) {
const data = await response . json ( ) ;
setTeamTimers ( ( prev ) = > ( { . . . prev , [ timeBankTeamId ] : data . timeRemaining } ) ) ;
const teamName = draftSlots . find ( ( s ) = > s . team . id === timeBankTeamId ) ? . team . name ;
toast . success ( ` Time bank adjusted for ${ teamName } ` ) ;
setTimeBankDialogOpen ( false ) ;
setTimeBankTeamId ( null ) ;
} else {
const error = await response . json ( ) ;
toast . error ( error . error || "Failed to adjust time bank" ) ;
}
} catch {
toast . error ( "Network error — failed to adjust time bank" ) ;
} finally {
setIsAdjustingTimeBank ( false ) ;
}
} ;
2026-03-02 13:18:47 -08:00
const handleForceManualPickOpen = useCallback ( ( pickNumber : number , teamId : string ) = > {
2026-02-22 22:36:12 -08:00
setSelectedPickSlot ( { pickNumber , teamId } ) ;
setForcePickDialogOpen ( true ) ;
2026-03-02 13:18:47 -08:00
} , [ ] ) ;
2026-02-22 22:36:12 -08:00
2025-10-17 12:51:47 -07:00
// Calculate current round
2026-02-20 11:16:34 -08:00
const currentRound = draftSlots . length > 0 ? Math . ceil ( currentPick / draftSlots . length ) : 1 ;
2025-10-17 12:30:58 -07:00
2025-10-18 14:55:26 -07:00
// Determine whose turn it is
2026-02-27 23:21:08 -08:00
const currentDraftSlot = useMemo (
( ) = > getTeamForPick ( currentPick , draftSlots ) ,
[ currentPick , draftSlots ]
) ;
2025-10-21 23:22:17 -07:00
const isMyTurn = ! ! (
userTeam && currentDraftSlot && currentDraftSlot . team . id === userTeam . id
) ;
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
const canPick = isMyTurn && season . status === "draft" && ! isPaused ; // Only team owner on their turn when draft is active
2025-10-18 14:55:26 -07:00
2026-02-27 23:21:08 -08:00
const currentDraftSlotOwnerName = currentDraftSlot ? ownerMap [ currentDraftSlot . team . id ] : undefined ;
Add draft clock UI, Fischer increment timer logic, and security fixes (#19)
- Add prominent clock badge to tab bar (lights up on your turn) with
correct Fischer increment chess-clock model: bank starts at initialTime,
+= incrementTime after each pick, other teams' banks untouched
- Extract pure timer helpers to app/lib/draft-timer.ts and add 29 unit
tests covering formatClockTime, calculateTimeAfterPick, getTimerColorClass,
and full snake-draft lifecycle regression scenarios
- Fix make-pick.ts: add status !== 'draft' and draftPaused server guards
- Fix draft-utils.ts: replace (global as any).__socketIO with getSocketIO(),
fix timeUsed to store actual timeRemaining at pick moment (not always 120),
add null timer warning, move timer fetch before pick insert
- Fix draft.start.ts: batch timer inserts, guard against empty draftSlots
- Fix DraftGridSection: memoize currentTeamId, widen teamTimers type to
Record<string, number | undefined>
- Fix duplicate animate-pulse (getTimerColorClass already includes it)
- Clamp negative seconds in formatClockTime to guard against timer drift
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-21 16:51:12 -08:00
const currentClockTime = currentDraftSlot ? teamTimers [ currentDraftSlot . team . id ] : undefined ;
const currentClockColor = getTimerColorClass ( currentClockTime ) ;
2025-10-17 12:51:47 -07:00
// Generate snake draft grid structure
2026-02-20 21:10:26 -08:00
const draftGrid = useMemo ( ( ) = > {
2025-10-17 12:51:47 -07:00
const teamCount = draftSlots . length ;
const rounds = season . draftRounds ;
2025-10-18 14:55:26 -07:00
const grid : Array <
Array < {
pickNumber : number ;
round : number ;
pickInRound : number ;
teamId : string ;
2026-03-21 09:44:05 -07:00
pick ? : ( typeof draftPicks ) [ number ] ;
2025-10-18 14:55:26 -07:00
} >
> = [ ] ;
2025-10-17 12:51:47 -07:00
for ( let round = 1 ; round <= rounds ; round ++ ) {
const roundPicks = [ ] ;
const isOddRound = round % 2 === 1 ;
2025-10-18 14:55:26 -07:00
2025-10-17 12:51:47 -07:00
for ( let i = 0 ; i < teamCount ; i ++ ) {
const pickInRound = i + 1 ;
const teamIndex = isOddRound ? i : teamCount - 1 - i ;
const pickNumber = ( round - 1 ) * teamCount + pickInRound ;
const teamId = draftSlots [ teamIndex ] ? . team . id ;
2025-10-18 14:55:26 -07:00
2026-03-21 09:44:05 -07:00
const pick = picks . find ( ( p ) = > p . pickNumber === pickNumber ) ;
2025-10-18 14:55:26 -07:00
2026-02-20 21:10:26 -08:00
roundPicks . push ( { pickNumber , round , pickInRound , teamId , pick } ) ;
2025-10-17 12:51:47 -07:00
}
grid . push ( roundPicks ) ;
}
2025-10-18 14:55:26 -07:00
2025-10-17 12:51:47 -07:00
return grid ;
2026-02-20 21:10:26 -08:00
} , [ picks , draftSlots , season . draftRounds ] ) ;
2025-10-17 12:51:47 -07:00
2025-10-17 16:58:35 -07:00
// Get drafted participant IDs for filtering
2026-02-20 21:10:26 -08:00
const draftedParticipantIds = useMemo (
2026-03-21 09:44:05 -07:00
( ) = > new Set ( picks . map ( ( p ) = > p . participant . id ) ) ,
2026-02-20 21:10:26 -08:00
[ picks ]
2025-10-18 14:55:26 -07:00
) ;
2025-10-17 16:58:35 -07:00
2026-02-28 23:16:06 -08:00
// Sport IDs where the current user's team has already made at least one pick
const userDraftedSportIds = useMemo ( ( ) = > {
if ( ! userTeam ) return new Set < string > ( ) ;
return new Set (
picks
2026-03-21 09:44:05 -07:00
. filter ( ( p ) = > p . team . id === userTeam . id )
. map ( ( p ) = > p . sport . id )
2026-02-28 23:16:06 -08:00
) ;
} , [ picks , userTeam ] ) ;
2026-03-02 10:13:51 -08:00
// Sport names where the current user's team has already made at least one pick
const userDraftedSportNames = useMemo ( ( ) = > {
if ( ! userTeam ) return new Set < string > ( ) ;
return new Set (
picks
2026-03-21 09:44:05 -07:00
. filter ( ( p ) = > p . team . id === userTeam . id )
. map ( ( p ) = > p . sport . name )
2026-03-02 10:13:51 -08:00
) ;
} , [ picks , userTeam ] ) ;
2025-10-17 16:58:35 -07:00
// Get unique sports for filter dropdown
2026-02-20 21:10:26 -08:00
const uniqueSports = useMemo (
( ) = >
Array . from (
2026-03-21 09:44:05 -07:00
new Set ( availableParticipants . map ( ( p ) = > p . sport . name ) )
2026-02-20 21:10:26 -08:00
) . sort ( ) ,
[ availableParticipants ]
) ;
2025-10-26 21:09:30 -07:00
// Filter participants based on search, sport, drafted status, and eligibility
2026-03-02 00:29:54 -08:00
const filteredParticipants = useMemo ( ( ) = > {
const sportFilterSet = new Set ( sportFilters ) ;
2026-03-21 09:44:05 -07:00
return availableParticipants . filter ( ( participant ) = > {
2026-03-02 00:29:54 -08:00
// Drafted filter - hide drafted participants by default
if ( hideDrafted && draftedParticipantIds . has ( participant . id ) ) {
return false ;
}
// Eligibility filter - hide ineligible participants by default (if user has a team)
if ( hideIneligible && eligibility ) {
const isEligible = eligibility . eligibleSportIds . has ( participant . sport . id ) ;
if ( ! isEligible ) {
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
return false ;
}
2026-03-02 00:29:54 -08:00
}
// Hide completed sports filter - hide participants from sports already drafted by user's team
if ( hideCompletedSports && userDraftedSportIds . has ( participant . sport . id ) ) {
return false ;
}
// Search filter
if (
searchQuery &&
! participant . name . toLowerCase ( ) . includes ( searchQuery . toLowerCase ( ) )
) {
return false ;
}
// Sport filter
if ( sportFilterSet . size > 0 && ! sportFilterSet . has ( participant . sport . name ) ) {
return false ;
}
return true ;
} ) ;
} , [ availableParticipants , hideDrafted , hideIneligible , hideCompletedSports , eligibility , draftedParticipantIds , userDraftedSportIds , searchQuery , sportFilters ] ) ;
2025-10-17 16:58:35 -07:00
2026-02-22 22:36:12 -08:00
// Shared component props — defined once to avoid duplication between desktop and mobile layouts
2026-03-02 13:18:47 -08:00
const handleHideCompletedSportsChange = useCallback ( ( hide : boolean ) = > {
setHideCompletedSports ( hide ) ;
if ( hide ) {
setSportFilters ( ( prev ) = > prev . filter ( ( s ) = > ! userDraftedSportNames . has ( s ) ) ) ;
}
} , [ userDraftedSportNames ] ) ;
2026-02-22 22:36:12 -08:00
const availableParticipantsSectionProps = {
participants : filteredParticipants ,
searchQuery ,
2026-03-02 00:29:54 -08:00
sportFilters ,
2026-02-22 22:36:12 -08:00
hideDrafted ,
hideIneligible ,
uniqueSports ,
draftedParticipantIds ,
queue ,
eligibility ,
canPick ,
hasTeam : ! ! userTeam ,
onSearchChange : setSearchQuery ,
2026-03-02 00:29:54 -08:00
onSportFiltersChange : setSportFilters ,
2026-02-22 22:36:12 -08:00
onHideDraftedChange : setHideDrafted ,
onHideIneligibleChange : setHideIneligible ,
2026-02-28 23:16:06 -08:00
hideCompletedSports ,
2026-03-02 10:13:51 -08:00
userDraftedSportNames ,
2026-03-02 13:18:47 -08:00
onHideCompletedSportsChange : handleHideCompletedSportsChange ,
2026-02-22 22:36:12 -08:00
onMakePick : handleMakePick ,
onAddToQueue : handleAddToQueue ,
onRemoveFromQueue : handleRemoveFromQueue ,
} ;
const draftGridSectionProps = {
draftSlots ,
draftGrid ,
currentPick ,
teamTimers ,
autodraftStatus ,
connectedTeams ,
isCommissioner ,
ownerMap ,
onAdjustTimeBankOpen : isCommissioner ? handleAdjustTimeBankOpen : undefined ,
2026-03-03 20:14:38 -08:00
onSetAutodraftOpen : isCommissioner ? handleSetAutodraftOpen : undefined ,
2026-02-22 22:36:12 -08:00
onForceAutopick : handleForceAutopick ,
onForceManualPickOpen : handleForceManualPickOpen ,
onReplacePick : isCommissioner ? handleReplacePickOpen : undefined ,
onRollbackToPick : isCommissioner && ! isDraftComplete ? handleRollbackToPick : undefined ,
} ;
2026-03-02 16:46:35 -08:00
const summaryViewProps = {
draftSlots ,
picks ,
sports : seasonSportsData ,
ownerMap ,
2026-03-02 22:19:19 -08:00
totalRounds : season.draftRounds ,
2026-03-02 16:46:35 -08:00
} ;
2026-03-02 13:18:47 -08:00
2026-03-02 16:46:35 -08:00
const rosterViewProps = {
2026-02-22 22:36:12 -08:00
draftSlots ,
picks ,
sports : seasonSportsData ,
ownerMap ,
} ;
2026-03-02 13:18:47 -08:00
const handleAutodraftUpdate = useCallback (
( isEnabled : boolean , mode : "next_pick" | "while_on" , queueOnly : boolean ) = > {
setUserAutodraft ( { isEnabled , mode , queueOnly } ) ;
} ,
[ ]
) ;
2026-02-22 22:36:12 -08:00
const queueSectionProps = userTeam
? {
queue ,
availableParticipants ,
seasonId : season.id ,
teamId : userTeam.id ,
isMyTurn ,
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
canPick ,
2026-02-22 22:36:12 -08:00
userAutodraft ,
onRemoveFromQueue : handleRemoveFromQueue ,
2026-03-02 13:18:47 -08:00
onAutodraftUpdate : handleAutodraftUpdate ,
2026-02-22 22:36:12 -08:00
onReorder : handleReorderQueue ,
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
onMakePick : handleMakePick ,
2026-02-22 22:36:12 -08:00
}
: null ;
2026-02-27 23:12:21 -08:00
const mobileTabs = userTeam
? [ MOBILE_TABS_BASE [ 0 ] , QUEUE_TAB , . . . MOBILE_TABS_BASE . slice ( 1 ) ]
: MOBILE_TABS_BASE ;
const mobileColCount = mobileTabs . length ;
2025-10-17 12:30:58 -07:00
return (
2026-02-23 08:22:00 -08:00
< div className = "h-dvh bg-background flex flex-col overflow-hidden" >
2025-10-18 23:33:13 -07:00
{ /* Draft Completion Banner */ }
{ isDraftComplete && (
2026-02-20 19:26:11 -08:00
< div className = "bg-emerald-500/20 border-b border-emerald-500/30 text-emerald-400 px-4 py-3 text-center font-semibold flex-shrink-0" >
2025-10-18 23:33:13 -07:00
🎉 Draft Complete ! The season is now active .
2025-10-20 15:03:11 -07:00
{ season . league . isPublicDraftBoard && (
< >
{ " " }
< a
href = { ` /leagues/ ${ season . leagueId } /draft-board/ ${ season . id } ` }
2026-02-20 19:26:11 -08:00
className = "underline hover:text-emerald-300"
2025-10-20 15:03:11 -07:00
>
View Draft Board
< / a >
< / >
) }
2025-10-18 23:33:13 -07:00
< / div >
) }
2025-10-17 12:45:30 -07:00
{ /* Standalone Header - No Main Nav */ }
2025-10-25 03:23:41 -07:00
< div className = "border-b bg-card flex-shrink-0" >
2025-10-17 12:51:47 -07:00
< div className = "w-full px-4 py-4" >
2025-10-17 12:45:30 -07:00
< div className = "flex items-center justify-between" >
2025-10-25 03:23:41 -07:00
< div className = "flex items-center gap-3" >
{ /* Mobile menu button - only show if user has team and sidebar is collapsed */ }
{ userTeam && sidebarCollapsed && (
< Button
variant = "ghost"
size = "icon"
onClick = { ( ) = > setSidebarCollapsed ( false ) }
className = "lg:hidden"
aria - label = "Open sidebar"
>
< svg
xmlns = "http://www.w3.org/2000/svg"
width = "24"
height = "24"
viewBox = "0 0 24 24"
fill = "none"
stroke = "currentColor"
strokeWidth = "2"
strokeLinecap = "round"
strokeLinejoin = "round"
>
2026-03-21 09:44:05 -07:00
< line x1 = "3" y1 = "12" x2 = "21" y2 = "12" / >
< line x1 = "3" y1 = "6" x2 = "21" y2 = "6" / >
< line x1 = "3" y1 = "18" x2 = "21" y2 = "18" / >
2025-10-25 03:23:41 -07:00
< / svg >
< / Button >
) }
< div >
2026-02-22 22:36:12 -08:00
< h1 className = "text-lg md:text-3xl font-bold" >
2025-10-25 03:23:41 -07:00
{ season . league . name } - { season . year } Draft
< / h1 >
< div className = "flex gap-4 text-sm text-muted-foreground mt-1" >
< span > Round : { currentRound } < / span >
< span > Pick : { currentPick } < / span >
< span className = "capitalize" >
{ season . status . replace ( "_" , " " ) }
< / span >
< / div >
2025-10-17 12:45:30 -07:00
< / div >
< / div >
< div className = "flex items-center gap-3" >
2026-02-22 22:36:12 -08:00
{ /* Commissioner Controls - hidden on mobile (shown in Controls tab) */ }
2025-10-18 14:55:26 -07:00
{ isCommissioner && season . status === "pre_draft" && (
2026-02-22 22:36:12 -08:00
< Button className = "hidden md:flex" onClick = { handleStartDraft } > Start Draft < / Button >
2025-10-18 14:55:26 -07:00
) }
2026-02-22 22:36:12 -08:00
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
{ isCommissioner && season . status === "draft" && ! isDraftComplete && (
2026-02-22 22:36:12 -08:00
< div className = "hidden md:flex" >
2025-10-18 23:19:41 -07:00
{ isPaused ? (
< Button onClick = { handleResumeDraft } variant = "default" >
Resume Draft
< / Button >
) : (
< Button onClick = { handlePauseDraft } variant = "outline" >
Pause Draft
< / Button >
) }
2026-02-22 22:36:12 -08:00
< / div >
2025-10-18 23:19:41 -07:00
) }
2025-10-18 14:55:26 -07:00
2025-10-17 12:45:30 -07:00
< div className = "flex items-center gap-2" >
< div
className = { ` w-3 h-3 rounded-full ${
2026-02-20 19:26:11 -08:00
isConnected ? "bg-emerald-500" : "bg-coral-accent"
2025-10-17 12:45:30 -07:00
} ` }
/ >
2026-02-22 22:36:12 -08:00
< span className = "hidden sm:inline text-sm font-medium" >
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
{ isConnected ? "Connected" : "Disconnected" }
2025-10-17 12:45:30 -07:00
< / span >
< / div >
2026-02-22 22:36:12 -08:00
< Button variant = "outline" asChild className = "hidden md:flex" >
2025-10-18 14:55:26 -07:00
< Link to = { ` /leagues/ ${ season . leagueId } ` } > Exit Draft Room < / Link >
2025-10-17 12:45:30 -07:00
< / Button >
< / div >
2025-10-17 12:30:58 -07:00
< / div >
< / div >
< / div >
2026-02-22 22:36:12 -08:00
{ /* Mobile On Clock bar */ }
{ season . status === "draft" && ! isDraftComplete && currentDraftSlot && (
< div className = { ` md:hidden flex-shrink-0 flex items-center justify-between px-4 py-2 border-b ${
isMyTurn
? "bg-electric/25 border-electric"
: "bg-muted/30"
} ` }>
< div >
< div className = { ` text-xs font-bold uppercase tracking-wider ${ isMyTurn ? "text-electric" : "text-muted-foreground" } ` } >
{ isMyTurn ? "Your Turn!" : "On the Clock" }
< / div >
2026-02-27 23:21:08 -08:00
< div className = "text-sm font-bold" >
{ currentDraftSlotOwnerName ? ? currentDraftSlot . team . name }
< / div >
{ currentDraftSlotOwnerName && (
< div className = "text-xs text-muted-foreground" > { currentDraftSlot . team . name } < / div >
) }
2026-02-22 22:36:12 -08:00
< / div >
{ isPaused ? (
< span className = "text-sm font-bold text-amber-accent" > Paused < / span >
) : (
< span className = { ` text-xl font-mono font-bold tabular-nums ${ currentClockColor } ` } >
{ formatClockTime ( currentClockTime ) }
< / span >
) }
< / div >
) }
2025-10-25 03:23:41 -07:00
2026-02-22 22:36:12 -08:00
{ /* Main Content — single layout tree based on isMobile to avoid duplicate component instances */ }
< div className = "flex-1 overflow-hidden" >
{ isMobile ? (
< div className = "flex h-full overflow-hidden flex-col" >
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
{ mobileTab === "available" && (
2026-02-22 22:36:12 -08:00
< AvailableParticipantsSection { ...availableParticipantsSectionProps } / >
) }
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
{ mobileTab === "queue" && (
< div className = "h-full overflow-y-auto" >
{ queueSectionProps ? (
< QueueSection { ...queueSectionProps } / >
) : (
< p className = "text-muted-foreground text-sm text-center py-8 px-4" >
Join a team to manage your queue
< / p >
) }
< / div >
) }
2026-02-22 22:36:12 -08:00
{ mobileTab === "board" && (
< DraftGridSection { ...draftGridSectionProps } / >
) }
2026-03-02 16:46:35 -08:00
{ mobileTab === "teams" && (
< div className = "flex flex-col h-full overflow-hidden" >
< div className = "flex-shrink-0 flex gap-1 p-2 border-b" >
< button
onClick = { ( ) = > setTeamsSubTab ( "rosters" ) }
className = { ` flex-1 py-1.5 text-sm font-medium rounded transition-colors ${
teamsSubTab === "rosters"
? "bg-accent text-accent-foreground"
: "text-muted-foreground hover:text-foreground"
} ` }
>
Roster
< / button >
< button
onClick = { ( ) = > setTeamsSubTab ( "summary" ) }
className = { ` flex-1 py-1.5 text-sm font-medium rounded transition-colors ${
teamsSubTab === "summary"
? "bg-accent text-accent-foreground"
: "text-muted-foreground hover:text-foreground"
} ` }
>
Summary
< / button >
< / div >
< div className = "flex-1 overflow-hidden" >
{ teamsSubTab === "rosters" ? (
< TeamRosterView { ...rosterViewProps } / >
) : (
< DraftSummaryView { ...summaryViewProps } / >
) }
< / div >
< / div >
2026-02-22 22:36:12 -08:00
) }
{ mobileTab === "controls" && (
< div className = "h-full overflow-y-auto p-4 space-y-6" >
{ isCommissioner && season . status === "pre_draft" && (
< Button className = "w-full min-h-[48px]" onClick = { handleStartDraft } >
Start Draft
< / Button >
) }
{ isCommissioner && season . status === "draft" && ! isDraftComplete && (
isPaused ? (
< Button className = "w-full min-h-[48px]" onClick = { handleResumeDraft } >
Resume Draft
< / Button >
) : (
< Button className = "w-full min-h-[48px]" variant = "outline" onClick = { handlePauseDraft } >
Pause Draft
< / Button >
)
Add draft clock UI, Fischer increment timer logic, and security fixes (#19)
- Add prominent clock badge to tab bar (lights up on your turn) with
correct Fischer increment chess-clock model: bank starts at initialTime,
+= incrementTime after each pick, other teams' banks untouched
- Extract pure timer helpers to app/lib/draft-timer.ts and add 29 unit
tests covering formatClockTime, calculateTimeAfterPick, getTimerColorClass,
and full snake-draft lifecycle regression scenarios
- Fix make-pick.ts: add status !== 'draft' and draftPaused server guards
- Fix draft-utils.ts: replace (global as any).__socketIO with getSocketIO(),
fix timeUsed to store actual timeRemaining at pick moment (not always 120),
add null timer warning, move timer fetch before pick insert
- Fix draft.start.ts: batch timer inserts, guard against empty draftSlots
- Fix DraftGridSection: memoize currentTeamId, widen teamTimers type to
Record<string, number | undefined>
- Fix duplicate animate-pulse (getTimerColorClass already includes it)
- Clamp negative seconds in formatClockTime to guard against timer drift
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-21 16:51:12 -08:00
) }
2025-10-25 03:23:41 -07:00
2026-02-22 22:36:12 -08:00
< section >
Claude/redesign autodraft queue c4 kp r (#40)
* Redesign autodraft queue system with three-state control and queue-only constraint
Core Logic & Database:
- Add `queue_only` boolean column to `autodraft_settings` (migration 0031)
- Rename autodraft UI states: Off / Next Pick / All Picks (while_on mode maps to All Picks)
- `autoPickForTeam`: respects new `queueOnly` param — skips EV fallback when enabled
- `executeAutoPick`: auto-disables autodraft + emits socket event when queue empties with queueOnly ON (AC3)
- `autodraft-updated` socket event now includes `queueOnly` field
Mobile UI Overhaul:
- Rename "Lobby" tab → "Available" (AC6)
- Add new "Queue" tab to mobile bottom nav with drag-reorder, per-item Draft buttons, and autodraft controls (AC5)
- Controls tab retains commissioner tools, notifications, exit; queue controls moved to Queue tab
- Turn indicator appears on both Available and Queue tabs
Components:
- `AutodraftSettings`: replaces toggle+radio with three-state button group (Off | Next Pick | All Picks) + "Only autodraft from queue" switch (AC1, AC2)
- `QueueSection`: adds `canPick` prop + per-item Draft buttons for instant drafting when on the clock
Desktop (AC4):
- Sidebar QueueSection unchanged in position; gains same three-state controls and Draft buttons
Tests (AC7):
- `autodraft.test.ts`: updated for queueOnly field and socket event shape
- `timer-autodraft.test.ts`: new tests for queue-only constraint, auto-shutoff transitions, and all three autodraft states
https://claude.ai/code/session_01PYhJicAStoJ2u6q6dV1naB
* fix: remove erroneous ?? fallbacks in autodraft socket emissions and add autoPickForTeam tests
- Remove `?? true` default on queueOnly in queue-empty auto-disable socket emit
(line 488) — was dead code since the column is NOT NULL, but semantically wrong
and would have caused client-side UI desync if the type ever relaxed
- Remove `?? false` default on the next_pick auto-disable path for consistency
- Add app/models/__tests__/auto-pick.test.ts with 6 tests covering the queueOnly
constraint: empty queue, all items drafted, partial queue skip, and EV fallback
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: add missing queueOnly prop to AutodraftSettings test fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* test: rewrite AutodraftSettings tests for three-state button group UI
The component was redesigned from a switch + radio buttons to Off/Next Pick/All Picks
buttons with a separate queue-only Switch toggle. Updated 17 stale tests and added 5
new tests covering the queue-only toggle and the All Picks/Off button interactions.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-27 22:16:26 -08:00
< h2 className = "font-semibold text-sm mb-2" > Recent Picks < / h2 >
2026-02-22 22:36:12 -08:00
< SidebarRecentPicks picks = { picks } / >
< / section >
< NotificationSettings
enabled = { notificationsEnabled }
onEnabledChange = { setNotificationsEnabled }
mode = { notificationsMode }
onModeChange = { setNotificationsMode }
permissionState = { notificationsPermission }
2025-10-25 18:25:26 -07:00
/ >
2026-02-22 22:36:12 -08:00
< Button variant = "outline" asChild className = "w-full min-h-[48px]" >
< Link to = { ` /leagues/ ${ season . leagueId } ` } > Exit Draft Room < / Link >
< / Button >
2025-10-25 18:25:26 -07:00
< / div >
2026-02-22 22:36:12 -08:00
) }
< / div >
) : (
< div className = "flex h-full overflow-hidden" >
{ userTeam && queueSectionProps && (
< DraftSidebar
collapsed = { sidebarCollapsed }
onCollapsedChange = { setSidebarCollapsed }
queueSection = { < QueueSection { ...queueSectionProps } / > }
recentPicksSection = { < SidebarRecentPicks picks = { picks } / > }
settingsSection = {
< NotificationSettings
enabled = { notificationsEnabled }
onEnabledChange = { setNotificationsEnabled }
mode = { notificationsMode }
onModeChange = { setNotificationsMode }
permissionState = { notificationsPermission }
/ >
}
2025-10-25 03:23:41 -07:00
/ >
2026-02-22 22:36:12 -08:00
) }
< div className = "flex-1 overflow-hidden" >
< Tabs
value = { activeTab }
onValueChange = { ( value ) = >
2026-03-02 16:46:35 -08:00
setActiveTab ( value as "participants" | "board" | "rosters" | "summary" )
2026-02-22 22:36:12 -08:00
}
className = "h-full flex flex-col"
>
< div className = { ` mt-4 transition-all duration-300 ${
isMyTurn && season . status === "draft" && ! isDraftComplete
? "bg-electric/25 border-y-2 border-electric shadow-[0_0_24px_0_rgb(0_200_255_/_0.18)]"
: ""
} ` }>
< div className = "flex items-center gap-3 px-4 py-2" >
< TabsList >
< TabsTrigger value = "participants" > Available Participants < / TabsTrigger >
< TabsTrigger value = "board" > Draft Board < / TabsTrigger >
2026-03-02 16:46:35 -08:00
< TabsTrigger value = "rosters" > Rosters < / TabsTrigger >
< TabsTrigger value = "summary" > Summary < / TabsTrigger >
2026-02-22 22:36:12 -08:00
< / TabsList >
{ season . status === "draft" && ! isDraftComplete && currentDraftSlot && (
< div className = { ` ml-auto flex items-center gap-2.5 rounded-lg px-3 py-1.5 flex-shrink-0 transition-all ${
isMyTurn
? "bg-electric/30 border-2 border-electric shadow-md shadow-electric/30"
: "border border-border/50"
} ` }>
< div className = "leading-tight" >
< div className = { ` text-xs font-bold uppercase tracking-wider ${ isMyTurn ? "text-electric" : "text-muted-foreground" } ` } >
{ isMyTurn ? "Your Turn!" : "On the Clock" }
< / div >
< div className = { ` text-sm font-bold ${ isMyTurn ? "text-foreground" : "text-muted-foreground" } ` } >
2026-02-27 23:21:08 -08:00
{ currentDraftSlotOwnerName ? ? currentDraftSlot . team . name }
2026-02-22 22:36:12 -08:00
< / div >
2026-02-27 23:21:08 -08:00
{ currentDraftSlotOwnerName && (
< div className = "text-xs text-muted-foreground" > { currentDraftSlot . team . name } < / div >
) }
2026-02-22 22:36:12 -08:00
< / div >
{ isPaused ? (
< span className = "text-sm font-bold text-amber-accent" > Paused < / span >
) : (
< span className = { ` text-2xl font-mono font-bold tabular-nums ${ currentClockColor } ` } >
{ formatClockTime ( currentClockTime ) }
< / span >
) }
< / div >
) }
< / div >
< / div >
< TabsContent value = "participants" className = "flex-1 overflow-hidden m-0" >
2026-02-27 23:12:21 -08:00
< AvailableParticipantsSection { ...availableParticipantsSectionProps } / >
2026-02-22 22:36:12 -08:00
< / TabsContent >
< TabsContent value = "board" className = "flex-1 overflow-hidden m-0" >
< DraftGridSection { ...draftGridSectionProps } / >
< / TabsContent >
2026-03-02 16:46:35 -08:00
< TabsContent value = "rosters" className = "flex-1 overflow-hidden m-0" >
< TeamRosterView { ...rosterViewProps } / >
< / TabsContent >
< TabsContent value = "summary" className = "flex-1 overflow-hidden m-0" >
< DraftSummaryView { ...summaryViewProps } / >
2026-02-22 22:36:12 -08:00
< / TabsContent >
< / Tabs >
< / div >
< / div >
) }
2025-10-18 14:55:26 -07:00
< / div >
2025-10-17 12:30:58 -07:00
2026-02-22 22:36:12 -08:00
{ /* Mobile Bottom Nav */ }
2026-02-27 23:12:21 -08:00
< nav className = { ` md:hidden flex-shrink-0 border-t bg-card grid ` } style = { { gridTemplateColumns : ` repeat( ${ mobileColCount } , 1fr) ` } } >
{ mobileTabs . map ( ( tab ) = > {
const showTurnIndicator =
( tab . id === "available" || tab . id === "queue" ) &&
isMyTurn &&
season . status === "draft" &&
! isDraftComplete ;
return (
< button
key = { tab . id }
onClick = { ( ) = > setMobileTab ( tab . id as typeof mobileTab ) }
className = { ` relative flex flex-col items-center justify-center py-2 gap-0.5 min-h-[56px] transition-colors ${
mobileTab === tab . id ? "text-electric" : "text-muted-foreground"
} ` }
>
< div className = "relative" >
< tab.Icon className = "h-5 w-5" / >
{ showTurnIndicator && (
< span className = "absolute -top-1 -right-1 w-2 h-2 rounded-full bg-electric" / >
) }
< / div >
< span className = "text-[10px] font-medium" > { tab . label } < / span >
< / button >
) ;
} ) }
< / nav >
2026-02-22 22:36:12 -08:00
2026-02-27 23:46:09 -08:00
< ParticipantSelectionDialog
Improve draft room UX with better error handling and UI refinements (#17)
* Remove pause/resume controls when draft is complete, rename Live to Connected
- Hide Pause/Resume Draft buttons when isDraftComplete is true
- Change 'Live' status indicator to 'Connected' in both draft room and draft board views
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
* Fix code review issues in draft room: security, bugs, and quality
Security:
- Fix inconsistent commissioner check: draft.start, force-autopick, force-manual-pick,
and make-pick all now query the commissioners table instead of league.createdBy,
so co-commissioners have consistent access to all draft controls
Bugs:
- canPick now includes !isPaused so the UI correctly blocks picks during a pause
- isDraftComplete initial state now covers 'completed' season status, not just 'active'
- Guard JSON.parse in queue.reorder.ts with try/catch to return 400 instead of 500
Code quality:
- Add error handling (try/catch + toast) to handlePauseDraft, handleResumeDraft,
handleRemoveFromQueue, and handleReorderQueue
- Replace alert() with toast.error() in handleMakePick, handleForceAutopick,
handleForceManualPick for consistent UX
- Memoize filteredParticipants with useMemo to avoid recomputing on every render
- Replace custom force-pick dialog div with ShadCN Dialog component for proper
keyboard support (Escape to close, focus trap, accessible markup); add dialog.tsx
- Remove console.log debug statements from socket event handlers and API routes
- Replace (global as any).__socketIO with getSocketIO() across all API routes
- Replace window.location.reload() in handleStartDraft with useRevalidator
https://claude.ai/code/session_01AUaKzx465NrY29Qv6MVwjC
---------
Co-authored-by: Claude <noreply@anthropic.com>
2026-02-20 21:50:27 -08:00
open = { forcePickDialogOpen && ! ! selectedPickSlot }
onOpenChange = { ( open ) = > {
setForcePickDialogOpen ( open ) ;
if ( ! open ) setSelectedPickSlot ( null ) ;
} }
2026-02-27 23:46:09 -08:00
title = "Force Manual Pick"
description = { ` Select a participant to draft for Pick # ${ selectedPickSlot ? . pickNumber } ` }
participants = { availableParticipants }
draftedParticipantIds = { draftedParticipantIds }
eligibility = { forcePickEligibility }
uniqueSports = { uniqueSports }
onSelect = { handleForceManualPick }
/ >
< ParticipantSelectionDialog
2026-02-20 22:47:29 -08:00
open = { replacePickDialogOpen && ! ! replacePickSlot }
onOpenChange = { ( open ) = > {
setReplacePickDialogOpen ( open ) ;
if ( ! open ) setReplacePickSlot ( null ) ;
} }
2026-02-27 23:46:09 -08:00
title = "Replace Pick"
description = { ` Select a participant to replace the current pick at slot # ${ replacePickSlot ? . pickNumber } ` }
participants = { availableParticipants }
draftedParticipantIds = { draftedParticipantIds }
allowParticipantId = { replacePickSlot ? . oldParticipantId }
currentParticipantId = { replacePickSlot ? . oldParticipantId }
eligibility = { replacePickEligibility }
uniqueSports = { uniqueSports }
onSelect = { handleReplacePick }
/ >
2026-02-20 22:47:29 -08:00
{ /* Rollback Confirmation Dialog */ }
< Dialog
open = { rollbackConfirmOpen }
onOpenChange = { ( open ) = > {
setRollbackConfirmOpen ( open ) ;
if ( ! open ) setRollbackPickNumber ( null ) ;
} }
>
< DialogContent >
< DialogHeader >
< DialogTitle > Roll Back Draft < / DialogTitle >
< DialogDescription >
{ rollbackPickNumber !== null && ( ( ) = > {
2026-03-21 09:44:05 -07:00
const count = picks . filter ( ( p ) = > p . pickNumber >= rollbackPickNumber ) . length ;
2026-02-20 22:47:29 -08:00
return ` This will erase ${ count } pick ${ count === 1 ? "" : "s" } (pick # ${ rollbackPickNumber } through the most recent) and return the draft to pick # ${ rollbackPickNumber } . This cannot be undone. ` ;
} ) ( ) }
< / DialogDescription >
< / DialogHeader >
< DialogFooter >
< Button variant = "outline" onClick = { ( ) = > setRollbackConfirmOpen ( false ) } >
Cancel
< / Button >
< Button variant = "destructive" onClick = { handleConfirmRollback } disabled = { isRollingBack } >
{ isRollingBack ? "Rolling Back..." : "Roll Back" }
< / Button >
< / DialogFooter >
< / DialogContent >
< / Dialog >
2026-02-22 16:16:51 -08:00
{ /* Time Bank Adjustment Dialog */ }
< Dialog
open = { timeBankDialogOpen }
onOpenChange = { ( open ) = > {
setTimeBankDialogOpen ( open ) ;
if ( ! open ) setTimeBankTeamId ( null ) ;
} }
>
< DialogContent >
< DialogHeader >
< DialogTitle > Adjust Time Bank < / DialogTitle >
< DialogDescription >
{ timeBankTeamId
? ` Adjusting time for ${ draftSlots . find ( ( s ) = > s . team . id === timeBankTeamId ) ? . team . name } `
: "Adjust a team's time bank" }
< / DialogDescription >
< / DialogHeader >
< div className = "flex flex-col gap-4 py-2" >
< div className = "flex gap-2" >
< button
type = "button"
onClick = { ( ) = > setTimeBankDirection ( "add" ) }
className = { ` flex-1 py-2 rounded-md border text-sm font-medium transition-colors ${
timeBankDirection === "add"
? "bg-emerald-500/20 border-emerald-500 text-emerald-400"
: "border-border text-muted-foreground hover:bg-muted"
} ` }
>
Add Time
< / button >
< button
type = "button"
onClick = { ( ) = > setTimeBankDirection ( "remove" ) }
className = { ` flex-1 py-2 rounded-md border text-sm font-medium transition-colors ${
timeBankDirection === "remove"
? "bg-destructive/20 border-destructive text-destructive"
: "border-border text-muted-foreground hover:bg-muted"
} ` }
>
Remove Time
< / button >
< / div >
< div className = "flex gap-2" >
< input
type = "number"
min = "0.001"
step = "any"
value = { timeBankAmount }
onChange = { ( e ) = > setTimeBankAmount ( e . target . value ) }
2026-02-27 23:46:09 -08:00
className = "flex-1 px-3 py-2 border rounded-md bg-background text-foreground text-base md:text-sm"
2026-02-22 16:16:51 -08:00
placeholder = "Amount"
/ >
< select
value = { timeBankUnit }
onChange = { ( e ) = >
setTimeBankUnit ( e . target . value as "seconds" | "minutes" | "hours" )
}
2026-02-27 23:46:09 -08:00
className = "px-3 py-2 border rounded-md bg-background text-foreground text-base md:text-sm"
2026-02-22 16:16:51 -08:00
>
< option value = "seconds" > Seconds < / option >
< option value = "minutes" > Minutes < / option >
< option value = "hours" > Hours < / option >
< / select >
< / div >
< / div >
< DialogFooter >
< Button variant = "outline" onClick = { ( ) = > setTimeBankDialogOpen ( false ) } >
Cancel
< / Button >
< Button
onClick = { handleConfirmAdjustTimeBank }
disabled = { isAdjustingTimeBank }
variant = { timeBankDirection === "remove" ? "destructive" : "default" }
>
{ isAdjustingTimeBank
? "Adjusting..."
: timeBankDirection === "add"
? "Add Time"
: "Remove Time" }
< / Button >
< / DialogFooter >
< / DialogContent >
< / Dialog >
2026-03-03 20:14:38 -08:00
{ /* Commissioner Autodraft Override Dialog */ }
< Dialog
open = { commissionerAutodraftDialogOpen }
onOpenChange = { ( open ) = > {
setCommissionerAutodraftDialogOpen ( open ) ;
if ( ! open ) setCommissionerAutodraftTeamId ( null ) ;
} }
>
< DialogContent >
< DialogHeader >
< DialogTitle > Set Autodraft < / DialogTitle >
< DialogDescription >
{ commissionerAutodraftTeamId
? ` Change autodraft for ${ draftSlots . find ( ( s ) = > s . team . id === commissionerAutodraftTeamId ) ? . team . name ? ? "this team" } `
: "Set a team's autodraft settings" }
< / DialogDescription >
< / DialogHeader >
{ commissionerAutodraftTeamId && (
< AutodraftSettings
seasonId = { season . id }
teamId = { commissionerAutodraftTeamId }
isEnabled = { autodraftStatus [ commissionerAutodraftTeamId ] ? . isEnabled ? ? false }
mode = { autodraftStatus [ commissionerAutodraftTeamId ] ? . mode ? ? "next_pick" }
queueOnly = { autodraftStatus [ commissionerAutodraftTeamId ] ? . queueOnly ? ? false }
isMyTurn = { false }
onUpdate = { handleCommissionerAutodraftUpdate }
/ >
) }
< / DialogContent >
< / Dialog >
2025-10-26 21:01:12 -07:00
{ /* Connection Overlay - blocks interaction until socket connects */ }
< ConnectionOverlay
isConnected = { isConnected }
isReconnecting = { isReconnecting }
connectionError = { connectionError }
/ >
2026-03-01 19:33:03 -08:00
{ /* Auth Recovery Overlay - blocks interaction when session expires */ }
< AuthRecoveryOverlay isAuthDegraded = { authDegraded } / >
2025-10-17 12:30:58 -07:00
< / div >
) ;
}