chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions 2

Fix oxlint errors: no-non-null-assertion and eqeqeq

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Parsons 2026-03-24 21:42:02 -07:00
parent 5fdf81b344
commit a18868e02b
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/golf-skills.ts
View file

@ -120,7 +120,7 @@ export async function batchUpsertGolfSkills(
participantId,
sportsSeasonId,
// decimal columns are stored/passed as strings in Drizzle
sgTotal: sgTotal != null ? String(sgTotal) : null,
sgTotal: sgTotal !== null && sgTotal !== undefined ? String(sgTotal) : null,
datagolfRank: datagolfRank ?? null,
mastersOdds: mastersOdds ?? null,
usOpenOdds: usOpenOdds ?? null,

4
app/services/simulations/__tests__/golf-simulator.test.ts
View file

@ -29,8 +29,8 @@ describe("americanToImplied", () => {
it("returns probability in (0, 1] for valid odds", () => {
const p = americanToImplied(200);
expect(p).not.toBeNull();
expect(p!).toBeGreaterThan(0);
expect(p!).toBeLessThanOrEqual(1);
expect(p).toBeGreaterThan(0);
expect(p).toBeLessThanOrEqual(1);
});
});

4
app/services/simulations/golf-simulator.ts
View file

@ -100,12 +100,12 @@ export function resolveSkill(
skills: GolfSkillsRecord | undefined,
oddsKey: keyof Pick<GolfSkillsRecord, "mastersOdds" | "usOpenOdds" | "openChampionshipOdds" | "pgaChampionshipOdds"> | null
): number {
if (skills?.sgTotal != null) {
if (skills?.sgTotal !== null && skills?.sgTotal !== undefined) {
return skills.sgTotal;
}
if (oddsKey && skills) {
const rawOdds = skills[oddsKey];
if (rawOdds != null) {
if (rawOdds !== null && rawOdds !== undefined) {
const implied = americanToImplied(rawOdds);
if (implied !== null) {
// Convert implied win probability to SG-equivalent: