chrisp/brackt
1
1
Fork 0
Code Issues 42 Pull requests Projects Releases Packages Wiki Activity Actions

mlb fix #87

Merged
chrisp merged 2 commits from claude/nice-goldberg-ub4bcy into main 2026-06-12 04:09:52 +00:00
Conversation 0 Commits 2 Files changed 2 +192 -8
chrisp commented 2026-06-12 02:53:41 +00:00
Owner
Copy link
No description provided.
chrisp added 2 commits 2026-06-12 02:53:42 +00:00 
When ESPN's API returns teams directly on the conference group (no division
children), all teams got division="" so only one team globally received
divisionRank=1. Fix by resolving division from a hardcoded team-name map
as a fallback, and scoping divisionRank computation per conference+division
to prevent AL/NL teams from sharing a group.

https://claude.ai/code/session_01288dkXYwKJUfXrEhPd8rmo
Fix divisionRank ordering and add warning for unknown teams
Some checks failed
🚀 Deploy / 🧪 Test (pull_request) Successful in 2m48s
Details
🚀 Deploy / ʦ🔍 Typecheck & Lint (pull_request) Failing after 49s
Details
🚀 Deploy / 🐳 Build (pull_request) Has been skipped
Details
🚀 Deploy / 🚀 Deploy (pull_request) Has been skipped
Details
0799177099 
Sort teams by win-loss within each division group before assigning
divisionRank so that the leader is always the best-record team, not
whichever team happened to appear first in ESPN's flat response.

Also warn to console when a team's displayName isn't in the hardcoded
MLB_TEAM_DIVISION map, surfacing renames or expansion teams immediately
instead of silently storing division="" and recreating the display bug.

https://claude.ai/code/session_01288dkXYwKJUfXrEhPd8rmo
chrisp force-pushed claude/nice-goldberg-ub4bcy from 0799177099 to c97e90b3ac 2026-06-12 04:04:33 +00:00 Compare
chrisp merged commit 058e96e67e into main 2026-06-12 04:09:52 +00:00
chrisp referenced this pull request from a commit 2026-06-12 04:09:54 +00:00
mlb fix (#87)
chrisp deleted branch claude/nice-goldberg-ub4bcy 2026-06-12 04:09:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
admin

Admin page tooling

  
defect

Something isn't working

  
draft

Related to the draft room

  
feature

New feature or request

  
infrastructure

Related to database/site infrastructure

  
new sport

Issue to add a new sport to the rotation

  
security

Things that can cause security issues

  
tech debt

Cleaning up things that will make us have a better life

  
ux

User interface or marketing

No labels
admin
defect
draft
feature
infrastructure
new sport
security
tech debt
ux
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: chrisp/brackt#87
No description provided.
Delete branch "claude/nice-goldberg-ub4bcy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?