- Drop now-unused `inArray` import from participant-expected-value.ts
(only the removed clearSourceOddsForParticipants used it).
- Use strict null/undefined check instead of `== null` in the test helper.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BHnoQ7myY3PzNdTnd7iGNE
Address two issues from code review:
- batchUpsertParticipantSimulatorInputs blindly COALESCE'd the metadata
column, preserving a stale sourceEloMethod/ratingMethod flag. A freshly
entered direct Elo/rating (Elo-ratings page, or the bulk CSV importer) was
then misclassified as generated and filtered out by
getParticipantSimulatorInputs, so the entered value was silently ignored.
Metadata now uses explicit caller metadata when given, otherwise preserves
existing flags but drops the method flag for any column receiving a fresh
direct value.
- The save-inputs auto-run catch reported success with "Simulation not run
yet" even when the simulation started and failed mid-run (leaving the season
in status 'failed'). It now re-checks the season status and reports a real
run failure distinctly from a not-ready/never-started run.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BHnoQ7myY3PzNdTnd7iGNE
Futures odds entry was split across two unrelated places: a standalone
/futures-odds page (which auto-ran the simulation on save and surfaced a
"Simulator is not ready" run failure as if the save itself had failed) and
the Bulk Simulator Inputs CSV importer on the simulator setup page.
Consolidate everything onto the Bulk Simulator Inputs card:
- batchUpsertParticipantSimulatorInputs now COALESCE-wraps every conflict
update column, so a partial paste (e.g. odds-only) updates just the columns
it provides instead of nulling out previously stored Elo/rating/etc.
- The bulk importer accepts sportsbook-style paste (one team per line ending
in American odds) when no CSV header is present, reusing the existing fuzzy
matcher, and auto-runs the simulation on save. A not-ready run is reported
as a successful save plus the readiness gap, never as a failed save.
- Retire the standalone /futures-odds page (now redirects to the simulator
setup page) and drop the redundant Futures links.
- Remove the now-dead futures-only model paths (batchSaveSourceOdds,
clearSourceOddsForParticipants, batchSaveFuturesOddsForSimulator,
batchSaveParticipantSimulatorSourceOdds); the EV-table bridge is preserved
by batchUpsertParticipantSimulatorInputs.
- Repoint the test to the consolidated path and assert the non-destructive
COALESCE behaviour.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BHnoQ7myY3PzNdTnd7iGNE
