chrisp
add196902b
## Summary - **Root cause**: `statsapi.mlb.com` returns 406 (deprecated). Switched MLB to ESPN's free standings API (`site.api.espn.com/apis/v2/sports/baseball/mlb/standings`), consistent with NBA, WNBA, and MLS. - **Refactor**: Extracted a shared `espn.ts` utility module, eliminating 4× duplication of `statsMap()`, `flattenEspnStandings()`, ESPN interfaces, and the `playoffSeed` → conference rank logic across adapters. - **Bug fixes** found during review and applied across all affected adapters: - `parseConferenceRank`: `|| undefined` falsy-zero bug replaced with `isNaN` guard - Sort comparators: stable alphabetical tiebreaker added to MLB, NBA, WNBA - `winPct`: falls back to `wins/(wins+losses)` if ESPN omits the stat (was silently 0) - statsMap pre-built once per entry before sorting in all adapters (was rebuilt per comparison) - WNBA `parseEntry`: accepts pre-computed `sm` instead of rebuilding it internally - MLB `gamesBack`: tests updated to reflect ESPN returns numeric `0` for division leaders (old API used `"-"` → `undefined`) ## Test plan - [ ] All 60 standings-sync unit tests pass (`npm run test:run -- app/services/standings-sync`) - [ ] Trigger MLB standings sync from admin panel and confirm it returns data without a 406 - [ ] Confirm NBA, WNBA, MLS syncs still work (adapters touched but behaviour unchanged) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Chris Parsons <chrisparsons1127@gmail.com> Reviewed-on: #62
87 lines
3 KiB
TypeScript
87 lines
3 KiB
TypeScript
import type { FetchedStandingsRecord, StandingsSyncAdapter } from "./types";
|
|
import {
|
|
flattenEspnStandings,
|
|
parseConferenceRank,
|
|
sortByWinLoss,
|
|
statsMap,
|
|
type EspnStandingsResponse,
|
|
} from "./espn";
|
|
|
|
const MLB_STANDINGS_URL =
|
|
"https://site.api.espn.com/apis/v2/sports/baseball/mlb/standings";
|
|
|
|
// "American League" → "AL", "National League" → "NL"
|
|
function abbreviateLeague(name: string): string {
|
|
if (name.startsWith("American")) return "AL";
|
|
if (name.startsWith("National")) return "NL";
|
|
return name;
|
|
}
|
|
|
|
// "American League East" → "AL East", "National League West" → "NL West"
|
|
function abbreviateDivision(name: string): string {
|
|
return name
|
|
.replace(/^American League /, "AL ")
|
|
.replace(/^National League /, "NL ");
|
|
}
|
|
|
|
export class MlbStandingsAdapter implements StandingsSyncAdapter {
|
|
async fetchStandings(): Promise<FetchedStandingsRecord[]> {
|
|
const response = await fetch(MLB_STANDINGS_URL);
|
|
if (!response.ok) {
|
|
throw new Error(`MLB standings API returned ${response.status}: ${response.statusText}`);
|
|
}
|
|
|
|
const json = (await response.json()) as EspnStandingsResponse;
|
|
const flattened = flattenEspnStandings(json);
|
|
|
|
if (flattened.length === 0) {
|
|
throw new Error("MLB standings API returned no entries — response shape may have changed");
|
|
}
|
|
|
|
// Pre-build statsMap once per entry so the sort doesn't rebuild it on every comparison.
|
|
const withSm = flattened.map(({ entry, conference, division }) => ({
|
|
entry,
|
|
conference,
|
|
division,
|
|
sm: statsMap(entry.stats),
|
|
}));
|
|
|
|
const sorted = [...withSm].toSorted(sortByWinLoss);
|
|
|
|
return sorted.map(({ entry, conference, division, sm }, leagueIdx): FetchedStandingsRecord => {
|
|
const wins = sm.get("wins")?.value ?? 0;
|
|
const losses = sm.get("losses")?.value ?? 0;
|
|
|
|
// Fall back to computing win% from wins/losses if ESPN omits the stat.
|
|
const winPctStat = sm.get("winPercent")?.value ?? sm.get("winPct")?.value;
|
|
const winPct = winPctStat ?? (wins + losses > 0 ? wins / (wins + losses) : 0);
|
|
|
|
const gamesBehind = sm.get("gamesBehind")?.value;
|
|
const streak = sm.get("streak")?.displayValue ?? sm.get("streakSummary")?.displayValue;
|
|
const lastTen =
|
|
sm.get("Last Ten Games")?.displayValue ?? sm.get("L10")?.displayValue ?? undefined;
|
|
const homeRecord = sm.get("Home")?.displayValue ?? undefined;
|
|
const awayRecord = sm.get("Road")?.displayValue ?? undefined;
|
|
|
|
const abbreviatedDiv = abbreviateDivision(division);
|
|
|
|
return {
|
|
teamName: entry.team.displayName,
|
|
externalTeamId: entry.team.id,
|
|
wins: Math.round(wins),
|
|
losses: Math.round(losses),
|
|
winPct,
|
|
gamesPlayed: Math.round(wins) + Math.round(losses),
|
|
gamesBack: gamesBehind,
|
|
conference: abbreviateLeague(conference),
|
|
division: abbreviatedDiv || undefined,
|
|
conferenceRank: parseConferenceRank(sm),
|
|
leagueRank: leagueIdx + 1,
|
|
streak,
|
|
lastTen,
|
|
homeRecord,
|
|
awayRecord,
|
|
};
|
|
});
|
|
}
|
|
}
|