* Fix no-shadow and consistent-function-scoping lint violations
Resolves all 11 no-shadow and 16 consistent-function-scoping oxlint
warnings and promotes both rules to errors in .oxlintrc.json.
no-shadow: renamed Drizzle callback params (sports→s, matches→m,
seasons→s) to avoid shadowing outer imports; removed shadowed
destructures (eq, inArray) from where callbacks; renamed inner
template→bracketTemplate, prev→currentTimers, season→ss, name→teamName
(with name: teamName fix to preserve semantics).
consistent-function-scoping: moved formatDate, getRankBadge,
getMovementIndicator, getPositionBadge, getStatusBadge, toDateStr,
elo (×2), weightedPick, sortByMatchNumber (×2) to module scope;
moved formatTime (×2), isValidLeagueName, getDraftTimes,
makeSeasonQueues to file scope in test files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix no-non-null-assertion lint violations and promote to error
Eliminates all 208 no-non-null-assertion warnings across 38 files.
Promotes typescript/no-non-null-assertion from warn to error in
.oxlintrc.json.
Fix patterns applied:
- Map.get(key)! after .has() check → extract with get() + null guard
- Map.get(key)! on pre-populated count maps → ?? 0 default
- .set(id, map.get(id)! + 1) increment → ?? 0 before adding
- participant1Id!/participant2Id! on DB matches → ?? "" fallback
- array.find()! in tests → guard + throw or expect().toBeDefined()
- bracketTemplateCache.get(id)! → null guard extract
- Various nullable field accesses → optional chain or ?? default
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix prefer-add-event-listener, no-unassigned-import, require-module-specifiers
Resolves all 9 remaining non-console lint warnings and promotes all
three rules to errors in .oxlintrc.json.
- prefer-add-event-listener: converted onchange/onclick/onload
assignments to addEventListener in useDraftNotifications.ts and
admin.data-sync.tsx; stored changeHandler ref for proper cleanup
with removeEventListener
- no-unassigned-import: configured rule with allow list for legitimate
side-effect imports (*.css, @testing-library/jest-dom,
@testing-library/cypress/add-commands)
- require-module-specifiers: removed redundant `export {}` from
cypress/support/e2e.ts (file already has an import)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Fix TypeScript errors from no-non-null-assertion fixes
Two fixes introduced by the non-null assertion cleanup produced type
errors:
- scoring-event.ts: `?? ""` was wrong type for a participant object map;
restructured to explicit null guards so TypeScript can narrow correctly
- standings-sync/index.ts: `?? null` after name-match lookup lost the
truthy guarantee, causing TS18047 on the write-back block; added
`participant &&` guard before accessing its properties
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* Add npm run typecheck as Stop hook in Claude settings
Runs a full project typecheck at the end of each Claude turn so type
errors surface as feedback before the next message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
139 lines
5.1 KiB
TypeScript
139 lines
5.1 KiB
TypeScript
import { database } from "~/database/context";
|
|
import { eq } from "drizzle-orm";
|
|
import * as schema from "~/database/schema";
|
|
import { findParticipantsBySportsSeasonId, updateParticipant } from "~/models/participant";
|
|
import { upsertRegularSeasonStandings } from "~/models/regular-season-standings";
|
|
import { upsertPendingStandingsMappings } from "~/models/pending-standings-mappings";
|
|
import { findMatchingTeamName } from "~/lib/normalize-team-name";
|
|
import { NhlStandingsAdapter } from "./nhl";
|
|
import { NbaStandingsAdapter } from "./nba";
|
|
import type { StandingsSyncAdapter, SyncResult, UnmatchedTeam } from "./types";
|
|
|
|
/**
|
|
* Map a simulator type to its standings sync adapter.
|
|
* Returns null for sports that don't use regularSeasonStandings
|
|
* (e.g. season_standings sports like F1 will use a different path when implemented).
|
|
*/
|
|
function getAdapter(simulatorType: string): StandingsSyncAdapter {
|
|
switch (simulatorType) {
|
|
case "nba_bracket":
|
|
return new NbaStandingsAdapter();
|
|
case "nhl_bracket":
|
|
return new NhlStandingsAdapter();
|
|
case "f1_standings":
|
|
throw new Error(
|
|
"F1 standings sync is not yet implemented. Use the manual standings page."
|
|
);
|
|
case "indycar_standings":
|
|
throw new Error(
|
|
"IndyCar standings sync is not yet implemented. Use the manual standings page."
|
|
);
|
|
default:
|
|
throw new Error(
|
|
`No standings sync adapter available for simulator type "${simulatorType}". ` +
|
|
"Only NBA and NHL are currently supported."
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Sync current standings from the appropriate external API for a sports season.
|
|
* Matches API team names to participants by name and bulk-upserts the results.
|
|
*
|
|
* Returns the count of synced teams and any API team names that couldn't be matched.
|
|
*/
|
|
export async function syncStandings(sportsSeasonId: string): Promise<SyncResult> {
|
|
const db = database();
|
|
|
|
// Load sports season with sport relation
|
|
const sportsSeason = await db.query.sportsSeasons.findFirst({
|
|
where: eq(schema.sportsSeasons.id, sportsSeasonId),
|
|
with: { sport: true },
|
|
});
|
|
|
|
if (!sportsSeason) {
|
|
throw new Error(`Sports season ${sportsSeasonId} not found`);
|
|
}
|
|
|
|
const simulatorType = sportsSeason.sport?.simulatorType;
|
|
if (!simulatorType) {
|
|
const sportName = sportsSeason.sport?.name ?? "(no sport linked)";
|
|
throw new Error(`Sport "${sportName}" has no simulator type configured`);
|
|
}
|
|
|
|
const adapter = getAdapter(simulatorType);
|
|
const fetchedRecords = await adapter.fetchStandings();
|
|
|
|
// Load all participants for this season
|
|
const participants = await findParticipantsBySportsSeasonId(sportsSeasonId);
|
|
const participantNames = participants.map((p) => p.name);
|
|
const participantByName = new Map(participants.map((p) => [p.name, p]));
|
|
// Build a map of externalId → participant for ID-first matching
|
|
const participantByExternalId = new Map(
|
|
participants.filter((p) => p.externalId).map((p) => [p.externalId ?? "", p])
|
|
);
|
|
|
|
const toUpsert: Parameters<typeof upsertRegularSeasonStandings>[0] = [];
|
|
const unmatchedRecords: typeof fetchedRecords = [];
|
|
|
|
for (const record of fetchedRecords) {
|
|
// Strategy A: try externalId-first (bypasses name matching entirely after first sync)
|
|
let participant = participantByExternalId.get(record.externalTeamId) ?? null;
|
|
|
|
if (!participant) {
|
|
// Fall back to name matching
|
|
const matchedName = findMatchingTeamName(record.teamName, participantNames);
|
|
if (matchedName) {
|
|
participant = participantByName.get(matchedName) ?? null;
|
|
// Write-back: persist externalId so future syncs skip name matching for this team
|
|
if (participant && !participant.externalId) {
|
|
await updateParticipant(participant.id, { externalId: record.externalTeamId });
|
|
}
|
|
}
|
|
}
|
|
|
|
if (!participant) {
|
|
unmatchedRecords.push(record);
|
|
continue;
|
|
}
|
|
|
|
toUpsert.push({
|
|
participantId: participant.id,
|
|
sportsSeasonId,
|
|
wins: record.wins,
|
|
losses: record.losses,
|
|
otLosses: record.otLosses ?? null,
|
|
ties: record.ties ?? null,
|
|
winPct: record.winPct,
|
|
gamesPlayed: record.gamesPlayed,
|
|
gamesBack: record.gamesBack ?? null,
|
|
conference: record.conference ?? null,
|
|
division: record.division ?? null,
|
|
conferenceRank: record.conferenceRank ?? null,
|
|
divisionRank: record.divisionRank ?? null,
|
|
leagueRank: record.leagueRank,
|
|
streak: record.streak ?? null,
|
|
lastTen: record.lastTen ?? null,
|
|
homeRecord: record.homeRecord ?? null,
|
|
awayRecord: record.awayRecord ?? null,
|
|
externalTeamId: record.externalTeamId,
|
|
syncedAt: new Date(),
|
|
});
|
|
}
|
|
|
|
if (toUpsert.length > 0) {
|
|
await upsertRegularSeasonStandings(toUpsert);
|
|
}
|
|
|
|
// Persist unmatched records so admin can resolve them without losing data on page reload
|
|
if (unmatchedRecords.length > 0) {
|
|
await upsertPendingStandingsMappings(sportsSeasonId, unmatchedRecords);
|
|
}
|
|
|
|
const unmatched: UnmatchedTeam[] = unmatchedRecords.map((r) => ({
|
|
teamName: r.teamName,
|
|
externalTeamId: r.externalTeamId,
|
|
}));
|
|
|
|
return { synced: toUpsert.length, unmatched };
|
|
}
|