brackt/app/routes/leagues/__tests__/README.md

Team Management Integration Tests

Overview

This directory contains integration tests for the team management feature in league settings. The tests are written using Vitest and cover the following functionality:

• Remove Team Owner: Commissioners can remove owners from teams
• Assign Team Owner: Admins can assign users to teams via dropdown
• Authorization: Proper access control for commissioners vs admins
• Edge Cases: Handling invalid inputs and error scenarios
• Integration Scenarios: Complete workflows and multi-team operations

Test Structure

Test File

• team-management.test.ts - Main test suite for team management features

Fixtures

• app/test/fixtures/user.ts - Mock user data including admin and regular users
• app/test/fixtures/team.ts - Mock team data
• app/test/fixtures/league.ts - Mock league data

Running Tests

Run all tests

npm test

Run tests in watch mode

npm run dev:test

Run tests with UI

npm run test:ui

Run tests with coverage

npm run test:coverage

Run only team management tests

npm test team-management

Test Coverage

The test suite covers:

1. Remove Owner Functionality (4 tests)

• ✅ Successfully remove an owner from a team
• ✅ Handle errors when removal fails
• ✅ Allow commissioners to remove owners
• ✅ Verify proper database calls

2. Assign Owner Functionality (5 tests)

• ✅ Successfully assign an owner to a team
• ✅ Handle errors when assignment fails
• ✅ Only allow admins to assign owners
• ✅ Prevent non-admins from assigning owners
• ✅ Replace existing owner when assigning new owner

3. Admin User List (3 tests)

• ✅ Fetch all users for admin dropdown
• ✅ Only fetch users when user is admin
• ✅ Return empty array for non-admin users

4. Authorization (3 tests)

• ✅ Verify admin status before allowing assignment
• ✅ Reject assignment for non-admin users
• ✅ Allow commissioners to remove owners regardless of admin status

5. Edge Cases (6 tests)

• ✅ Prevent assigning user who already owns a team in the league
• ✅ Handle removing owner from team with no owner
• ✅ Handle assigning owner to team that already has owner
• ✅ Handle invalid team ID gracefully
• ✅ Handle invalid user clerk ID gracefully
• ✅ Proper error messages

6. Integration Scenarios (3 tests)

• ✅ Complete workflow: assign then remove owner
• ✅ Reassigning owner from one user to another
• ✅ Handle multiple teams with different ownership states

Total: 24 tests

Key Features Tested

Commissioner Capabilities

• Remove owners from any team in their league
• No ability to assign owners (admin-only)

Admin Capabilities

• Remove owners from any team
• Assign any user to any team via dropdown
• Access to full user list for assignment

Security

• Admin-only check enforced for assignments
• Commissioner access verified for removals
• Proper error handling for unauthorized access

Mocking Strategy

The tests use Vitest's mocking capabilities to:

• Mock database operations (removeTeamOwner, assignTeamOwner)
• Mock user authentication (isUserAdminByClerkId)
• Mock user data fetching (findAllUsers)
• Simulate various success and error scenarios

Future Enhancements

Potential additions to the test suite:

• Test UI component rendering
• Test form validation
• Test loading states
• Test success/error toast messages
• Test concurrent operations
• Test with real database (integration tests)
• Performance tests for large user lists