The chain (checkAndTriggerNextAutodraft) picks consecutive while_on teams immediately after a pick, but is capped at totalTeams iterations. Once the cap is hit, the next while_on team had to wait for the full timer countdown before their pick fired — which users experienced as autodraft intermittently not working. Root cause fix: the timer loop now detects while_on mode and triggers the pick immediately (≤1 s) regardless of time remaining, bypassing the countdown. A timer-update with timeRemaining:0 is emitted first so clients don't see a frozen timer. If the chain already handled the pick, executeAutoPick returns "Pick already made" and the timer moves on harmlessly. Additional fixes: - Add timerTickRunning guard so concurrent setInterval ticks (when a chain takes >1 s) don't race on the same pick slot - Use onConflictDoNothing on the draft pick INSERT in executeAutoPick so a DB unique-constraint collision is treated as "Pick already made" rather than pausing the draft - Cache draftSlots per season in the timer loop (slots never change during an active draft) — eliminates one DB query per tick - currentPickNumber || 1 → ?? 1 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
269 lines
9.1 KiB
TypeScript
269 lines
9.1 KiB
TypeScript
import { drizzle } from "drizzle-orm/postgres-js";
|
|
import postgres from "postgres";
|
|
import * as schema from "~/database/schema";
|
|
import { eq, and, asc, sql } from "drizzle-orm";
|
|
import type { InferSelectModel } from "drizzle-orm";
|
|
import { getSocketIO } from "./socket";
|
|
import { executeAutoPick, calculatePickInfo } from "~/models/draft-utils";
|
|
import { logger } from "./logger";
|
|
|
|
// Create a dedicated database connection for the timer
|
|
const connectionString = process.env.DATABASE_URL;
|
|
if (!connectionString) {
|
|
throw new Error("DATABASE_URL is required for timer system");
|
|
}
|
|
const client = postgres(connectionString);
|
|
const db = drizzle(client, { schema });
|
|
|
|
let timerInterval: NodeJS.Timeout | null = null;
|
|
let timerTickRunning = false;
|
|
|
|
// Draft slots never change during an active draft — cache them to avoid
|
|
// a redundant query on every tick.
|
|
const draftSlotsCache = new Map<string, { teamId: string; draftOrder: number }[]>();
|
|
|
|
/**
|
|
* Start the draft timer system
|
|
* Runs every second to update all active draft timers
|
|
*/
|
|
export function startDraftTimerSystem(): void {
|
|
if (timerInterval) {
|
|
logger.log("[Timer] Timer system already running");
|
|
return;
|
|
}
|
|
|
|
timerInterval = setInterval(async () => {
|
|
// Skip this tick if the previous one is still running (e.g. long autodraft chain)
|
|
// to prevent concurrent ticks from racing on the same pick slot.
|
|
if (timerTickRunning) return;
|
|
timerTickRunning = true;
|
|
try {
|
|
await updateDraftTimers();
|
|
} catch (error) {
|
|
logger.error("[Timer] Error updating draft timers:", error);
|
|
} finally {
|
|
timerTickRunning = false;
|
|
}
|
|
}, 1000);
|
|
|
|
logger.log("[Timer] Draft timer system started");
|
|
}
|
|
|
|
/**
|
|
* Stop the draft timer system
|
|
*/
|
|
export function stopDraftTimerSystem(): void {
|
|
if (timerInterval) {
|
|
clearInterval(timerInterval);
|
|
timerInterval = null;
|
|
logger.log("[Timer] Draft timer system stopped");
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Update all active draft timers
|
|
* Called every second by the timer interval
|
|
*/
|
|
async function updateDraftTimers(): Promise<void> {
|
|
const io = getSocketIO();
|
|
|
|
// Get all active drafts
|
|
const activeDrafts = await db.query.seasons.findMany({
|
|
where: eq(schema.seasons.status, "draft"),
|
|
});
|
|
|
|
if (activeDrafts.length === 0) {
|
|
draftSlotsCache.clear();
|
|
return;
|
|
}
|
|
|
|
// Evict cache entries for seasons no longer actively drafting.
|
|
const activeIds = new Set(activeDrafts.map((s) => s.id));
|
|
for (const cachedId of draftSlotsCache.keys()) {
|
|
if (!activeIds.has(cachedId)) draftSlotsCache.delete(cachedId);
|
|
}
|
|
|
|
for (const season of activeDrafts) {
|
|
// Skip if draft is paused
|
|
if (season.draftPaused) {
|
|
continue;
|
|
}
|
|
|
|
const currentPickNumber = season.currentPickNumber ?? 1;
|
|
|
|
// Draft slots never change during an active draft — use the cache.
|
|
let draftSlots = draftSlotsCache.get(season.id);
|
|
if (!draftSlots) {
|
|
draftSlots = await db.query.draftSlots.findMany({
|
|
where: eq(schema.draftSlots.seasonId, season.id),
|
|
orderBy: asc(schema.draftSlots.draftOrder),
|
|
});
|
|
draftSlotsCache.set(season.id, draftSlots);
|
|
}
|
|
|
|
const totalTeams = draftSlots.length;
|
|
if (totalTeams === 0) continue;
|
|
|
|
const { pickInRound } = calculatePickInfo(currentPickNumber, totalTeams);
|
|
const currentDraftSlot = draftSlots.find(
|
|
(slot) => slot.draftOrder === pickInRound
|
|
);
|
|
|
|
if (!currentDraftSlot) {
|
|
continue;
|
|
}
|
|
|
|
const currentTeamId = currentDraftSlot.teamId;
|
|
|
|
// Get current team's timer
|
|
const timer = await db.query.draftTimers.findFirst({
|
|
where: and(
|
|
eq(schema.draftTimers.seasonId, season.id),
|
|
eq(schema.draftTimers.teamId, currentTeamId)
|
|
),
|
|
});
|
|
|
|
if (!timer) {
|
|
logger.warn(
|
|
`[Timer] No timer found for team ${currentTeamId} in season ${season.id}, creating with initial time`
|
|
);
|
|
// Standard mode seeds with the per-pick time; chess clock seeds with the full bank.
|
|
const initialTime = season.draftTimerMode === "standard"
|
|
? (season.draftIncrementTime || 30)
|
|
: (season.draftInitialTime || 120);
|
|
await db
|
|
.insert(schema.draftTimers)
|
|
.values({
|
|
seasonId: season.id,
|
|
teamId: currentTeamId,
|
|
timeRemaining: initialTime,
|
|
});
|
|
|
|
// Emit timer update so clients are aware of the new timer
|
|
io.to(`draft-${season.id}`).emit("timer-update", {
|
|
seasonId: season.id,
|
|
teamId: currentTeamId,
|
|
timeRemaining: initialTime,
|
|
currentPickNumber,
|
|
});
|
|
|
|
// Continue processing with the newly created timer on the next tick
|
|
continue;
|
|
}
|
|
|
|
// Fetch autodraft settings once — used both for while_on bypass and timer-expiry path.
|
|
const autodraftSettings = await db.query.autodraftSettings.findFirst({
|
|
where: and(
|
|
eq(schema.autodraftSettings.seasonId, season.id),
|
|
eq(schema.autodraftSettings.teamId, currentTeamId)
|
|
),
|
|
});
|
|
const shouldAutodraft = autodraftSettings?.isEnabled ?? false;
|
|
// while_on means "pick immediately when it's my turn" — bypass the countdown.
|
|
const isWhileOn = shouldAutodraft && autodraftSettings?.mode === "while_on";
|
|
|
|
// Trigger pick when: timer expired OR team is in while_on autodraft mode.
|
|
// The chain picks consecutive while_on teams after each pick, but it is capped at
|
|
// totalTeams iterations. The while_on bypass here fills the gap: the timer picks
|
|
// the next while_on team within one tick (≤1 s) rather than waiting for the full
|
|
// countdown to expire. If the chain already made this pick, executeAutoPick
|
|
// returns "Pick already made" which triggerAutoPick treats as a non-fatal no-op.
|
|
if (timer.timeRemaining <= 0 || isWhileOn) {
|
|
if (timer.timeRemaining <= 0) {
|
|
logger.log(
|
|
`[Timer] ⚠️ Timer expired for team ${currentTeamId} in season ${season.id} (pick ${currentPickNumber})`
|
|
);
|
|
} else {
|
|
logger.log(
|
|
`[Timer] ⚡ while_on autodraft — immediate pick for team ${currentTeamId} in season ${season.id} (pick ${currentPickNumber})`
|
|
);
|
|
// Emit 0 so clients see the timer hit zero before the pick-made event arrives.
|
|
io.to(`draft-${season.id}`).emit("timer-update", {
|
|
seasonId: season.id,
|
|
teamId: currentTeamId,
|
|
timeRemaining: 0,
|
|
currentPickNumber,
|
|
});
|
|
}
|
|
|
|
const success = await triggerAutoPick(season.id, currentTeamId, currentPickNumber, shouldAutodraft ? (autodraftSettings ?? null) : null);
|
|
|
|
if (!success) {
|
|
logger.error(`[Timer] Pausing draft ${season.id} — auto-pick failed for team ${currentTeamId} pick ${currentPickNumber}`);
|
|
await db.update(schema.seasons).set({ draftPaused: true }).where(eq(schema.seasons.id, season.id));
|
|
io.to(`draft-${season.id}`).emit("draft-paused", { seasonId: season.id, paused: true });
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
// Atomically decrement timer (race-condition safe: uses DB-level update
|
|
// so concurrent increments from pick handlers are never overwritten)
|
|
const [updatedTimer] = await db
|
|
.update(schema.draftTimers)
|
|
.set({
|
|
timeRemaining: sql`GREATEST(${schema.draftTimers.timeRemaining} - 1, 0)`,
|
|
updatedAt: new Date(),
|
|
})
|
|
.where(eq(schema.draftTimers.id, timer.id))
|
|
.returning();
|
|
|
|
const newTimeRemaining = updatedTimer?.timeRemaining ?? 0;
|
|
|
|
// Emit timer update to all clients in the draft room
|
|
io.to(`draft-${season.id}`).emit("timer-update", {
|
|
seasonId: season.id,
|
|
teamId: currentTeamId,
|
|
timeRemaining: newTimeRemaining,
|
|
currentPickNumber,
|
|
});
|
|
|
|
// If timer just hit 0, trigger auto-pick (next_pick mode or no autodraft)
|
|
if (newTimeRemaining === 0) {
|
|
const success = await triggerAutoPick(season.id, currentTeamId, currentPickNumber, shouldAutodraft ? (autodraftSettings ?? null) : null);
|
|
|
|
if (!success) {
|
|
logger.error(`[Timer] Pausing draft ${season.id} — auto-pick failed for team ${currentTeamId} pick ${currentPickNumber}`);
|
|
await db.update(schema.seasons).set({ draftPaused: true }).where(eq(schema.seasons.id, season.id));
|
|
io.to(`draft-${season.id}`).emit("draft-paused", { seasonId: season.id, paused: true });
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Trigger an automatic pick when timer expires.
|
|
* Returns true if the pick succeeded (or was already made by another path),
|
|
* false if a real failure occurred that requires commissioner intervention.
|
|
*/
|
|
async function triggerAutoPick(
|
|
seasonId: string,
|
|
teamId: string,
|
|
pickNumber: number,
|
|
autodraftSettings: InferSelectModel<typeof schema.autodraftSettings> | null
|
|
): Promise<boolean> {
|
|
try {
|
|
const result = await executeAutoPick({
|
|
seasonId,
|
|
teamId,
|
|
pickNumber,
|
|
triggeredBy: "timer",
|
|
autodraftSettings,
|
|
db,
|
|
});
|
|
|
|
if (!result.success) {
|
|
// A race condition where the pick was already made is not a real failure
|
|
if (result.error === "Pick already made") {
|
|
return true;
|
|
}
|
|
logger.error(`[Timer] Auto-pick failed: ${result.error}`);
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
} catch (error) {
|
|
logger.error("[Timer] Error in triggerAutoPick:", error);
|
|
return false;
|
|
}
|
|
}
|