brackt/app/services/simulations/runner.ts

176 lines
6.2 KiB
TypeScript
Raw Normal View History

Formalize simulator system with manifest, input-policy, runner, and admin UI (#409) Introduces three new schema tables (simulator_profiles, sports_season_simulator_configs, season_participant_simulator_inputs), a central model layer (app/models/simulator.ts), and a single runner entry point so every simulator run follows the same prepare → simulate → persist → snapshot → recalculate flow. Key additions: - manifest.ts: per-simulator display names, default configs, required/ optional inputs, derivable-input declarations, and setup sections - input-policy.ts: resolves sourceElo from projectedWins, projectedTablePoints, or sourceOdds; resolves ratings from sourceOdds; supports block / fallbackElo / averageKnown / worstKnownMinus strategies - runner.ts: single entry point for admin simulation runs; materialises derived inputs, normalises result columns, zeroes omitted participants, snapshots EVs, and recalculates linked fantasy standings - /admin/simulators: inventory page with per-season readiness and bulk run - /admin/sports-seasons/:id/simulator: per-season setup page with readiness summary, input-policy editor, raw JSON config override, and CSV bulk input - NCAAM/NCAAW simulators now read ratings from season_participant_simulator_inputs, falling back to the hardcoded name-keyed maps while DB data is being populated - Clone flow copies simulator config by default; volatile inputs (odds, Elo) only copied when explicitly requested Code-review fixes included in this commit: - source field in compatibility bridge checked with !== null instead of !== undefined - sourceEloRequirementLabel no longer appends "configured fallback" when the participant is already excluded from all resolved sources - Duplicate inline label maps in input-policy.ts replaced with simulatorInputLabel - save-config preserves existing inputPolicy when the submitted JSON omits it - Input table truncation label added (Showing 20 of N) - CSV description notes values must not contain commas - N+1 comment added to listSportsSeasonSimulatorSummaries - assertRegistrySchemaDriftFree called in manifest tests - Runner test suite added covering happy path, already-running guard, readiness failure, empty results, and error recovery with status reset Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-11 21:09:53 -07:00
import { eq } from "drizzle-orm";
import { database } from "~/database/context";
import * as schema from "~/database/schema";
import { DEFAULT_SCORING_RULES } from "~/lib/scoring-types";
import type { ScoringRules } from "~/services/ev-calculator";
import { batchUpsertParticipantEvSnapshots } from "~/models/ev-snapshot";
import { batchUpsertParticipantEVs } from "~/models/participant-expected-value";
import { recalculateStandings } from "~/models/scoring-calculator";
import { findParticipantsBySportsSeasonId } from "~/models/season-participant";
import { findSportsSeasonById, updateSportsSeason } from "~/models/sports-season";
import { calculateEV } from "~/services/ev-calculator";
import { getSimulator, type SimulatorType } from "~/services/simulations/registry";
import { normalizeSimulationResultColumns } from "~/services/simulations/simulation-probabilities";
import {
getSportsSeasonSimulatorConfig,
prepareSimulatorInputsForRun,
validateSimulatorReadiness,
} from "~/models/simulator";
const ZERO_PROBS = {
probFirst: 0,
probSecond: 0,
probThird: 0,
probFourth: 0,
probFifth: 0,
probSixth: 0,
probSeventh: 0,
probEighth: 0,
};
async function getPersistenceContext(
simulatorType: SimulatorType,
sportsSeason: Awaited<ReturnType<typeof findSportsSeasonById>>
): Promise<{ scoringRules: ScoringRules; source: "elo_simulation" | "performance_model" }> {
if (simulatorType !== "brackt") {
return { scoringRules: DEFAULT_SCORING_RULES, source: "elo_simulation" };
}
if (!sportsSeason?.fantasySeasonId) {
throw new Error("Brackt simulations must run against a private per-league sports season, not the global Brackt template.");
}
const fantasySeason = await database().query.seasons.findFirst({
where: eq(schema.seasons.id, sportsSeason.fantasySeasonId),
});
if (!fantasySeason) {
throw new Error("Linked fantasy season not found for Brackt simulation.");
}
return {
source: "performance_model",
scoringRules: {
pointsFor1st: fantasySeason.pointsFor1st,
pointsFor2nd: fantasySeason.pointsFor2nd,
pointsFor3rd: fantasySeason.pointsFor3rd,
pointsFor4th: fantasySeason.pointsFor4th,
pointsFor5th: fantasySeason.pointsFor5th,
pointsFor6th: fantasySeason.pointsFor6th,
pointsFor7th: fantasySeason.pointsFor7th,
pointsFor8th: fantasySeason.pointsFor8th,
},
};
}
export interface RunSportsSeasonSimulationResult {
sportsSeasonId: string;
simulatorType: SimulatorType;
simulatedParticipants: number;
zeroedParticipants: number;
snapshotDate: string;
}
export async function runSportsSeasonSimulation(
sportsSeasonId: string
): Promise<RunSportsSeasonSimulationResult> {
const sportsSeason = await findSportsSeasonById(sportsSeasonId);
if (!sportsSeason) {
throw new Error("Sports season not found");
}
if (sportsSeason.status === "completed") {
throw new Error("Completed sports seasons cannot be simulated.");
}
Formalize simulator system with manifest, input-policy, runner, and admin UI (#409) Introduces three new schema tables (simulator_profiles, sports_season_simulator_configs, season_participant_simulator_inputs), a central model layer (app/models/simulator.ts), and a single runner entry point so every simulator run follows the same prepare → simulate → persist → snapshot → recalculate flow. Key additions: - manifest.ts: per-simulator display names, default configs, required/ optional inputs, derivable-input declarations, and setup sections - input-policy.ts: resolves sourceElo from projectedWins, projectedTablePoints, or sourceOdds; resolves ratings from sourceOdds; supports block / fallbackElo / averageKnown / worstKnownMinus strategies - runner.ts: single entry point for admin simulation runs; materialises derived inputs, normalises result columns, zeroes omitted participants, snapshots EVs, and recalculates linked fantasy standings - /admin/simulators: inventory page with per-season readiness and bulk run - /admin/sports-seasons/:id/simulator: per-season setup page with readiness summary, input-policy editor, raw JSON config override, and CSV bulk input - NCAAM/NCAAW simulators now read ratings from season_participant_simulator_inputs, falling back to the hardcoded name-keyed maps while DB data is being populated - Clone flow copies simulator config by default; volatile inputs (odds, Elo) only copied when explicitly requested Code-review fixes included in this commit: - source field in compatibility bridge checked with !== null instead of !== undefined - sourceEloRequirementLabel no longer appends "configured fallback" when the participant is already excluded from all resolved sources - Duplicate inline label maps in input-policy.ts replaced with simulatorInputLabel - save-config preserves existing inputPolicy when the submitted JSON omits it - Input table truncation label added (Showing 20 of N) - CSV description notes values must not contain commas - N+1 comment added to listSportsSeasonSimulatorSummaries - assertRegistrySchemaDriftFree called in manifest tests - Runner test suite added covering happy path, already-running guard, readiness failure, empty results, and error recovery with status reset Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-11 21:09:53 -07:00
const simulatorConfig = await getSportsSeasonSimulatorConfig(sportsSeasonId);
if (!simulatorConfig) {
throw new Error(
"This sport has no simulator type configured. Set a simulator type on the sport in the admin panel before running a simulation."
);
}
if (sportsSeason.simulationStatus === "running") {
throw new Error("A simulation is already running for this sports season. Please wait for it to complete.");
}
const readiness = await validateSimulatorReadiness(sportsSeasonId);
if (!readiness.canRun) {
throw new Error(
`Simulator is not ready: ${readiness.missingInputs.join(", ") || "missing required setup"}.`
);
}
await prepareSimulatorInputsForRun(sportsSeasonId);
await updateSportsSeason(sportsSeasonId, { simulationStatus: "running" });
try {
const simulator = getSimulator(simulatorConfig.simulatorType);
Unify simulator strength on a single blended Elo Replace the two parallel odds/Elo mechanisms with one model: every strength source (raw Elo, projected wins, projected table points, futures odds) converts to an Elo, those blend by weight into a single Elo, and that one Elo feeds every simulator. This supersedes the earlier source-priority + per-match probability blend approach. Resolution (app/services/simulations/input-policy.ts): - SimulatorInputPolicy gains baseEloPriority (order among the substitutable base sources: raw Elo / projected wins / projected table points) and oddsWeight (0–1). resolveSourceElos/resolveRatings now compute baseElo, derive an odds Elo via convertFuturesToElo, and blend: 0 = base only, 1 = futures override, between = weighted blend (method "blend"). - Drops the odds-inclusive sourceEloPriority and the prefersFuturesOdds helper. Simulators consume the single resolved Elo: - UCL, World Cup, NCAA Football, MLB drop their separate normalized-odds signal, convertFuturesToElo calls, and per-match probability blend; they read the resolved sourceElo (preserving each sim's hardcoded fallback Elo table). The optional SimulationContext oddsWeight plumbing (types.ts/runner.ts) is removed. - UCL is routed through the central blend (requiredInputs sourceElo, derivable from sourceOdds) so any entered Elo and futures blend uniformly. - College hockey already blends odds into Elo internally (and uses NPI rank the central resolver can't), so its central oddsWeight is set to 0 to avoid double-counting; the simulator is unchanged. Manifest: per-profile oddsWeight defaults (World Cup/UCL/MLB 0.3, NCAA FB 0.4, college hockey 0; global default 0.3). UI: the Input Policy card exposes one "Futures vs. Elo — Odds Blend Weight" control; the /admin/simulators inventory badge shows the effective blend ("Elo only" / "NN% blend" / "overrides Elo") with the odds participant count. Tests: input-policy blend math (0/0.5/1) for Elo and ratings, baseEloPriority and oddsWeight parsing/clamping, manifest per-profile weights; obsolete source-priority and oddsWeight-context tests removed/replaced. Note: this intentionally shifts the calibrated EV outputs of the four sims that previously blended at the probability level (accepted in design discussion). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QhNeB7gN6VKene7sdbBVQT
2026-06-26 01:39:12 +00:00
const results = await simulator.simulate(sportsSeasonId);
Formalize simulator system with manifest, input-policy, runner, and admin UI (#409) Introduces three new schema tables (simulator_profiles, sports_season_simulator_configs, season_participant_simulator_inputs), a central model layer (app/models/simulator.ts), and a single runner entry point so every simulator run follows the same prepare → simulate → persist → snapshot → recalculate flow. Key additions: - manifest.ts: per-simulator display names, default configs, required/ optional inputs, derivable-input declarations, and setup sections - input-policy.ts: resolves sourceElo from projectedWins, projectedTablePoints, or sourceOdds; resolves ratings from sourceOdds; supports block / fallbackElo / averageKnown / worstKnownMinus strategies - runner.ts: single entry point for admin simulation runs; materialises derived inputs, normalises result columns, zeroes omitted participants, snapshots EVs, and recalculates linked fantasy standings - /admin/simulators: inventory page with per-season readiness and bulk run - /admin/sports-seasons/:id/simulator: per-season setup page with readiness summary, input-policy editor, raw JSON config override, and CSV bulk input - NCAAM/NCAAW simulators now read ratings from season_participant_simulator_inputs, falling back to the hardcoded name-keyed maps while DB data is being populated - Clone flow copies simulator config by default; volatile inputs (odds, Elo) only copied when explicitly requested Code-review fixes included in this commit: - source field in compatibility bridge checked with !== null instead of !== undefined - sourceEloRequirementLabel no longer appends "configured fallback" when the participant is already excluded from all resolved sources - Duplicate inline label maps in input-policy.ts replaced with simulatorInputLabel - save-config preserves existing inputPolicy when the submitted JSON omits it - Input table truncation label added (Showing 20 of N) - CSV description notes values must not contain commas - N+1 comment added to listSportsSeasonSimulatorSummaries - assertRegistrySchemaDriftFree called in manifest tests - Runner test suite added covering happy path, already-running guard, readiness failure, empty results, and error recovery with status reset Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-11 21:09:53 -07:00
if (results.length === 0) {
throw new Error("Simulation returned no results. Check that participants have simulator input data.");
}
normalizeSimulationResultColumns(results);
const allSeasonParticipants = await findParticipantsBySportsSeasonId(sportsSeasonId);
const simulatedIds = new Set(results.map((r) => r.participantId));
const zeroedParticipants = allSeasonParticipants.filter((p) => !simulatedIds.has(p.id));
const persistence = await getPersistenceContext(simulatorConfig.simulatorType, sportsSeason);
await batchUpsertParticipantEVs([
...results.map((r) => ({
participantId: r.participantId,
sportsSeasonId,
probabilities: r.probabilities,
scoringRules: persistence.scoringRules,
source: persistence.source,
})),
...zeroedParticipants.map((p) => ({
participantId: p.id,
sportsSeasonId,
probabilities: ZERO_PROBS,
scoringRules: persistence.scoringRules,
source: persistence.source,
})),
]);
const seasonSports = await database().query.seasonSports.findMany({
where: eq(schema.seasonSports.sportsSeasonId, sportsSeasonId),
});
await Promise.all(seasonSports.map(({ seasonId }) => recalculateStandings(seasonId)));
const snapshotDate = new Date().toISOString().slice(0, 10);
await batchUpsertParticipantEvSnapshots(
results.map((r) => ({
participantId: r.participantId,
sportsSeasonId,
snapshotDate,
probFirst: r.probabilities.probFirst,
probSecond: r.probabilities.probSecond,
probThird: r.probabilities.probThird,
probFourth: r.probabilities.probFourth,
probFifth: r.probabilities.probFifth,
probSixth: r.probabilities.probSixth,
probSeventh: r.probabilities.probSeventh,
probEighth: r.probabilities.probEighth,
calculatedEV: calculateEV(r.probabilities, persistence.scoringRules),
source: r.source,
}))
);
await updateSportsSeason(sportsSeasonId, { simulationStatus: "idle" });
return {
sportsSeasonId,
simulatorType: simulatorConfig.simulatorType,
simulatedParticipants: results.length,
zeroedParticipants: zeroedParticipants.length,
snapshotDate,
};
} catch (error) {
await updateSportsSeason(sportsSeasonId, { simulationStatus: "failed" });
throw error;
}
}