scoring notifications #115

Merged

chrisp merged 2 commits from claude/scoring-notification-display-jooaym into main

2026-06-30 01:58:20 +00:00

chrisp commented

2026-06-30 01:32:36 +00:00

Owner

No description provided.

chrisp added 2 commits 2026-06-30 01:32:37 +00:00

Show winning team's owner in scoring notifications when loser is eliminated 4a9a70ca7c

When a match is displayed because the loser was eliminated (0-pt), the winner's
manager was previously omitted if the winner only advanced without earning points.
Now the winner's owner is always credited on any match that passes the notability
gate, while the gate itself (winnerScoreChanged || loserNotifiable) still prevents
purely-advancing matches from appearing.

Adds isMatchNotable() pure helper alongside isLoserNotifiable() to make the
display rule testable in isolation.

Co-Authored-By: Claude <noreply@anthropic.com>

Address code-review findings: ping guard, dual filter, inline helper

🚀 Deploy / 🧪 Test (pull_request) Successful in 2m42s

Details

🚀 Deploy / ʦ🔍 Typecheck & Lint (pull_request) Successful in 1m19s

Details

🚀 Deploy / 🐳 Build (pull_request) Has been skipped

Details

🚀 Deploy / 🚀 Deploy (pull_request) Has been skipped

Details

9a39267bdb

- Restore winnerScoreChanged guard on winnerDiscordUserId so advancing-only
  winners are shown in the embed but not Discord-pinged
- Add display-name filter at the end of the scoredMatches chain so
  scoredMatches always reflects exactly what appears in the embed, eliminating
  the dual-gate split between scoring-calculator.ts and discord.ts
- Remove isMatchNotable export and inline x.winnerScoreChanged || x.showLoser
  at its sole call site; move the reasoning into the existing comment block

Co-Authored-By: Claude <noreply@anthropic.com>