scoring notifications #115

Merged
chrisp merged 2 commits from claude/scoring-notification-display-jooaym into main 2026-06-30 01:58:20 +00:00

2 commits

Author SHA1 Message Date
Claude
9a39267bdb
Address code-review findings: ping guard, dual filter, inline helper
All checks were successful
🚀 Deploy / 🧪 Test (pull_request) Successful in 2m42s
🚀 Deploy / ʦ🔍 Typecheck & Lint (pull_request) Successful in 1m19s
🚀 Deploy / 🐳 Build (pull_request) Has been skipped
🚀 Deploy / 🚀 Deploy (pull_request) Has been skipped
- Restore winnerScoreChanged guard on winnerDiscordUserId so advancing-only
  winners are shown in the embed but not Discord-pinged
- Add display-name filter at the end of the scoredMatches chain so
  scoredMatches always reflects exactly what appears in the embed, eliminating
  the dual-gate split between scoring-calculator.ts and discord.ts
- Remove isMatchNotable export and inline x.winnerScoreChanged || x.showLoser
  at its sole call site; move the reasoning into the existing comment block

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-29 23:40:19 +00:00
Claude
4a9a70ca7c
Show winning team's owner in scoring notifications when loser is eliminated
When a match is displayed because the loser was eliminated (0-pt), the winner's
manager was previously omitted if the winner only advanced without earning points.
Now the winner's owner is always credited on any match that passes the notability
gate, while the gate itself (winnerScoreChanged || loserNotifiable) still prevents
purely-advancing matches from appearing.

Adds isMatchNotable() pure helper alongside isLoserNotifiable() to make the
display rule testable in isolation.

Co-Authored-By: Claude <noreply@anthropic.com>
2026-06-29 22:19:30 +00:00