* Fix NBA Play-In 7/8 loser incorrectly marked as eliminated
processPlayoffEvent (called by autoCompleteRoundIfDone when all round matches
finish) was marking every non-scoring round loser as eliminated without
checking doesLoserAdvance. This caused the 7v8 loser, who should advance to
Play-In Round 2, to get finalPosition=0 as soon as the full round completed.
Fixes:
- processPlayoffEvent now calls doesLoserAdvance per match before writing a
0-pt elimination result, matching the guard already in processMatchResult
- recalculate-floors handler now passes loserAdvances to processMatchResult
so a full reprocess also respects the loser-advances rule
- recalculateAffectedLeagues gains a skipDiscord option; recalculate-floors
uses it so clicking the admin "Recalculate Floors" button corrects the bad
data without re-announcing results on Discord
- Add two tests confirming 7v8 loser is not eliminated and 9v10 loser is
https://claude.ai/code/session_01QmvezscLYY38gN4GbvXZbA
* Address code review feedback on Play-In loserAdvances fix
- Use outer `round` variable instead of match.round in processPlayoffEvent
(they're identical, but consistent with surrounding code)
- Add comment at recalculate-floors call site explaining skipDiscord intent
- Combine two redundant test cases into one covering all four assertions
- Add West conference matches (M3/M4) to test fixture — East-only was
insufficient given doesLoserAdvance checks matchNumber 1 & 3
- Add guard test: when bracketTemplateId is null all losers are eliminated,
catching any future refactor that drops the field from the DB query
https://claude.ai/code/session_01QmvezscLYY38gN4GbvXZbA
---------
Co-authored-by: Claude <noreply@anthropic.com>
f356bdce03